74932 2011-12-20 07:43:12 -0800 [Qt][WK2] Add ArgumentCoder functions for size_t. 2011-12-21 08:37:23 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 74931 1 zeno zeno andersca cmarcelo jesus kenneth sam webkit.review.bot zoltan oldest_to_newest 524614 0 zeno 2011-12-20 07:43:12 -0800 This allows the WebProcess/UIProcess to exchange data of the size of a native pointer. 524640 1 120035 zeno 2011-12-20 09:05:00 -0800 Created attachment 120035 patch for review. 524721 2 120035 hausmann 2011-12-20 11:46:03 -0800 Comment on attachment 120035 patch for review. View in context: https://bugs.webkit.org/attachment.cgi?id=120035&action=review > Source/WebKit2/Shared/qt/ArgumentCodersQt.cpp:100 > +#if WTF_USE_JSVALUE64 That doesn't sound like the right macro to use. Technically it refers to an implementation detail of JSC. I also think uintptr_t is a better type to use than size_t, and with a bit of template specialization you should be able to figure out the size of uintptr_t, instead of using the macro. I see what you're trying to use this for, but I don't think it's the right thing to do. I'll comment on the other bug about the use-case. 524764 3 zeno 2011-12-20 12:38:37 -0800 I was in doubt about that myself. But it seemed to be very straightforward, and i was - honestly - curious about the feedback. ;-) Another option would be to use a QUuid. Do you think that would be a better approach? 525272 4 zeno 2011-12-21 08:37:23 -0800 Assuming that we are not going with the pointer magic we will not need this functionality. Therefore i am closing this bug again. 120035 2011-12-20 09:05:00 -0800 2011-12-20 11:46:03 -0800 patch for review. 74932_20111220-180216.patch text/plain 2271 zeno ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmM2MwOTlmLi42YTViNDU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTEtMTItMjAgIFplbm8gQWxiaXNzZXIgIDx6ZW5vQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgW1F0XVtXSzJdIEFkZCBBcmd1bWVudENvZGVyIGZ1bmN0aW9ucyBmb3Igc2l6ZV90LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ5MzIKKworICAg ICAgICBBbGxvdyB0aGUgV2ViUHJvY2Vzcy9VSVByb2Nlc3MgdG8gZXhjaGFuZ2UgZGF0YQorICAg ICAgICBvZiB0aGUgc2l6ZSBvZiBhIG5hdGl2ZSBwb2ludGVyLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2hhcmVkL3F0L0FyZ3VtZW50Q29kZXJz UXQuY3BwOgorICAgICAgICAoQ29yZUlQQzo6OjplbmNvZGUpOgorICAgICAgICAoQ29yZUlQQzo6 OjpkZWNvZGUpOgorICAgICAgICAqIFNoYXJlZC9xdC9Bcmd1bWVudENvZGVyc1F0Lmg6CisKIDIw MTEtMTItMTcgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBNYWtlIFBs YXRmb3JtVG91Y2hFdmVudCBpbmhlcml0IGZyb20gUGxhdGZvcm1FdmVudApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvU2hhcmVkL3F0L0FyZ3VtZW50Q29kZXJzUXQuY3BwIGIvU291cmNlL1dl YktpdDIvU2hhcmVkL3F0L0FyZ3VtZW50Q29kZXJzUXQuY3BwCmluZGV4IGM4OWJmNDQuLmIzNDdl NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9Bcmd1bWVudENvZGVyc1F0 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvcXQvQXJndW1lbnRDb2RlcnNRdC5jcHAK QEAgLTk1LDQgKzk1LDIyIEBAIGJvb2wgQXJndW1lbnRDb2RlcjxXZWJDb3JlOjpEcmFnRGF0YT46 OmRlY29kZShBcmd1bWVudERlY29kZXIqIGRlY29kZXIsIERyYWdEYXRhCiAgICAgcmV0dXJuIHRy dWU7CiB9CiAKK3ZvaWQgQXJndW1lbnRDb2RlcjxzaXplX3Q+OjplbmNvZGUoQXJndW1lbnRFbmNv ZGVyKiBlbmNvZGVyLCBjb25zdCBzaXplX3QmIGRhdGEpCit7CisjaWYgV1RGX1VTRV9KU1ZBTFVF NjQKKyAgICBlbmNvZGVyLT5lbmNvZGVVSW50NjQoc3RhdGljX2Nhc3Q8Y29uc3QgdWludDY0X3Qm PihkYXRhKSk7CisjZWxzZQorICAgIGVuY29kZXItPmVuY29kZVVJbnQzMihzdGF0aWNfY2FzdDxj b25zdCB1aW50MzJfdCY+KGRhdGEpKTsKKyNlbmRpZgorfQorCitib29sIEFyZ3VtZW50Q29kZXI8 c2l6ZV90Pjo6ZGVjb2RlKEFyZ3VtZW50RGVjb2RlciogZGVjb2Rlciwgc2l6ZV90JiBkYXRhKQor eworI2lmIFdURl9VU0VfSlNWQUxVRTY0CisgICAgcmV0dXJuIGRlY29kZXItPmRlY29kZVVJbnQ2 NChyZWludGVycHJldF9jYXN0PHVpbnQ2NF90Jj4oZGF0YSkpOworI2Vsc2UKKyAgICByZXR1cm4g ZGVjb2Rlci0+ZGVjb2RlVUludDMyKHJlaW50ZXJwcmV0X2Nhc3Q8dWludDMyX3QmPihkYXRhKSk7 CisjZW5kaWYKK30KKwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL3F0L0Fy Z3VtZW50Q29kZXJzUXQuaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9Bcmd1bWVudENvZGVy c1F0LmgKaW5kZXggNGQxNWNjMC4uMmFhNmM0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv U2hhcmVkL3F0L0FyZ3VtZW50Q29kZXJzUXQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv cXQvQXJndW1lbnRDb2RlcnNRdC5oCkBAIC0zNCw2ICszNCwxNCBAQCB0ZW1wbGF0ZTw+IHN0cnVj dCBBcmd1bWVudENvZGVyPFdlYkNvcmU6OkRyYWdEYXRhPiB7CiAgICAgc3RhdGljIGJvb2wgZGVj b2RlKEFyZ3VtZW50RGVjb2RlciosIFdlYkNvcmU6OkRyYWdEYXRhJik7CiB9OwogCit2b2lkIGVu Y29kZShBcmd1bWVudEVuY29kZXIqLCBjb25zdCBzaXplX3QmKTsKK2Jvb2wgZGVjb2RlKEFyZ3Vt ZW50RGVjb2RlciosIHNpemVfdCYpOworCit0ZW1wbGF0ZTw+IHN0cnVjdCBBcmd1bWVudENvZGVy PHNpemVfdD4geworICAgIHN0YXRpYyB2b2lkIGVuY29kZShBcmd1bWVudEVuY29kZXIqLCBjb25z dCBzaXplX3QmKTsKKyAgICBzdGF0aWMgYm9vbCBkZWNvZGUoQXJndW1lbnREZWNvZGVyKiwgc2l6 ZV90Jik7Cit9OworCiB9CiAKICNlbmRpZiAvLyBBcmd1bWVudENvZGVyc1F0X2gK