74920 2011-12-20 04:20:41 -0800 [EFL] Add 'Select All' option to context menus in WebKit-EFL. 2011-12-21 14:44:20 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mpakulavelrutka webkit-unassigned gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 524525 0 mpakulavelrutka 2011-12-20 04:20:41 -0800 Enable 'Select All' option to context menus called on input fields in WebKit-EFL as it is enabled in GTK and QT ports. 524527 1 120007 mpakulavelrutka 2011-12-20 04:23:15 -0800 Created attachment 120007 proposed patch 524550 2 rakuco 2011-12-20 05:28:54 -0800 Looks OK, even though I don't know this part of the code. Does it need bug 74179 to work properly? 525059 3 gyuyoung.kim 2011-12-20 19:47:00 -0800 LGTM too. 525177 4 mpakulavelrutka 2011-12-21 01:02:09 -0800 It is not dependent from any way how we implement context menu, whether it is using 74179 (CROSS_PLATFORM_CONTEXT_MENU=ON) or not. Main code is placed in ContextMenuController which is common for all platforms. Only EFL specific code is matching value of ContextMenuItem::ContextMenuItemTagSelectAll with EWK_CONTEXT_MENU_ITEM_SELECT_ALL. 525468 5 120007 eric 2011-12-21 12:27:42 -0800 Comment on attachment 120007 proposed patch OK. 525634 6 120007 webkit.review.bot 2011-12-21 14:44:13 -0800 Comment on attachment 120007 proposed patch Clearing flags on attachment: 120007 Committed r103455: <http://trac.webkit.org/changeset/103455> 525635 7 webkit.review.bot 2011-12-21 14:44:20 -0800 All reviewed patches have been landed. Closing bug. 120007 2011-12-20 04:23:15 -0800 2011-12-21 14:44:13 -0800 proposed patch patch_select_all.diff text/plain 6267 mpakulavelrutka ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MGI3Y2E0Li5iYjU3MTJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTEtMTItMjAgIE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1z dW5nLmNvbT4KKworICAgICAgICBbRUZMXSBBZGQgJ1NlbGVjdCBBbGwnIG9wdGlvbiB0byBjb250 ZXh0IG1lbnVzIGluIFdlYktpdC1FRkwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD03NDkyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEVuYWJsZSAnU2VsZWN0IEFsbCcgb3B0aW9uIHRvIGNvbnRleHQgbWVu dXMgY2FsbGVkIG9uIGlucHV0IGZpZWxkcyBpbiBXZWJLaXQtRUZMCisgICAgICAgIGFzIGl0IGlz IGVuYWJsZWQgaW4gR1RLIGFuZCBRVCBwb3J0cy4KKworICAgICAgICAqIHBhZ2UvQ29udGV4dE1l bnVDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRleHRNZW51Q29udHJvbGxl cjo6Y29udGV4dE1lbnVJdGVtU2VsZWN0ZWQpOiBBZGQgJ1NlbGVjdCBBbGwnIG9wdGlvbi4KKyAg ICAgICAgKFdlYkNvcmU6OkNvbnRleHRNZW51Q29udHJvbGxlcjo6cG9wdWxhdGUpOiBBcHBlbmQg J1NlbGVjdCBBbGwnIGl0ZW0uCisgICAgICAgIChXZWJDb3JlOjpDb250ZXh0TWVudUNvbnRyb2xs ZXI6OmNoZWNrT3JFbmFibGVJZk5lZWRlZCk6IEVuYWJsZSAnU2VsZWN0IEFsbCcgb3B0aW9uLgor ICAgICAgICAqIHBsYXRmb3JtL0NvbnRleHRNZW51SXRlbS5oOiBBZGQgJ1NlbGVjdCBBbGwnIG9w dGlvbi4KKyAgICAgICAgKiBwbGF0Zm9ybS9Mb2NhbGl6YXRpb25TdHJhdGVneS5oOiBBZGQgY29u c3RydWN0b3IgZm9yICdTZWxlY3QgQWxsJyBvcHRpb24uCisgICAgICAgICogcGxhdGZvcm0vTG9j YWxpemVkU3RyaW5ncy5oOiBBZGQgY29uc3RydWN0b3IgZm9yICdTZWxlY3QgQWxsJyBvcHRpb24u CisKIDIwMTEtMTItMjAgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFtSZWZhY3RvcmluZ10gUmVwbGFjZSBpbXAgd2l0aCBpbXBsIGluIENvZGVHZW5lcmF0 b3JKUy5wbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRy b2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9Db250ZXh0TWVudUNvbnRyb2xsZXIuY3Bw CmluZGV4IDMxMTM0NDUuLmJmZTMyNjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv Q29udGV4dE1lbnVDb250cm9sbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnRl eHRNZW51Q29udHJvbGxlci5jcHAKQEAgLTI3OSw3ICsyNzksNyBAQCB2b2lkIENvbnRleHRNZW51 Q29udHJvbGxlcjo6Y29udGV4dE1lbnVJdGVtU2VsZWN0ZWQoQ29udGV4dE1lbnVJdGVtKiBpdGVt KQogICAgICAgICBmcmFtZS0+ZWRpdG9yKCktPnBlcmZvcm1EZWxldGUoKTsKICAgICAgICAgYnJl YWs7CiAjZW5kaWYKLSNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFFUKQorI2lmIFBMQVRG T1JNKEdUSykgfHwgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNKEVGTCkKICAgICBjYXNlIENvbnRl eHRNZW51SXRlbVRhZ1NlbGVjdEFsbDoKICAgICAgICAgZnJhbWUtPmVkaXRvcigpLT5jb21tYW5k KCJTZWxlY3RBbGwiKS5leGVjdXRlKCk7CiAgICAgICAgIGJyZWFrOwpAQCAtNjgwLDcgKzY4MCw3 IEBAIHZvaWQgQ29udGV4dE1lbnVDb250cm9sbGVyOjpwb3B1bGF0ZSgpCiAjaWYgUExBVEZPUk0o R1RLKQogICAgIENvbnRleHRNZW51SXRlbSBEZWxldGVJdGVtKEFjdGlvblR5cGUsIENvbnRleHRN ZW51SXRlbVRhZ0RlbGV0ZSwgY29udGV4dE1lbnVJdGVtVGFnRGVsZXRlKCkpOwogI2VuZGlmCi0j aWYgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShRVCkKKyNpZiBQTEFURk9STShHVEspIHx8IFBM QVRGT1JNKFFUKSB8fCBQTEFURk9STShFRkwpCiAgICAgQ29udGV4dE1lbnVJdGVtIFNlbGVjdEFs bEl0ZW0oQWN0aW9uVHlwZSwgQ29udGV4dE1lbnVJdGVtVGFnU2VsZWN0QWxsLCBjb250ZXh0TWVu dUl0ZW1UYWdTZWxlY3RBbGwoKSk7CiAjZW5kaWYKIApAQCAtODk5LDcgKzg5OSw3IEBAIHZvaWQg Q29udGV4dE1lbnVDb250cm9sbGVyOjpwb3B1bGF0ZSgpCiAgICAgICAgIGFwcGVuZEl0ZW0oRGVs ZXRlSXRlbSwgbV9jb250ZXh0TWVudS5nZXQoKSk7CiAgICAgICAgIGFwcGVuZEl0ZW0oKnNlcGFy YXRvckl0ZW0oKSwgbV9jb250ZXh0TWVudS5nZXQoKSk7CiAjZW5kaWYKLSNpZiBQTEFURk9STShH VEspIHx8IFBMQVRGT1JNKFFUKQorI2lmIFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oUVQpIHx8 IFBMQVRGT1JNKEVGTCkKICAgICAgICAgYXBwZW5kSXRlbShTZWxlY3RBbGxJdGVtLCBtX2NvbnRl eHRNZW51LmdldCgpKTsKICNlbmRpZgogCkBAIC0xMDQ5LDEyICsxMDQ5LDE2IEBAIHZvaWQgQ29u dGV4dE1lbnVDb250cm9sbGVyOjpjaGVja09yRW5hYmxlSWZOZWVkZWQoQ29udGV4dE1lbnVJdGVt JiBpdGVtKSBjb25zdAogICAgICAgICBjYXNlIENvbnRleHRNZW51SXRlbVRhZ0RlbGV0ZToKICAg ICAgICAgICAgIHNob3VsZEVuYWJsZSA9IGZyYW1lLT5lZGl0b3IoKS0+Y2FuRGVsZXRlKCk7CiAg ICAgICAgICAgICBicmVhazsKLSAgICAgICAgY2FzZSBDb250ZXh0TWVudUl0ZW1UYWdTZWxlY3RB bGw6CiAgICAgICAgIGNhc2UgQ29udGV4dE1lbnVJdGVtVGFnSW5wdXRNZXRob2RzOgogICAgICAg ICBjYXNlIENvbnRleHRNZW51SXRlbVRhZ1VuaWNvZGU6CiAgICAgICAgICAgICBzaG91bGRFbmFi bGUgPSB0cnVlOwogICAgICAgICAgICAgYnJlYWs7CiAjZW5kaWYKKyNpZiBQTEFURk9STShHVEsp IHx8IFBMQVRGT1JNKEVGTCkKKyAgICAgICAgY2FzZSBDb250ZXh0TWVudUl0ZW1UYWdTZWxlY3RB bGw6CisgICAgICAgICAgICBzaG91bGRFbmFibGUgPSB0cnVlOworICAgICAgICAgICAgYnJlYWs7 CisjZW5kaWYKICAgICAgICAgY2FzZSBDb250ZXh0TWVudUl0ZW1UYWdVbmRlcmxpbmU6IHsKICAg ICAgICAgICAgIHNob3VsZENoZWNrID0gZnJhbWUtPmVkaXRvcigpLT5zZWxlY3Rpb25IYXNTdHls ZShDU1NQcm9wZXJ0eVdlYmtpdFRleHREZWNvcmF0aW9uc0luRWZmZWN0LCAidW5kZXJsaW5lIikg IT0gRmFsc2VUcmlTdGF0ZTsKICAgICAgICAgICAgIHNob3VsZEVuYWJsZSA9IGZyYW1lLT5lZGl0 b3IoKS0+Y2FuRWRpdFJpY2hseSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vQ29udGV4dE1lbnVJdGVtLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Db250ZXh0TWVu dUl0ZW0uaAppbmRleCBlMzY5MzQ4Li40Y2FhYjgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9Db250ZXh0TWVudUl0ZW0uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9Db250ZXh0TWVudUl0ZW0uaApAQCAtNzgsNyArNzgsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAjaWYgUExBVEZPUk0oR1RLKQogICAgICAgICBDb250ZXh0TWVudUl0ZW1UYWdEZWxldGUsCiAj ZW5kaWYKLSNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFFUKQorI2lmIFBMQVRGT1JNKEdU SykgfHwgUExBVEZPUk0oUVQpIHx8IFBMQVRGT1JNIChFRkwpCiAgICAgICAgIENvbnRleHRNZW51 SXRlbVRhZ1NlbGVjdEFsbCwKICNlbmRpZgogI2lmIFBMQVRGT1JNKEdUSykKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvY2FsaXphdGlvblN0cmF0ZWd5LmggYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9Mb2NhbGl6YXRpb25TdHJhdGVneS5oCmluZGV4IDNkMWEyYjguLmIw MGFiMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvY2FsaXphdGlvblN0 cmF0ZWd5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9jYWxpemF0aW9uU3RyYXRl Z3kuaApAQCAtNzQsNyArNzQsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBTdHJpbmcgY29udGV4 dE1lbnVJdGVtVGFnSW5wdXRNZXRob2RzKCkgPSAwOwogICAgIHZpcnR1YWwgU3RyaW5nIGNvbnRl eHRNZW51SXRlbVRhZ1VuaWNvZGUoKSA9IDA7CiAjZW5kaWYKLSNpZiBQTEFURk9STShHVEspIHx8 IFBMQVRGT1JNKFFUKQorI2lmIFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oUVQpIHx8IFBMQVRG T1JNKEVGTCkKICAgICB2aXJ0dWFsIFN0cmluZyBjb250ZXh0TWVudUl0ZW1UYWdTZWxlY3RBbGwo KSA9IDA7CiAjZW5kaWYKICAgICB2aXJ0dWFsIFN0cmluZyBjb250ZXh0TWVudUl0ZW1UYWdOb0d1 ZXNzZXNGb3VuZCgpID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xv Y2FsaXplZFN0cmluZ3MuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvY2FsaXplZFN0cmlu Z3MuaAppbmRleCBjNDlhZDkxLi5lZGNlYjYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9Mb2NhbGl6ZWRTdHJpbmdzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v TG9jYWxpemVkU3RyaW5ncy5oCkBAIC03MCw3ICs3MCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICBTdHJpbmcgY29udGV4dE1lbnVJdGVtVGFnSW5wdXRNZXRob2RzKCk7CiAgICAgU3RyaW5n IGNvbnRleHRNZW51SXRlbVRhZ1VuaWNvZGUoKTsKICNlbmRpZgotI2lmIFBMQVRGT1JNKEdUSykg fHwgUExBVEZPUk0oUVQpCisjaWYgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShRVCkgfHwgUExB VEZPUk0oRUZMKQogICAgIFN0cmluZyBjb250ZXh0TWVudUl0ZW1UYWdTZWxlY3RBbGwoKTsKICNl bmRpZgogICAgIFN0cmluZyBjb250ZXh0TWVudUl0ZW1UYWdOb0d1ZXNzZXNGb3VuZCgpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9lZmwv Q2hhbmdlTG9nCmluZGV4IGQ1Njk4MGMuLmFiM2E5NTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvZWZsL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMS0xMi0yMCAgTWljaGHFgiBQYWt1xYJhIHZlbCBSdXRrYSAgPG0ucGFr dWxhQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEFkZCAnU2VsZWN0IEFsbCcgb3B0aW9u IHRvIGNvbnRleHQgbWVudXMgaW4gV2ViS2l0LUVGTC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0OTIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlICdTZWxlY3QgQWxsJyBvcHRpb24gdG8gY29u dGV4dCBtZW51cyBjYWxsZWQgb24gaW5wdXQgZmllbGRzIGluIFdlYktpdC1FRkwKKyAgICAgICAg YXMgaXQgaXMgZW5hYmxlZCBpbiBHVEsgYW5kIFFUIHBvcnRzLgorCisgICAgICAgICogZXdrL2V3 a19jb250ZXh0bWVudS5oOiBBZGQgbmV3IGNvbnRleHQgbWVudSBvcHRpb24gJ1NlbGVjdCBBbGwn LgorCiAyMDExLTEyLTE5ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAog ICAgICAgICBbRUZMXSBDaGFuZ2UgdGhlIGJlaGF2aW9yIG9mIGV3a192aWV3X3NjYWxlX3NldC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfY29udGV4dG1lbnUuaCBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfY29udGV4dG1lbnUuaAppbmRleCBmZDMyNDAwLi40ZThl ZjllIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX2NvbnRleHRtZW51LmgK KysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19jb250ZXh0bWVudS5oCkBAIC02NSw2ICs2 NSw3IEBAIGVudW0gX0V3a19Db250ZXh0X01lbnVfQWN0aW9uIHsKICAgICBFV0tfQ09OVEVYVF9N RU5VX0lURU1fVEFHX1JFTE9BRCwKICAgICBFV0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX0NVVCwK ICAgICBFV0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX1BBU1RFLAorICAgIEVXS19DT05URVhUX01F TlVfSVRFTV9UQUdfU0VMRUNUX0FMTCwKICAgICBFV0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX1NQ RUxMSU5HX0dVRVNTLAogICAgIEVXS19DT05URVhUX01FTlVfSVRFTV9UQUdfTk9fR1VFU1NFU19G T1VORCwKICAgICBFV0tfQ09OVEVYVF9NRU5VX0lURU1fVEFHX0lHTk9SRV9TUEVMTElORywK