74906 2011-12-19 20:23:25 -0800 Tightened up Vector<T>::append 2011-12-21 17:50:30 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren rniwa oldest_to_newest 524400 0 ggaren 2011-12-19 20:23:25 -0800 Tightened up Vector<T>::append 524411 1 119982 ggaren 2011-12-19 20:44:40 -0800 Created attachment 119982 Patch 524879 2 ggaren 2011-12-20 15:30:55 -0800 Committed r103356: <http://trac.webkit.org/changeset/103356> 525892 3 rniwa 2011-12-21 17:50:30 -0800 This patch may have caused 7.5% memory use increase on Windows. See https://bugs.webkit.org/show_bug.cgi?id=75050. 119982 2011-12-19 20:44:40 -0800 2011-12-20 14:10:04 -0800 Patch bug-74906-20111219204437.patch text/plain 3103 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAzMjk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDExLTEyLTE5ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgVGlnaHRlbmVkIHVwIFZlY3RvcjxUPjo6YXBwZW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDkwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdCBhIG1lYXN1cmFibGUgc3BlZWR1cCwgYnV0IGNv ZGUgaW5zcGVjdGlvbiBzaG93cyBiZXR0ZXIgY29kZSBnZW5lcmF0ZWQsCisgICAgICAgIGFuZCBJ IGJlbGlldmUgdGhpcyBpcyBhIHN0ZXAgdG93YXJkIHR1cm5pbmcgb2ZmIC1mb21pdC1mcmFtZS1w b2ludGVyLgorCisgICAgICAgICogd3RmL1ZlY3Rvci5oOgorICAgICAgICAoV1RGOjo6OmFwcGVu ZCk6CisgICAgICAgIChXVEY6Ojo6YXBwZW5kU2xvd0Nhc2UpOiBTcGxpdCBvdXQgdGhlIHNsb3cg Y2FzZSBpbnRvIGEgc2VwYXJhdGUgZnVuY3Rpb24KKyAgICAgICAgdG8ga2VlcCB1bm5lY2Vzc2Fy eSBpbnN0cnVjdGlvbnMgb2ZmIHRoZSBob3QgcGF0aC4gVGhpcyBtZWFucyB0aGUgaG90CisgICAg ICAgIHBhdGggY2FuIG5vdyBiZSBpbmxpbmVkIG1vcmUgb2Z0ZW4uCisgICAgICAgIAorICAgICAg ICBSZW1vdmVkIHNvbWUgb2xkIE1TVkM3IGNydWZ0LiBIb3BlZnVsbHksIHdlIGRvbid0IG5lZWQg dG8gaGFuZyBvbiB0byBhCisgICAgICAgIGNvbXBpbGVyIHdvcmstYXJvdW5kIGZyb20gMjAwNy4K KwogMjAxMS0xMi0xOSAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+ CiAKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0OTAz CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1ZlY3Rvci5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yLmgJKHJldmlzaW9uIDEwMzI5MSkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvVmVjdG9yLmgJKHdvcmtpbmcgY29weSkKQEAgLTYw Nyw2ICs2MDcsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICAgICAgYm9vbCB0cnlFeHBhbmRDYXBh Y2l0eShzaXplX3QgbmV3TWluQ2FwYWNpdHkpOwogICAgICAgICBjb25zdCBUKiB0cnlFeHBhbmRD YXBhY2l0eShzaXplX3QgbmV3TWluQ2FwYWNpdHksIGNvbnN0IFQqKTsKICAgICAgICAgdGVtcGxh dGU8dHlwZW5hbWUgVT4gVSogZXhwYW5kQ2FwYWNpdHkoc2l6ZV90IG5ld01pbkNhcGFjaXR5LCBV Kik7IAorICAgICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiB2b2lkIGFwcGVuZFNsb3dDYXNlKGNv bnN0IFUmKTsKIAogICAgICAgICBzaXplX3QgbV9zaXplOwogICAgICAgICBCdWZmZXIgbV9idWZm ZXI7CkBAIC05NTMsMjQgKzk1NCwyNiBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICB0ZW1wbGF0ZTx0 eXBlbmFtZSBULCBzaXplX3QgaW5saW5lQ2FwYWNpdHk+IHRlbXBsYXRlPHR5cGVuYW1lIFU+CiAg ICAgQUxXQVlTX0lOTElORSB2b2lkIFZlY3RvcjxULCBpbmxpbmVDYXBhY2l0eT46OmFwcGVuZChj b25zdCBVJiB2YWwpCiAgICAgewotICAgICAgICBjb25zdCBVKiBwdHIgPSAmdmFsOwotICAgICAg ICBpZiAoc2l6ZSgpID09IGNhcGFjaXR5KCkpIHsKLSAgICAgICAgICAgIHB0ciA9IGV4cGFuZENh cGFjaXR5KHNpemUoKSArIDEsIHB0cik7Ci0gICAgICAgICAgICBpZiAoIWJlZ2luKCkpCi0gICAg ICAgICAgICAgICAgcmV0dXJuOworICAgICAgICBpZiAoc2l6ZSgpICE9IGNhcGFjaXR5KCkpIHsK KyAgICAgICAgICAgIG5ldyAoTm90TnVsbCwgZW5kKCkpIFQodmFsKTsKKyAgICAgICAgICAgICsr bV9zaXplOworICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9Ci0gICAgICAgICAgICAKLSNp ZiBDT01QSUxFUihNU1ZDN19PUl9MT1dFUikKLSAgICAgICAgLy8gRklYTUU6IE1TVkM3IGdlbmVy YXRlcyBjb21waWxhdGlvbiBlcnJvcnMgd2hlbiB0cnlpbmcgdG8gYXNzaWduCi0gICAgICAgIC8v IGEgcG9pbnRlciB0byBhIFZlY3RvciBvZiBpdHMgYmFzZSBjbGFzcyAoaS5lLiBjYW4ndCBkb3du Y2FzdCkuIFNvIGZhcgotICAgICAgICAvLyBJJ3ZlIGJlZW4gdW5hYmxlIHRvIGRldGVybWluZSBh bnkgbG9naWNhbCByZWFzb24gZm9yIHRoaXMsIHNvIEkgY2FuCi0gICAgICAgIC8vIG9ubHkgYXNz dW1lIGl0IGlzIGEgYnVnIHdpdGggdGhlIGNvbXBpbGVyLiBDYXN0aW5nIGlzIGEgYmFkIHNvbHV0 aW9uLAotICAgICAgICAvLyBob3dldmVyLCBiZWNhdXNlIGl0IHN1YnZlcnRzIGltcGxpY2l0IGNv bnZlcnNpb25zLCBzbyBhIGJldHRlciAKLSAgICAgICAgLy8gb25lIGlzIG5lZWRlZC4gCi0gICAg ICAgIG5ldyAoTm90TnVsbCwgZW5kKCkpIFQoc3RhdGljX2Nhc3Q8VD4oKnB0cikpOwotI2Vsc2UK KworICAgICAgICBhcHBlbmRTbG93Q2FzZSh2YWwpOworICAgIH0KKworICAgIHRlbXBsYXRlPHR5 cGVuYW1lIFQsIHNpemVfdCBpbmxpbmVDYXBhY2l0eT4gdGVtcGxhdGU8dHlwZW5hbWUgVT4KKyAg ICB2b2lkIFZlY3RvcjxULCBpbmxpbmVDYXBhY2l0eT46OmFwcGVuZFNsb3dDYXNlKGNvbnN0IFUm IHZhbCkKKyAgICB7CisgICAgICAgIEFTU0VSVChzaXplKCkgPT0gY2FwYWNpdHkoKSk7CisKKyAg ICAgICAgY29uc3QgVSogcHRyID0gJnZhbDsKKyAgICAgICAgcHRyID0gZXhwYW5kQ2FwYWNpdHko c2l6ZSgpICsgMSwgcHRyKTsKKyAgICAgICAgaWYgKCFiZWdpbigpKQorICAgICAgICAgICAgcmV0 dXJuOworCiAgICAgICAgIG5ldyAoTm90TnVsbCwgZW5kKCkpIFQoKnB0cik7Ci0jZW5kaWYKICAg ICAgICAgKyttX3NpemU7CiAgICAgfQogCg==