74871 2011-12-19 09:53:37 -0800 [chromium] compositing/shadows tests fail with accelerated painting 2011-12-20 00:39:28 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alokp alokp cc-bugs jamesr senorblanco vangelis webkit.review.bot oldest_to_newest 523954 0 alokp 2011-12-19 09:53:37 -0800 GrContext::createPlatformSurface does not bind the stencil buffer. The new API GrContext::createPlatformTexture does the right thing. 523976 1 119882 alokp 2011-12-19 10:28:10 -0800 Created attachment 119882 proposed patch 524101 2 119882 senorblanco 2011-12-19 12:12:55 -0800 Comment on attachment 119882 proposed patch I'm cool with this, but leaving for one of the compositor guys to give a thumbs up on the ManagedTexture stuff. 524369 3 119882 jamesr 2011-12-19 18:59:27 -0800 Comment on attachment 119882 proposed patch R=me 524467 4 119882 webkit.review.bot 2011-12-20 00:39:24 -0800 Comment on attachment 119882 proposed patch Clearing flags on attachment: 119882 Committed r103309: <http://trac.webkit.org/changeset/103309> 524468 5 webkit.review.bot 2011-12-20 00:39:28 -0800 All reviewed patches have been landed. Closing bug. 119882 2011-12-19 10:28:10 -0800 2011-12-20 00:39:24 -0800 proposed patch 74871.patch text/plain 7316 alokp SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzI0NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDExLTEyLTE5ICBBbG9rIFBy aXlhZGFyc2hpICA8YWxva3BAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gY29t cG9zaXRpbmcvc2hhZG93cyB0ZXN0cyBmYWlsIHdpdGggYWNjZWxlcmF0ZWQgcGFpbnRpbmcKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0ODcxCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBTd2l0 Y2hlZCBvdmVyIHRvIG5ldyBBUEkgZm9yIGNyZWF0aW5nIGFjY2VsZXJhdGVkIGNhbnZhcyBHckNv bnRleHQ6OmNyZWF0ZVBsYXRmb3JtVGV4dHVyZS4KKyAgICAgICAgSXQgY29ycmVjdGx5IGJpbmRz IHRoZSBzdGVuY2lsIGJ1ZmZlciB0byB0aGUgRkJPLgorCisgICAgICAgIFRlc3Q6IGNvbXBvc2l0 aW5nL3NoYWRvd3Mvc2hhZG93LWRyYXdpbmcuaHRtbCAoZXhpc3RpbmcpCisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9GcmFtZUJ1ZmZlclNrUGljdHVyZUNhbnZhc0xheWVy VGV4dHVyZVVwZGF0ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlQWNjZWxlcmF0ZWRD YW52YXMpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVCdWZmZXJTa1BpY3R1cmVDYW52YXNMYXll clRleHR1cmVVcGRhdGVyOjp1cGRhdGVUZXh0dXJlUmVjdCk6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vTWFuYWdlZFRleHR1cmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 TWFuYWdlZFRleHR1cmU6OmFsbG9jYXRlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1hbmFnZWRUZXh0 dXJlOjpiaW5kVGV4dHVyZSk6CisgICAgICAgIChXZWJDb3JlOjpNYW5hZ2VkVGV4dHVyZTo6ZnJh bWVidWZmZXJUZXh0dXJlMkQpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L01hbmFnZWRUZXh0dXJlLmg6CisKIDIwMTEtMTItMTkgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3 ZWJraXQub3JnPgogCiAgICAgICAgIEF2b2lkIGluc3RhbnRpYXRpbmcgU2Nyb2xsQW5pbWF0b3Jz IHdoZW4gcG9zc2libGUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9GcmFtZUJ1ZmZlclNrUGljdHVyZUNhbnZhc0xheWVyVGV4dHVyZVVwZGF0ZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0ZyYW1lQnVmZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5jcHAJKHJldmlz aW9uIDEwMjk3NCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0ZyYW1lQnVmZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlci5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTM3LDY0ICszNywyNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLW5h bWVzcGFjZSB7Ci0KLWNsYXNzIEZyYW1lQnVmZmVyIHsKLXB1YmxpYzoKLSAgICBGcmFtZUJ1ZmZl cigpOwotICAgIH5GcmFtZUJ1ZmZlcigpOwotCi0gICAgU2tDYW52YXMqIGluaXRpYWxpemUoR3Jh cGhpY3NDb250ZXh0M0QqLCBUZXh0dXJlQWxsb2NhdG9yKiwgTWFuYWdlZFRleHR1cmUqKTsKLQot cHJpdmF0ZToKLSAgICBHcmFwaGljc0NvbnRleHQzRCogbV9jb250ZXh0OwotICAgIFBsYXRmb3Jt M0RPYmplY3QgbV9mYm87Ci0gICAgT3duUHRyPFNrQ2FudmFzPiBtX2NhbnZhczsKLX07Ci0KLUZy YW1lQnVmZmVyOjpGcmFtZUJ1ZmZlcigpCi0gICAgOiBtX2NvbnRleHQoMCkKLSAgICAsIG1fZmJv KDApCi17Ci19Ci0KLUZyYW1lQnVmZmVyOjp+RnJhbWVCdWZmZXIoKQorc3RhdGljIFBhc3NPd25Q dHI8U2tDYW52YXM+IGNyZWF0ZUFjY2VsZXJhdGVkQ2FudmFzKEdyYXBoaWNzQ29udGV4dDNEKiBj b250ZXh0LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIFRleHR1cmVBbGxvY2F0b3IqIGFsbG9jYXRvciwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBNYW5hZ2VkVGV4dHVyZSogdGV4dHVyZSkKIHsK LSAgICBtX2NhbnZhcy5jbGVhcigpOworICAgIC8vIEFsbG9jYXRlIHNvIHRoYXQgd2UgaGF2ZSBh IHZhbGlkIHRleHR1cmUgaWQuCisgICAgdGV4dHVyZS0+YWxsb2NhdGUoYWxsb2NhdG9yKTsKIAot ICAgIGlmIChtX2ZibykKLSAgICAgICAgbV9jb250ZXh0LT5kZWxldGVGcmFtZWJ1ZmZlcihtX2Zi byk7Ci19Ci0KLVNrQ2FudmFzKiBGcmFtZUJ1ZmZlcjo6aW5pdGlhbGl6ZShHcmFwaGljc0NvbnRl eHQzRCogY29udGV4dCwgVGV4dHVyZUFsbG9jYXRvciogYWxsb2NhdG9yLCBNYW5hZ2VkVGV4dHVy ZSogdGV4dHVyZSkKLXsKLSAgICBtX2NvbnRleHQgPSBjb250ZXh0OwotICAgIG1fZmJvID0gbV9j b250ZXh0LT5jcmVhdGVGcmFtZWJ1ZmZlcigpOwotICAgIG1fY29udGV4dC0+YmluZEZyYW1lYnVm ZmVyKEdyYXBoaWNzQ29udGV4dDNEOjpGUkFNRUJVRkZFUiwgbV9mYm8pOwotICAgIHRleHR1cmUt PmZyYW1lYnVmZmVyVGV4dHVyZTJEKG1fY29udGV4dCwgYWxsb2NhdG9yKTsKLQotICAgIC8vIENy ZWF0ZSBhIHNraWEgZ3B1IGNhbnZhcy4KLSAgICBHckNvbnRleHQqIGdyQ29udGV4dCA9IG1fY29u dGV4dC0+Z3JDb250ZXh0KCk7CisgICAgR3JDb250ZXh0KiBnckNvbnRleHQgPSBjb250ZXh0LT5n ckNvbnRleHQoKTsKICAgICBJbnRTaXplIGNhbnZhc1NpemUgPSB0ZXh0dXJlLT5zaXplKCk7Ci0g ICAgR3JQbGF0Zm9ybVN1cmZhY2VEZXNjIHRhcmdldERlc2M7Ci0gICAgdGFyZ2V0RGVzYy5yZXNl dCgpOwotICAgIHRhcmdldERlc2MuZlN1cmZhY2VUeXBlID0ga1RleHR1cmVSZW5kZXJUYXJnZXRf R3JQbGF0Zm9ybVN1cmZhY2VUeXBlOwotICAgIHRhcmdldERlc2MuZlJlbmRlclRhcmdldEZsYWdz ID0ga05vbmVfR3JQbGF0Zm9ybVJlbmRlclRhcmdldEZsYWdCaXQ7Ci0gICAgdGFyZ2V0RGVzYy5m V2lkdGggPSBjYW52YXNTaXplLndpZHRoKCk7Ci0gICAgdGFyZ2V0RGVzYy5mSGVpZ2h0ID0gY2Fu dmFzU2l6ZS5oZWlnaHQoKTsKLSAgICB0YXJnZXREZXNjLmZDb25maWcgPSBrUkdCQV84ODg4X0dy UGl4ZWxDb25maWc7Ci0gICAgdGFyZ2V0RGVzYy5mU3RlbmNpbEJpdHMgPSA4OwotICAgIHRhcmdl dERlc2MuZlBsYXRmb3JtVGV4dHVyZSA9IHRleHR1cmUtPnRleHR1cmVJZCgpOwotICAgIHRhcmdl dERlc2MuZlBsYXRmb3JtUmVuZGVyVGFyZ2V0ID0gbV9mYm87Ci0gICAgU2tBdXRvVFVucmVmPEdy VGV4dHVyZT4gdGFyZ2V0KHN0YXRpY19jYXN0PEdyVGV4dHVyZSo+KGdyQ29udGV4dC0+Y3JlYXRl UGxhdGZvcm1TdXJmYWNlKHRhcmdldERlc2MpKSk7CisgICAgR3JQbGF0Zm9ybVRleHR1cmVEZXNj IHRleHR1cmVEZXNjOworICAgIHRleHR1cmVEZXNjLmZGbGFncyA9IGtSZW5kZXJUYXJnZXRfR3JQ bGF0Zm9ybVRleHR1cmVGbGFnOworICAgIHRleHR1cmVEZXNjLmZXaWR0aCA9IGNhbnZhc1NpemUu d2lkdGgoKTsKKyAgICB0ZXh0dXJlRGVzYy5mSGVpZ2h0ID0gY2FudmFzU2l6ZS5oZWlnaHQoKTsK KyAgICB0ZXh0dXJlRGVzYy5mQ29uZmlnID0ga1JHQkFfODg4OF9HclBpeGVsQ29uZmlnOworICAg IHRleHR1cmVEZXNjLmZUZXh0dXJlSGFuZGxlID0gdGV4dHVyZS0+dGV4dHVyZUlkKCk7CisgICAg U2tBdXRvVFVucmVmPEdyVGV4dHVyZT4gdGFyZ2V0KGdyQ29udGV4dC0+Y3JlYXRlUGxhdGZvcm1U ZXh0dXJlKHRleHR1cmVEZXNjKSk7CiAgICAgU2tBdXRvVFVucmVmPFNrRGV2aWNlPiBkZXZpY2Uo bmV3IFNrR3B1RGV2aWNlKGdyQ29udGV4dCwgdGFyZ2V0LmdldCgpKSk7Ci0gICAgbV9jYW52YXMg PSBhZG9wdFB0cihuZXcgU2tDYW52YXMoZGV2aWNlLmdldCgpKSk7Ci0KLSAgICByZXR1cm4gbV9j YW52YXMuZ2V0KCk7CisgICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBTa0NhbnZhcyhkZXZpY2UuZ2V0 KCkpKTsKIH0KIAotfSAvLyBuYW1lc3BhY2UKLQogRnJhbWVCdWZmZXJTa1BpY3R1cmVDYW52YXNM YXllclRleHR1cmVVcGRhdGVyOjpUZXh0dXJlOjpUZXh0dXJlKEZyYW1lQnVmZmVyU2tQaWN0dXJl Q2FudmFzTGF5ZXJUZXh0dXJlVXBkYXRlciogdGV4dHVyZVVwZGF0ZXIsIFBhc3NPd25QdHI8TWFu YWdlZFRleHR1cmU+IHRleHR1cmUpCiAgICAgOiBMYXllclRleHR1cmVVcGRhdGVyOjpUZXh0dXJl KHRleHR1cmUpCiAgICAgLCBtX3RleHR1cmVVcGRhdGVyKHRleHR1cmVVcGRhdGVyKQpAQCAtMTQz LDggKzEwNSw3IEBAIHZvaWQgRnJhbWVCdWZmZXJTa1BpY3R1cmVDYW52YXNMYXllclRleHQKICAg ICBjb250ZXh0LT5nckNvbnRleHQoKS0+cmVzZXRDb250ZXh0KCk7CiAKICAgICAvLyBDcmVhdGUg YW4gYWNjZWxlcmF0ZWQgY2FudmFzIHRvIGRyYXcgb24uCi0gICAgRnJhbWVCdWZmZXIgYnVmZmVy OwotICAgIFNrQ2FudmFzKiBjYW52YXMgPSBidWZmZXIuaW5pdGlhbGl6ZShjb250ZXh0LCBhbGxv Y2F0b3IsIHRleHR1cmUpOworICAgIE93blB0cjxTa0NhbnZhcz4gY2FudmFzID0gY3JlYXRlQWNj ZWxlcmF0ZWRDYW52YXMoY29udGV4dCwgYWxsb2NhdG9yLCB0ZXh0dXJlKTsKIAogICAgIGNhbnZh cy0+Y2xpcFJlY3QoU2tSZWN0KGRlc3RSZWN0KSk7CiAgICAgLy8gVGhlIGNvbXBvc2l0b3IgZXhw ZWN0cyB0aGUgdGV4dHVyZXMgdG8gYmUgdXBzaWRlLWRvd24gc28gaXQgY2FuIGZsaXAKQEAgLTE1 Niw3ICsxMTcsNyBAQCB2b2lkIEZyYW1lQnVmZmVyU2tQaWN0dXJlQ2FudmFzTGF5ZXJUZXh0CiAg ICAgLy8gTm90ZSB0aGF0IGRlc3RSZWN0IGlzIGRlZmluZWQgcmVsYXRpdmUgdG8gc291cmNlUmVj dC4KICAgICBjYW52YXMtPnRyYW5zbGF0ZShjb250ZW50UmVjdCgpLngoKSAtIHNvdXJjZVJlY3Qu eCgpICsgZGVzdFJlY3QueCgpLAogICAgICAgICAgICAgICAgICAgICAgIGNvbnRlbnRSZWN0KCku eSgpIC0gc291cmNlUmVjdC55KCkgKyBkZXN0UmVjdC55KCkpOwotICAgIGRyYXdQaWN0dXJlKGNh bnZhcyk7CisgICAgZHJhd1BpY3R1cmUoY2FudmFzLmdldCgpKTsKIAogICAgIC8vIEZsdXNoIFNL SUEgY29udGV4dCBzbyB0aGF0IGFsbCB0aGUgcmVuZGVyZWQgc3R1ZmYgYXBwZWFycyBvbiB0aGUg dGV4dHVyZS4KICAgICBjb250ZXh0LT5nckNvbnRleHQoKS0+Zmx1c2goKTsKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL01hbmFnZWRUZXh0dXJlLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9N YW5hZ2VkVGV4dHVyZS5jcHAJKHJldmlzaW9uIDEwMjk3NCkKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL01hbmFnZWRUZXh0dXJlLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtODAsMTkgKzgwLDIyIEBAIHZvaWQgTWFuYWdlZFRleHR1cmU6OnVucmVzZXJ2ZSgpCiAg ICAgbV90ZXh0dXJlTWFuYWdlci0+dW5wcm90ZWN0VGV4dHVyZShtX3Rva2VuKTsKIH0KIAotdm9p ZCBNYW5hZ2VkVGV4dHVyZTo6YmluZFRleHR1cmUoR3JhcGhpY3NDb250ZXh0M0QqIGNvbnRleHQs IFRleHR1cmVBbGxvY2F0b3IqIGFsbG9jYXRvcikKK3ZvaWQgTWFuYWdlZFRleHR1cmU6OmFsbG9j YXRlKFRleHR1cmVBbGxvY2F0b3IqIGFsbG9jYXRvcikKIHsKICAgICBBU1NFUlQobV90ZXh0dXJl TWFuYWdlci0+aGFzVGV4dHVyZShtX3Rva2VuKSk7CiAgICAgaWYgKCFtX3RleHR1cmVJZCkKICAg ICAgICAgbV90ZXh0dXJlSWQgPSBtX3RleHR1cmVNYW5hZ2VyLT5hbGxvY2F0ZVRleHR1cmUoYWxs b2NhdG9yLCBtX3Rva2VuKTsKK30KKwordm9pZCBNYW5hZ2VkVGV4dHVyZTo6YmluZFRleHR1cmUo R3JhcGhpY3NDb250ZXh0M0QqIGNvbnRleHQsIFRleHR1cmVBbGxvY2F0b3IqIGFsbG9jYXRvcikK K3sKKyAgICBhbGxvY2F0ZShhbGxvY2F0b3IpOwogICAgIGNvbnRleHQtPmJpbmRUZXh0dXJlKEdy YXBoaWNzQ29udGV4dDNEOjpURVhUVVJFXzJELCBtX3RleHR1cmVJZCk7CiB9CiAKIHZvaWQgTWFu YWdlZFRleHR1cmU6OmZyYW1lYnVmZmVyVGV4dHVyZTJEKEdyYXBoaWNzQ29udGV4dDNEKiBjb250 ZXh0LCBUZXh0dXJlQWxsb2NhdG9yKiBhbGxvY2F0b3IpCiB7Ci0gICAgQVNTRVJUKG1fdGV4dHVy ZU1hbmFnZXItPmhhc1RleHR1cmUobV90b2tlbikpOwotICAgIGlmICghbV90ZXh0dXJlSWQpCi0g ICAgICAgIG1fdGV4dHVyZUlkID0gbV90ZXh0dXJlTWFuYWdlci0+YWxsb2NhdGVUZXh0dXJlKGFs bG9jYXRvciwgbV90b2tlbik7CisgICAgYWxsb2NhdGUoYWxsb2NhdG9yKTsKICAgICBjb250ZXh0 LT5mcmFtZWJ1ZmZlclRleHR1cmUyRChHcmFwaGljc0NvbnRleHQzRDo6RlJBTUVCVUZGRVIsIEdy YXBoaWNzQ29udGV4dDNEOjpDT0xPUl9BVFRBQ0hNRU5UMCwgR3JhcGhpY3NDb250ZXh0M0Q6OlRF WFRVUkVfMkQsIG1fdGV4dHVyZUlkLCAwKTsKIH0KIApJbmRleDogU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTWFuYWdlZFRleHR1cmUuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9NYW5hZ2VkVGV4dHVyZS5o CShyZXZpc2lvbiAxMDI5NzQpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9NYW5hZ2VkVGV4dHVyZS5oCSh3b3JraW5nIGNvcHkpCkBAIC01NSw2ICs1NSw3IEBA IHB1YmxpYzoKICAgICAgICAgcmV0dXJuIG1fdGV4dHVyZU1hbmFnZXItPmlzUHJvdGVjdGVkKG1f dG9rZW4pOwogICAgIH0KIAorICAgIHZvaWQgYWxsb2NhdGUoVGV4dHVyZUFsbG9jYXRvciopOwog ICAgIHZvaWQgYmluZFRleHR1cmUoR3JhcGhpY3NDb250ZXh0M0QqLCBUZXh0dXJlQWxsb2NhdG9y Kik7CiAgICAgdm9pZCBmcmFtZWJ1ZmZlclRleHR1cmUyRChHcmFwaGljc0NvbnRleHQzRCosIFRl eHR1cmVBbGxvY2F0b3IqKTsKIAo=