74838 2011-12-18 23:03:17 -0800 Enable <track> for Mac build 2012-01-06 16:43:20 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson joepeck sam webkit-bug-importer webkit.review.bot oldest_to_newest 523749 0 eric.carlson 2011-12-18 23:03:17 -0800 Define ENABLE_VIDEO_TRACK and initialize the runtime feature to true; 523750 1 119821 eric.carlson 2011-12-18 23:04:01 -0800 Created attachment 119821 Proposed patch 523752 2 webkit.review.bot 2011-12-18 23:05:22 -0800 Attachment 119821 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/wtf/Platform.h', u'S..." exit_code: 1 Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp:177: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 523755 3 119821 darin 2011-12-18 23:10:46 -0800 Comment on attachment 119821 Proposed patch No change log here. Turning this on is fine. 523913 4 eric.carlson 2011-12-19 07:59:50 -0800 http://trac.webkit.org/changeset/103240 531515 5 joepeck 2012-01-06 16:42:58 -0800 The FeatureDefines files are normally identical across all Mac projects (JSC, WC, WK, WK2). This patch missed JavaScriptCore's FeatureDefines file but modified all the others, and modified Platform.h. Is the JSC diff necessary or was that just missed by accident? 531516 6 webkit-bug-importer 2012-01-06 16:43:20 -0800 <rdar://problem/10658329> 119821 2011-12-18 23:04:01 -0800 2011-12-18 23:10:46 -0800 Proposed patch patch_configuration.txt text/plain 2901 eric.carlson SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDEwMTc4OCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpA QCAtNTQzLDYgKzU0Myw3IEBACiAjZGVmaW5lIEVOQUJMRV9TTU9PVEhfU0NST0xMSU5HIDEKICNk ZWZpbmUgRU5BQkxFX1dFQl9BUkNISVZFIDEKICNkZWZpbmUgRU5BQkxFX1dFQl9BVURJTyAxCisj ZGVmaW5lIEVOQUJMRV9WSURFT19UUkFDSyAxCiAjZW5kaWYgLyogUExBVEZPUk0oTUFDKSAmJiAh UExBVEZPUk0oSU9TKSAqLwogCiAjaWYgUExBVEZPUk0oQ0hST01JVU0pICYmIE9TKERBUldJTikK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29u ZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVE ZWZpbmVzLnhjY29uZmlnCShyZXZpc2lvbiAxMDE3ODgpCisrKyBTb3VyY2UvV2ViQ29yZS9Db25m aWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtMTEw LDcgKzExMCw3IEBAIEVOQUJMRV9TVkcgPSBFTkFCTEVfU1ZHOwogRU5BQkxFX1NWR19GT05UUyA9 IEVOQUJMRV9TVkdfRk9OVFM7CiBFTkFCTEVfVE9VQ0hfSUNPTl9MT0FESU5HID0gOwogRU5BQkxF X1ZJREVPID0gRU5BQkxFX1ZJREVPOwotRU5BQkxFX1ZJREVPX1RSQUNLID0gOworRU5BQkxFX1ZJ REVPX1RSQUNLID0gRU5BQkxFX1ZJREVPX1RSQUNLOwogRU5BQkxFX1dFQkdMID0gRU5BQkxFX1dF QkdMOwogRU5BQkxFX1dFQl9BVURJTyA9IEVOQUJMRV9XRUJfQVVESU87CiBFTkFCTEVfV0VCX1NP Q0tFVFMgPSBFTkFCTEVfV0VCX1NPQ0tFVFM7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRGZWF0dXJlcy5jcHAJKHJl dmlzaW9uIDEwMzA2MykKKysrIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2dlbmVyaWMvUnVudGlt ZUVuYWJsZWRGZWF0dXJlcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE3Myw3ICsxNzMsMTEgQEAg Ym9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc01lZGlhU291cgogI2VuZGlmCiAKICNpZiBF TkFCTEUoVklERU9fVFJBQ0spCi1ib29sIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzVmlkZW9U cmFja0VuYWJsZWQgPSBmYWxzZTsKKyNpZiBQTEFURk9STShNQUMpCisgICAgYm9vbCBSdW50aW1l RW5hYmxlZEZlYXR1cmVzOjppc1ZpZGVvVHJhY2tFbmFibGVkID0gdHJ1ZTsKKyNlbHNlCisgICAg Ym9vbCBSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjppc1ZpZGVvVHJhY2tFbmFibGVkID0gZmFsc2U7 CisjZW5kaWYKICNlbmRpZgogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9Db25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZpZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9GZWF0dXJlRGVmaW5lcy54Y2NvbmZp ZwkocmV2aXNpb24gMTAxNzg4KQorKysgU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlvbnMvRmVh dHVyZURlZmluZXMueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTExMCw3ICsxMTAsNyBAQCBF TkFCTEVfU1ZHID0gRU5BQkxFX1NWRzsKIEVOQUJMRV9TVkdfRk9OVFMgPSBFTkFCTEVfU1ZHX0ZP TlRTOwogRU5BQkxFX1RPVUNIX0lDT05fTE9BRElORyA9IDsKIEVOQUJMRV9WSURFTyA9IEVOQUJM RV9WSURFTzsKLUVOQUJMRV9WSURFT19UUkFDSyA9IDsKK0VOQUJMRV9WSURFT19UUkFDSyA9IEVO QUJMRV9WSURFT19UUkFDSzsKIEVOQUJMRV9XRUJHTCA9IEVOQUJMRV9XRUJHTDsKIEVOQUJMRV9X RUJfQVVESU8gPSBFTkFCTEVfV0VCX0FVRElPOwogRU5BQkxFX1dFQl9TT0NLRVRTID0gRU5BQkxF X1dFQl9TT0NLRVRTOwpJbmRleDogU291cmNlL1dlYktpdC9tYWMvQ29uZmlndXJhdGlvbnMvRmVh dHVyZURlZmluZXMueGNjb25maWcKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvQ29u ZmlndXJhdGlvbnMvRmVhdHVyZURlZmluZXMueGNjb25maWcJKHJldmlzaW9uIDEwMTc4OCkKKysr IFNvdXJjZS9XZWJLaXQvbWFjL0NvbmZpZ3VyYXRpb25zL0ZlYXR1cmVEZWZpbmVzLnhjY29uZmln CSh3b3JraW5nIGNvcHkpCkBAIC0xMTAsNyArMTEwLDcgQEAgRU5BQkxFX1NWRyA9IEVOQUJMRV9T Vkc7CiBFTkFCTEVfU1ZHX0ZPTlRTID0gRU5BQkxFX1NWR19GT05UUzsKIEVOQUJMRV9UT1VDSF9J Q09OX0xPQURJTkcgPSA7CiBFTkFCTEVfVklERU8gPSBFTkFCTEVfVklERU87Ci1FTkFCTEVfVklE RU9fVFJBQ0sgPSA7CitFTkFCTEVfVklERU9fVFJBQ0sgPSBFTkFCTEVfVklERU9fVFJBQ0s7CiBF TkFCTEVfV0VCR0wgPSBFTkFCTEVfV0VCR0w7CiBFTkFCTEVfV0VCX0FVRElPID0gRU5BQkxFX1dF Ql9BVURJTzsKIEVOQUJMRV9XRUJfU09DS0VUUyA9IEVOQUJMRV9XRUJfU09DS0VUUzsK