74834 2011-12-18 19:22:24 -0800 Update dropzone implementation per spec update 2012-01-03 14:21:50 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned ojan tony webkit.review.bot oldest_to_newest 523654 0 yael 2011-12-18 19:22:24 -0800 Per https://bugs.webkit.org/show_bug.cgi?id=58210#c43 the spec has changed, so the webkit implementation needs an update. 523660 1 119802 yael 2011-12-18 19:32:43 -0800 Created attachment 119802 Patch Update support for dropzone attribute to use file: and string: instead of f: and s:. 523796 2 119802 kenneth 2011-12-19 01:02:41 -0800 Comment on attachment 119802 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119802&action=review > Source/WebCore/ChangeLog:11 > + Update support for dropzone attribute to use file: and string: instead of f: and s:. > + > + No new tests. Existing tests over this and were updated. > + Maybe you should say what spec this is part of? 523884 3 119858 yael 2011-12-19 06:34:28 -0800 Created attachment 119858 Patch. Added link to the spec. 523973 4 119858 tony 2011-12-19 10:25:17 -0800 Comment on attachment 119858 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=119858&action=review > Source/WebCore/dom/Clipboard.cpp:213 > + if (keyword.length() > 5 && keyword.startsWith("file:")) Nit: startsWith will check the length for you so you can remove the length() > 5 check. > Source/WebCore/dom/Clipboard.cpp:216 > + if (keyword.length() > 7 && keyword.startsWith("string:")) Remove the length() > 7 check. 524267 5 119942 yael 2011-12-19 16:20:22 -0800 Created attachment 119942 Patch for landing Thanks for the review, Tony :) 524422 6 119942 webkit.review.bot 2011-12-19 21:27:14 -0800 Comment on attachment 119942 Patch for landing Clearing flags on attachment: 119942 Committed r103303: <http://trac.webkit.org/changeset/103303> 524423 7 webkit.review.bot 2011-12-19 21:27:18 -0800 All reviewed patches have been landed. Closing bug. 529063 8 tony 2012-01-03 14:21:50 -0800 *** Bug 75495 has been marked as a duplicate of this bug. *** 119802 2011-12-18 19:32:43 -0800 2011-12-19 06:34:28 -0800 Patch 74834.patch text/plain 4957 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzIxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDExLTEyLTE4ICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBVcGRhdGUgZHJvcHpvbmUg aW1wbGVtZW50YXRpb24gcGVyIHNwZWMgdXBkYXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDgzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBzdXBwb3J0IGZvciBkcm9wem9uZSBhdHRyaWJ1 dGUgdG8gdXNlIGZpbGU6IGFuZCBzdHJpbmc6IGluc3RlYWQgb2YgZjogYW5kIHM6LiAKKworICAg ICAgICBObyBuZXcgdGVzdHMuIEV4aXN0aW5nIHRlc3RzIG92ZXIgdGhpcyBhbmQgd2VyZSB1cGRh dGVkLgorCisgICAgICAgICogZG9tL0NsaXBib2FyZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD bGlwYm9hcmQ6Omhhc0Ryb3Bab25lVHlwZSk6CisKIDIwMTEtMTItMTggIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIxMDMyMDUuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcAkocmV2aXNpb24g MTAyODQ2KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTIxMCwxNyArMjEwLDEzIEBAIFN0cmluZyBjb252ZXJ0RHJhZ09wZXJhdGlvblRvRHJv cFpvbmVPcGUKIAogYm9vbCBDbGlwYm9hcmQ6Omhhc0Ryb3Bab25lVHlwZShjb25zdCBTdHJpbmcm IGtleXdvcmQpCiB7Ci0gICAgaWYgKGtleXdvcmQubGVuZ3RoKCkgPCAzIHx8IGtleXdvcmRbMV0g IT0gJzonKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIAotICAgIHN3aXRjaCAoa2V5 d29yZFswXSkgewotICAgIGNhc2UgJ2YnOgotICAgICAgICByZXR1cm4gaGFzRmlsZU9mVHlwZShr ZXl3b3JkLnN1YnN0cmluZygyKSk7Ci0gICAgY2FzZSAncyc6Ci0gICAgICAgIHJldHVybiBoYXNT dHJpbmdPZlR5cGUoa2V5d29yZC5zdWJzdHJpbmcoMikpOwotICAgIGRlZmF1bHQ6Ci0gICAgICAg IHJldHVybiBmYWxzZTsKLSAgICB9CisgICAgaWYgKGtleXdvcmQubGVuZ3RoKCkgPiA1ICYmIGtl eXdvcmQuc3RhcnRzV2l0aCgiZmlsZToiKSkKKyAgICAgICAgcmV0dXJuIGhhc0ZpbGVPZlR5cGUo a2V5d29yZC5zdWJzdHJpbmcoNSkpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAKKyAg ICBpZiAoa2V5d29yZC5sZW5ndGgoKSA+IDcgJiYga2V5d29yZC5zdGFydHNXaXRoKCJzdHJpbmc6 IikpCisgICAgICAgIHJldHVybiBoYXNTdHJpbmdPZlR5cGUoa2V5d29yZC5zdWJzdHJpbmcoNykp OworCisgICAgcmV0dXJuIGZhbHNlOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4 OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCShyZXZpc2lvbiAxMDMyMTApCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0xMi0xOCAgWWFlbCBBaGFyb24gIDx5YWVsLmFo YXJvbkBub2tpYS5jb20+CisKKyAgICAgICAgVXBkYXRlIGRyb3B6b25lIGltcGxlbWVudGF0aW9u IHBlciBzcGVjIHVwZGF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NzQ4MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBVcGRhdGUgdGhlIHRlc3RzIHBlciBzcGVjIGNoYW5nZS4KKworICAgICAgICAqIGZh c3QvZXZlbnRzL2Ryb3B6b25lLTAwMS5odG1sOgorICAgICAgICAqIGZhc3QvZXZlbnRzL2Ryb3B6 b25lLTAwMi5odG1sOgorICAgICAgICAqIGZhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMy5odG1sOgor ICAgICAgICAqIGZhc3QvZXZlbnRzL2Ryb3B6b25lLTAwNC5odG1sOgorCiAyMDExLTEyLTE4ICBE YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUG9zaXRpb25lZCBGbG9h dHM6IEFzc2VydGlvbiBoaXQgaW4gZmFzdC9ibG9jay9wb3NpdGlvbmluZy9wb3NpdGlvbmVkLWZs b2F0LWxheW91dC1hZnRlci1pbWFnZS1sb2FkLmh0bWwKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL2Ryb3B6b25lLTAwMS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL2Ryb3B6b25lLTAwMS5odG1sCShyZXZpc2lvbiAxMDI4NDYpCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0wMDEuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMzQsNyAr MzQsNyBAQCB3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKQogCiBmdW5jdGlvbiBjaGFuZ2VEcm9w Wm9uZSgpCiB7Ci0gICAgZHJvcFRhcmdldC5zZXRBdHRyaWJ1dGUoIndlYmtpdGRyb3B6b25lIiwg ZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tkcm9wRWZmZWN0RWxlbS5zZWxlY3RlZEluZGV4XS52YWx1 ZSArICIgczp0ZXh0L3BsYWluIik7CisgICAgZHJvcFRhcmdldC5zZXRBdHRyaWJ1dGUoIndlYmtp dGRyb3B6b25lIiwgZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tkcm9wRWZmZWN0RWxlbS5zZWxlY3Rl ZEluZGV4XS52YWx1ZSArICIgc3RyaW5nOnRleHQvcGxhaW4iKTsKIH0KIAogZnVuY3Rpb24gZHJh Z1N0YXJ0KGUpCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0wMDIuaHRt bAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0wMDIuaHRt bAkocmV2aXNpb24gMTAyODQ2KQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJvcHpvbmUt MDAyLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDcgQEAgd2luZG93Lm9ubG9hZCA9 IGZ1bmN0aW9uKCkKIAogZnVuY3Rpb24gY2hhbmdlRHJvcFpvbmUoKQogewotICAgIGRyb3BUYXJn ZXQuc2V0QXR0cmlidXRlKCJ3ZWJraXRkcm9wem9uZSIsICIgUzp0ZXh0L3BsYWluIHM6dXJsICIg KyBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZh bHVlKTsKKyAgICBkcm9wVGFyZ2V0LnNldEF0dHJpYnV0ZSgid2Via2l0ZHJvcHpvbmUiLCAiIFN0 UmluRzp0ZXh0L3BsYWluIHNUcklORzp1cmwgIiArIGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJv cEVmZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUpOwogfQogCiBmdW5jdGlvbiBwcmludERy b3BFdmVudChlKQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJvcHpvbmUtMDAzLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJvcHpvbmUtMDAzLmh0 bWwJKHJldmlzaW9uIDEwMjg0NikKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25l LTAwMy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw3ICszMiw3IEBAIHdpbmRvdy5vbmxvYWQg PSBmdW5jdGlvbigpCiAKIGZ1bmN0aW9uIGNoYW5nZURyb3Bab25lKCkKIHsKLSAgICBkcm9wVGFy Z2V0LnNldEF0dHJpYnV0ZSgid2Via2l0ZHJvcHpvbmUiLCBkcm9wRWZmZWN0RWxlbS5vcHRpb25z W2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlICsgIiBzOnRleHQvcGxhaW4gczph bnkvdHlwZSIpOworICAgIGRyb3BUYXJnZXQuc2V0QXR0cmlidXRlKCJ3ZWJraXRkcm9wem9uZSIs IGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFs dWUgKyAiIHN0cmluZzp0ZXh0L3BsYWluIHN0cmluZzphbnkvdHlwZSIpOwogfQogCiBmdW5jdGlv biBwcmludERyb3BFdmVudChlKQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJvcHpv bmUtMDA0Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJvcHpv bmUtMDA0Lmh0bWwJKHJldmlzaW9uIDEwMjg0NikKKysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRz L2Ryb3B6b25lLTAwNC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw3ICsyOSw3IEBAIHdpbmRv dy5vbmxvYWQgPSBmdW5jdGlvbigpCiAKIGZ1bmN0aW9uIGNoYW5nZURyb3Bab25lKCkKIHsKLSAg ICBkcm9wVGFyZ2V0LnNldEF0dHJpYnV0ZSgid2Via2l0ZHJvcHpvbmUiLCBkcm9wRWZmZWN0RWxl bS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlICsgIiBmOnRleHQv aHRtbCIpOworICAgIGRyb3BUYXJnZXQuc2V0QXR0cmlidXRlKCJ3ZWJraXRkcm9wem9uZSIsIGRy b3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUg KyAiIGZpbGU6dGV4dC9odG1sIik7CiB9CiAKIGZ1bmN0aW9uIHByaW50RHJvcEV2ZW50KGUpCg== 119858 2011-12-19 06:34:28 -0800 2011-12-19 16:20:22 -0800 Patch. 74834.patch text/plain 5041 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzIxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTE4ICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBVcGRhdGUgZHJvcHpvbmUg aW1wbGVtZW50YXRpb24gcGVyIHNwZWMgdXBkYXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDgzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBzdXBwb3J0IGZvciBkcm9wem9uZSBhdHRyaWJ1 dGUgdG8gdXNlIGZpbGU6IGFuZCBzdHJpbmc6IGluc3RlYWQgb2YgZjogYW5kIHM6LiAKKyAgICAg ICAgaHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1cnJlbnQtd29yay8jdGhl LWRyb3B6b25lLWF0dHJpYnV0ZQorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gRXhpc3RpbmcgdGVz dHMgY292ZXIgdGhpcyBhbmQgd2VyZSB1cGRhdGVkLgorCisgICAgICAgICogZG9tL0NsaXBib2Fy ZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDbGlwYm9hcmQ6Omhhc0Ryb3Bab25lVHlwZSk6CisK IDIwMTEtMTItMTggIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMDMyMDUuCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9k b20vQ2xpcGJvYXJkLmNwcAkocmV2aXNpb24gMTAyODQ2KQorKysgU291cmNlL1dlYkNvcmUvZG9t L0NsaXBib2FyZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIxMCwxNyArMjEwLDEzIEBAIFN0cmlu ZyBjb252ZXJ0RHJhZ09wZXJhdGlvblRvRHJvcFpvbmVPcGUKIAogYm9vbCBDbGlwYm9hcmQ6Omhh c0Ryb3Bab25lVHlwZShjb25zdCBTdHJpbmcmIGtleXdvcmQpCiB7Ci0gICAgaWYgKGtleXdvcmQu bGVuZ3RoKCkgPCAzIHx8IGtleXdvcmRbMV0gIT0gJzonKQotICAgICAgICByZXR1cm4gZmFsc2U7 Ci0gICAgICAgIAotICAgIHN3aXRjaCAoa2V5d29yZFswXSkgewotICAgIGNhc2UgJ2YnOgotICAg ICAgICByZXR1cm4gaGFzRmlsZU9mVHlwZShrZXl3b3JkLnN1YnN0cmluZygyKSk7Ci0gICAgY2Fz ZSAncyc6Ci0gICAgICAgIHJldHVybiBoYXNTdHJpbmdPZlR5cGUoa2V5d29yZC5zdWJzdHJpbmco MikpOwotICAgIGRlZmF1bHQ6Ci0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICB9CisgICAgaWYg KGtleXdvcmQubGVuZ3RoKCkgPiA1ICYmIGtleXdvcmQuc3RhcnRzV2l0aCgiZmlsZToiKSkKKyAg ICAgICAgcmV0dXJuIGhhc0ZpbGVPZlR5cGUoa2V5d29yZC5zdWJzdHJpbmcoNSkpOworICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAKKyAgICBpZiAoa2V5d29yZC5sZW5ndGgoKSA+IDcgJiYg a2V5d29yZC5zdGFydHNXaXRoKCJzdHJpbmc6IikpCisgICAgICAgIHJldHVybiBoYXNTdHJpbmdP ZlR5cGUoa2V5d29yZC5zdWJzdHJpbmcoNykpOworCisgICAgcmV0dXJuIGZhbHNlOwogfQogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDMyMTApCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0x Mi0xOCAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBub2tpYS5jb20+CisKKyAgICAgICAgVXBk YXRlIGRyb3B6b25lIGltcGxlbWVudGF0aW9uIHBlciBzcGVjIHVwZGF0ZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ4MzQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhlIHRlc3RzIHBlciBz cGVjIGNoYW5nZS4KKworICAgICAgICAqIGZhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMS5odG1sOgor ICAgICAgICAqIGZhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMi5odG1sOgorICAgICAgICAqIGZhc3Qv ZXZlbnRzL2Ryb3B6b25lLTAwMy5odG1sOgorICAgICAgICAqIGZhc3QvZXZlbnRzL2Ryb3B6b25l LTAwNC5odG1sOgorCiAyMDExLTEyLTE4ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+ CiAKICAgICAgICAgUG9zaXRpb25lZCBGbG9hdHM6IEFzc2VydGlvbiBoaXQgaW4gZmFzdC9ibG9j ay9wb3NpdGlvbmluZy9wb3NpdGlvbmVkLWZsb2F0LWxheW91dC1hZnRlci1pbWFnZS1sb2FkLmh0 bWwKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMS5odG1sCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMS5odG1sCShyZXZp c2lvbiAxMDI4NDYpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0wMDEuaHRt bAkod29ya2luZyBjb3B5KQpAQCAtMzQsNyArMzQsNyBAQCB3aW5kb3cub25sb2FkID0gZnVuY3Rp b24oKQogCiBmdW5jdGlvbiBjaGFuZ2VEcm9wWm9uZSgpCiB7Ci0gICAgZHJvcFRhcmdldC5zZXRB dHRyaWJ1dGUoIndlYmtpdGRyb3B6b25lIiwgZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tkcm9wRWZm ZWN0RWxlbS5zZWxlY3RlZEluZGV4XS52YWx1ZSArICIgczp0ZXh0L3BsYWluIik7CisgICAgZHJv cFRhcmdldC5zZXRBdHRyaWJ1dGUoIndlYmtpdGRyb3B6b25lIiwgZHJvcEVmZmVjdEVsZW0ub3B0 aW9uc1tkcm9wRWZmZWN0RWxlbS5zZWxlY3RlZEluZGV4XS52YWx1ZSArICIgc3RyaW5nOnRleHQv cGxhaW4iKTsKIH0KIAogZnVuY3Rpb24gZHJhZ1N0YXJ0KGUpCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9kcm9wem9uZS0wMDIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2V2ZW50cy9kcm9wem9uZS0wMDIuaHRtbAkocmV2aXNpb24gMTAyODQ2KQorKysgTGF5b3V0 VGVzdHMvZmFzdC9ldmVudHMvZHJvcHpvbmUtMDAyLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTMy LDcgKzMyLDcgQEAgd2luZG93Lm9ubG9hZCA9IGZ1bmN0aW9uKCkKIAogZnVuY3Rpb24gY2hhbmdl RHJvcFpvbmUoKQogewotICAgIGRyb3BUYXJnZXQuc2V0QXR0cmlidXRlKCJ3ZWJraXRkcm9wem9u ZSIsICIgUzp0ZXh0L3BsYWluIHM6dXJsICIgKyBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BF ZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlKTsKKyAgICBkcm9wVGFyZ2V0LnNldEF0dHJp YnV0ZSgid2Via2l0ZHJvcHpvbmUiLCAiIFN0UmluRzp0ZXh0L3BsYWluIHNUcklORzp1cmwgIiAr IGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFs dWUpOwogfQogCiBmdW5jdGlvbiBwcmludERyb3BFdmVudChlKQpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvZHJvcHpvbmUtMDAzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvZHJvcHpvbmUtMDAzLmh0bWwJKHJldmlzaW9uIDEwMjg0NikKKysrIExheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0z Miw3ICszMiw3IEBAIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpCiAKIGZ1bmN0aW9uIGNoYW5n ZURyb3Bab25lKCkKIHsKLSAgICBkcm9wVGFyZ2V0LnNldEF0dHJpYnV0ZSgid2Via2l0ZHJvcHpv bmUiLCBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhd LnZhbHVlICsgIiBzOnRleHQvcGxhaW4gczphbnkvdHlwZSIpOworICAgIGRyb3BUYXJnZXQuc2V0 QXR0cmlidXRlKCJ3ZWJraXRkcm9wem9uZSIsIGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVm ZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUgKyAiIHN0cmluZzp0ZXh0L3BsYWluIHN0cmlu ZzphbnkvdHlwZSIpOwogfQogCiBmdW5jdGlvbiBwcmludERyb3BFdmVudChlKQpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJvcHpvbmUtMDA0Lmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJvcHpvbmUtMDA0Lmh0bWwJKHJldmlzaW9uIDEwMjg0NikK KysrIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwNC5odG1sCSh3b3JraW5nIGNv cHkpCkBAIC0yOSw3ICsyOSw3IEBAIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpCiAKIGZ1bmN0 aW9uIGNoYW5nZURyb3Bab25lKCkKIHsKLSAgICBkcm9wVGFyZ2V0LnNldEF0dHJpYnV0ZSgid2Vi a2l0ZHJvcHpvbmUiLCBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVj dGVkSW5kZXhdLnZhbHVlICsgIiBmOnRleHQvaHRtbCIpOworICAgIGRyb3BUYXJnZXQuc2V0QXR0 cmlidXRlKCJ3ZWJraXRkcm9wem9uZSIsIGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVmZmVj dEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUgKyAiIGZpbGU6dGV4dC9odG1sIik7CiB9CiAKIGZ1 bmN0aW9uIHByaW50RHJvcEV2ZW50KGUpCg== 119942 2011-12-19 16:20:22 -0800 2011-12-19 21:27:14 -0800 Patch for landing 74834.patch text/plain 4985 yael SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzIxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTE4ICBZYWVsIEFo YXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAgICBVcGRhdGUgZHJvcHpvbmUg aW1wbGVtZW50YXRpb24gcGVyIHNwZWMgdXBkYXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDgzNAorCisgICAgICAgIFJldmlld2VkIGJ5IFRvbnkg Q2hhbmcuCisKKyAgICAgICAgVXBkYXRlIHN1cHBvcnQgZm9yIGRyb3B6b25lIGF0dHJpYnV0ZSB0 byB1c2UgZmlsZTogYW5kIHN0cmluZzogaW5zdGVhZCBvZiBmOiBhbmQgczouIAorICAgICAgICBo dHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mvd2ViLWFwcHMvY3VycmVudC13b3JrLyN0aGUtZHJv cHpvbmUtYXR0cmlidXRlCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBFeGlzdGluZyB0ZXN0cyBj b3ZlciB0aGlzIGFuZCB3ZXJlIHVwZGF0ZWQuCisKKyAgICAgICAgKiBkb20vQ2xpcGJvYXJkLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNsaXBib2FyZDo6aGFzRHJvcFpvbmVUeXBlKToKKwogMjAx MS0xMi0xOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwMzIwNS4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2RvbS9DbGlwYm9hcmQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9D bGlwYm9hcmQuY3BwCShyZXZpc2lvbiAxMDI4NDYpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vQ2xp cGJvYXJkLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjEwLDE3ICsyMTAsMTMgQEAgU3RyaW5nIGNv bnZlcnREcmFnT3BlcmF0aW9uVG9Ecm9wWm9uZU9wZQogCiBib29sIENsaXBib2FyZDo6aGFzRHJv cFpvbmVUeXBlKGNvbnN0IFN0cmluZyYga2V5d29yZCkKIHsKLSAgICBpZiAoa2V5d29yZC5sZW5n dGgoKSA8IDMgfHwga2V5d29yZFsxXSAhPSAnOicpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAg ICAgICAgCi0gICAgc3dpdGNoIChrZXl3b3JkWzBdKSB7Ci0gICAgY2FzZSAnZic6Ci0gICAgICAg IHJldHVybiBoYXNGaWxlT2ZUeXBlKGtleXdvcmQuc3Vic3RyaW5nKDIpKTsKLSAgICBjYXNlICdz JzoKLSAgICAgICAgcmV0dXJuIGhhc1N0cmluZ09mVHlwZShrZXl3b3JkLnN1YnN0cmluZygyKSk7 Ci0gICAgZGVmYXVsdDoKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIH0KKyAgICBpZiAoa2V5 d29yZC5zdGFydHNXaXRoKCJmaWxlOiIpKQorICAgICAgICByZXR1cm4gaGFzRmlsZU9mVHlwZShr ZXl3b3JkLnN1YnN0cmluZyg1KSk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAorICAg IGlmIChrZXl3b3JkLnN0YXJ0c1dpdGgoInN0cmluZzoiKSkKKyAgICAgICAgcmV0dXJuIGhhc1N0 cmluZ09mVHlwZShrZXl3b3JkLnN1YnN0cmluZyg3KSk7CisKKyAgICByZXR1cm4gZmFsc2U7CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzIxMCkKKysr IExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisy MDExLTEyLTE4ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KKworICAgICAg ICBVcGRhdGUgZHJvcHpvbmUgaW1wbGVtZW50YXRpb24gcGVyIHNwZWMgdXBkYXRlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDgzNAorCisgICAgICAg IFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcuCisKKyAgICAgICAgVXBkYXRlIHRoZSB0ZXN0cyBwZXIg c3BlYyBjaGFuZ2UuCisKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9kcm9wem9uZS0wMDEuaHRtbDoK KyAgICAgICAgKiBmYXN0L2V2ZW50cy9kcm9wem9uZS0wMDIuaHRtbDoKKyAgICAgICAgKiBmYXN0 L2V2ZW50cy9kcm9wem9uZS0wMDMuaHRtbDoKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9kcm9wem9u ZS0wMDQuaHRtbDoKKwogMjAxMS0xMi0xOCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29t PgogCiAgICAgICAgIFBvc2l0aW9uZWQgRmxvYXRzOiBBc3NlcnRpb24gaGl0IGluIGZhc3QvYmxv Y2svcG9zaXRpb25pbmcvcG9zaXRpb25lZC1mbG9hdC1sYXlvdXQtYWZ0ZXItaW1hZ2UtbG9hZC5o dG1sCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0wMDEuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0wMDEuaHRtbAkocmV2 aXNpb24gMTAyODQ2KQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvZHJvcHpvbmUtMDAxLmh0 bWwJKHdvcmtpbmcgY29weSkKQEAgLTM0LDcgKzM0LDcgQEAgd2luZG93Lm9ubG9hZCA9IGZ1bmN0 aW9uKCkKIAogZnVuY3Rpb24gY2hhbmdlRHJvcFpvbmUoKQogewotICAgIGRyb3BUYXJnZXQuc2V0 QXR0cmlidXRlKCJ3ZWJraXRkcm9wem9uZSIsIGRyb3BFZmZlY3RFbGVtLm9wdGlvbnNbZHJvcEVm ZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUgKyAiIHM6dGV4dC9wbGFpbiIpOworICAgIGRy b3BUYXJnZXQuc2V0QXR0cmlidXRlKCJ3ZWJraXRkcm9wem9uZSIsIGRyb3BFZmZlY3RFbGVtLm9w dGlvbnNbZHJvcEVmZmVjdEVsZW0uc2VsZWN0ZWRJbmRleF0udmFsdWUgKyAiIHN0cmluZzp0ZXh0 L3BsYWluIik7CiB9CiAKIGZ1bmN0aW9uIGRyYWdTdGFydChlKQpJbmRleDogTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvZHJvcHpvbmUtMDAyLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9ldmVudHMvZHJvcHpvbmUtMDAyLmh0bWwJKHJldmlzaW9uIDEwMjg0NikKKysrIExheW91 dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMi5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0z Miw3ICszMiw3IEBAIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpCiAKIGZ1bmN0aW9uIGNoYW5n ZURyb3Bab25lKCkKIHsKLSAgICBkcm9wVGFyZ2V0LnNldEF0dHJpYnV0ZSgid2Via2l0ZHJvcHpv bmUiLCAiIFM6dGV4dC9wbGFpbiBzOnVybCAiICsgZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tkcm9w RWZmZWN0RWxlbS5zZWxlY3RlZEluZGV4XS52YWx1ZSk7CisgICAgZHJvcFRhcmdldC5zZXRBdHRy aWJ1dGUoIndlYmtpdGRyb3B6b25lIiwgIiBTdFJpbkc6dGV4dC9wbGFpbiBzVHJJTkc6dXJsICIg KyBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BFZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZh bHVlKTsKIH0KIAogZnVuY3Rpb24gcHJpbnREcm9wRXZlbnQoZSkKSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwMy5odG1sCShyZXZpc2lvbiAxMDI4NDYpCisrKyBMYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0wMDMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MzIsNyArMzIsNyBAQCB3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKQogCiBmdW5jdGlvbiBjaGFu Z2VEcm9wWm9uZSgpCiB7Ci0gICAgZHJvcFRhcmdldC5zZXRBdHRyaWJ1dGUoIndlYmtpdGRyb3B6 b25lIiwgZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tkcm9wRWZmZWN0RWxlbS5zZWxlY3RlZEluZGV4 XS52YWx1ZSArICIgczp0ZXh0L3BsYWluIHM6YW55L3R5cGUiKTsKKyAgICBkcm9wVGFyZ2V0LnNl dEF0dHJpYnV0ZSgid2Via2l0ZHJvcHpvbmUiLCBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BF ZmZlY3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlICsgIiBzdHJpbmc6dGV4dC9wbGFpbiBzdHJp bmc6YW55L3R5cGUiKTsKIH0KIAogZnVuY3Rpb24gcHJpbnREcm9wRXZlbnQoZSkKSW5kZXg6IExh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwNC5odG1sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Ryb3B6b25lLTAwNC5odG1sCShyZXZpc2lvbiAxMDI4NDYp CisrKyBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9kcm9wem9uZS0wMDQuaHRtbAkod29ya2luZyBj b3B5KQpAQCAtMjksNyArMjksNyBAQCB3aW5kb3cub25sb2FkID0gZnVuY3Rpb24oKQogCiBmdW5j dGlvbiBjaGFuZ2VEcm9wWm9uZSgpCiB7Ci0gICAgZHJvcFRhcmdldC5zZXRBdHRyaWJ1dGUoIndl YmtpdGRyb3B6b25lIiwgZHJvcEVmZmVjdEVsZW0ub3B0aW9uc1tkcm9wRWZmZWN0RWxlbS5zZWxl Y3RlZEluZGV4XS52YWx1ZSArICIgZjp0ZXh0L2h0bWwiKTsKKyAgICBkcm9wVGFyZ2V0LnNldEF0 dHJpYnV0ZSgid2Via2l0ZHJvcHpvbmUiLCBkcm9wRWZmZWN0RWxlbS5vcHRpb25zW2Ryb3BFZmZl Y3RFbGVtLnNlbGVjdGVkSW5kZXhdLnZhbHVlICsgIiBmaWxlOnRleHQvaHRtbCIpOwogfQogCiBm dW5jdGlvbiBwcmludERyb3BFdmVudChlKQo=