74827 2011-12-18 17:02:14 -0800 KURL::protocolIs() should handle 8-bit strings. 2011-12-18 18:42:27 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74832 1 kling kling darin oldest_to_newest 523579 0 kling 2011-12-18 17:02:14 -0800 We're unnecessarily converting to 16-bit strings here. 523584 1 119790 kling 2011-12-18 17:20:53 -0800 Created attachment 119790 Patch 523586 2 119790 darin 2011-12-18 17:39:44 -0800 Comment on attachment 119790 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119790&action=review > Source/WebCore/platform/KURL.cpp:1718 > +bool charactersAreProtocol(const CharType* url, const char* protocol) This should have static on it for the same reason that isLetterMatchIgnoringCase does. 523587 3 kling 2011-12-18 17:40:35 -0800 Committed r103199: <http://trac.webkit.org/changeset/103199> 523589 4 kling 2011-12-18 17:48:53 -0800 (In reply to comment #2) > (From update of attachment 119790 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119790&action=review > > > Source/WebCore/platform/KURL.cpp:1718 > > +bool charactersAreProtocol(const CharType* url, const char* protocol) > > This should have static on it for the same reason that isLetterMatchIgnoringCase does. Can I take that as an rs=you to add it? 523591 5 darin 2011-12-18 17:50:36 -0800 Yes. 119790 2011-12-18 17:20:53 -0800 2011-12-18 17:39:44 -0800 Patch bug-74827.diff text/plain 2873 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlOTJmZTkzLi5hYTJhYjQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTEtMTItMTggIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIEtVUkw6OnByb3RvY29sSXMoKSBzaG91bGQgaGFuZGxlIDgtYml0IHN0cmluZ3MuCisgICAg ICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzc0ODI3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vS1VSTC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjppc0xldHRlck1hdGNoSWdub3JpbmdDYXNlKToKKworICAgICAgICAgICAgVHVybmVk IHRoaXMgaW50byBhIHRlbXBsYXRlIG1ldGhvZCBzbyBpdCBjYW4gYmUgdXNlZCBmb3IgYm90aCBV Q2hhciBhbmQgTENoYXIuCisKKyAgICAgICAgKFdlYkNvcmU6OmNoYXJhY3RlcnNBcmVQcm90b2Nv bCk6CisgICAgICAgIChXZWJDb3JlOjpwcm90b2NvbElzKToKKworICAgICAgICAgICAgSGFuZGxl IDgvMTYgYml0IHN0cmluZ3Mgc2VwYXJhdGVseSB0byBhdm9pZCBjb252ZXJzaW9uLgorCisyMDEx LTEyLTE4ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KKwogICAgICAgICBIVE1M QWxsQ29sbGVjdGlvbjogR2V0IHJpZCBvZiBzdGF0ZWZ1bCBuYW1lZEl0ZW0gdHJhdmVyc2FsLgog ICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi83NDgwMz4KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJM LmNwcAppbmRleCA5ZWIxZTJmLi5lY2UyZTE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9LVVJMLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcApA QCAtNjAsNyArNjAsOCBAQCB0eXBlZGVmIFZlY3RvcjxVQ2hhciwgNTEyPiBVQ2hhckJ1ZmZlcjsK IHN0YXRpYyBjb25zdCB1bnNpZ25lZCBtYXhpbXVtVmFsaWRQb3J0TnVtYmVyID0gMHhGRkZFOwog c3RhdGljIGNvbnN0IHVuc2lnbmVkIGludmFsaWRQb3J0TnVtYmVyID0gMHhGRkZGOwogCi1zdGF0 aWMgaW5saW5lIGJvb2wgaXNMZXR0ZXJNYXRjaElnbm9yaW5nQ2FzZShVQ2hhciBjaGFyYWN0ZXIs IGNoYXIgbG93ZXJjYXNlTGV0dGVyKQordGVtcGxhdGU8dHlwZW5hbWUgQ2hhclR5cGU+CitzdGF0 aWMgaW5saW5lIGJvb2wgaXNMZXR0ZXJNYXRjaElnbm9yaW5nQ2FzZShDaGFyVHlwZSBjaGFyYWN0 ZXIsIGNoYXIgbG93ZXJjYXNlTGV0dGVyKQogewogICAgIEFTU0VSVChpc0FTQ0lJTG93ZXIobG93 ZXJjYXNlTGV0dGVyKSk7CiAgICAgcmV0dXJuIChjaGFyYWN0ZXIgfCAweDIwKSA9PSBsb3dlcmNh c2VMZXR0ZXI7CkBAIC02OCwxMiArNjksNiBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaXNMZXR0ZXJN YXRjaElnbm9yaW5nQ2FzZShVQ2hhciBjaGFyYWN0ZXIsIGNoYXIgbG93ZXJjYXNlTGV0dAogCiAj aWYgIVVTRShHT09HTEVVUkwpCiAKLXN0YXRpYyBpbmxpbmUgYm9vbCBpc0xldHRlck1hdGNoSWdu b3JpbmdDYXNlKGNoYXIgY2hhcmFjdGVyLCBjaGFyIGxvd2VyY2FzZUxldHRlcikKLXsKLSAgICBB U1NFUlQoaXNBU0NJSUxvd2VyKGxvd2VyY2FzZUxldHRlcikpOwotICAgIHJldHVybiAoY2hhcmFj dGVyIHwgMHgyMCkgPT0gbG93ZXJjYXNlTGV0dGVyOwotfQotCiBlbnVtIFVSTENoYXJhY3RlckNs YXNzZXMgewogICAgIC8vIGFscGhhIAogICAgIFNjaGVtZUZpcnN0Q2hhciA9IDEgPDwgMCwKQEAg LTE3MTksMTAgKzE3MTQsOSBAQCB2b2lkIEtVUkw6OmNvcHlUb0J1ZmZlcihDaGFyQnVmZmVyJiBi dWZmZXIpIGNvbnN0CiAgICAgY29weUFTQ0lJKG1fc3RyaW5nLCBidWZmZXIuZGF0YSgpKTsKIH0K IAotYm9vbCBwcm90b2NvbElzKGNvbnN0IFN0cmluZyYgdXJsLCBjb25zdCBjaGFyKiBwcm90b2Nv bCkKK3RlbXBsYXRlPHR5cGVuYW1lIENoYXJUeXBlPgorYm9vbCBjaGFyYWN0ZXJzQXJlUHJvdG9j b2woY29uc3QgQ2hhclR5cGUqIHVybCwgY29uc3QgY2hhciogcHJvdG9jb2wpCiB7Ci0gICAgLy8g RG8gdGhlIGNvbXBhcmlzb24gd2l0aG91dCBtYWtpbmcgYSBuZXcgc3RyaW5nIG9iamVjdC4KLSAg ICBhc3NlcnRQcm90b2NvbElzR29vZChwcm90b2NvbCk7CiAgICAgZm9yIChpbnQgaSA9IDA7IDsg KytpKSB7CiAgICAgICAgIGlmICghcHJvdG9jb2xbaV0pCiAgICAgICAgICAgICByZXR1cm4gdXJs W2ldID09ICc6JzsKQEAgLTE3MzEsNiArMTcyNSwxNiBAQCBib29sIHByb3RvY29sSXMoY29uc3Qg U3RyaW5nJiB1cmwsIGNvbnN0IGNoYXIqIHByb3RvY29sKQogICAgIH0KIH0KIAorYm9vbCBwcm90 b2NvbElzKGNvbnN0IFN0cmluZyYgdXJsLCBjb25zdCBjaGFyKiBwcm90b2NvbCkKK3sKKyAgICBh c3NlcnRQcm90b2NvbElzR29vZChwcm90b2NvbCk7CisKKyAgICAvLyBEbyB0aGUgY29tcGFyaXNv biB3aXRob3V0IG1ha2luZyBhIG5ldyBzdHJpbmcgb2JqZWN0LgorICAgIGlmICh1cmwuaXM4Qml0 KCkpCisgICAgICAgIHJldHVybiBjaGFyYWN0ZXJzQXJlUHJvdG9jb2wodXJsLmNoYXJhY3RlcnM4 KCksIHByb3RvY29sKTsKKyAgICByZXR1cm4gY2hhcmFjdGVyc0FyZVByb3RvY29sKHVybC5jaGFy YWN0ZXJzMTYoKSwgcHJvdG9jb2wpOworfQorCiBib29sIGlzVmFsaWRQcm90b2NvbChjb25zdCBT dHJpbmcmIHByb3RvY29sKQogewogICAgIC8vIFJGQzM5ODY6IEFMUEhBICooIEFMUEhBIC8gRElH SVQgLyAiKyIgLyAiLSIgLyAiLiIgKQo=