74817 2011-12-18 12:15:06 -0800 The scrolling coordinator should know about the main frame scroll layer 2011-12-18 12:27:53 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca levin+threading webkit.review.bot oldest_to_newest 523510 0 andersca 2011-12-18 12:15:06 -0800 The scrolling coordinator should know about the main frame scroll layer 523511 1 119773 andersca 2011-12-18 12:16:36 -0800 Created attachment 119773 Patch 523515 2 119773 kling 2011-12-18 12:23:39 -0800 Comment on attachment 119773 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119773&action=review > Source/WebCore/page/ScrollingCoordinator.h:60 > + // Should be called whenever the scroll layer for the given frame changes. > + void setFrameScrollLayer(Frame*, const GraphicsLayer* scrollLayer); > + > // Should be called whenever the geometry of the given frame changes, > // including the visible content rect and the content size. > void syncFrameGeometry(Frame*); frameScrollLayerChanged() and frameGeometryChanged() might be better names for these functions. 523517 3 andersca 2011-12-18 12:27:53 -0800 Committed r103185: <http://trac.webkit.org/changeset/103185> 119773 2011-12-18 12:16:36 -0800 2011-12-18 12:23:39 -0800 Patch bug-74817-20111218121643.patch text/plain 4635 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWZjYzZmYzU1ODI1ZWMx NmFlM2U4MTdiOWFmNWMxMjkxNDA3NTg5Ny4uOTk1OTNiODM3YjBiMGZjZTEzNzc5OWIwNjM3NDEx ZjhmNGY0MjA4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDExLTEyLTE4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgVGhlIHNjcm9sbGlu ZyBjb29yZGluYXRvciBzaG91bGQga25vdyBhYm91dCB0aGUgbWFpbiBmcmFtZSBzY3JvbGwgbGF5 ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0ODE3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWdl L1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmg6CisgICAgICAgICogcGFnZS9tYWMvU2Nyb2xsaW5nQ29v cmRpbmF0b3JNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdUaHJlYWQ6OnRocmVh ZENhbGxiYWNrKToKKyAgICAgICAgTW92ZSB0aGUgKiB0byB3aGVyZSBpdCBiZWxvbmdzLgorCisg ICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvcjo6c2V0RnJhbWVTY3JvbGxMYXll cik6CisgICAgICAgIEtlZXAgdHJhY2sgb2YgdGhlIHVuZGVybHlpbmcgQ0FMYXllciBvZiB0aGUg ZnJhbWUgc2Nyb2xsIGxheWVyLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmVu c3VyZVJvb3RMYXllcik6CisgICAgICAgIENhbGwgU2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNldEZy YW1lU2Nyb2xsTGF5ZXIuCisKKzIwMTEtMTItMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KKwogICAgICAgICBUaGUgc2Nyb2xsaW5nIGNvb3JkaW5hdG9yIHNob3VsZCBr ZWVwIHRyYWNrIG9mIHRoZSBtYWluIGZyYW1lIGdlb21ldHJ5CiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDgxNgogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgKaW5kZXggNjU1YjZlN2M0OTAzYzE4OWNhODNjOGYyOTc4 NmJhNzg5MGQ0YzlkYS4uYmM4MTA5MDllMGNjYWRlMGM1ODM0Y2JlOTUwYzFhMjkzNjlmZjVjMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9TY3JvbGxpbmdDb29yZGluYXRvci5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaApAQCAtMjgsMTQg KzI4LDIwIEBACiAKICNpZiBFTkFCTEUoVEhSRUFERURfU0NST0xMSU5HKQogCisjaW5jbHVkZSAi R3JhcGhpY3NMYXllci5oIgogI2luY2x1ZGUgIkludFJlY3QuaCIKICNpbmNsdWRlIDx3dGYvRm9y d2FyZC5oPgogI2luY2x1ZGUgPHd0Zi9UaHJlYWRTYWZlUmVmQ291bnRlZC5oPgogI2luY2x1ZGUg PHd0Zi9UaHJlYWRpbmcuaD4KIAorI2lmIFBMQVRGT1JNKE1BQykKKyNpbmNsdWRlIDx3dGYvUmV0 YWluUHRyLmg+CisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBGcmFtZTsK K2NsYXNzIEdyYXBoaWNzTGF5ZXI7CiBjbGFzcyBQYWdlOwogY2xhc3MgUGxhdGZvcm1XaGVlbEV2 ZW50OwogCkBAIC00Niw2ICs1Miw5IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgcGFnZURlc3Ryb3ll ZCgpOwogCisgICAgLy8gU2hvdWxkIGJlIGNhbGxlZCB3aGVuZXZlciB0aGUgc2Nyb2xsIGxheWVy IGZvciB0aGUgZ2l2ZW4gZnJhbWUgY2hhbmdlcy4KKyAgICB2b2lkIHNldEZyYW1lU2Nyb2xsTGF5 ZXIoRnJhbWUqLCBjb25zdCBHcmFwaGljc0xheWVyKiBzY3JvbGxMYXllcik7CisKICAgICAvLyBT aG91bGQgYmUgY2FsbGVkIHdoZW5ldmVyIHRoZSBnZW9tZXRyeSBvZiB0aGUgZ2l2ZW4gZnJhbWUg Y2hhbmdlcywKICAgICAvLyBpbmNsdWRpbmcgdGhlIHZpc2libGUgY29udGVudCByZWN0IGFuZCB0 aGUgY29udGVudCBzaXplLgogICAgIHZvaWQgc3luY0ZyYW1lR2VvbWV0cnkoRnJhbWUqKTsKQEAg LTY4LDYgKzc3LDkgQEAgcHJpdmF0ZToKICAgICBNdXRleCBtX21haW5GcmFtZUdlb21ldHJ5TXV0 ZXg7CiAgICAgSW50UmVjdCBtX21haW5GcmFtZVZpc2libGVDb250ZW50UmVjdDsKICAgICBJbnRT aXplIG1fbWFpbkZyYW1lQ29udGVudHNTaXplOworI2lmIFBMQVRGT1JNKE1BQykKKyAgICBSZXRh aW5QdHI8UGxhdGZvcm1MYXllcj4gbV9tYWluRnJhbWVTY3JvbGxMYXllcjsKKyNlbmRpZgogfTsK IAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFn ZS9tYWMvU2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL21h Yy9TY3JvbGxpbmdDb29yZGluYXRvck1hYy5tbQppbmRleCA4NGNmOWY1OWE5NzcyYmMwODQyMTY3 YjI4MzM2Yzk4ZTMwYWM5NTNjLi5mZTZiZjNmMzZjZjUwNzNhMzRiNmMyZDgxZGQ4YTA1YTRiODVm ZTk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL21hYy9TY3JvbGxpbmdDb29yZGlu YXRvck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL21hYy9TY3JvbGxpbmdDb29yZGlu YXRvck1hYy5tbQpAQCAtMjksNiArMjksNyBAQAogCiAjaW1wb3J0ICJTY3JvbGxpbmdDb29yZGlu YXRvci5oIgogCisjaW1wb3J0ICJQYWdlLmgiCiAjaW1wb3J0IDx3dGYvRnVuY3Rpb25hbC5oPgog I2ltcG9ydCA8d3RmL01haW5UaHJlYWQuaD4KICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIuaD4KQEAg LTkyLDcgKzkzLDcgQEAgdm9pZCBTY3JvbGxpbmdUaHJlYWQ6OmNyZWF0ZVRocmVhZElmTmVlZGVk KCkKICAgICB9CiB9CiAKLXZvaWQqIFNjcm9sbGluZ1RocmVhZDo6dGhyZWFkQ2FsbGJhY2sodm9p ZCAqc2Nyb2xsaW5nVGhyZWFkKQordm9pZCogU2Nyb2xsaW5nVGhyZWFkOjp0aHJlYWRDYWxsYmFj ayh2b2lkKiBzY3JvbGxpbmdUaHJlYWQpCiB7CiAgICAgc3RhdGljX2Nhc3Q8U2Nyb2xsaW5nVGhy ZWFkKj4oc2Nyb2xsaW5nVGhyZWFkKS0+dGhyZWFkQm9keSgpOwogCkBAIC0xNTgsNiArMTU5LDIw IEBAIHN0YXRpYyBTY3JvbGxpbmdUaHJlYWQmIHNjcm9sbGluZ1RocmVhZCgpCiAgICAgcmV0dXJu IHNjcm9sbGluZ1RocmVhZDsKIH0KIAordm9pZCBTY3JvbGxpbmdDb29yZGluYXRvcjo6c2V0RnJh bWVTY3JvbGxMYXllcihGcmFtZSogZnJhbWUsIGNvbnN0IEdyYXBoaWNzTGF5ZXIqIHNjcm9sbExh eWVyKQoreworICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CisgICAgQVNTRVJUKG1fcGFnZSk7 CisKKyAgICBpZiAoZnJhbWUgIT0gbV9wYWdlLT5tYWluRnJhbWUoKSkKKyAgICAgICAgcmV0dXJu OworCisgICAgTXV0ZXhMb2NrZXIgbG9ja2VyKG1fbWFpbkZyYW1lR2VvbWV0cnlNdXRleCk7Cisg ICAgbV9tYWluRnJhbWVTY3JvbGxMYXllciA9IHNjcm9sbExheWVyLT5wbGF0Zm9ybUxheWVyKCk7 CisKKyAgICAvLyBGSVhNRTogSW5mb3JtIHRoZSBzY3JvbGxpbmcgdGhyZWFkPworfQorCiBib29s IFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjppc1Njcm9sbGluZ1RocmVhZCgpCiB7CiAgICAgcmV0dXJu IHNjcm9sbGluZ1RocmVhZCgpLmlzQ3VycmVudFRocmVhZCgpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCA4OTczNWExNjA4 MmFjMTQ0MDRjZTE1NDFkMzQ3Njg0NzJmYzI0YTFiLi5lZDIzZWY5MDFiMTgxNDQyYTU0Nzk0ZTY5 NzZlNDE0N2I5NThhMDMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyTGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtMTgwNSw2ICsxODA1LDExIEBAIHZvaWQgUmVuZGVy TGF5ZXJDb21wb3NpdG9yOjplbnN1cmVSb290TGF5ZXIoKQogCiAgICAgICAgICAgICBmcmFtZVZp ZXdEaWRDaGFuZ2VTaXplKCk7CiAgICAgICAgICAgICBmcmFtZVZpZXdEaWRTY3JvbGwobV9yZW5k ZXJWaWV3LT5mcmFtZVZpZXcoKS0+c2Nyb2xsUG9zaXRpb24oKSk7CisKKyNpZiBFTkFCTEUoVEhS RUFERURfU0NST0xMSU5HKQorICAgICAgICAgICAgaWYgKFNjcm9sbGluZ0Nvb3JkaW5hdG9yKiBz Y3JvbGxpbmdDb29yZGluYXRvciA9IHRoaXMtPnNjcm9sbGluZ0Nvb3JkaW5hdG9yKCkpCisgICAg ICAgICAgICAgICAgc2Nyb2xsaW5nQ29vcmRpbmF0b3ItPnNldEZyYW1lU2Nyb2xsTGF5ZXIobV9y ZW5kZXJWaWV3LT5mcmFtZVZpZXcoKS0+ZnJhbWUoKSwgbV9zY3JvbGxMYXllci5nZXQoKSk7Cisj ZW5kaWYKICAgICAgICAgfQogICAgIH0gZWxzZSB7CiAgICAgICAgIGlmIChtX292ZXJmbG93Q29u dHJvbHNIb3N0TGF5ZXIpIHsK