74816 2011-12-18 11:39:07 -0800 The scrolling coordinator should keep track of the main frame geometry 2011-12-18 11:52:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca levin+threading webkit.review.bot oldest_to_newest 523499 0 andersca 2011-12-18 11:39:07 -0800 The scrolling coordinator should keep track of the main frame geometry 523501 1 119772 andersca 2011-12-18 11:41:15 -0800 Created attachment 119772 Patch 523505 2 119772 kling 2011-12-18 11:49:35 -0800 Comment on attachment 119772 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119772&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:1247 > + if (ScrollingCoordinator* scrollingCoordinator = this->scrollingCoordinator()) > + scrollingCoordinator->syncFrameGeometry(m_renderView->frameView()->frame()); Wrong indentation level here. 523507 3 andersca 2011-12-18 11:52:51 -0800 Committed r103182: <http://trac.webkit.org/changeset/103182> 119772 2011-12-18 11:41:15 -0800 2011-12-18 11:49:35 -0800 Patch bug-74816-20111218114122.patch text/plain 6705 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTEwMzc5NWY1OGYyYzVm YjUxY2QzYTgyNzQ1YWU4YWMxNjQyY2FmYi4uMjM5NzU5NmNmMzU5OGUyNjU2ZDAwMmIxZWIyZjQx MGUwZTM1MTdjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDExLTEyLTE4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgVGhlIHNjcm9sbGlu ZyBjb29yZGluYXRvciBzaG91bGQga2VlcCB0cmFjayBvZiB0aGUgbWFpbiBmcmFtZSBnZW9tZXRy eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ4MTYK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2Uv U2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nQ29v cmRpbmF0b3I6OnN5bmNGcmFtZUdlb21ldHJ5KToKKyAgICAgICAgVXBkYXRlIHRoZSBmcmFtZSBn ZW9tZXRyeSBhY2NvcmRpbmdseSB3aGVuIGl0IGNoYW5nZXMuCisKKyAgICAgICAgKiBwYWdlL1Nj cm9sbGluZ0Nvb3JkaW5hdG9yLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQ29t cG9zaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6OmZy YW1lVmlld0RpZENoYW5nZVNpemUpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21w b3NpdG9yOjp1cGRhdGVSb290TGF5ZXJQb3NpdGlvbik6CisgICAgICAgIENhbGwgU2Nyb2xsaW5n Q29vcmRpbmF0b3I6OnN5bmNGcmFtZUdlb21ldHJ5LgorCisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJMYXllckNvbXBvc2l0b3I6OnNjcm9sbGluZ0Nvb3JkaW5hdG9yKToKKyAgICAgICAgQWRkIG5l dyBnZXR0ZXIuCisKKzIwMTEtMTItMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxl LmNvbT4KKwogICAgICAgICBBZGQgYSBzY3JvbGxpbmcgdGhyZWFkIHRvIHRoZSBzY3JvbGxpbmcg Y29vcmRpbmF0b3IKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc0ODE0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2Nyb2xsaW5nQ29v cmRpbmF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TY3JvbGxpbmdDb29yZGluYXRvci5j cHAKaW5kZXggMWM4Y2QzMDI2MzczOWZhOTQxNmEzMTJlZGE5NzU3M2NjODJhMTZmMS4uNDdiZTVl YmUwNjNhNmNmMWQ0NjhlYzEzMWYzYmNhNThiOWU3N2JiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGFnZS9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKQEAgLTI5LDcgKzI5LDEyIEBACiAKICNpbmNs dWRlICJTY3JvbGxpbmdDb29yZGluYXRvci5oIgogCisjaW5jbHVkZSAiRnJhbWUuaCIKKyNpbmNs dWRlICJGcmFtZVZpZXcuaCIKKyNpbmNsdWRlICJJbnRSZWN0LmgiCisjaW5jbHVkZSAiUGFnZS5o IgogI2luY2x1ZGUgPHd0Zi9GdW5jdGlvbmFsLmg+CisjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQu aD4KICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBA IC01NSw2ICs2MCwyNyBAQCB2b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpwYWdlRGVzdHJveWVk KCkKICAgICBtX3BhZ2UgPSAwOwogfQogCit2b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpzeW5j RnJhbWVHZW9tZXRyeShGcmFtZSogZnJhbWUpCit7CisgICAgQVNTRVJUKGlzTWFpblRocmVhZCgp KTsKKyAgICBBU1NFUlQobV9wYWdlKTsKKworICAgIGlmIChmcmFtZSAhPSBtX3BhZ2UtPm1haW5G cmFtZSgpKQorICAgICAgICByZXR1cm47CisKKyAgICBJbnRSZWN0IHZpc2libGVDb250ZW50UmVj dCA9IGZyYW1lLT52aWV3KCktPnZpc2libGVDb250ZW50UmVjdCgpOworICAgIEludFNpemUgY29u dGVudHNTaXplID0gZnJhbWUtPnZpZXcoKS0+Y29udGVudHNTaXplKCk7CisKKyAgICBNdXRleExv Y2tlciBsb2NrZXIobV9tYWluRnJhbWVHZW9tZXRyeU11dGV4KTsKKyAgICBpZiAobV9tYWluRnJh bWVWaXNpYmxlQ29udGVudFJlY3QgPT0gdmlzaWJsZUNvbnRlbnRSZWN0ICYmIG1fbWFpbkZyYW1l Q29udGVudHNTaXplID09IGNvbnRlbnRzU2l6ZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgbV9t YWluRnJhbWVWaXNpYmxlQ29udGVudFJlY3QgPSB2aXNpYmxlQ29udGVudFJlY3Q7CisgICAgbV9t YWluRnJhbWVDb250ZW50c1NpemUgPSBjb250ZW50c1NpemU7CisKKyAgICAvLyBGSVhNRTogSW5m b3JtIHRoZSBzY3JvbGxpbmcgdGhyZWFkIHRoYXQgdGhlIGZyYW1lIGdlb21ldHJ5IGhhcyBjaGFu Z2VkLgorfQorCiBib29sIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjpoYW5kbGVXaGVlbEV2ZW50KGNv bnN0IFBsYXRmb3JtV2hlZWxFdmVudCYpCiB7CiAgICAgLy8gRklYTUU6IEltcGxlbWVudC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaAppbmRleCA5NmIzNDc3NzQw MTcxNzg2YjQ2ZTAwYWE3MzAyZTNkMDE1OGJlODcwLi42NTViNmU3YzQ5MDNjMTg5Y2E4M2M4ZjI5 Nzg2YmE3ODkwZDRjOWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1Njcm9sbGlu Z0Nvb3JkaW5hdG9yLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9TY3JvbGxpbmdDb29yZGlu YXRvci5oCkBAIC0yOCwxMiArMjgsMTQgQEAKIAogI2lmIEVOQUJMRShUSFJFQURFRF9TQ1JPTExJ TkcpCiAKKyNpbmNsdWRlICJJbnRSZWN0LmgiCiAjaW5jbHVkZSA8d3RmL0ZvcndhcmQuaD4KICNp bmNsdWRlIDx3dGYvVGhyZWFkU2FmZVJlZkNvdW50ZWQuaD4KICNpbmNsdWRlIDx3dGYvVGhyZWFk aW5nLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorY2xhc3MgRnJhbWU7CiBjbGFzcyBQYWdl OwogY2xhc3MgUGxhdGZvcm1XaGVlbEV2ZW50OwogCkBAIC00NCw2ICs0NiwxMCBAQCBwdWJsaWM6 CiAKICAgICB2b2lkIHBhZ2VEZXN0cm95ZWQoKTsKIAorICAgIC8vIFNob3VsZCBiZSBjYWxsZWQg d2hlbmV2ZXIgdGhlIGdlb21ldHJ5IG9mIHRoZSBnaXZlbiBmcmFtZSBjaGFuZ2VzLAorICAgIC8v IGluY2x1ZGluZyB0aGUgdmlzaWJsZSBjb250ZW50IHJlY3QgYW5kIHRoZSBjb250ZW50IHNpemUu CisgICAgdm9pZCBzeW5jRnJhbWVHZW9tZXRyeShGcmFtZSopOworCiAgICAgLy8gQ2FuIGJlIGNh bGxlZCBmcm9tIGFueSB0aHJlYWQuIFdpbGwgdHJ5IHRvIGhhbmRsZSB0aGUgd2hlZWwgZXZlbnQg b24gdGhlIHNjcm9sbGluZyB0aHJlYWQsCiAgICAgLy8gYW5kIHJldHVybiBmYWxzZSBpZiB0aGUg ZXZlbnQgbXVzdCBiZSBzZW50IGFnYWluIHRvIHRoZSBXZWJDb3JlIGV2ZW50IGhhbmRsZXIuCiAg ICAgYm9vbCBoYW5kbGVXaGVlbEV2ZW50KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYpOwpAQCAt NTgsNiArNjQsMTAgQEAgcHJpdmF0ZToKIAogcHJpdmF0ZToKICAgICBQYWdlKiBtX3BhZ2U7CisK KyAgICBNdXRleCBtX21haW5GcmFtZUdlb21ldHJ5TXV0ZXg7CisgICAgSW50UmVjdCBtX21haW5G cmFtZVZpc2libGVDb250ZW50UmVjdDsKKyAgICBJbnRTaXplIG1fbWFpbkZyYW1lQ29udGVudHNT aXplOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcAppbmRleCAxNzRlMmNhYzYyNjc0 NGE2NGIwNjZlYTllZDQ0MGU3OTc0MWZiMTNkLi40OGViNjZiMmMxZThhYmI2MGFkNWQ0NDhhOTFj ZWJiN2Y3M2Y5M2Y0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJDb21wb3NpdG9yLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJDb21wb3NpdG9yLmNwcApAQCAtNTYsNiArNTYsMTAgQEAKICNpbmNsdWRlICJIVE1MTWVk aWFFbGVtZW50LmgiCiAjZW5kaWYKIAorI2lmIEVOQUJMRShUSFJFQURFRF9TQ1JPTExJTkcpCisj aW5jbHVkZSAiU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaCIKKyNlbmRpZgorCiAjaWYgUFJPRklMRV9M QVlFUl9SRUJVSUxECiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAjZW5kaWYKQEAgLTk3 OSw2ICs5ODMsMTEgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0b3I6OmZyYW1lVmlld0RpZENo YW5nZVNpemUoKQogICAgICAgICBpZiAobV9sYXllckZvck92ZXJoYW5nQXJlYXMpCiAgICAgICAg ICAgICBtX2xheWVyRm9yT3ZlcmhhbmdBcmVhcy0+c2V0U2l6ZShmcmFtZVZpZXctPmZyYW1lUmVj dCgpLnNpemUoKSk7CiAjZW5kaWYKKworI2lmIEVOQUJMRShUSFJFQURFRF9TQ1JPTExJTkcpCisg ICAgICAgIGlmIChTY3JvbGxpbmdDb29yZGluYXRvciogc2Nyb2xsaW5nQ29vcmRpbmF0b3IgPSB0 aGlzLT5zY3JvbGxpbmdDb29yZGluYXRvcigpKQorICAgICAgICAgICAgc2Nyb2xsaW5nQ29vcmRp bmF0b3ItPnN5bmNGcmFtZUdlb21ldHJ5KGZyYW1lVmlldy0+ZnJhbWUoKSk7CisjZW5kaWYKICAg ICB9CiB9CiAKQEAgLTEyMzIsNiArMTI0MSwxMSBAQCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRv cjo6dXBkYXRlUm9vdExheWVyUG9zaXRpb24oKQogICAgICAgICBGcmFtZVZpZXcqIGZyYW1lVmll dyA9IG1fcmVuZGVyVmlldy0+ZnJhbWVWaWV3KCk7CiAgICAgICAgIG1fY2xpcExheWVyLT5zZXRT aXplKGZyYW1lVmlldy0+dmlzaWJsZUNvbnRlbnRSZWN0KGZhbHNlIC8qIGV4Y2x1ZGUgc2Nyb2xs YmFycyAqLykuc2l6ZSgpKTsKICAgICB9CisKKyNpZiBFTkFCTEUoVEhSRUFERURfU0NST0xMSU5H KQorICAgICAgICBpZiAoU2Nyb2xsaW5nQ29vcmRpbmF0b3IqIHNjcm9sbGluZ0Nvb3JkaW5hdG9y ID0gdGhpcy0+c2Nyb2xsaW5nQ29vcmRpbmF0b3IoKSkKKyAgICAgICAgICAgIHNjcm9sbGluZ0Nv b3JkaW5hdG9yLT5zeW5jRnJhbWVHZW9tZXRyeShtX3JlbmRlclZpZXctPmZyYW1lVmlldygpLT5m cmFtZSgpKTsKKyNlbmRpZgogfQogCiB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6ZGlkU3Rh cnRBY2NlbGVyYXRlZEFuaW1hdGlvbihDU1NQcm9wZXJ0eUlEIHByb3BlcnR5KQpAQCAtMjAwMCw2 ICsyMDE0LDE4IEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpkZXZpY2VPclBhZ2VTY2Fs ZUZhY3RvckNoYW5nZWQoKQogICAgICAgICByb290TGF5ZXItPm5vdGVEZXZpY2VPclBhZ2VTY2Fs ZUZhY3RvckNoYW5nZWRJbmNsdWRpbmdEZXNjZW5kYW50cygpOwogfQogCisjaWYgRU5BQkxFKFRI UkVBREVEX1NDUk9MTElORykKK1Njcm9sbGluZ0Nvb3JkaW5hdG9yKiBSZW5kZXJMYXllckNvbXBv c2l0b3I6OnNjcm9sbGluZ0Nvb3JkaW5hdG9yKCkgY29uc3QKK3sKKyAgICBpZiAoRnJhbWUqIGZy YW1lID0gbV9yZW5kZXJWaWV3LT5mcmFtZVZpZXcoKS0+ZnJhbWUoKSkgeworICAgICAgICBpZiAo UGFnZSogcGFnZSA9IGZyYW1lLT5wYWdlKCkpCisgICAgICAgICAgICByZXR1cm4gcGFnZS0+c2Ny b2xsaW5nQ29vcmRpbmF0b3IoKTsKKyAgICB9CisKKyAgICByZXR1cm4gMDsKK30KKyNlbmRpZgor CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBVU0UoQUNDRUxFUkFURURfQ09N UE9TSVRJTkcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJDb21wb3NpdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21w b3NpdG9yLmgKaW5kZXggNjU3NDE0YmIxNjk4YjkzYmFmYjY4YzZmN2M5NGVlNGNiMjE0Mzk3MC4u ZDQ0Y2Q3MzI5NTFiNjcxM2JiY2JjZTg5ZDQ1OTQyYjg4ZDg5NTM2ZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaApAQCAtNDAsNiArNDAs OSBAQCBjbGFzcyBSZW5kZXJQYXJ0OwogI2lmIEVOQUJMRShWSURFTykKIGNsYXNzIFJlbmRlclZp ZGVvOwogI2VuZGlmCisjaWYgRU5BQkxFKFRIUkVBREVEX1NDUk9MTElORykKK2NsYXNzIFNjcm9s bGluZ0Nvb3JkaW5hdG9yOworI2VuZGlmCiAKIGVudW0gQ29tcG9zaXRpbmdVcGRhdGVUeXBlIHsK ICAgICBDb21wb3NpdGluZ1VwZGF0ZUFmdGVyTGF5b3V0T3JTdHlsZUNoYW5nZSwKQEAgLTI5Myw2 ICsyOTYsMTAgQEAgcHJpdmF0ZToKICAgICBib29sIHJlcXVpcmVzT3ZlcmhhbmdBcmVhc0xheWVy KCkgY29uc3Q7CiAjZW5kaWYKIAorI2lmIEVOQUJMRShUSFJFQURFRF9TQ1JPTExJTkcpCisgICAg U2Nyb2xsaW5nQ29vcmRpbmF0b3IqIHNjcm9sbGluZ0Nvb3JkaW5hdG9yKCkgY29uc3Q7CisjZW5k aWYKKwogcHJpdmF0ZToKICAgICBSZW5kZXJWaWV3KiBtX3JlbmRlclZpZXc7CiAgICAgT3duUHRy PEdyYXBoaWNzTGF5ZXI+IG1fcm9vdENvbnRlbnRMYXllcjsK