74808 2011-12-18 03:17:00 -0800 REGRESSION(r103149): prepare-ChangeLog outputs a warning 2011-12-20 22:38:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73531 1 haraken haraken darin ddkilzer rniwa webkit.review.bot oldest_to_newest 523426 0 haraken 2011-12-18 03:17:00 -0800 After r103149, prepare-ChangeLog outputs the following warning due to missing the prototype declaration of main(). main::main() called too early to check prototype at ./Tools/Scripts/prepare-ChangeLog line 117. 523427 1 119756 haraken 2011-12-18 03:19:41 -0800 Created attachment 119756 Patch 523433 2 119756 ddkilzer 2011-12-18 05:03:15 -0800 Comment on attachment 119756 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119756&action=review r=me > Tools/Scripts/prepare-ChangeLog:67 > +sub main(); Should be in alphabetical order. 523434 3 119759 haraken 2011-12-18 05:08:18 -0800 Created attachment 119759 patch for commit 523435 4 haraken 2011-12-18 05:10:42 -0800 (In reply to comment #2) > (From update of attachment 119756 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119756&action=review > > r=me > > > Tools/Scripts/prepare-ChangeLog:67 > > +sub main(); > > Should be in alphabetical order. Subroutines in this file had been declared in the order in which they defined. I sorted all subroutine declarations in the alphabetical order, and committed. Thanks. 523443 5 119759 webkit.review.bot 2011-12-18 06:43:31 -0800 Comment on attachment 119759 patch for commit Clearing flags on attachment: 119759 Committed r103171: <http://trac.webkit.org/changeset/103171> 119756 2011-12-18 03:19:41 -0800 2011-12-18 05:03:15 -0800 Patch bug-74808-20111218201939.patch text/plain 1135 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMTcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjhiMWQ5Mzc5ODA2MWUyNTdhM2MxZjhkMDRjYmY2YzU1 YjE4ZTE1Ny4uMzkxNDljZTY3OWVkN2I1NWI0ZDBkY2I0YjlkZTAxMzNiZTUzNzMzYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDExLTEyLTE4ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSRUdSRVNTSU9OKHIxMDMxNDkpOiBwcmVwYXJlLUNoYW5nZUxvZyBvdXRwdXRzIGEg d2FybmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzQ4MDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGRlZCB0aGUgcHJvdG90eXBlIGRlY2xhcmF0aW9uIG9mIG1haW4oKSB0byBhdm9pZCB3YXJuaW5n IG1lc3NhZ2VzLgorCisgICAgICAgICogU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZzoKKwogMjAx MS0xMi0xNyAgQWRlbmlsc29uIENhdmFsY2FudGkgIDxjYXZhbGNhbnRpaUBnbWFpbC5jb20+CiAK ICAgICAgICAgW1F0XSBGaXggUXRUZXN0QnJvd3NlciBjb21waWxhdGlvbiB3aXRoIFF0V2lkZ2V0 cyBtb2R1bGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cgYi9U b29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCmluZGV4IDQ2OWQ3ZDRmZmFkMjU3Y2M2YzVi ODhmMTEyMmFmODlkZjRlODMyOTguLjM4NzZkNzUzYjc3OTljYzlmOGMxN2VjODExOGYyN2E5NWJi OTMwNzEgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKKysrIGIv VG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZwpAQCAtNjQsNiArNjQsNyBAQCB1c2UgbGli ICRGaW5kQmluOjpCaW47CiB1c2UgUE9TSVggcXcoc3RyZnRpbWUpOwogdXNlIFZDU1V0aWxzOwog CitzdWIgbWFpbigpOwogc3ViIGNoYW5nZUxvZ0RhdGUoJCk7CiBzdWIgY2hhbmdlTG9nRW1haWxB ZGRyZXNzRnJvbUFyZ3MoJCQpOwogc3ViIGNoYW5nZUxvZ05hbWVGcm9tQXJncygkJCk7Cg== 119759 2011-12-18 05:08:18 -0800 2011-12-18 06:43:31 -0800 patch for commit bug-74808-20111218220816.patch text/plain 3007 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMTcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjhiMWQ5Mzc5ODA2MWUyNTdhM2MxZjhkMDRjYmY2YzU1 YjE4ZTE1Ny4uNzM0MGUxZDMyZTM5ODcxMWU4YjNhZGFhZWM0NDM2NjYwZDFiYjZjOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDExLTEyLTE4ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSRUdSRVNTSU9OKHIxMDMxNDkpOiBwcmVwYXJlLUNoYW5nZUxvZyBvdXRwdXRzIGEg d2FybmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzQ4MDgKKworICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBLaWx6ZXIuCisKKyAgICAgICAgQWRk ZWQgdGhlIHByb3RvdHlwZSBkZWNsYXJhdGlvbiBvZiBtYWluKCkgdG8gYXZvaWQgd2FybmluZyBt ZXNzYWdlcy4KKyAgICAgICAgU29ydGVkIHN1YnJvdXRpbmUgZGVjbGFyYXRpb25zIGluIHRoZSBh bHBoYWJldGljYWwgb3JkZXIuCisKKyAgICAgICAgKiBTY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9n OgorCiAyMDExLTEyLTE3ICBBZGVuaWxzb24gQ2F2YWxjYW50aSAgPGNhdmFsY2FudGlpQGdtYWls LmNvbT4KIAogICAgICAgICBbUXRdIEZpeCBRdFRlc3RCcm93c2VyIGNvbXBpbGF0aW9uIHdpdGgg UXRXaWRnZXRzIG1vZHVsZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5n ZUxvZyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKaW5kZXggNDY5ZDdkNGZmYWQy NTdjYzZjNWI4OGYxMTIyYWY4OWRmNGU4MzI5OC4uNGE2ZDk2MWY1MWIyNWZmMzA3NDg1ZjZlZTky Y2Y3MTcwYWM3ZTEwYiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxv ZworKysgYi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCkBAIC02Nyw0MiArNjcsNDMg QEAgdXNlIFZDU1V0aWxzOwogc3ViIGNoYW5nZUxvZ0RhdGUoJCk7CiBzdWIgY2hhbmdlTG9nRW1h aWxBZGRyZXNzRnJvbUFyZ3MoJCQpOwogc3ViIGNoYW5nZUxvZ05hbWVGcm9tQXJncygkJCk7Ci1z dWIgZmV0Y2hCdWdEZXNjcmlwdGlvbkZyb21VUkwoJCQpOwotc3ViIGZpbmRDaGFuZ2VMb2dzKCQp Owotc3ViIGdldExhdGVzdENoYW5nZUxvZ3MoJCk7Ci1zdWIgcmVzb2x2ZUNvbmZsaWN0ZWRDaGFu Z2VMb2dzKCQpOwotc3ViIGdlbmVyYXRlTmV3Q2hhbmdlTG9ncygkJCQkJCQkJCQkJCk7Ci1zdWIg cHJpbnREaWZmKCQkJCQpOwotc3ViIG9wZW5DaGFuZ2VMb2dzKCQpOwotc3ViIGRpZmZGcm9tVG9T dHJpbmcoJCQkKTsKLXN1YiBkaWZmQ29tbWFuZCgkJCQkKTsKLXN1YiBzdGF0dXNDb21tYW5kKCQk JCQpOwogc3ViIGNyZWF0ZVBhdGNoQ29tbWFuZCgkJCQkKTsKK3N1YiBkZWNvZGVFbnRpdGllcygk KTsKK3N1YiBkZXRlcm1pbmVQcm9wZXJ0eUNoYW5nZXMoJCQkKTsKK3N1YiBkaWZmQ29tbWFuZCgk JCQkKTsKK3N1YiBkaWZmRnJvbVRvU3RyaW5nKCQkJCk7CiBzdWIgZGlmZkhlYWRlckZvcm1hdCgp Oworc3ViIGV4dHJhY3RMaW5lUmFuZ2UoJCk7CitzdWIgZmV0Y2hCdWdEZXNjcmlwdGlvbkZyb21V UkwoJCQpOworc3ViIGZpbmRDaGFuZ2VMb2dzKCQpOwogc3ViIGZpbmRPcmlnaW5hbEZpbGVGcm9t U3ZuKCQpOwotc3ViIGRldGVybWluZVByb3BlcnR5Q2hhbmdlcygkJCQpOwotc3ViIHBsdXJhbGl6 ZUFuZExpc3QoJCRAKTsKIHN1YiBnZW5lcmF0ZUZpbGVMaXN0KFwlJCQkKTsKIHN1YiBnZW5lcmF0 ZUZ1bmN0aW9uTGlzdHMoJCQkJCQpOwotc3ViIGlzVW5tb2RpZmllZFN0YXR1cygkKTsKLXN1YiBp c01vZGlmaWVkU3RhdHVzKCQpOwotc3ViIGlzQWRkZWRTdGF0dXMoJCk7Ci1zdWIgaXNDb25mbGlj dFN0YXR1cygkJCQpOwotc3ViIHN0YXR1c0Rlc2NyaXB0aW9uKCQkJCQpOwotc3ViIHByb3BlcnR5 Q2hhbmdlRGVzY3JpcHRpb24oJCk7Ci1zdWIgZXh0cmFjdExpbmVSYW5nZSgkKTsKLXN1YiB0ZXN0 TGlzdEZvckNoYW5nZUxvZyhAKTsKK3N1YiBnZW5lcmF0ZU5ld0NoYW5nZUxvZ3MoJCQkJCQkJCQk JCQpOworc3ViIGdldExhdGVzdENoYW5nZUxvZ3MoJCk7CiBzdWIgZ2V0X2Z1bmN0aW9uX2xpbmVf cmFuZ2VzKCQkKTsKIHN1YiBnZXRfZnVuY3Rpb25fbGluZV9yYW5nZXNfZm9yX2MoJCQpOwogc3Vi IGdldF9mdW5jdGlvbl9saW5lX3Jhbmdlc19mb3JfamF2YSgkJCk7CiBzdWIgZ2V0X2Z1bmN0aW9u X2xpbmVfcmFuZ2VzX2Zvcl9qYXZhc2NyaXB0KCQkKTsKIHN1YiBnZXRfZnVuY3Rpb25fbGluZV9y YW5nZXNfZm9yX3BlcmwoJCQpOwogc3ViIGdldF9zZWxlY3Rvcl9saW5lX3Jhbmdlc19mb3JfY3Nz KCQkKTsKK3N1YiBpc0FkZGVkU3RhdHVzKCQpOworc3ViIGlzQ29uZmxpY3RTdGF0dXMoJCQkKTsK K3N1YiBpc01vZGlmaWVkU3RhdHVzKCQpOworc3ViIGlzVW5tb2RpZmllZFN0YXR1cygkKTsKK3N1 YiBtYWluKCk7CiBzdWIgbWV0aG9kX2RlY2xfdG9fc2VsZWN0b3IoJCk7CitzdWIgbm9ybWFsaXpl TGluZUVuZGluZ3MoJCQpOworc3ViIG9wZW5DaGFuZ2VMb2dzKCQpOworc3ViIHBsdXJhbGl6ZUFu ZExpc3QoJCRAKTsKK3N1YiBwcmludERpZmYoJCQkJCk7CiBzdWIgcHJvY2Vzc1BhdGhzKFxAKTsK K3N1YiBwcm9wZXJ0eUNoYW5nZURlc2NyaXB0aW9uKCQpOworc3ViIHJlc29sdmVDb25mbGljdGVk Q2hhbmdlTG9ncygkKTsKIHN1YiByZXZpZXdlckFuZERlc2NyaXB0aW9uRm9yR2l0Q29tbWl0KCQk KTsKLXN1YiBub3JtYWxpemVMaW5lRW5kaW5ncygkJCk7Ci1zdWIgZGVjb2RlRW50aXRpZXMoJCk7 CitzdWIgc3RhdHVzQ29tbWFuZCgkJCQkKTsKK3N1YiBzdGF0dXNEZXNjcmlwdGlvbigkJCQkKTsK K3N1YiB0ZXN0TGlzdEZvckNoYW5nZUxvZyhAKTsKIAogIyMjIENvbnN0YW50IHZhcmlhYmxlcy4K ICMgUHJvamVjdCB0aW1lIHpvbmUgZm9yIEN1cGVydGlubywgQ0EsIFVTCg==