<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>74807</bug_id>
          
          <creation_ts>2011-12-18 02:31:02 -0800</creation_ts>
          <short_desc>It should be possible to change the value of an Options variable without recompiling the world</short_desc>
          <delta_ts>2011-12-21 14:41:52 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>barraclough</cc>
    
    <cc>wingo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>523420</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-12-18 02:31:02 -0800</bug_when>
    <thetext>Patch forthcoming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>524281</commentid>
    <comment_count>1</comment_count>
      <attachid>119948</attachid>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-12-19 16:39:08 -0800</bug_when>
    <thetext>Created attachment 119948
the patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>524310</commentid>
    <comment_count>2</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-12-19 17:07:18 -0800</bug_when>
    <thetext>&lt;rdar://problem/10604755&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>524312</commentid>
    <comment_count>3</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-12-19 17:12:25 -0800</bug_when>
    <thetext>Landed in http://trac.webkit.org/changeset/103286</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>525626</commentid>
    <comment_count>4</comment_count>
    <who name="Andy Wingo">wingo</who>
    <bug_when>2011-12-21 14:36:56 -0800</bug_when>
    <thetext>Hi Filip,

Was this a simple reversion of bug 72938?

Do you have any more specific feedback for me?

Thanks,

Andy</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>525631</commentid>
    <comment_count>5</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2011-12-21 14:41:52 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; Hi Filip,
&gt; 
&gt; Was this a simple reversion of bug 72938?

Yes, it was.

&gt; 
&gt; Do you have any more specific feedback for me?

JavaScriptCore is not meant to be used on the command-line, but rather, as a framework. Often the only practical way to change a heuristic is to recompile.  And if I have to do that, then I don&apos;t want to have to recompile the whole world.

Hence why Options variables were originally defined in a C++ file as out-of-line constants.

While I like your change, since it reduces code duplication, it means that to change an Options value I have to edit Options.h, which is included in a bunch of places, causing nearly a world-recompile.  This is especially annoying when I&apos;m debugging, profiling, and optimizing WebKit.

-F</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>119948</attachid>
            <date>2011-12-19 16:39:08 -0800</date>
            <delta_ts>2011-12-19 16:47:32 -0800</delta_ts>
            <desc>the patch</desc>
            <filename>options_patch_1.diff</filename>
            <type>text/plain</type>
            <size>10996</size>
            <attacher name="Filip Pizlo">fpizlo</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAzMjc4KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA
CisyMDExLTEyLTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg
SXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGNoYW5nZSB0aGUgdmFsdWUgb2YgYW4gT3B0aW9ucyB2
YXJpYWJsZSB3aXRob3V0IHJlY29tcGlsaW5nIHRoZSB3b3JsZAorICAgICAgICBodHRwczovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ4MDcKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5jcHA6CisgICAg
ICAgIChKU0M6Ok9wdGlvbnM6OmluaXRpYWxpemVPcHRpb25zKToKKyAgICAgICAgKiBydW50aW1l
L09wdGlvbnMuaDoKKwogMjAxMS0xMi0xOSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv
dEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEwMzI1MC4K
SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuY3BwCShyZXZpc2lv
biAxMDMyNzgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmNwcAko
d29ya2luZyBjb3B5KQpAQCAtNDQsOSArNDQsNTEgQEAKIAogbmFtZXNwYWNlIEpTQyB7IG5hbWVz
cGFjZSBPcHRpb25zIHsKIAotI2RlZmluZSBERUZJTkUodHlwZSwgY25hbWUsIGRlZmF1bHRfdmFs
KSB0eXBlIGNuYW1lOwotRk9SX0VBQ0hfT1BUSU9OKERFRklORSkKLSN1bmRlZiBERUZJTkUKK3Vu
c2lnbmVkIG1heGltdW1PcHRpbWl6YXRpb25DYW5kaWRhdGVJbnN0cnVjdGlvbkNvdW50OworCit1
bnNpZ25lZCBtYXhpbXVtRnVuY3Rpb25Gb3JDYWxsSW5saW5lQ2FuZGlkYXRlSW5zdHJ1Y3Rpb25D
b3VudDsKK3Vuc2lnbmVkIG1heGltdW1GdW5jdGlvbkZvckNvbnN0cnVjdElubGluZUNhbmRpZGF0
ZUluc3RydWN0aW9uQ291bnQ7CisKK3Vuc2lnbmVkIG1heGltdW1JbmxpbmluZ0RlcHRoOworCitp
bnQzMl90IGV4ZWN1dGlvbkNvdW50ZXJWYWx1ZUZvck9wdGltaXplQWZ0ZXJXYXJtVXA7CitpbnQz
Ml90IGV4ZWN1dGlvbkNvdW50ZXJWYWx1ZUZvck9wdGltaXplQWZ0ZXJMb25nV2FybVVwOworaW50
MzJfdCBleGVjdXRpb25Db3VudGVyVmFsdWVGb3JEb250T3B0aW1pemVBbnl0aW1lU29vbjsKK2lu
dDMyX3QgZXhlY3V0aW9uQ291bnRlclZhbHVlRm9yT3B0aW1pemVTb29uOworaW50MzJfdCBleGVj
dXRpb25Db3VudGVyVmFsdWVGb3JPcHRpbWl6ZU5leHRJbnZvY2F0aW9uOworCitpbnQzMl90IGV4
ZWN1dGlvbkNvdW50ZXJJbmNyZW1lbnRGb3JMb29wOworaW50MzJfdCBleGVjdXRpb25Db3VudGVy
SW5jcmVtZW50Rm9yUmV0dXJuOworCit1bnNpZ25lZCBkZXNpcmVkU3BlY3VsYXRpdmVTdWNjZXNz
RmFpbFJhdGlvOworCitkb3VibGUgbGlrZWx5VG9UYWtlU2xvd0Nhc2VUaHJlc2hvbGQ7Citkb3Vi
bGUgY291bGRUYWtlU2xvd0Nhc2VUaHJlc2hvbGQ7Cit1bnNpZ25lZCBsaWtlbHlUb1Rha2VTbG93
Q2FzZU1pbmltdW1Db3VudDsKK3Vuc2lnbmVkIGNvdWxkVGFrZVNsb3dDYXNlTWluaW11bUNvdW50
OworCitkb3VibGUgb3NyRXhpdFByb21pbmVuY2VGb3JGcmVxdWVudEV4aXRTaXRlOworCit1bnNp
Z25lZCBsYXJnZUZhaWxDb3VudFRocmVzaG9sZEJhc2U7Cit1bnNpZ25lZCBsYXJnZUZhaWxDb3Vu
dFRocmVzaG9sZEJhc2VGb3JMb29wOworCit1bnNpZ25lZCByZW9wdGltaXphdGlvblJldHJ5Q291
bnRlck1heDsKK3Vuc2lnbmVkIHJlb3B0aW1pemF0aW9uUmV0cnlDb3VudGVyU3RlcDsKKwordW5z
aWduZWQgbWluaW11bU9wdGltaXphdGlvbkRlbGF5OwordW5zaWduZWQgbWF4aW11bU9wdGltaXph
dGlvbkRlbGF5OworZG91YmxlIGRlc2lyZWRQcm9maWxlTGl2ZW5lc3NSYXRlOworZG91YmxlIGRl
c2lyZWRQcm9maWxlRnVsbG5lc3NSYXRlOworCitkb3VibGUgZG91YmxlVm90ZVJhdGlvRm9yRG91
YmxlRm9ybWF0OworCit1bnNpZ25lZCBtaW5pbXVtTnVtYmVyT2ZTY2Fuc0JldHdlZW5SZWJhbGFu
Y2U7Cit1bnNpZ25lZCBnY01hcmtTdGFja1NlZ21lbnRTaXplOwordW5zaWduZWQgbWluaW11bU51
bWJlck9mQ2VsbHNUb0tlZXA7Cit1bnNpZ25lZCBtYXhpbXVtTnVtYmVyT2ZTaGFyZWRTZWdtZW50
czsKK3Vuc2lnbmVkIHNoYXJlZFN0YWNrV2FrZXVwVGhyZXNob2xkOwordW5zaWduZWQgbnVtYmVy
T2ZHQ01hcmtlcnM7Cit1bnNpZ25lZCBvcGFxdWVSb290TWVyZ2VUaHJlc2hvbGQ7CiAKICNpZiBF
TkFCTEUoUlVOX1RJTUVfSEVVUklTVElDUykKIHN0YXRpYyBib29sIHBhcnNlKGNvbnN0IGNoYXIq
IHN0cmluZywgaW50MzJfdCYgdmFsdWUpCkBAIC04NywzNSArMTI5LDY3IEBAIHZvaWQgc2V0SGV1
cmlzdGljKFQmIHZhcmlhYmxlLCBjb25zdCBjaGEKIAogdm9pZCBpbml0aWFsaXplT3B0aW9ucygp
CiB7Ci0jZGVmaW5lIElOSVQodHlwZSwgY25hbWUsIGRlZmF1bHRfdmFsKSBTRVQoY25hbWUsIGRl
ZmF1bHRfdmFsKTsKLSAgICBGT1JfRUFDSF9PUFRJT04oSU5JVCkKLSN1bmRlZiBJTklUCisgICAg
U0VUKG1heGltdW1PcHRpbWl6YXRpb25DYW5kaWRhdGVJbnN0cnVjdGlvbkNvdW50LCAxMDAwKTsK
KyAgICAKKyAgICBTRVQobWF4aW11bUZ1bmN0aW9uRm9yQ2FsbElubGluZUNhbmRpZGF0ZUluc3Ry
dWN0aW9uQ291bnQsIDE1MCk7CisgICAgU0VUKG1heGltdW1GdW5jdGlvbkZvckNvbnN0cnVjdElu
bGluZUNhbmRpZGF0ZUluc3RydWN0aW9uQ291bnQsIDgwKTsKKyAgICAKKyAgICBTRVQobWF4aW11
bUlubGluaW5nRGVwdGgsIDUpOworCisgICAgU0VUKGV4ZWN1dGlvbkNvdW50ZXJWYWx1ZUZvck9w
dGltaXplQWZ0ZXJXYXJtVXAsICAgICAtMTAwMCk7CisgICAgU0VUKGV4ZWN1dGlvbkNvdW50ZXJW
YWx1ZUZvck9wdGltaXplQWZ0ZXJMb25nV2FybVVwLCAtNTAwMCk7CisgICAgU0VUKGV4ZWN1dGlv
bkNvdW50ZXJWYWx1ZUZvckRvbnRPcHRpbWl6ZUFueXRpbWVTb29uLCBzdGQ6Om51bWVyaWNfbGlt
aXRzPGludDMyX3Q+OjptaW4oKSk7CisgICAgU0VUKGV4ZWN1dGlvbkNvdW50ZXJWYWx1ZUZvck9w
dGltaXplU29vbiwgICAgICAgICAgICAtMTAwMCk7CisgICAgU0VUKGV4ZWN1dGlvbkNvdW50ZXJW
YWx1ZUZvck9wdGltaXplTmV4dEludm9jYXRpb24sICAwKTsKKworICAgIFNFVChleGVjdXRpb25D
b3VudGVySW5jcmVtZW50Rm9yTG9vcCwgICAxKTsKKyAgICBTRVQoZXhlY3V0aW9uQ291bnRlcklu
Y3JlbWVudEZvclJldHVybiwgMTUpOworCisgICAgU0VUKGRlc2lyZWRTcGVjdWxhdGl2ZVN1Y2Nl
c3NGYWlsUmF0aW8sIDYpOworICAgIAorICAgIFNFVChsaWtlbHlUb1Rha2VTbG93Q2FzZVRocmVz
aG9sZCwgICAgMC4xNSk7CisgICAgU0VUKGNvdWxkVGFrZVNsb3dDYXNlVGhyZXNob2xkLCAgICAg
ICAwLjA1KTsgLy8gU2hvdWxkbid0IGJlIHplcm8gYmVjYXVzZSBzb21lIG9wcyB3aWxsIHNwdXJp
b3VzbHkgdGFrZSBzbG93IGNhc2UsIGZvciBleGFtcGxlIGZvciBsaW5raW5nIG9yIGNhY2hpbmcu
CisgICAgU0VUKGxpa2VseVRvVGFrZVNsb3dDYXNlTWluaW11bUNvdW50LCAxMDApOworICAgIFNF
VChjb3VsZFRha2VTbG93Q2FzZU1pbmltdW1Db3VudCwgICAgMTApOworICAgIAorICAgIFNFVChv
c3JFeGl0UHJvbWluZW5jZUZvckZyZXF1ZW50RXhpdFNpdGUsIDAuMyk7CiAKLSAgICAvLyBOb3cg
d2UgaW5pdGlhbGl6ZSBoZXVyaXN0aWNzIHdob3NlIGRlZmF1bHRzIGFyZSBub3Qga25vd24gYXQK
LSAgICAvLyBjb21waWxlLXRpbWUuCisgICAgU0VUKGxhcmdlRmFpbENvdW50VGhyZXNob2xkQmFz
ZSwgICAgICAgIDIwKTsKKyAgICBTRVQobGFyZ2VGYWlsQ291bnRUaHJlc2hvbGRCYXNlRm9yTG9v
cCwgMSk7CiAKLSAgICBpZiAoIWdjTWFya1N0YWNrU2VnbWVudFNpemUpCi0gICAgICAgIGdjTWFy
a1N0YWNrU2VnbWVudFNpemUgPSBwYWdlU2l6ZSgpOworICAgIFNFVChyZW9wdGltaXphdGlvblJl
dHJ5Q291bnRlclN0ZXAsIDEpOwogCi0gICAgaWYgKCFudW1iZXJPZkdDTWFya2VycykgewotICAg
ICAgICBpbnQgY3B1c1RvVXNlID0gMTsKKyAgICBTRVQobWluaW11bU9wdGltaXphdGlvbkRlbGF5
LCAgIDEpOworICAgIFNFVChtYXhpbXVtT3B0aW1pemF0aW9uRGVsYXksICAgNSk7CisgICAgU0VU
KGRlc2lyZWRQcm9maWxlTGl2ZW5lc3NSYXRlLCAwLjc1KTsKKyAgICBTRVQoZGVzaXJlZFByb2Zp
bGVGdWxsbmVzc1JhdGUsIDAuMzUpOworICAgIAorICAgIFNFVChkb3VibGVWb3RlUmF0aW9Gb3JE
b3VibGVGb3JtYXQsIDIpOworICAgIAorICAgIFNFVChtaW5pbXVtTnVtYmVyT2ZTY2Fuc0JldHdl
ZW5SZWJhbGFuY2UsIDEwMDAwKTsKKyAgICBTRVQoZ2NNYXJrU3RhY2tTZWdtZW50U2l6ZSwgICAg
ICAgICAgICAgICBwYWdlU2l6ZSgpKTsKKyAgICBTRVQobWluaW11bU51bWJlck9mQ2VsbHNUb0tl
ZXAsICAgICAgICAgICAxMCk7CisgICAgU0VUKG1heGltdW1OdW1iZXJPZlNoYXJlZFNlZ21lbnRz
LCAgICAgICAgMyk7CisgICAgU0VUKHNoYXJlZFN0YWNrV2FrZXVwVGhyZXNob2xkLCAgICAgICAg
ICAgMSk7CisgICAgU0VUKG9wYXF1ZVJvb3RNZXJnZVRocmVzaG9sZCwgICAgICAgICAgICAgMTAw
MCk7CisKKyAgICBpbnQgY3B1c1RvVXNlID0gMTsKICNpZiBPUyhEQVJXSU4pICYmIEVOQUJMRShQ
QVJBTExFTF9HQykKLSAgICAgICAgaW50IG5hbWVbMl07Ci0gICAgICAgIHNpemVfdCB2YWx1ZVNp
emUgPSBzaXplb2YoY3B1c1RvVXNlKTsKLSAgICAgICAgbmFtZVswXSA9IENUTF9IVzsKLSAgICAg
ICAgbmFtZVsxXSA9IEhXX0FWQUlMQ1BVOwotICAgICAgICBzeXNjdGwobmFtZSwgMiwgJmNwdXNU
b1VzZSwgJnZhbHVlU2l6ZSwgMCwgMCk7CisgICAgaW50IG5hbWVbMl07CisgICAgc2l6ZV90IHZh
bHVlU2l6ZSA9IHNpemVvZihjcHVzVG9Vc2UpOworICAgIG5hbWVbMF0gPSBDVExfSFc7CisgICAg
bmFtZVsxXSA9IEhXX0FWQUlMQ1BVOworICAgIHN5c2N0bChuYW1lLCAyLCAmY3B1c1RvVXNlLCAm
dmFsdWVTaXplLCAwLCAwKTsKICNlbmRpZgotICAgICAgICAvLyBXZSBkb24ndCBzY2FsZSBzbyB3
ZWxsIGJleW9uZCA0LgotICAgICAgICBpZiAoY3B1c1RvVXNlID4gNCkKLSAgICAgICAgICAgIGNw
dXNUb1VzZSA9IDQ7Ci0gICAgICAgIC8vIEJlIHBhcmFub2lkLCBpdCBpcyB0aGUgT1Mgd2UncmUg
ZGVhbGluZyB3aXRoLCBhZnRlciBhbGwuCi0gICAgICAgIGlmIChjcHVzVG9Vc2UgPCAxKQotICAg
ICAgICAgICAgY3B1c1RvVXNlID0gMTsKLQotICAgICAgICBudW1iZXJPZkdDTWFya2VycyA9IGNw
dXNUb1VzZTsKLSAgICB9CisgICAgLy8gV2UgZG9uJ3Qgc2NhbGUgc28gd2VsbCBiZXlvbmQgNC4K
KyAgICBpZiAoY3B1c1RvVXNlID4gNCkKKyAgICAgICAgY3B1c1RvVXNlID0gNDsKKyAgICAvLyBC
ZSBwYXJhbm9pZCwgaXQgaXMgdGhlIE9TIHdlJ3JlIGRlYWxpbmcgd2l0aCwgYWZ0ZXIgYWxsLgor
ICAgIGlmIChjcHVzVG9Vc2UgPCAxKQorICAgICAgICBjcHVzVG9Vc2UgPSAxOwogICAgIAorICAg
IFNFVChudW1iZXJPZkdDTWFya2VycywgY3B1c1RvVXNlKTsKKwogICAgIEFTU0VSVChleGVjdXRp
b25Db3VudGVyVmFsdWVGb3JEb250T3B0aW1pemVBbnl0aW1lU29vbiA8PSBleGVjdXRpb25Db3Vu
dGVyVmFsdWVGb3JPcHRpbWl6ZUFmdGVyTG9uZ1dhcm1VcCk7CiAgICAgQVNTRVJUKGV4ZWN1dGlv
bkNvdW50ZXJWYWx1ZUZvck9wdGltaXplQWZ0ZXJMb25nV2FybVVwIDw9IGV4ZWN1dGlvbkNvdW50
ZXJWYWx1ZUZvck9wdGltaXplQWZ0ZXJXYXJtVXApOwogICAgIEFTU0VSVChleGVjdXRpb25Db3Vu
dGVyVmFsdWVGb3JPcHRpbWl6ZUFmdGVyV2FybVVwIDw9IGV4ZWN1dGlvbkNvdW50ZXJWYWx1ZUZv
ck9wdGltaXplU29vbik7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9PcHRp
b25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9u
cy5oCShyZXZpc2lvbiAxMDMyNzgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9P
cHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTMwLDY1ICszMCw1MSBAQAogCiBuYW1lc3BhY2Ug
SlNDIHsgbmFtZXNwYWNlIE9wdGlvbnMgewogCi0vLyBtYXhpbXVtSW5saW5pbmdEZXB0aCBpcyB0
aGUgbWF4aW11bSBkZXB0aCBvZiBpbmxpbmUgc3RhY2ssIHNvIDEgPSBubwotLy8gaW5saW5pbmcs
IDIgPSBvbmUgbGV2ZWwsIGV0YworZXh0ZXJuIHVuc2lnbmVkIG1heGltdW1PcHRpbWl6YXRpb25D
YW5kaWRhdGVJbnN0cnVjdGlvbkNvdW50OwogCi0vLyBjb3VsZFRha2VTbG93Q2FzZVRocmVzaG9s
ZCBzaG91bGRuJ3QgYmUgemVybyBiZWNhdXNlIHNvbWUgb3BzIHdpbGwgc3B1cmlvdXNseQotLy8g
dGFrZSBzbG93IGNhc2UsIGZvciBleGFtcGxlIGZvciBsaW5raW5nIG9yIGNhY2hpbmcuCitleHRl
cm4gdW5zaWduZWQgbWF4aW11bUZ1bmN0aW9uRm9yQ2FsbElubGluZUNhbmRpZGF0ZUluc3RydWN0
aW9uQ291bnQ7CitleHRlcm4gdW5zaWduZWQgbWF4aW11bUZ1bmN0aW9uRm9yQ29uc3RydWN0SW5s
aW5lQ2FuZGlkYXRlSW5zdHJ1Y3Rpb25Db3VudDsKIAotI2RlZmluZSBGT1JfRUFDSF9IRVVSSVNU
SUMobSkgXAotICAgIG0odW5zaWduZWQsIG1heGltdW1PcHRpbWl6YXRpb25DYW5kaWRhdGVJbnN0
cnVjdGlvbkNvdW50LCAxMDAwKSBcCi0gICAgXAotICAgIG0odW5zaWduZWQsIG1heGltdW1GdW5j
dGlvbkZvckNhbGxJbmxpbmVDYW5kaWRhdGVJbnN0cnVjdGlvbkNvdW50LCAxNTApIFwKLSAgICBt
KHVuc2lnbmVkLCBtYXhpbXVtRnVuY3Rpb25Gb3JDb25zdHJ1Y3RJbmxpbmVDYW5kaWRhdGVJbnN0
cnVjdGlvbkNvdW50LCA4MCkgXAotICAgIFwKLSAgICBtKHVuc2lnbmVkLCBtYXhpbXVtSW5saW5p
bmdEZXB0aCwgNSkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCi0gICAgXAotICAgIG0o
aW50MzJfdCwgZXhlY3V0aW9uQ291bnRlclZhbHVlRm9yT3B0aW1pemVBZnRlcldhcm1VcCwgICAg
ICAtMTAwMCkgXAotICAgIG0oaW50MzJfdCwgZXhlY3V0aW9uQ291bnRlclZhbHVlRm9yT3B0aW1p
emVBZnRlckxvbmdXYXJtVXAsICAtNTAwMCkgXAotICAgIG0oaW50MzJfdCwgZXhlY3V0aW9uQ291
bnRlclZhbHVlRm9yRG9udE9wdGltaXplQW55dGltZVNvb24sICBzdGQ6Om51bWVyaWNfbGltaXRz
PGludDMyX3Q+OjptaW4oKSkgXAotICAgIG0oaW50MzJfdCwgZXhlY3V0aW9uQ291bnRlclZhbHVl
Rm9yT3B0aW1pemVTb29uLCAgICAgICAgICAgICAtMTAwMCkgXAotICAgIG0oaW50MzJfdCwgZXhl
Y3V0aW9uQ291bnRlclZhbHVlRm9yT3B0aW1pemVOZXh0SW52b2NhdGlvbiwgICAwKSBcCi0gICAg
XAotICAgIG0oaW50MzJfdCwgZXhlY3V0aW9uQ291bnRlckluY3JlbWVudEZvckxvb3AsICAgICAg
IDEpIFwKLSAgICBtKGludDMyX3QsIGV4ZWN1dGlvbkNvdW50ZXJJbmNyZW1lbnRGb3JSZXR1cm4s
ICAgICAxNSkgXAotICAgIFwKLSAgICBtKHVuc2lnbmVkLCBkZXNpcmVkU3BlY3VsYXRpdmVTdWNj
ZXNzRmFpbFJhdGlvLCAgICA2KSBcCi0gICAgXAotICAgIG0oZG91YmxlLCAgIGxpa2VseVRvVGFr
ZVNsb3dDYXNlVGhyZXNob2xkLCAgICAgICAgIDAuMTUpIFwKLSAgICBtKGRvdWJsZSwgICBjb3Vs
ZFRha2VTbG93Q2FzZVRocmVzaG9sZCwgICAgICAgICAgICAwLjA1KSBcCi0gICAgbSh1bnNpZ25l
ZCwgbGlrZWx5VG9UYWtlU2xvd0Nhc2VNaW5pbXVtQ291bnQsICAgICAgMTAwKSBcCi0gICAgbSh1
bnNpZ25lZCwgY291bGRUYWtlU2xvd0Nhc2VNaW5pbXVtQ291bnQsICAgICAgICAgMTApIFwKLSAg
ICBcCi0gICAgbShkb3VibGUsICAgb3NyRXhpdFByb21pbmVuY2VGb3JGcmVxdWVudEV4aXRTaXRl
LCAgMC4zKSBcCi0gICAgXAotICAgIG0odW5zaWduZWQsIGxhcmdlRmFpbENvdW50VGhyZXNob2xk
QmFzZSwgICAgICAgICAgIDIwKSBcCi0gICAgbSh1bnNpZ25lZCwgbGFyZ2VGYWlsQ291bnRUaHJl
c2hvbGRCYXNlRm9yTG9vcCwgICAgMSkgXAotICAgIFwKLSAgICBtKHVuc2lnbmVkLCByZW9wdGlt
aXphdGlvblJldHJ5Q291bnRlck1heCwgICAgICAgICAwKSBcCi0gICAgbSh1bnNpZ25lZCwgcmVv
cHRpbWl6YXRpb25SZXRyeUNvdW50ZXJTdGVwLCAgICAgICAgMSkgXAotICAgIFwKLSAgICBtKHVu
c2lnbmVkLCBtaW5pbXVtT3B0aW1pemF0aW9uRGVsYXksICAgICAgICAgICAgICAxKSBcCi0gICAg
bSh1bnNpZ25lZCwgbWF4aW11bU9wdGltaXphdGlvbkRlbGF5LCAgICAgICAgICAgICAgNSkgXAot
ICAgIG0oZG91YmxlLCBkZXNpcmVkUHJvZmlsZUxpdmVuZXNzUmF0ZSwgICAgICAgICAgICAgIDAu
NzUpIFwKLSAgICBtKGRvdWJsZSwgZGVzaXJlZFByb2ZpbGVGdWxsbmVzc1JhdGUsICAgICAgICAg
ICAgICAwLjM1KSBcCi0gICAgXAotICAgIG0oZG91YmxlLCAgIGRvdWJsZVZvdGVSYXRpb0ZvckRv
dWJsZUZvcm1hdCwgICAgICAgIDIpIFwKLSAgICBcCi0gICAgbSh1bnNpZ25lZCwgbWluaW11bU51
bWJlck9mU2NhbnNCZXR3ZWVuUmViYWxhbmNlLCAgMTAwMDApIFwKLSAgICBtKHVuc2lnbmVkLCBn
Y01hcmtTdGFja1NlZ21lbnRTaXplLCAgICAgICAgICAgICAgICAwKSBcCi0gICAgbSh1bnNpZ25l
ZCwgbWluaW11bU51bWJlck9mQ2VsbHNUb0tlZXAsICAgICAgICAgICAgMTApIFwKLSAgICBtKHVu
c2lnbmVkLCBtYXhpbXVtTnVtYmVyT2ZTaGFyZWRTZWdtZW50cywgICAgICAgICAzKSBcCi0gICAg
bSh1bnNpZ25lZCwgc2hhcmVkU3RhY2tXYWtldXBUaHJlc2hvbGQsICAgICAgICAgICAgMSkgXAot
ICAgIG0odW5zaWduZWQsIG51bWJlck9mR0NNYXJrZXJzLCAgICAgICAgICAgICAgICAgICAgIDAp
IFwKLSAgICBtKHVuc2lnbmVkLCBvcGFxdWVSb290TWVyZ2VUaHJlc2hvbGQsICAgICAgICAgICAg
ICAxMDAwKQotCi0jZGVmaW5lIEZPUl9FQUNIX09QVElPTihtKSBcCi0gICAgRk9SX0VBQ0hfSEVV
UklTVElDKG0pCi0KLSNkZWZpbmUgREVDTEFSRSh0eXBlLCBjbmFtZSwgZGVmYXVsdF92YWwpIGV4
dGVybiB0eXBlIGNuYW1lOwotRk9SX0VBQ0hfT1BUSU9OKERFQ0xBUkUpCi0jdW5kZWYgREVDTEFS
RQorZXh0ZXJuIHVuc2lnbmVkIG1heGltdW1JbmxpbmluZ0RlcHRoOyAvLyBEZXB0aCBvZiBpbmxp
bmUgc3RhY2ssIHNvIDEgPSBubyBpbmxpbmluZywgMiA9IG9uZSBsZXZlbCwgZXRjLgorCitleHRl
cm4gaW50MzJfdCBleGVjdXRpb25Db3VudGVyVmFsdWVGb3JPcHRpbWl6ZUFmdGVyV2FybVVwOwor
ZXh0ZXJuIGludDMyX3QgZXhlY3V0aW9uQ291bnRlclZhbHVlRm9yT3B0aW1pemVBZnRlckxvbmdX
YXJtVXA7CitleHRlcm4gaW50MzJfdCBleGVjdXRpb25Db3VudGVyVmFsdWVGb3JEb250T3B0aW1p
emVBbnl0aW1lU29vbjsKK2V4dGVybiBpbnQzMl90IGV4ZWN1dGlvbkNvdW50ZXJWYWx1ZUZvck9w
dGltaXplU29vbjsKK2V4dGVybiBpbnQzMl90IGV4ZWN1dGlvbkNvdW50ZXJWYWx1ZUZvck9wdGlt
aXplTmV4dEludm9jYXRpb247CisKK2V4dGVybiBpbnQzMl90IGV4ZWN1dGlvbkNvdW50ZXJJbmNy
ZW1lbnRGb3JMb29wOworZXh0ZXJuIGludDMyX3QgZXhlY3V0aW9uQ291bnRlckluY3JlbWVudEZv
clJldHVybjsKKworZXh0ZXJuIHVuc2lnbmVkIGRlc2lyZWRTcGVjdWxhdGl2ZVN1Y2Nlc3NGYWls
UmF0aW87CisKK2V4dGVybiBkb3VibGUgbGlrZWx5VG9UYWtlU2xvd0Nhc2VUaHJlc2hvbGQ7Citl
eHRlcm4gZG91YmxlIGNvdWxkVGFrZVNsb3dDYXNlVGhyZXNob2xkOworZXh0ZXJuIHVuc2lnbmVk
IGxpa2VseVRvVGFrZVNsb3dDYXNlTWluaW11bUNvdW50OworZXh0ZXJuIHVuc2lnbmVkIGNvdWxk
VGFrZVNsb3dDYXNlTWluaW11bUNvdW50OworCitleHRlcm4gZG91YmxlIG9zckV4aXRQcm9taW5l
bmNlRm9yRnJlcXVlbnRFeGl0U2l0ZTsKKworZXh0ZXJuIHVuc2lnbmVkIGxhcmdlRmFpbENvdW50
VGhyZXNob2xkQmFzZTsKK2V4dGVybiB1bnNpZ25lZCBsYXJnZUZhaWxDb3VudFRocmVzaG9sZEJh
c2VGb3JMb29wOworCitleHRlcm4gdW5zaWduZWQgcmVvcHRpbWl6YXRpb25SZXRyeUNvdW50ZXJN
YXg7CitleHRlcm4gdW5zaWduZWQgcmVvcHRpbWl6YXRpb25SZXRyeUNvdW50ZXJTdGVwOworCitl
eHRlcm4gdW5zaWduZWQgbWluaW11bU9wdGltaXphdGlvbkRlbGF5OworZXh0ZXJuIHVuc2lnbmVk
IG1heGltdW1PcHRpbWl6YXRpb25EZWxheTsKK2V4dGVybiBkb3VibGUgZGVzaXJlZFByb2ZpbGVM
aXZlbmVzc1JhdGU7CitleHRlcm4gZG91YmxlIGRlc2lyZWRQcm9maWxlRnVsbG5lc3NSYXRlOwor
CitleHRlcm4gZG91YmxlIGRvdWJsZVZvdGVSYXRpb0ZvckRvdWJsZUZvcm1hdDsKKworZXh0ZXJu
IHVuc2lnbmVkIG1pbmltdW1OdW1iZXJPZlNjYW5zQmV0d2VlblJlYmFsYW5jZTsKK2V4dGVybiB1
bnNpZ25lZCBnY01hcmtTdGFja1NlZ21lbnRTaXplOworZXh0ZXJuIHVuc2lnbmVkIG1pbmltdW1O
dW1iZXJPZkNlbGxzVG9LZWVwOworZXh0ZXJuIHVuc2lnbmVkIG1heGltdW1OdW1iZXJPZlNoYXJl
ZFNlZ21lbnRzOworZXh0ZXJuIHVuc2lnbmVkIHNoYXJlZFN0YWNrV2FrZXVwVGhyZXNob2xkOwor
ZXh0ZXJuIHVuc2lnbmVkIG51bWJlck9mR0NNYXJrZXJzOworZXh0ZXJuIHVuc2lnbmVkIG9wYXF1
ZVJvb3RNZXJnZVRocmVzaG9sZDsKIAogdm9pZCBpbml0aWFsaXplT3B0aW9ucygpOwogCg==
</data>
<flag name="review"
          id="120087"
          type_id="1"
          status="+"
          setter="barraclough"
    />
          </attachment>
      

    </bug>

</bugzilla>