74791 2011-12-17 14:06:34 -0800 [Qt] Fix QtTestBrowser compilation with QtWidgets module 2011-12-17 19:35:32 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 savagobr webkit-unassigned webkit.review.bot oldest_to_newest 523349 0 savagobr 2011-12-17 14:06:34 -0800 Compilation will fail due to missing QT += widgets with current qt5 hash. 523350 1 119735 savagobr 2011-12-17 14:12:15 -0800 Created attachment 119735 Link with libQtWidgets 523357 2 119735 kenneth 2011-12-17 15:22:49 -0800 Comment on attachment 119735 Link with libQtWidgets I think this should only be done with Qt5 right? 523364 3 119742 savagobr 2011-12-17 17:15:02 -0800 Created attachment 119742 Only use QtWidgets module if using Qt5 523366 4 119743 savagobr 2011-12-17 17:22:19 -0800 Created attachment 119743 Only use QtWidgets module if using Qt5, reuse previous test clause 523369 5 119743 kling 2011-12-17 18:20:03 -0800 Comment on attachment 119743 Only use QtWidgets module if using Qt5, reuse previous test clause rs=me 523392 6 119743 webkit.review.bot 2011-12-17 19:35:28 -0800 Comment on attachment 119743 Only use QtWidgets module if using Qt5, reuse previous test clause Clearing flags on attachment: 119743 Committed r103164: <http://trac.webkit.org/changeset/103164> 523393 7 webkit.review.bot 2011-12-17 19:35:32 -0800 All reviewed patches have been landed. Closing bug. 119735 2011-12-17 14:12:15 -0800 2011-12-17 17:15:02 -0800 Link with libQtWidgets buildfix_qtwidgets.patch text/plain 1316 savagobr RnJvbSBhOWUwMzI2Y2Q0ODA4OTIzN2U0YjljYmY0Yjk5ZDZkNmQ5NTU3NjA2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8Y2F2YWxjYW50aWlAZ21h aWwuY29tPgpEYXRlOiBTYXQsIDE3IERlYyAyMDExIDE4OjA5OjM5IC0wNDAwClN1YmplY3Q6IFtQ QVRDSF0gQnVpbGQgZml4LgoKU2lnbmVkLW9mZi1ieTogQWRlbmlsc29uIENhdmFsY2FudGkgPGNh dmFsY2FudGlpQGdtYWlsLmNvbT4KLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgIHwgICAgOSArKysrKysrKysKIFRvb2xzL1F0VGVzdEJyb3dzZXIvUXRUZXN0QnJvd3Nl ci5wcm8gfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9n CmluZGV4IDUyOThjZmUuLjM3OGIwYTEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysg Yi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0xMi0xNyAgQWRlbmlsc29u IENhdmFsY2FudGkgIDxjYXZhbGNhbnRpaUBnbWFpbC5jb20+CisKKyAgICAgICAgW1F0XSBGaXgg UXRUZXN0QnJvd3NlciBjb21waWxhdGlvbiB3aXRoIFF0V2lkZ2V0cyBtb2R1bGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0NzkxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBRdFRlc3RCcm93c2VyL1F0 VGVzdEJyb3dzZXIucHJvOgorCiAyMDExLTEyLTE3ICBLZW50YXJvIEhhcmEgIDxoYXJha2VuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgdG9wLWxldmVsIGNvZGUgY29tcGxldGVseSBm cm9tIHByZXBhcmUtQ2hhbmdlTG9nCmRpZmYgLS1naXQgYS9Ub29scy9RdFRlc3RCcm93c2VyL1F0 VGVzdEJyb3dzZXIucHJvIGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9RdFRlc3RCcm93c2VyLnBybwpp bmRleCBhZmY0ZDFiLi40NjE2NjRhIDEwMDY0NAotLS0gYS9Ub29scy9RdFRlc3RCcm93c2VyL1F0 VGVzdEJyb3dzZXIucHJvCisrKyBiL1Rvb2xzL1F0VGVzdEJyb3dzZXIvUXRUZXN0QnJvd3Nlci5w cm8KQEAgLTQxLDcgKzQxLDcgQEAgQ09ORklHICs9IHF0d2Via2l0CiAKIERFU1RESVIgPSAkJFJP T1RfQlVJTERfRElSL2JpbgogCi1RVCArPSBuZXR3b3JrCitRVCArPSBuZXR3b3JrIHdpZGdldHMK IG1hY3g6UVQgKz0geG1sCiBoYXZlUXQoNSk6IFFUICs9IHByaW50c3VwcG9ydAogCi0tIAoxLjcu NS40Cgo= 119742 2011-12-17 17:15:02 -0800 2011-12-17 17:22:19 -0800 Only use QtWidgets module if using Qt5 buildfix_qtwidgets_qt5.patch text/plain 1362 savagobr RnJvbSAzNjU5MWZmNjNiY2Y1NDAyYzI1ZmVmNDA4Yjc0YTRhZDk5NzE4Y2MyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8Y2F2YWxjYW50aWlAZ21h aWwuY29tPgpEYXRlOiBTYXQsIDE3IERlYyAyMDExIDE4OjA5OjM5IC0wNDAwClN1YmplY3Q6IFtQ QVRDSF0gQnVpbGQgZml4LCB1c2UgUXRXaWRnZXRzIG1vZHVsZSBpZiBjb21waWxlZCB3aXRoIFF0 NS4KClNpZ25lZC1vZmYtYnk6IEFkZW5pbHNvbiBDYXZhbGNhbnRpIDxjYXZhbGNhbnRpaUBnbWFp bC5jb20+Ci0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDkg KysrKysrKysrCiBUb29scy9RdFRlc3RCcm93c2VyL1F0VGVzdEJyb3dzZXIucHJvIHwgICAgMiAr KwogMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1Mjk4Y2Zl Li4zNzhiMGExIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMTItMTcgIEFkZW5pbHNvbiBDYXZhbGNhbnRpICA8 Y2F2YWxjYW50aWlAZ21haWwuY29tPgorCisgICAgICAgIFtRdF0gRml4IFF0VGVzdEJyb3dzZXIg Y29tcGlsYXRpb24gd2l0aCBRdFdpZGdldHMgbW9kdWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDc5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogUXRUZXN0QnJvd3Nlci9RdFRlc3RCcm93c2VyLnBy bzoKKwogMjAxMS0xMi0xNyAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmVtb3ZlIHRvcC1sZXZlbCBjb2RlIGNvbXBsZXRlbHkgZnJvbSBwcmVwYXJlLUNo YW5nZUxvZwpkaWZmIC0tZ2l0IGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9RdFRlc3RCcm93c2VyLnBy byBiL1Rvb2xzL1F0VGVzdEJyb3dzZXIvUXRUZXN0QnJvd3Nlci5wcm8KaW5kZXggYWZmNGQxYi4u YTcxMmJiYyAxMDA2NDQKLS0tIGEvVG9vbHMvUXRUZXN0QnJvd3Nlci9RdFRlc3RCcm93c2VyLnBy bworKysgYi9Ub29scy9RdFRlc3RCcm93c2VyL1F0VGVzdEJyb3dzZXIucHJvCkBAIC00Miw2ICs0 Miw4IEBAIENPTkZJRyArPSBxdHdlYmtpdAogREVTVERJUiA9ICQkUk9PVF9CVUlMRF9ESVIvYmlu CiAKIFFUICs9IG5ldHdvcmsKK2hhdmVRdCg1KTogUVQgKz0gd2lkZ2V0cworCiBtYWN4OlFUICs9 IHhtbAogaGF2ZVF0KDUpOiBRVCArPSBwcmludHN1cHBvcnQKIAotLSAKMS43LjUuNAoK 119743 2011-12-17 17:22:19 -0800 2011-12-17 19:35:28 -0800 Only use QtWidgets module if using Qt5, reuse previous test clause buildfix_qtwidgets_qt5.patch text/plain 1414 savagobr RnJvbSA5NzQ5YzI1YTRiZTRjNjZmYjMwYWI4ZjdhNmFjNTg5ZDRhN2Y4YTU5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVuaWxzb24gQ2F2YWxjYW50aSA8Y2F2YWxjYW50aWlAZ21h aWwuY29tPgpEYXRlOiBTYXQsIDE3IERlYyAyMDExIDE4OjA5OjM5IC0wNDAwClN1YmplY3Q6IFtQ QVRDSF0gQnVpbGQgZml4LCB1c2UgUXRXaWRnZXRzIG1vZHVsZSBpZiBjb21waWxlZCB3aXRoIFF0 NS4KClNpZ25lZC1vZmYtYnk6IEFkZW5pbHNvbiBDYXZhbGNhbnRpIDxjYXZhbGNhbnRpaUBnbWFp bC5jb20+Ci0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICB8ICAgIDkg KysrKysrKysrCiBUb29scy9RdFRlc3RCcm93c2VyL1F0VGVzdEJyb3dzZXIucHJvIHwgICAgMyAr Ky0KIDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTI5OGNm ZS4uMzc4YjBhMSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDExLTEyLTE3ICBBZGVuaWxzb24gQ2F2YWxjYW50aSAg PGNhdmFsY2FudGlpQGdtYWlsLmNvbT4KKworICAgICAgICBbUXRdIEZpeCBRdFRlc3RCcm93c2Vy IGNvbXBpbGF0aW9uIHdpdGggUXRXaWRnZXRzIG1vZHVsZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ3OTEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFF0VGVzdEJyb3dzZXIvUXRUZXN0QnJvd3Nlci5w cm86CisKIDIwMTEtMTItMTcgIEtlbnRhcm8gSGFyYSAgPGhhcmFrZW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJlbW92ZSB0b3AtbGV2ZWwgY29kZSBjb21wbGV0ZWx5IGZyb20gcHJlcGFyZS1D aGFuZ2VMb2cKZGlmZiAtLWdpdCBhL1Rvb2xzL1F0VGVzdEJyb3dzZXIvUXRUZXN0QnJvd3Nlci5w cm8gYi9Ub29scy9RdFRlc3RCcm93c2VyL1F0VGVzdEJyb3dzZXIucHJvCmluZGV4IGFmZjRkMWIu LjhiNmIzZmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1F0VGVzdEJyb3dzZXIvUXRUZXN0QnJvd3Nlci5w cm8KKysrIGIvVG9vbHMvUXRUZXN0QnJvd3Nlci9RdFRlc3RCcm93c2VyLnBybwpAQCAtNDIsOCAr NDIsOSBAQCBDT05GSUcgKz0gcXR3ZWJraXQKIERFU1RESVIgPSAkJFJPT1RfQlVJTERfRElSL2Jp bgogCiBRVCArPSBuZXR3b3JrCisKIG1hY3g6UVQgKz0geG1sCi1oYXZlUXQoNSk6IFFUICs9IHBy aW50c3VwcG9ydAoraGF2ZVF0KDUpOiBRVCArPSBwcmludHN1cHBvcnQgd2lkZ2V0cwogCiAhZW1i ZWRkZWQ6IFBLR0NPTkZJRyArPSBmb250Y29uZmlnCiAKLS0gCjEuNy41LjQKCg==