74788 2011-12-17 12:59:03 -0800 REGRESSION(r103130) - svg/W3C-SVG-1.1/animate-elem-*-t.svg asserting 2012-01-20 07:12:53 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 64671 P2 Normal --- 1 enne schenney beidson darin enne jknotten rniwa schenney webkit.review.bot zimmermann oldest_to_newest 523344 0 enne 2011-12-17 12:59:03 -0800 A number of svg animation tests are intermittently crashing on an assert in debug in Chromium's layout tests, although the release tests continue to pass. ASSERTION FAILED: m_activeState != Active /b/build/slave/webkit-mac-latest-dbg/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../svg/animation/SVGSMILElement.cpp(921) : void WebCore::SVGSMILElement::progress(WebCore::SMILTime, WebCore::SVGSMILElement *) 1 0x53462dec WebCore::SVGSMILElement::progress(WebCore::SMILTime, WebCore::SVGSMILElement*) 2 0x53450374 WebCore::SMILTimeContainer::updateAnimations(WebCore::SMILTime, double, WTF::String const&) 3 0x5344f73b WebCore::SMILTimeContainer::timerFired(WebCore::Timer<WebCore::SMILTimeContainer>*) 4 0x5345af17 WebCore::Timer<WebCore::SMILTimeContainer>::fired() 5 0x51e7119e WebCore::ThreadTimers::sharedTimerFiredInternal() 6 0x51e70f2f WebCore::ThreadTimers::sharedTimerFired() 7 0x53842689 webkit_glue::WebKitPlatformSupportImpl::DoTimeout() 8 0x538431d7 base::BaseTimer<webkit_glue::WebKitPlatformSupportImpl, false>::TimerTask::Run() Here's a sampling of tests that have been failing. Win, Linux, and Mac all seem affected. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2FW3C-SVG-1.1%2Fanimate-elem-46-t.svg%2Csvg%2FW3C-SVG-1.1%2Fanimate-elem-44-t.svg%2Csvg%2FW3C-SVG-1.1%2Fanimate-elem-52-t.svg%2Csvg%2FW3C-SVG-1.1%2Fanimate-elem-41-t.svg%2Csvg%2FW3C-SVG-1.1%2Fanimate-elem-81-t.svg%2Csvg%2FW3C-SVG-1.1%2Fanimate-elem-65-t.svg%2Csvg%2FW3C-SVG-1.1%2Fanimate-elem-82-t.svg From the potential revision ranges where the above tests started crashing, the culprit is r103130 or before. In looking at http://trac.webkit.org/log/?action=stop_on_copy&mode=stop_on_copy&rev=103130&stop_rev=103100&limit=100&verbose=on, this seems the most likely revision. I was able to repro this locally on Chromium's debug Linux DRT by running all the animate-elem*.svg tests with child-processes=1, where one test consistently failed. If I reverted this patch, it succeeded in 10/10 runs. 523345 1 enne 2011-12-17 13:19:37 -0800 Committed r103156: <http://trac.webkit.org/changeset/103156> 526939 2 rniwa 2011-12-23 19:57:36 -0800 It appears that these tests are no longer asserting. 526966 3 rniwa 2011-12-24 01:07:54 -0800 Hm... it appears that some of these crashes are still happening. I've removed them all in http://trac.webkit.org/changeset/103645 but had to add some of them back in http://trac.webkit.org/changeset/103654. 532949 4 jknotten 2012-01-10 03:48:00 -0800 svg/W3C-SVG-1.1/animate-elem-60-t.svg is flakily asserting on linux dgb: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=svg%2FW3C-SVG-1.1%2Fanimate-elem-60-t.svg 533888 5 schenney 2012-01-11 07:41:47 -0800 Taking ownership, as it seems the fastest way to get to the bottom of this. I'll first update expectations to mark it failing. 533893 6 122020 schenney 2012-01-11 07:49:25 -0800 Created attachment 122020 Patch Expectations update to stop build failures 533947 7 122020 webkit.review.bot 2012-01-11 09:20:07 -0800 Comment on attachment 122020 Patch Clearing flags on attachment: 122020 Committed r104715: <http://trac.webkit.org/changeset/104715> 533948 8 webkit.review.bot 2012-01-11 09:20:12 -0800 All reviewed patches have been landed. Closing bug. 533949 9 schenney 2012-01-11 09:20:59 -0800 Still need to actually fix it. 539485 10 schenney 2012-01-20 07:12:53 -0800 Marking all bugs reporting assertions in WebCore::SVGSMILElement::progress as duplicates. *** This bug has been marked as a duplicate of bug 64671 *** 122020 2012-01-11 07:49:25 -0800 2012-01-11 09:20:07 -0800 Patch bug-74788-20120111104924.patch text/plain 1506 schenney SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEwNDcxMSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTAxLTExICBTdGVwaGVuIENoZW5uZXkg IDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTAzMTMwKSAt IHN2Zy9XM0MtU1ZHLTEuMS9hbmltYXRlLWVsZW0tKi10LnN2ZyBhc3NlcnRpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0Nzg4CisKKyAgICAgICAg VW5yZXZpZXdlZCBjaHJvbWl1bSBleHBlY3RhdGlvbnMgdXBkYXRlLCBwZW5kaW5nIGEgcmVhbCBm aXguCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6 IEFkZGVkIGFuaW1hdGUtZWxlbS02MC10LnN2ZyBsaW51eCBkZWJ1ZyBmbGFrZXkgY3Jhc2gKKwog MjAxMi0wMS0xMSAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgV2ViS2l0MiBuZWVkcyBsYXlvdXRUZXN0Q29udHJvbGxlci5vdmVycmlkZVByZWZlcmVuY2UK SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVj dGF0aW9ucy50eHQJKHJldmlzaW9uIDEwNDcxMSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2No cm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29ya2luZyBjb3B5KQpAQCAtODk1LDYgKzg5 NSw3IEBAIEJVR0NSMTAyODQgTUFDIDogc3ZnL2N1c3RvbS9wYXRoLWJhZC1kYXQKIC8vICh3cm9u ZyBiYXNlbGluZSB3YXMgY29tbWl0dGVkKS4gTm8gaWRlYSBhYm91dCB3aGVuIGl0IHJlYWxseSBz dGFydGVkIHRvIGZhaWwuCiBCVUdDUjUyNjkyIExJTlVYIFdJTiBSRUxFQVNFIDogc3ZnL1czQy1T VkctMS4xL2FuaW1hdGUtZWxlbS04MC10LnN2ZyA9IElNQUdFK1RFWFQKIEJVR0NSNTI2OTIgQlVH V0s3NDc4OCBMSU5VWCBXSU4gREVCVUcgOiBzdmcvVzNDLVNWRy0xLjEvYW5pbWF0ZS1lbGVtLTgw LXQuc3ZnID0gSU1BR0UrVEVYVCBDUkFTSAorQlVHQ1I1MjY5MiBCVUdXSzc0Nzg4IExJTlVYIFdJ TiBERUJVRyA6IHN2Zy9XM0MtU1ZHLTEuMS9hbmltYXRlLWVsZW0tNjAtdC5zdmcgPSBJTUFHRStU RVhUIENSQVNICiBCVUdXSzc0Nzg4IE1BQyA6IHN2Zy9XM0MtU1ZHLTEuMS9hbmltYXRlLWVsZW0t ODAtdC5zdmcgPSBQQVNTIENSQVNICiAKIC8vIFdpbmRvd3MgYW5kIE1hYyBuZWVkIHJlYmFzZWxp bmluZyBhZnRlciA1MzM3OCBwYXRjaC4K