<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>74786</bug_id>
          
          <creation_ts>2011-12-17 05:14:43 -0800</creation_ts>
          <short_desc>Do accelerated filtering when drop-shadow is not the last filter in the chain</short_desc>
          <delta_ts>2014-03-02 10:15:51 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>68479</dependson>
          <blocked>68469</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Marrin">cmarrin</reporter>
          <assigned_to name="Chris Marrin">cmarrin</assigned_to>
          <cc>aroben</cc>
    
    <cc>dino</cc>
    
    <cc>krit</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>523289</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Marrin">cmarrin</who>
    <bug_when>2011-12-17 05:14:43 -0800</bug_when>
    <thetext>With https://bugs.webkit.org/show_bug.cgi?id=68479 filters are accelerated on CALayers. But the drop-shadow filter is done with CA&apos;s shadow properties which are applied after filters. So currently drop-shadow has to be the last filter in the chain or we don&apos;t accelerate filters. We could add a parent layer which could render all the filters that come after the drop-shadow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>523311</commentid>
    <comment_count>1</comment_count>
    <who name="Chris Marrin">cmarrin</who>
    <bug_when>2011-12-17 09:53:27 -0800</bug_when>
    <thetext>Add webkit-bug-importer to CC list</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>523901</commentid>
    <comment_count>2</comment_count>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2011-12-19 07:23:03 -0800</bug_when>
    <thetext>(Pinging bug importer)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>523919</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2011-12-19 08:26:30 -0800</bug_when>
    <thetext>&lt;rdar://problem/10601044&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>871455</commentid>
    <comment_count>4</comment_count>
    <who name="Dirk Schulze">krit</who>
    <bug_when>2013-04-08 22:30:31 -0700</bug_when>
    <thetext>I might be wrong, but if I understand the code correctly, each filter is added to a filter chain &quot;array&quot;. Would it be much slower to replace a drop shadow with
* a blur filter
* 2 compositing filter (one compositing with a flood color)
* 1 affineTransform filter

I just looked at the CIFilter path, but it doesn&apos;t look so much different to CAFilter, does it? I couldn&apos;t find official docs for CAFilter.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>878806</commentid>
    <comment_count>5</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2013-04-20 14:22:43 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; I might be wrong, but if I understand the code correctly, each filter is added to a filter chain &quot;array&quot;. Would it be much slower to replace a drop shadow with
&gt; * a blur filter
&gt; * 2 compositing filter (one compositing with a flood color)
&gt; * 1 affineTransform filter
&gt; 
&gt; I just looked at the CIFilter path, but it doesn&apos;t look so much different to CAFilter, does it? I couldn&apos;t find official docs for CAFilter.

We could do this with CI but not CA filters (because they don&apos;t have a blend that takes two inputs).</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>