74772 2011-12-16 17:34:09 -0800 FEComposite does not build when you disable filters on ARMv7 2011-12-17 19:16:31 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin ddkilzer krit oldest_to_newest 523179 0 benjamin 2011-12-16 17:34:09 -0800 Look like there could be a few missing ENABLE(FILTERS) here... 523180 1 119704 benjamin 2011-12-16 17:39:20 -0800 Created attachment 119704 Patch 523195 2 119704 kling 2011-12-16 18:07:02 -0800 Comment on attachment 119704 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119704&action=review > Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h:33 > +#if CPU(ARM_NEON) && COMPILER(GCC) > + > #include <wtf/Platform.h> This doesn't look right, we get CPU() and COMPILER() from Platform.h 523209 3 ddkilzer 2011-12-16 19:40:59 -0800 (In reply to comment #2) > (From update of attachment 119704 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119704&action=review > > > Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h:33 > > +#if CPU(ARM_NEON) && COMPILER(GCC) > > + > > #include <wtf/Platform.h> > > This doesn't look right, we get CPU() and COMPILER() from Platform.h The magic of the WebCorePrefix.h header means that the CPU() and COMPILER() macros will be defined (at least on OS X), but it would be best to put #include <wtf/Platform.h> above the macros for other ports. 523210 4 119704 ddkilzer 2011-12-16 19:42:10 -0800 Comment on attachment 119704 Patch r=me if you fix the #include <wtf/Platform.h> location in FECompositeArithmeticNEON.h. 523245 5 benjamin 2011-12-16 21:26:59 -0800 I don't mind but isn't the file always gonna be included after config.h anyway? 523248 6 benjamin 2011-12-16 21:55:04 -0800 Committed r103143: <http://trac.webkit.org/changeset/103143> 523382 7 ddkilzer 2011-12-17 19:16:31 -0800 (In reply to comment #5) > I don't mind but isn't the file always gonna be included after config.h anyway? True. I guess it's the principle of the matter. :) 119704 2011-12-16 17:39:20 -0800 2011-12-16 19:42:10 -0800 Patch bug-74772-20111216173919.patch text/plain 2438 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMDA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI2MzMxOGZkOGFjZDcz MGJmOWM0Mjg4ZmYzZDMyYzMzNzQxYzg0NS4uYzYwNDYxNjQ5NDBlNDhhNTMwYjU1YzY1MjNiOTZl YWU2YzQ3YTc2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTEyLTE2ICBCZW5q YW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgorCisgICAgICAgIEZFQ29tcG9zaXRl IGRvZXMgbm90IGJ1aWxkIHdoZW4geW91IGRpc2FibGUgZmlsdGVycyBvbiBBUk12NworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ3NzIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgdGhlIG1pc3Npbmcg RU5BQkxFKEZJTFRFUlMpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9h cm0vRkVDb21wb3NpdGVBcml0aG1ldGljTkVPTi5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZmlsdGVycy9hcm0vRkVDb21wb3NpdGVBcml0aG1ldGljTkVPTi5oOgorCiAyMDExLTEy LTE1ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZC4gRml4IGJ1aWxkIGJyZWFrIHdoZW4gZGF0YS10cmFuc2Zlci1pdGVtcyBpcyBl bmFibGVkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmls dGVycy9hcm0vRkVDb21wb3NpdGVBcml0aG1ldGljTkVPTi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUNvbXBvc2l0ZUFyaXRobWV0aWNORU9OLmNw cAppbmRleCBmYjA0MDk4YTM4Y2U0Zjc4NzM4NWU5Y2IyMTQwZjRmNDAxMjQ5YjExLi4yMmE4NDU4 MjNiZGFhNTQ3ZmI2MWFkMDdiNzY4NGE3ZDNhMjFmNDUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUNvbXBvc2l0ZUFyaXRobWV0aWNO RU9OLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2Fy bS9GRUNvbXBvc2l0ZUFyaXRobWV0aWNORU9OLmNwcApAQCAtMjUsNiArMjUsOCBAQAogICovCiAK ICNpbmNsdWRlICJjb25maWcuaCIKKworI2lmIEVOQUJMRShGSUxURVJTKQogI2luY2x1ZGUgIkZF Q29tcG9zaXRlQXJpdGhtZXRpY05FT04uaCIKIAogI2lmIENQVShBUk1fTkVPTikgJiYgQ09NUElM RVIoR0NDKQpAQCAtMTQ4LDMgKzE1MCw2IEBAIFRPU1RSSU5HKG5lb25EcmF3Q29tcG9zaXRlQXJp dGhtZXRpYykgIjoiIE5MCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBDUFUo QVJNX05FT04pICYmIENPTVBJTEVSKEdDQykKKworI2VuZGlmIC8vIEVOQUJMRShGSUxURVJTKQor CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2Fy bS9GRUNvbXBvc2l0ZUFyaXRobWV0aWNORU9OLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9maWx0ZXJzL2FybS9GRUNvbXBvc2l0ZUFyaXRobWV0aWNORU9OLmgKaW5kZXggNjc2 ODljNTk5ZTY2M2FmNGMzYTA1ZWEwOWMxYjFiMzIxMzU5MDRlOC4uNGU1MmYxNzgwYWZhNzgxNTQ2 NzlmN2FiN2I2MmQxODJlNTU5OTY1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZmlsdGVycy9hcm0vRkVDb21wb3NpdGVBcml0aG1ldGljTkVPTi5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZFQ29tcG9zaXRl QXJpdGhtZXRpY05FT04uaApAQCAtMjcsOSArMjcsMTEgQEAKICNpZm5kZWYgRkVDb21wb3NpdGVB cml0aG1ldGljTkVPTl9oCiAjZGVmaW5lIEZFQ29tcG9zaXRlQXJpdGhtZXRpY05FT05faAogCisj aWYgRU5BQkxFKEZJTFRFUlMpCisjaWYgQ1BVKEFSTV9ORU9OKSAmJiBDT01QSUxFUihHQ0MpCisK ICNpbmNsdWRlIDx3dGYvUGxhdGZvcm0uaD4KIAotI2lmIENQVShBUk1fTkVPTikgJiYgQ09NUElM RVIoR0NDKQogCiAjaW5jbHVkZSAiRkVDb21wb3NpdGUuaCIKIApAQCAtNDcsNSArNDksNiBAQCBp bmxpbmUgdm9pZCBGRUNvbXBvc2l0ZTo6cGxhdGZvcm1Bcml0aG1ldGljTmVvbih1bnNpZ25lZCBj aGFyKiBzb3VyY2UsIHVuc2lnbmVkCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAv LyBDUFUoQVJNX05FT04pICYmIENPTVBJTEVSKEdDQykKKyNlbmRpZiAvLyBFTkFCTEUoRklMVEVS UykKIAogI2VuZGlmIC8vIEZFQ29tcG9zaXRlQXJpdGhtZXRpY05FT05faAo=