74770 2011-12-16 16:56:39 -0800 Convert more WorkItems over to WTF::Functions 2011-12-16 17:03:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 523163 0 andersca 2011-12-16 16:56:39 -0800 Convert more WorkItems over to WTF::Functions 523164 1 119701 andersca 2011-12-16 16:58:10 -0800 Created attachment 119701 Patch 523167 2 119701 kling 2011-12-16 17:01:44 -0800 Comment on attachment 119701 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119701&action=review > Source/WebKit2/WebProcess/Plugins/PluginView.cpp:1221 > - RunLoop::main()->scheduleWork(WorkItem::createDeref(this)); > + RunLoop::main()->dispatch(bind(derefPluginView, this)); I don't think WorkItem::createDeref() has any more call sites, so you should remove it, too. 523168 3 andersca 2011-12-16 17:03:47 -0800 Committed r103132: <http://trac.webkit.org/changeset/103132> 119701 2011-12-16 16:58:10 -0800 2011-12-16 17:01:44 -0800 Patch bug-74770-20111216165813.patch text/plain 6952 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDJjZDU5NjQ2YjhmMWMx ZTAxMTc2NmY2MDc4YTk3NTg5NmI1NzJjOC4uZDlmN2UxOTk1ZTMzZTk5MDViODEwMDc5ZjJiN2Ni NTczMTY4NjRlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDExLTEyLTE2ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQ29udmVydCBtb3Jl IFdvcmtJdGVtcyBvdmVyIHRvIFdURjo6RnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDc3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogUGxhdGZvcm0vV29ya1F1ZXVlLmNwcDoKKyAgICAg ICAgKFdvcmtRdWV1ZTo6ZGlzcGF0Y2hBZnRlckRlbGF5KToKKyAgICAgICAgKiBQbGF0Zm9ybS9X b3JrUXVldWUuaDoKKyAgICAgICAgKiBTaGFyZWQvQ2hpbGRQcm9jZXNzLmNwcDoKKyAgICAgICAg KFdlYktpdDo6Q2hpbGRQcm9jZXNzOjpkaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZSk6Cisg ICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL1RocmVhZExhdW5jaGVyLmNwcDoKKyAgICAgICAg KFdlYktpdDo6VGhyZWFkTGF1bmNoZXI6OmxhdW5jaFRocmVhZCk6CisgICAgICAgICogVUlQcm9j ZXNzL0xhdW5jaGVyL21hYy9Qcm9jZXNzTGF1bmNoZXJNYWMubW06CisgICAgICAgIChXZWJLaXQ6 OlByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2Vzcyk6CisgICAgICAgICogV2ViUHJvY2Vzcy9Q bHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0 c2NhcGVQbHVnaW46OnBsdWdpblRocmVhZEFzeW5jQ2FsbCk6CisgICAgICAgICogV2ViUHJvY2Vz cy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwOgorICAgICAgICAoV2ViS2l0OjpkZXJlZlBsdWdpblZp ZXcpOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5WaWV3Ojp1bnByb3RlY3RQbHVnaW5Gcm9tRGVz dHJ1Y3Rpb24pOgorCisyMDExLTEyLTE2ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBs ZS5jb20+CisKICAgICAgICAgQWRkIGEgcHJldHR5IGR1bWIgdGlsZSBjYWNoZSB0byBXZWJUaWxl Q2FjaGVMYXllcgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NzQ3NTMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vV29ya1F1ZXVl LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL1dvcmtRdWV1ZS5jcHAKaW5kZXggMTI0OTll OTcyODJjMGQ2ZjdlOWU2ZThjYTRjNThmNDI2OGE5Y2VlZC4uMzY0YmVkMjE0MWViNzk1NzhhODNm OTI4YWVlMjQyMzg5YTc3ODVhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0v V29ya1F1ZXVlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Xb3JrUXVldWUuY3Bw CkBAIC00NSw2ICs0NSwxMSBAQCB2b2lkIFdvcmtRdWV1ZTo6ZGlzcGF0Y2goY29uc3QgRnVuY3Rp b248dm9pZCgpPiYgZnVuY3Rpb24pCiAgICAgc2NoZWR1bGVXb3JrKFdvcmtJdGVtOjpjcmVhdGUo ZnVuY3Rpb24pKTsKIH0KIAordm9pZCBXb3JrUXVldWU6OmRpc3BhdGNoQWZ0ZXJEZWxheShjb25z dCBGdW5jdGlvbjx2b2lkKCk+JiBmdW5jdGlvbiwgZG91YmxlIGRlbGF5KQoreworICAgIHNjaGVk dWxlV29ya0FmdGVyRGVsYXkoV29ya0l0ZW06OmNyZWF0ZShmdW5jdGlvbiksIGRlbGF5KTsKK30K Kwogdm9pZCBXb3JrUXVldWU6OmludmFsaWRhdGUoKQogewogICAgIHsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1BsYXRmb3JtL1dvcmtRdWV1ZS5oIGIvU291cmNlL1dlYktpdDIvUGxhdGZv cm0vV29ya1F1ZXVlLmgKaW5kZXggM2Q2OTcxYzc0Y2RmY2ExZjMyMmIyM2EzZjU3MGI1YmRkZjhh YjEwOC4uODBiOGZkZjNlODdlMDFmZDNmMTZjMWI5OTZjYTZkZDc4ZmQyZWM1NiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vV29ya1F1ZXVlLmgKKysrIGIvU291cmNlL1dlYktp dDIvUGxhdGZvcm0vV29ya1F1ZXVlLmgKQEAgLTY4LDYgKzY4LDkgQEAgcHVibGljOgogICAgIC8v IFdpbGwgZGlzcGF0Y2ggdGhlIGdpdmVuIGZ1bmN0aW9uIHRvIHJ1biBhcyBzb29uIGFzIHBvc3Np YmxlLgogICAgIHZvaWQgZGlzcGF0Y2goY29uc3QgRnVuY3Rpb248dm9pZCgpPiYpOwogCisgICAg Ly8gV2lsbCBkaXNwYXRjaCB0aGUgZ2l2ZW4gZnVuY3Rpb24gYWZ0ZXIgdGhlIGdpdmVuIGRlbGF5 IChpbiBzZWNvbmRzKS4KKyAgICB2b2lkIGRpc3BhdGNoQWZ0ZXJEZWxheShjb25zdCBGdW5jdGlv bjx2b2lkKCk+JiwgZG91YmxlIGRlbGF5KTsKKwogICAgIC8vIEZJWE1FOiBHZXQgcmlkIG9mIFdv cmtJdGVtIGV2ZXJ5d2hlcmUuCiAKICAgICAvLyBXaWxsIHNjaGVkdWxlIHRoZSBnaXZlbiB3b3Jr IGl0ZW0gdG8gcnVuIGFzIHNvb24gYXMgcG9zc2libGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQ2hpbGRQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9DaGls ZFByb2Nlc3MuY3BwCmluZGV4IGU3MDBjYWEwZjYzMzg2YmJhOWE0ZTA1MzM0MmUyZjk4ZDU1MDYy OTMuLjhiM2NkYjI4MmNiOWI4M2Y0YjQ4ZTIwNzUzNDZmODVmZmI5ZDRhNmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9DaGlsZFByb2Nlc3MuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9DaGlsZFByb2Nlc3MuY3BwCkBAIC05Myw4ICs5Myw4IEBAIHZvaWQgQ2hpbGRQ cm9jZXNzOjpkaWRDbG9zZU9uQ29ubmVjdGlvbldvcmtRdWV1ZShXb3JrUXVldWUmIHdvcmtRdWV1 ZSwgQ29yZUlQQzo6CiAgICAgLy8gSWYgdGhlIGNvbm5lY3Rpb24gaGFzIGJlZW4gY2xvc2VkIGFu ZCB3ZSBoYXZlbid0IHJlc3BvbmRlZCBpbiB0aGUgbWFpbiB0aHJlYWQgZm9yIDEwIHNlY29uZHMK ICAgICAvLyB0aGUgcHJvY2VzcyB3aWxsIGV4aXQgZm9yY2libHkuCiAgICAgc3RhdGljIGNvbnN0 IGRvdWJsZSB3YXRjaGRvZ0RlbGF5ID0gMTAuMDsKLSAgICAKLSAgICB3b3JrUXVldWUuc2NoZWR1 bGVXb3JrQWZ0ZXJEZWxheShXb3JrSXRlbTo6Y3JlYXRlKHdhdGNoZG9nQ2FsbGJhY2spLCB3YXRj aGRvZ0RlbGF5KTsKKworICAgIHdvcmtRdWV1ZS5kaXNwYXRjaEFmdGVyRGVsYXkoYmluZChzdGF0 aWNfY2FzdDx2b2lkKCopKCk+KHdhdGNoZG9nQ2FsbGJhY2spKSwgd2F0Y2hkb2dEZWxheSk7CiB9 CiAgICAgCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9MYXVuY2hlci9UaHJlYWRMYXVuY2hlci5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvTGF1bmNoZXIvVGhyZWFkTGF1bmNoZXIuY3BwCmluZGV4IGQzMzE3NDkwMDQ3OGM5 MmUzYmFjYWY3NGZmMzAyZTlkYWU5ZDRmNjUuLjNjMGZiZjE2MGNjNzZlNjAxODQxNWQ2ZDNiMzRj Njk2MTYxNmJhMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hl ci9UaHJlYWRMYXVuY2hlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5j aGVyL1RocmVhZExhdW5jaGVyLmNwcApAQCAtNDMsNyArNDMsNyBAQCB2b2lkIFRocmVhZExhdW5j aGVyOjpsYXVuY2hUaHJlYWQoKQogICAgIENvcmVJUEM6OkNvbm5lY3Rpb246OklkZW50aWZpZXIg Y29ubmVjdGlvbklkZW50aWZpZXIgPSBjcmVhdGVXZWJUaHJlYWQoKTsKIAogICAgIC8vIFdlJ3Zl IGZpbmlzaGVkIGxhdW5jaGluZyB0aGUgdGhyZWFkLCBtZXNzYWdlIGJhY2sgdG8gdGhlIG1haW4g cnVuIGxvb3AuCi0gICAgUnVuTG9vcDo6bWFpbigpLT5zY2hlZHVsZVdvcmsoV29ya0l0ZW06OmNy ZWF0ZSh0aGlzLCAmVGhyZWFkTGF1bmNoZXI6OmRpZEZpbmlzaExhdW5jaGluZ1RocmVhZCwgY29u bmVjdGlvbklkZW50aWZpZXIpKTsKKyAgICBSdW5Mb29wOjptYWluKCktPmRpc3BhdGNoKGJpbmQo JlRocmVhZExhdW5jaGVyOjpkaWRGaW5pc2hMYXVuY2hpbmdUaHJlYWQsIHRoaXMsIGNvbm5lY3Rp b25JZGVudGlmaWVyKSk7CiB9CiAKIHZvaWQgVGhyZWFkTGF1bmNoZXI6OmRpZEZpbmlzaExhdW5j aGluZ1RocmVhZChDb3JlSVBDOjpDb25uZWN0aW9uOjpJZGVudGlmaWVyIGlkZW50aWZpZXIpCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvbWFjL1Byb2Nlc3NM YXVuY2hlck1hYy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJv Y2Vzc0xhdW5jaGVyTWFjLm1tCmluZGV4IDI5OWYwMjM0ODFmOTkzNGI3MDFjZDIyMWMzOTU5ODAz OTcyNWJmZjQuLjFlMjBhOGY0NjcwNGZhNzVmMzk2MjQ3ZWNlYjE4ZTQ2ZjEwMzU1ZjEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJvY2Vzc0xhdW5j aGVyTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9tYWMvUHJv Y2Vzc0xhdW5jaGVyTWFjLm1tCkBAIC0xODIsNyArMTgyLDcgQEAgdm9pZCBQcm9jZXNzTGF1bmNo ZXI6OmxhdW5jaFByb2Nlc3MoKQogICAgIH0KICAgICAKICAgICAvLyBXZSd2ZSBmaW5pc2hlZCBs YXVuY2hpbmcgdGhlIHByb2Nlc3MsIG1lc3NhZ2UgYmFjayB0byB0aGUgbWFpbiBydW4gbG9vcC4K LSAgICBSdW5Mb29wOjptYWluKCktPnNjaGVkdWxlV29yayhXb3JrSXRlbTo6Y3JlYXRlKHRoaXMs ICZQcm9jZXNzTGF1bmNoZXI6OmRpZEZpbmlzaExhdW5jaGluZ1Byb2Nlc3MsIHByb2Nlc3NJZGVu dGlmaWVyLCBsaXN0ZW5pbmdQb3J0KSk7CisgICAgUnVuTG9vcDo6bWFpbigpLT5kaXNwYXRjaChi aW5kKCZQcm9jZXNzTGF1bmNoZXI6OmRpZEZpbmlzaExhdW5jaGluZ1Byb2Nlc3MsIHRoaXMsIHBy b2Nlc3NJZGVudGlmaWVyLCBsaXN0ZW5pbmdQb3J0KSk7CiB9CiAKIHZvaWQgUHJvY2Vzc0xhdW5j aGVyOjp0ZXJtaW5hdGVQcm9jZXNzKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uY3BwCmluZGV4IDQw ODlhNWZiMWUyYTRkNTNjN2I3MTI0YTIwZWE1MDdmMjU0OTUzNzguLjY5MjNlN2JjMDFjZmQyNmJh MzRhZWRiNDU0MTAyZmU5NWU3NDg3ZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL05ldHNjYXBlUGx1Z2luLmNwcApAQCAt MzA4LDcgKzMwOCw3IEBAIHZvaWQgTmV0c2NhcGVQbHVnaW46OnBvcFBvcHVwc0VuYWJsZWRTdGF0 ZSgpCiAKIHZvaWQgTmV0c2NhcGVQbHVnaW46OnBsdWdpblRocmVhZEFzeW5jQ2FsbCh2b2lkICgq ZnVuY3Rpb24pKHZvaWQqKSwgdm9pZCogdXNlckRhdGEpCiB7Ci0gICAgUnVuTG9vcDo6bWFpbigp LT5zY2hlZHVsZVdvcmsoV29ya0l0ZW06OmNyZWF0ZSh0aGlzLCAmTmV0c2NhcGVQbHVnaW46Omhh bmRsZVBsdWdpblRocmVhZEFzeW5jQ2FsbCwgZnVuY3Rpb24sIHVzZXJEYXRhKSk7CisgICAgUnVu TG9vcDo6bWFpbigpLT5kaXNwYXRjaChiaW5kKCZOZXRzY2FwZVBsdWdpbjo6aGFuZGxlUGx1Z2lu VGhyZWFkQXN5bmNDYWxsLCB0aGlzLCBmdW5jdGlvbiwgdXNlckRhdGEpKTsKIH0KICAgICAKIHZv aWQgTmV0c2NhcGVQbHVnaW46OmhhbmRsZVBsdWdpblRocmVhZEFzeW5jQ2FsbCh2b2lkICgqZnVu Y3Rpb24pKHZvaWQqKSwgdm9pZCogdXNlckRhdGEpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAKaW5kZXggN2RlMGZkNjU3YTgzYTI4ZTAwMzg5 MzBiOTYwZmQyNGNhYjQwOTg1Yi4uNWI5MTVkYzQwMWIwOTc0NjE1OTQ3YTA5MmQ1ZTI4YjI5NjZl ZGQ0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdp blZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5W aWV3LmNwcApAQCAtMTIwMiw2ICsxMjAyLDExIEBAIHZvaWQgUGx1Z2luVmlldzo6cHJvdGVjdFBs dWdpbkZyb21EZXN0cnVjdGlvbigpCiAgICAgICAgIHJlZigpOwogfQogCitzdGF0aWMgdm9pZCBk ZXJlZlBsdWdpblZpZXcoUGx1Z2luVmlldyogcGx1Z2luVmlldykKK3sKKyAgICBwbHVnaW5WaWV3 LT5kZXJlZigpOworfQorCiB2b2lkIFBsdWdpblZpZXc6OnVucHJvdGVjdFBsdWdpbkZyb21EZXN0 cnVjdGlvbigpCiB7CiAgICAgaWYgKG1faXNCZWluZ0Rlc3Ryb3llZCkKQEAgLTEyMTMsNyArMTIx OCw3IEBAIHZvaWQgUGx1Z2luVmlldzo6dW5wcm90ZWN0UGx1Z2luRnJvbURlc3RydWN0aW9uKCkK ICAgICAvLyB0aGUgZGVzdHJveWVkIG9iamVjdCBoaWdoZXIgb24gdGhlIHN0YWNrLiBUbyBwcmV2 ZW50IHRoaXMsIGlmIHRoZSBwbHVnLWluIGhhcwogICAgIC8vIG9ubHkgb25lIHJlbWFpbmluZyBy ZWZlcmVuY2UsIGNhbGwgZGVyZWYoKSBhc3luY2hyb25vdXNseS4KICAgICBpZiAoaGFzT25lUmVm KCkpCi0gICAgICAgIFJ1bkxvb3A6Om1haW4oKS0+c2NoZWR1bGVXb3JrKFdvcmtJdGVtOjpjcmVh dGVEZXJlZih0aGlzKSk7CisgICAgICAgIFJ1bkxvb3A6Om1haW4oKS0+ZGlzcGF0Y2goYmluZChk ZXJlZlBsdWdpblZpZXcsIHRoaXMpKTsKICAgICBlbHNlCiAgICAgICAgIGRlcmVmKCk7CiB9Cg==