74767 2011-12-16 16:22:13 -0800 Remove unused variable after r103120 (buildfix) 2011-12-17 08:37:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED INVALID P1 Critical --- 1 rafael.lobo rafael.lobo darin kling mrowe oliver ossy rafael.lobo rniwa webkit.review.bot oldest_to_newest 523146 0 rafael.lobo 2011-12-16 16:22:13 -0800 The compiler was complaining about "valueGPR" being set but not used. That patch used that value on its asserts, but right now as it is not used anymore, we're most likely safe to remove it. 523148 1 119697 rafael.lobo 2011-12-16 16:25:57 -0800 Created attachment 119697 Patch 523211 2 119697 webkit.review.bot 2011-12-16 19:46:33 -0800 Comment on attachment 119697 Patch Clearing flags on attachment: 119697 Committed r103139: <http://trac.webkit.org/changeset/103139> 523212 3 webkit.review.bot 2011-12-16 19:46:37 -0800 All reviewed patches have been landed. Closing bug. 523221 4 rniwa 2011-12-16 20:18:12 -0800 This patch massively broke builds :( 523232 5 rniwa 2011-12-16 20:40:45 -0800 /Volumes/Data/slave/snowleopard-intel-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1597:5: error: use of undeclared identifier 'valueGPR' [3] ASSERT_UNUSED(valueGPR, valueGPR != property); ^ /Volumes/Data/slave/snowleopard-intel-release/build/Source/JavaScriptCore/wtf/Assertions.h:233:51: note: instantiated from: #define ASSERT_UNUSED(variable, assertion) ((void)variable) ^ /Volumes/Data/slave/snowleopard-intel-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1597:19: note: instantiated from: ASSERT_UNUSED(valueGPR, valueGPR != property); ^ /Volumes/Data/slave/snowleopard-intel-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1745:5: error: use of undeclared identifier 'valueGPR' [3] ASSERT_UNUSED(valueGPR, valueGPR != property); ^ /Volumes/Data/slave/snowleopard-intel-release/build/Source/JavaScriptCore/wtf/Assertions.h:233:51: note: instantiated from: #define ASSERT_UNUSED(variable, assertion) ((void)variable) ^ /Volumes/Data/slave/snowleopard-intel-release/build/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:1745:19: note: instantiated from: ASSERT_UNUSED(valueGPR, valueGPR != property); ^ 2 errors generated. 523238 6 mrowe 2011-12-16 20:50:16 -0800 I rolled it out in r103142 since it’s so obviously incorrect. 523239 7 mrowe 2011-12-16 20:57:17 -0800 It’d be useful to mention which build you’re trying to fix with this change. The build certainly hasn’t been broken since r74747 for any of the major ports we deal with. 523240 8 rafael.lobo 2011-12-16 21:05:33 -0800 (In reply to comment #7) > It’d be useful to mention which build you’re trying to fix with this change. The build certainly hasn’t been broken since r74747 for any of the major ports we deal with. The patch was fixing the build warning that came with https://bugs.webkit.org/show_bug.cgi?id=74747. It was actually r103120, I've wrongly used the bug id instead in the title. But when it landed, the code that it was fixing was reverted right before, so the fix lost its sense. 523241 9 mrowe 2011-12-16 21:07:59 -0800 Ok. Closing as invalid then since there’s nothing to do here. 523254 10 darin 2011-12-16 22:32:52 -0800 The value is used in ASSERT_UNUSED. How did I miss that? 523286 11 ossy 2011-12-17 04:31:07 -0800 (In reply to comment #8) > (In reply to comment #7) > > It’d be useful to mention which build you’re trying to fix with this change. The build certainly hasn’t been broken since r74747 for any of the major ports we deal with. > > The patch was fixing the build warning that came with https://bugs.webkit.org/show_bug.cgi?id=74747. It was actually r103120, I've wrongly used the bug id instead in the title. But when it landed, the code that it was fixing was reverted right before, so the fix lost its sense. Next time it would be better if you add a comment to the original bug and/or add the original bug to the blocks list of the buildfix bug. (sheriffbot does same thing with rollout bug reports) 523301 12 rafael.lobo 2011-12-17 08:37:17 -0800 (In reply to comment #11) > (In reply to comment #8) > > (In reply to comment #7) > > > It’d be useful to mention which build you’re trying to fix with this change. The build certainly hasn’t been broken since r74747 for any of the major ports we deal with. > > > > The patch was fixing the build warning that came with https://bugs.webkit.org/show_bug.cgi?id=74747. It was actually r103120, I've wrongly used the bug id instead in the title. But when it landed, the code that it was fixing was reverted right before, so the fix lost its sense. > > Next time it would be better if you add a comment to the original bug and/or add the original bug to the blocks list of the buildfix bug. (sheriffbot does same thing with rollout bug reports) Ok, I'll do that. And sorry about the trouble with this one. 119697 2011-12-16 16:25:57 -0800 2011-12-16 19:46:33 -0800 Patch bug-74767-20111216212552.patch text/plain 4045 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 MjIxMzBiNTBjNmJjNjc1OTZlN2EwMjBkMTJkM2U4MTRkYjIyY2FlLi4wNjQ5NDg3NTMwMjY4Y2Jh YjM0NWU2ZWFmOTk0NWQzNzUzOTU4OTI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxMS0xMi0xNiAgUmFmYWVsIEJyYW5kYW8gIDxyYWZhZWwubG9ib0BvcGVu Ym9zc2Eub3JnPgorCisgICAgICAgIFJlbW92ZSB1bnVzZWQgdmFyaWFibGUgYWZ0ZXIgcjc0NzQ3 IChidWlsZGZpeCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc0NzY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1 bGF0aXZlSklUOjpjb21waWxlUHV0QnlWYWxGb3JCeXRlQXJyYXkpOgorICAgICAgICAoSlNDOjpE Rkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlUHV0QnlWYWxGb3JJbnRUeXBlZEFycmF5KToKKwog MjAxMS0xMi0xNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFB1 dEJ5VmFsW0FsaWFzXSB1bm5lY2Vzc2FyaWx5IHJlbG9hZHMgdGhlIHN0b3JhZ2UgYnVmZmVyCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNw cCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCmluZGV4 IDg4OTNhZmVjZjZmMTg4MDM2MzM4YmU4YWFhYmUxMTI0MmIzNDNkYmQuLjM0OGIxODZlMGNjYTEz YmEzMTQ0Yzg3ZGQxOWRmNjVmN2E1MTkxNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwCkBAIC0xNTU3LDcgKzE1NTcsNiBAQCB2b2lkIFNw ZWN1bGF0aXZlSklUOjpjb21waWxlUHV0QnlWYWxGb3JCeXRlQXJyYXkoTm9kZSYgbm9kZSkKICAg ICAgICAgc3BlY3VsYXRpb25DaGVjayhCYWRUeXBlLCBKU1ZhbHVlU291cmNlOjp1bmJveGVkQ2Vs bChiYXNlLmdwcigpKSwgYmFzZUluZGV4LCBtX2ppdC5icmFuY2hQdHIoTWFjcm9Bc3NlbWJsZXI6 Ok5vdEVxdWFsLCBNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhiYXNlLmdwcigpLCBKU0NlbGw6OmNs YXNzSW5mb09mZnNldCgpKSwgTWFjcm9Bc3NlbWJsZXI6OlRydXN0ZWRJbW1QdHIoJkpTQnl0ZUFy cmF5OjpzX2luZm8pKSk7CiAgICAgfQogICAgIEdQUlRlbXBvcmFyeSB2YWx1ZTsKLSAgICBHUFJS ZWcgdmFsdWVHUFI7CiAKICAgICBpZiAoYXQodmFsdWVJbmRleCkuaXNDb25zdGFudCgpKSB7CiAg ICAgICAgIEpTVmFsdWUganNWYWx1ZSA9IHZhbHVlT2ZKU0NvbnN0YW50KHZhbHVlSW5kZXgpOwpA QCAtMTU3Niw3ICsxNTc1LDYgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZVB1dEJ5VmFs Rm9yQnl0ZUFycmF5KE5vZGUmIG5vZGUpCiAgICAgICAgIEdQUlJlZyBzY3JhdGNoUmVnID0gc2Ny YXRjaC5ncHIoKTsKICAgICAgICAgbV9qaXQubW92ZShJbW0zMigoaW50KWQpLCBzY3JhdGNoUmVn KTsKICAgICAgICAgdmFsdWUuYWRvcHQoc2NyYXRjaCk7Ci0gICAgICAgIHZhbHVlR1BSID0gc2Ny YXRjaFJlZzsKICAgICB9IGVsc2UgaWYgKCFhdCh2YWx1ZUluZGV4KS5zaG91bGROb3RTcGVjdWxh dGVJbnRlZ2VyKCkpIHsKICAgICAgICAgU3BlY3VsYXRlSW50ZWdlck9wZXJhbmQgdmFsdWVPcCh0 aGlzLCB2YWx1ZUluZGV4KTsKICAgICAgICAgR1BSVGVtcG9yYXJ5IHNjcmF0Y2godGhpcyk7CkBA IC0xNTkxLDcgKzE1ODksNiBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlUHV0QnlWYWxG b3JCeXRlQXJyYXkoTm9kZSYgbm9kZSkKICAgICAgICAgY2xhbXBlZC5saW5rKCZtX2ppdCk7CiAg ICAgICAgIGluQm91bmRzLmxpbmsoJm1faml0KTsKICAgICAgICAgdmFsdWUuYWRvcHQoc2NyYXRj aCk7Ci0gICAgICAgIHZhbHVlR1BSID0gc2NyYXRjaFJlZzsKICAgICB9IGVsc2UgewogICAgICAg ICBTcGVjdWxhdGVEb3VibGVPcGVyYW5kIHZhbHVlT3AodGhpcywgdmFsdWVJbmRleCk7CiAgICAg ICAgIEdQUlRlbXBvcmFyeSByZXN1bHQodGhpcyk7CkBAIC0xNjAwLDcgKzE1OTcsNiBAQCB2b2lk IFNwZWN1bGF0aXZlSklUOjpjb21waWxlUHV0QnlWYWxGb3JCeXRlQXJyYXkoTm9kZSYgbm9kZSkK ICAgICAgICAgR1BSUmVnIGdwciA9IHJlc3VsdC5ncHIoKTsKICAgICAgICAgY29tcGlsZUNsYW1w RG91YmxlVG9CeXRlKG1faml0LCBncHIsIGZwciwgZmxvYXRTY3JhdGNoLmZwcigpKTsKICAgICAg ICAgdmFsdWUuYWRvcHQocmVzdWx0KTsKLSAgICAgICAgdmFsdWVHUFIgPSBncHI7CiAgICAgfQog ICAgIFN0b3JhZ2VPcGVyYW5kIHN0b3JhZ2UodGhpcywgc3RvcmFnZUluZGV4KTsKICAgICBTcGVj dWxhdGVJbnRlZ2VyT3BlcmFuZCBwcm9wZXJ0eSh0aGlzLCBwcm9wZXJ0eUluZGV4KTsKQEAgLTE3 MjgsNyArMTcyNCw2IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQdXRCeVZhbEZvcklu dFR5cGVkQXJyYXkoY29uc3QgVHlwZWRBcnJheURlc2NyaXB0b3ImCiAgICAgICAgICAgICBvdXRP ZkJvdW5kcyA9IG1faml0LmJyYW5jaDMyKE1hY3JvQXNzZW1ibGVyOjpBYm92ZU9yRXF1YWwsIHBy b3BlcnR5UmVnLCBNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhiYXNlLmdwcigpLCBkZXNjcmlwdG9y Lm1fbGVuZ3RoT2Zmc2V0KSk7CiAgICAgfQogICAgIEdQUlRlbXBvcmFyeSB2YWx1ZTsKLSAgICBH UFJSZWcgdmFsdWVHUFI7CiAgICAgCiAgICAgaWYgKGF0KHZhbHVlSW5kZXgpLmlzQ29uc3RhbnQo KSkgewogICAgICAgICBKU1ZhbHVlIGpzVmFsdWUgPSB2YWx1ZU9mSlNDb25zdGFudCh2YWx1ZUlu ZGV4KTsKQEAgLTE3NDIsMTQgKzE3MzcsMTIgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGls ZVB1dEJ5VmFsRm9ySW50VHlwZWRBcnJheShjb25zdCBUeXBlZEFycmF5RGVzY3JpcHRvciYKICAg ICAgICAgR1BSUmVnIHNjcmF0Y2hSZWcgPSBzY3JhdGNoLmdwcigpOwogICAgICAgICBtX2ppdC5t b3ZlKEltbTMyKChpbnQpZCksIHNjcmF0Y2hSZWcpOwogICAgICAgICB2YWx1ZS5hZG9wdChzY3Jh dGNoKTsKLSAgICAgICAgdmFsdWVHUFIgPSBzY3JhdGNoUmVnOwogICAgIH0gZWxzZSBpZiAoIWF0 KHZhbHVlSW5kZXgpLnNob3VsZE5vdFNwZWN1bGF0ZUludGVnZXIoKSkgewogICAgICAgICBTcGVj dWxhdGVJbnRlZ2VyT3BlcmFuZCB2YWx1ZU9wKHRoaXMsIHZhbHVlSW5kZXgpOwogICAgICAgICBH UFJUZW1wb3Jhcnkgc2NyYXRjaCh0aGlzKTsKICAgICAgICAgR1BSUmVnIHNjcmF0Y2hSZWcgPSBz Y3JhdGNoLmdwcigpOwogICAgICAgICBtX2ppdC5tb3ZlKHZhbHVlT3AuZ3ByKCksIHNjcmF0Y2hS ZWcpOwogICAgICAgICB2YWx1ZS5hZG9wdChzY3JhdGNoKTsKLSAgICAgICAgdmFsdWVHUFIgPSBz Y3JhdGNoUmVnOwogICAgIH0gZWxzZSB7CiAgICAgICAgIFNwZWN1bGF0ZURvdWJsZU9wZXJhbmQg dmFsdWVPcCh0aGlzLCB2YWx1ZUluZGV4KTsKICAgICAgICAgR1BSVGVtcG9yYXJ5IHJlc3VsdCh0 aGlzKTsKQEAgLTE3NjYsNyArMTc1OSw2IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQ dXRCeVZhbEZvckludFR5cGVkQXJyYXkoY29uc3QgVHlwZWRBcnJheURlc2NyaXB0b3ImCiAgICAg ICAgICAgICBtX2ppdC50cnVuY2F0ZURvdWJsZVRvVWludDMyKGZwciwgZ3ByKTsKICAgICAgICAg Zml4ZWQubGluaygmbV9qaXQpOwogICAgICAgICB2YWx1ZS5hZG9wdChyZXN1bHQpOwotICAgICAg ICB2YWx1ZUdQUiA9IGdwcjsKICAgICB9CiAKICAgICBzd2l0Y2ggKGVsZW1lbnRTaXplKSB7Cg==