74764 2011-12-16 16:13:27 -0800 Make WebIntentServiceInfo constructor public for testing. 2011-12-22 14:09:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 75123 1 gbillock gbillock dglazkov fishd webkit.review.bot oldest_to_newest 523136 0 gbillock 2011-12-16 16:13:27 -0800 Make WebIntentServiceInfo constructor public for testing. 523137 1 119694 gbillock 2011-12-16 16:13:52 -0800 Created attachment 119694 Patch 523138 2 webkit.review.bot 2011-12-16 16:15:25 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 523144 3 119694 fishd 2011-12-16 16:21:58 -0800 Comment on attachment 119694 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119694&action=review > Source/WebKit/chromium/public/WebIntentServiceInfo.h:44 > + WebIntentServiceInfo(); please note that using this constructor will break the build if used outside of webkit.dll. perhaps you mean to export it? WEBKIT_EXPORT is the way, or in this case, I think it would be better to just inline the constructor as we do elsewhere. 523178 4 119694 webkit.review.bot 2011-12-16 17:31:47 -0800 Comment on attachment 119694 Patch Attachment 119694 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10904943 New failing tests: http/tests/inspector/resource-tree/resource-tree-document-url.html 523947 5 119873 gbillock 2011-12-19 09:41:01 -0800 Created attachment 119873 Patch 523953 6 119694 gbillock 2011-12-19 09:50:22 -0800 Comment on attachment 119694 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119694&action=review >> Source/WebKit/chromium/public/WebIntentServiceInfo.h:44 >> + WebIntentServiceInfo(); > > please note that using this constructor will break the build if used outside of > webkit.dll. perhaps you mean to export it? WEBKIT_EXPORT is the way, or in > this case, I think it would be better to just inline the constructor as we do > elsewhere. Done. 524481 7 119873 webkit.review.bot 2011-12-20 01:41:47 -0800 Comment on attachment 119873 Patch Clearing flags on attachment: 119873 Committed r103311: <http://trac.webkit.org/changeset/103311> 524482 8 webkit.review.bot 2011-12-20 01:41:57 -0800 All reviewed patches have been landed. Closing bug. 119694 2011-12-16 16:13:52 -0800 2011-12-19 09:50:21 -0800 Patch bug-74764-20111216161351.patch text/plain 1556 gbillock U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhlNGEwNzA2MzE3MzM4YTc1M2VjNDZiZWUyODhhOWIwMWNlZmRjOTkuLmJhODZkNGRhZjhmMTU1 NmNkZDc5ZjY4YTViNjg1NGRiOWFiZTUxZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTEtMTItMTYgIEdyZWcgQmlsbG9jayAgPGdiaWxsb2NrQGdvb2ds ZS5jb20+CisKKyAgICAgICAgTWFrZSBXZWJJbnRlbnRTZXJ2aWNlSW5mbyBjb25zdHJ1Y3RvciBw dWJsaWMgZm9yIHRlc3RpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NDc2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcHVibGljL1dlYkludGVudFNlcnZpY2VJbmZvLmg6CisKIDIwMTEtMTItMTIg IFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgV2ViS2l0IGNvZGUg c2hvdWxkbid0IGJlIGNhbGxpbmcgYXBwbHlDb21tYW5kIGRpcmVjdGx5CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnRlbnRTZXJ2aWNlSW5mby5oIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW50ZW50U2VydmljZUluZm8uaAppbmRleCAz NDdkNDYxYjZlZmM3NjY1NjZlNGM3Y2Q2N2YxYTQyNGRmMWNhYjQ3Li4zNzg3MzVlYzkyMWExNWNj NmZmNjkzMGEyYWY2MzA1OWI1MTlmOWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJJbnRlbnRTZXJ2aWNlSW5mby5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkludGVudFNlcnZpY2VJbmZvLmgKQEAgLTQxLDYgKzQxLDcgQEAgbmFt ZXNwYWNlIFdlYktpdCB7CiAvLyBTZWUgc3BlYyBhdCBodHRwOi8vd3d3LmNocm9taXVtLm9yZy9k ZXZlbG9wZXJzL2Rlc2lnbi1kb2N1bWVudHMvd2ViaW50ZW50c2FwaQogY2xhc3MgV2ViSW50ZW50 U2VydmljZUluZm8gewogcHVibGljOgorICAgIFdlYkludGVudFNlcnZpY2VJbmZvKCk7CiAgICAg fldlYkludGVudFNlcnZpY2VJbmZvKCkgeyB9CiAKICAgICAvLyBUaGUgbG9jYXRpb24gb2YgdGhl IGhhbmRsZXIgcGFnZSByZWdpc3RlcmVkIGJ5IHRoZSBzZXJ2aWNlLgpAQCAtNjYsMTAgKzY3LDYg QEAgcHVibGljOgogICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIGRpc3Bvc2l0aW9uKCkgY29u c3Q7CiAgICAgV0VCS0lUX0VYUE9SVCB2b2lkIHNldERpc3Bvc2l0aW9uKGNvbnN0IFdlYlN0cmlu ZyYpOwogCi0jaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCi0gICAgV2ViSW50ZW50U2VydmljZUlu Zm8oKTsKLSNlbmRpZgotCiBwcml2YXRlOgogICAgIFdlYlN0cmluZyBtX2FjdGlvbjsKICAgICBX ZWJTdHJpbmcgbV90eXBlOwo= 119873 2011-12-19 09:41:01 -0800 2011-12-20 01:41:47 -0800 Patch bug-74764-20111219094059.patch text/plain 2049 gbillock U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNjU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhlNGEwNzA2MzE3MzM4YTc1M2VjNDZiZWUyODhhOWIwMWNlZmRjOTkuLmJhODZkNGRhZjhmMTU1 NmNkZDc5ZjY4YTViNjg1NGRiOWFiZTUxZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTEtMTItMTYgIEdyZWcgQmlsbG9jayAgPGdiaWxsb2NrQGdvb2ds ZS5jb20+CisKKyAgICAgICAgTWFrZSBXZWJJbnRlbnRTZXJ2aWNlSW5mbyBjb25zdHJ1Y3RvciBw dWJsaWMgZm9yIHRlc3RpbmcuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NDc2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcHVibGljL1dlYkludGVudFNlcnZpY2VJbmZvLmg6CisKIDIwMTEtMTItMTIg IFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgV2ViS2l0IGNvZGUg c2hvdWxkbid0IGJlIGNhbGxpbmcgYXBwbHlDb21tYW5kIGRpcmVjdGx5CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnRlbnRTZXJ2aWNlSW5mby5oIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW50ZW50U2VydmljZUluZm8uaAppbmRleCAz NDdkNDYxYjZlZmM3NjY1NjZlNGM3Y2Q2N2YxYTQyNGRmMWNhYjQ3Li41ODc5YmU4YWFjMWQzZGI5 N2NjZjFhZTZjMTc2OGIxYjgxZWE4NWUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJJbnRlbnRTZXJ2aWNlSW5mby5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkludGVudFNlcnZpY2VJbmZvLmgKQEAgLTQxLDYgKzQxLDcgQEAgbmFt ZXNwYWNlIFdlYktpdCB7CiAvLyBTZWUgc3BlYyBhdCBodHRwOi8vd3d3LmNocm9taXVtLm9yZy9k ZXZlbG9wZXJzL2Rlc2lnbi1kb2N1bWVudHMvd2ViaW50ZW50c2FwaQogY2xhc3MgV2ViSW50ZW50 U2VydmljZUluZm8gewogcHVibGljOgorICAgIFdlYkludGVudFNlcnZpY2VJbmZvKCkgeyB9CiAg ICAgfldlYkludGVudFNlcnZpY2VJbmZvKCkgeyB9CiAKICAgICAvLyBUaGUgbG9jYXRpb24gb2Yg dGhlIGhhbmRsZXIgcGFnZSByZWdpc3RlcmVkIGJ5IHRoZSBzZXJ2aWNlLgpAQCAtNjYsMTAgKzY3 LDYgQEAgcHVibGljOgogICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIGRpc3Bvc2l0aW9uKCkg Y29uc3Q7CiAgICAgV0VCS0lUX0VYUE9SVCB2b2lkIHNldERpc3Bvc2l0aW9uKGNvbnN0IFdlYlN0 cmluZyYpOwogCi0jaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCi0gICAgV2ViSW50ZW50U2Vydmlj ZUluZm8oKTsKLSNlbmRpZgotCiBwcml2YXRlOgogICAgIFdlYlN0cmluZyBtX2FjdGlvbjsKICAg ICBXZWJTdHJpbmcgbV90eXBlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViSW50ZW50U2VydmljZUluZm8uY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViSW50ZW50U2VydmljZUluZm8uY3BwCmluZGV4IGM2MzY1Y2VmM2FmOGExNmU0ZjBkMmFjNmFh ODNiYWFhNDk1NTEwODYuLmJkMTk4MzQ4OGNhMWE5NzU5YjM1N2I2ZTJlZDgzYTk0MDllYjI5YTMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkludGVudFNlcnZpY2VJ bmZvLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnRlbnRTZXJ2aWNl SW5mby5jcHAKQEAgLTMzLDggKzMzLDYgQEAKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLVdlYklu dGVudFNlcnZpY2VJbmZvOjpXZWJJbnRlbnRTZXJ2aWNlSW5mbygpIHsgfQotCiBXZWJVUkwgV2Vi SW50ZW50U2VydmljZUluZm86OnVybCgpIGNvbnN0CiB7CiAgICAgcmV0dXJuIG1faHJlZjsK