74761 2011-12-16 15:23:30 -0800 [chromium] Remove WebCString's dependency on WebCore 2011-12-16 16:01:29 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74583 1 jamesr jamesr abarth fishd webkit.review.bot oldest_to_newest 523093 0 jamesr 2011-12-16 15:23:30 -0800 [chromium] Remove WebCString's dependency on WebCore 523097 1 119687 jamesr 2011-12-16 15:24:22 -0800 Created attachment 119687 Patch 523100 2 119687 fishd 2011-12-16 15:26:40 -0800 Comment on attachment 119687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119687&action=review > Source/WebKit/chromium/src/WebCString.cpp:94 > + return String::fromUTF8(data(), length()); maybe slightly better as WebString::fromUTF8(...) ? 523103 3 webkit.review.bot 2011-12-16 15:27:41 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 523107 4 jamesr 2011-12-16 15:29:19 -0800 Ah cool, I can avoid the <wtf/text/WTFString.h> #include as well that way. 523112 5 119690 jamesr 2011-12-16 15:33:13 -0800 Created attachment 119690 Patch 523128 6 jamesr 2011-12-16 16:01:29 -0800 Committed r103124: <http://trac.webkit.org/changeset/103124> 119687 2011-12-16 15:24:22 -0800 2011-12-16 15:33:10 -0800 Patch bug-74761-20111216152421.patch text/plain 2739 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVmZmEyMzQ0ZDRjNzA5ZWQ2YTg0NmYzNjY2MjlmZmI3YzA4YzQxZmYuLmVjMDcwNDlkMDU1ZGEz M2Y5ZGJlZDMyZDY3NWJkZmMzZmJkMmI1MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMTItMTYgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFJlbW92ZSBXZWJDU3RyaW5nJ3MgZGVwZW5k ZW5jeSBvbiBXZWJDb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NDc2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92ZSBXZWJDU3RyaW5nOjpmcm9tVVRGMTYoKSwgd2hpY2ggYXJlIG5ldmVyIGNh bGxlZCwgYW5kIGltcGxlbWVudCBXZWJDU3RyaW5nOjp1dGYxNigpIHVzaW5nIFdURiBpbnN0ZWFk IG9mCisgICAgICAgIFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0RW5jb2RpbmcuCisKKyAgICAg ICAgKiBwdWJsaWMvcGxhdGZvcm0vV2ViQ1N0cmluZy5oOgorICAgICAgICAqIHNyYy9XZWJDU3Ry aW5nLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ1N0cmluZzo6dXRmMTYpOgorCiAyMDExLTEy LTE1ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2No cm9taXVtXSBTZXQgdGhlIENDTGF5ZXJUcmVlSG9zdCBwb2ludGVyIG9uIExheWVyQ2hyb21pdW0g aW5zdGFuY2VzIGVhZ2VybHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL3BsYXRmb3JtL1dlYkNTdHJpbmcuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L3BsYXRmb3JtL1dlYkNTdHJpbmcuaAppbmRleCAxNWRmNmNkOWY5ZDY4MTVhZTkwODU3YWJlYWUw NjA1MmQyYjJkZWZjLi44ZmEwZTgyM2M0ODRkNjEwYjk5ZjVhNjMxYjMwMzAyNjQ4YWMzNDNlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9wbGF0Zm9ybS9XZWJDU3Ry aW5nLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0vV2ViQ1N0 cmluZy5oCkBAIC04OSw5ICs4OSw2IEBAIHB1YmxpYzoKIAogICAgIFdFQktJVF9FWFBPUlQgV2Vi U3RyaW5nIHV0ZjE2KCkgY29uc3Q7CiAKLSAgICBXRUJLSVRfRVhQT1JUIHN0YXRpYyBXZWJDU3Ry aW5nIGZyb21VVEYxNihjb25zdCBXZWJVQ2hhciogZGF0YSwgc2l6ZV90IGxlbmd0aCk7Ci0gICAg V0VCS0lUX0VYUE9SVCBzdGF0aWMgV2ViQ1N0cmluZyBmcm9tVVRGMTYoY29uc3QgV2ViVUNoYXIq IGRhdGEpOwotCiAjaWYgV0VCS0lUX0lNUExFTUVOVEFUSU9OCiAgICAgV2ViQ1N0cmluZyhjb25z dCBXVEY6OkNTdHJpbmcmKTsKICAgICBXZWJDU3RyaW5nJiBvcGVyYXRvcj0oY29uc3QgV1RGOjpD U3RyaW5nJik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJDU3Ry aW5nLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkNTdHJpbmcuY3BwCmluZGV4 IDNjMzE5MWNhMDJkMmVlNmFjYzc2N2VmNjg2YjUwMDc3NzJjODZjY2MuLjVjNDI5N2E4YmZhNjVl YThmZmFhMWI3NGY1MjEwMWYxZmYxNmM5MTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkNTdHJpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkNTdHJpbmcuY3BwCkBAIC0zMSw5ICszMSw5IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAj aW5jbHVkZSAicGxhdGZvcm0vV2ViQ1N0cmluZy5oIgogCi0jaW5jbHVkZSAiVGV4dEVuY29kaW5n LmgiCiAjaW5jbHVkZSAicGxhdGZvcm0vV2ViU3RyaW5nLmgiCiAjaW5jbHVkZSA8d3RmL3RleHQv Q1N0cmluZy5oPgorI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2Ug V2ViS2l0IHsKIApAQCAtOTEsMjEgKzkxLDcgQEAgY29uc3QgY2hhciogV2ViQ1N0cmluZzo6ZGF0 YSgpIGNvbnN0CiAKIFdlYlN0cmluZyBXZWJDU3RyaW5nOjp1dGYxNigpIGNvbnN0CiB7Ci0gICAg cmV0dXJuIFdlYkNvcmU6OlVURjhFbmNvZGluZygpLmRlY29kZShkYXRhKCksIGxlbmd0aCgpKTsK LX0KLQotV2ViQ1N0cmluZyBXZWJDU3RyaW5nOjpmcm9tVVRGMTYoY29uc3QgV2ViVUNoYXIqIGRh dGEsIHNpemVfdCBsZW5ndGgpCi17Ci0gICAgcmV0dXJuIFdlYkNvcmU6OlVURjhFbmNvZGluZygp LmVuY29kZSgKLSAgICAgICAgZGF0YSwgbGVuZ3RoLCBXZWJDb3JlOjpRdWVzdGlvbk1hcmtzRm9y VW5lbmNvZGFibGVzKTsKLX0KLQotV2ViQ1N0cmluZyBXZWJDU3RyaW5nOjpmcm9tVVRGMTYoY29u c3QgV2ViVUNoYXIqIGRhdGEpCi17Ci0gICAgc2l6ZV90IGxlbiA9IDA7Ci0gICAgd2hpbGUgKGRh dGFbbGVuXSAhPSBXZWJVQ2hhcigwKSkKLSAgICAgICAgbGVuKys7Ci0gICAgcmV0dXJuIGZyb21V VEYxNihkYXRhLCBsZW4pOworICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KGRhdGEoKSwgbGVu Z3RoKCkpOwogfQogCiBXZWJDU3RyaW5nOjpXZWJDU3RyaW5nKGNvbnN0IFdURjo6Q1N0cmluZyYg cykK 119690 2011-12-16 15:33:13 -0800 2011-12-16 15:39:27 -0800 Patch bug-74761-20111216153312.patch text/plain 2631 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhkM2EyMzE2OTIwYjQzNDQwMWIwMTUyZWM0NGYzNzBmNmQ1ZDJlMTAuLmI0MzU3NzA5NDVjOWM2 MTdjNzJmNTc2YjAxYjE2YjI0YjI1MjdhMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMTItMTYgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIFJlbW92ZSBXZWJDU3RyaW5nJ3MgZGVwZW5k ZW5jeSBvbiBXZWJDb3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD03NDc2MQorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KKworICAg ICAgICBSZW1vdmUgV2ViQ1N0cmluZzo6ZnJvbVVURjE2KCksIHdoaWNoIGFyZSBuZXZlciBjYWxs ZWQsIGFuZCBpbXBsZW1lbnQgV2ViQ1N0cmluZzo6dXRmMTYoKSB1c2luZyBXVEYgaW5zdGVhZCBv ZgorICAgICAgICBXZWJDb3JlL3BsYXRmb3JtL3RleHQvVGV4dEVuY29kaW5nLgorCisgICAgICAg ICogcHVibGljL3BsYXRmb3JtL1dlYkNTdHJpbmcuaDoKKyAgICAgICAgKiBzcmMvV2ViQ1N0cmlu Zy5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkNTdHJpbmc6OnV0ZjE2KToKKwogMjAxMS0xMi0x NiAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIEdpdmUgUGxhdGZvcm1F dmVudHMgYSBiYXNlIGNsYXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9wbGF0Zm9ybS9XZWJDU3RyaW5nLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9wbGF0Zm9ybS9XZWJDU3RyaW5nLmgKaW5kZXggMTVkZjZjZDlmOWQ2ODE1YWU5MDg1N2FiZWFl MDYwNTJkMmIyZGVmYy4uOGZhMGU4MjNjNDg0ZDYxMGI5OWY1YTYzMWIzMDMwMjY0OGFjMzQzZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvcGxhdGZvcm0vV2ViQ1N0 cmluZy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL3BsYXRmb3JtL1dlYkNT dHJpbmcuaApAQCAtODksOSArODksNiBAQCBwdWJsaWM6CiAKICAgICBXRUJLSVRfRVhQT1JUIFdl YlN0cmluZyB1dGYxNigpIGNvbnN0OwogCi0gICAgV0VCS0lUX0VYUE9SVCBzdGF0aWMgV2ViQ1N0 cmluZyBmcm9tVVRGMTYoY29uc3QgV2ViVUNoYXIqIGRhdGEsIHNpemVfdCBsZW5ndGgpOwotICAg IFdFQktJVF9FWFBPUlQgc3RhdGljIFdlYkNTdHJpbmcgZnJvbVVURjE2KGNvbnN0IFdlYlVDaGFy KiBkYXRhKTsKLQogI2lmIFdFQktJVF9JTVBMRU1FTlRBVElPTgogICAgIFdlYkNTdHJpbmcoY29u c3QgV1RGOjpDU3RyaW5nJik7CiAgICAgV2ViQ1N0cmluZyYgb3BlcmF0b3I9KGNvbnN0IFdURjo6 Q1N0cmluZyYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViQ1N0 cmluZy5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJDU3RyaW5nLmNwcAppbmRl eCAzYzMxOTFjYTAyZDJlZTZhY2M3NjdlZjY4NmI1MDA3NzcyYzg2Y2NjLi42M2ViOWM2ODUzNTkz MWQyYWNlNThmNmU4MTM2ZDVlNzU5MmQ5ZjViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3NyYy9XZWJDU3RyaW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJDU3RyaW5nLmNwcApAQCAtMzEsNyArMzEsNiBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgog I2luY2x1ZGUgInBsYXRmb3JtL1dlYkNTdHJpbmcuaCIKIAotI2luY2x1ZGUgIlRleHRFbmNvZGlu Zy5oIgogI2luY2x1ZGUgInBsYXRmb3JtL1dlYlN0cmluZy5oIgogI2luY2x1ZGUgPHd0Zi90ZXh0 L0NTdHJpbmcuaD4KIApAQCAtOTEsMjEgKzkwLDcgQEAgY29uc3QgY2hhciogV2ViQ1N0cmluZzo6 ZGF0YSgpIGNvbnN0CiAKIFdlYlN0cmluZyBXZWJDU3RyaW5nOjp1dGYxNigpIGNvbnN0CiB7Ci0g ICAgcmV0dXJuIFdlYkNvcmU6OlVURjhFbmNvZGluZygpLmRlY29kZShkYXRhKCksIGxlbmd0aCgp KTsKLX0KLQotV2ViQ1N0cmluZyBXZWJDU3RyaW5nOjpmcm9tVVRGMTYoY29uc3QgV2ViVUNoYXIq IGRhdGEsIHNpemVfdCBsZW5ndGgpCi17Ci0gICAgcmV0dXJuIFdlYkNvcmU6OlVURjhFbmNvZGlu ZygpLmVuY29kZSgKLSAgICAgICAgZGF0YSwgbGVuZ3RoLCBXZWJDb3JlOjpRdWVzdGlvbk1hcmtz Rm9yVW5lbmNvZGFibGVzKTsKLX0KLQotV2ViQ1N0cmluZyBXZWJDU3RyaW5nOjpmcm9tVVRGMTYo Y29uc3QgV2ViVUNoYXIqIGRhdGEpCi17Ci0gICAgc2l6ZV90IGxlbiA9IDA7Ci0gICAgd2hpbGUg KGRhdGFbbGVuXSAhPSBXZWJVQ2hhcigwKSkKLSAgICAgICAgbGVuKys7Ci0gICAgcmV0dXJuIGZy b21VVEYxNihkYXRhLCBsZW4pOworICAgIHJldHVybiBXZWJTdHJpbmc6OmZyb21VVEY4KGRhdGEo KSwgbGVuZ3RoKCkpOwogfQogCiBXZWJDU3RyaW5nOjpXZWJDU3RyaW5nKGNvbnN0IFdURjo6Q1N0 cmluZyYgcykK