74758 2011-12-16 15:12:52 -0800 Canvas should respect backing store scale ratio when used as drawImage() source 2011-12-16 15:29:29 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton adele eoconnor mdelaney7 simon.fraser timothy oldest_to_newest 523082 0 thorton 2011-12-16 15:12:52 -0800 The source rectangle passed into drawImage() when using a Canvas source is interpreted in backing store space, when it should instead be interpreted in the Canvas pixel space. <rdar://problem/10350194> I have a patch. 523089 1 119685 thorton 2011-12-16 15:20:59 -0800 Created attachment 119685 patch 523092 2 119685 simon.fraser 2011-12-16 15:23:21 -0800 Comment on attachment 119685 patch View in context: https://bugs.webkit.org/attachment.cgi?id=119685&action=review > Source/WebCore/ChangeLog:14 > + * WebCore.xcodeproj/project.pbxproj: Huh? 523094 3 thorton 2011-12-16 15:23:49 -0800 (In reply to comment #2) > (From update of attachment 119685 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119685&action=review > > > Source/WebCore/ChangeLog:14 > > + * WebCore.xcodeproj/project.pbxproj: > > Huh? Odd. I'll fix it and commit. 523109 4 thorton 2011-12-16 15:29:29 -0800 Landed in r103118. 119685 2011-12-16 15:20:59 -0800 2011-12-16 15:23:21 -0800 patch canvas-backing-store.patch text/plain 5119 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2MmRhNGEzLi44YzNhOGQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTEtMTItMTYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgQ2FudmFzIHNob3VsZCByZXNwZWN0IGJhY2tpbmcgc3RvcmUgc2NhbGUgcmF0aW8g d2hlbiB1c2VkIGFzIGRyYXdJbWFnZSgpIHNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ3NTgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEw MzUwMTk0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEludGVycHJldCB0aGUgc291cmNlIHJlY3RhbmdsZSBwYXNzZWQgaW50byBkcmF3SW1hZ2UoKSB3 aGVuIHVzaW5nIGEgQ2FudmFzIHNvdXJjZSBpbiB0aGUgc291cmNlIENhbnZhcyBjb29yZGluYXRl IHNwYWNlLAorICAgICAgICBpbnN0ZWFkIG9mIGluIHRoZSBiYWNraW5nIHN0b3JlIGNvb3JkaW5h dGUgc3BhY2UsIHdpdGhvdXQgY2hhbmdpbmcgdGhlIGJlaGF2aW9yIG9mIGRyYXdJbWFnZShjYW52 YXMsIHgsIHkpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIFdlYkNvcmUu eGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajoKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDYW52YXNFbGVtZW50Ojpjb252ZXJ0RGV2 aWNlVG9Mb2dpY2FsKToKKyAgICAgICAgKiBodG1sL0hUTUxDYW52YXNFbGVtZW50Lmg6CisgICAg ICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6ZHJhd0ltYWdlKToKKwogMjAxMS0x Mi0xNSAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmVuYW1l IFdFQktJVF9sb3NlX2NvbnRleHQgdG8gV0VCS0lUX1dFQkdMX2xvc2VfY29udGV4dApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAppbmRleCBmYzJiYjkzLi5jYTk5M2Uz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcApAQCAtNDAyLDYg KzQwMiwxMyBAQCBGbG9hdFNpemUgSFRNTENhbnZhc0VsZW1lbnQ6OmNvbnZlcnRMb2dpY2FsVG9E ZXZpY2UoY29uc3QgRmxvYXRTaXplJiBsb2dpY2FsU2l6ZQogICAgIHJldHVybiBGbG9hdFNpemUo d2lkdGgsIGhlaWdodCk7CiB9CiAKK0Zsb2F0U2l6ZSBIVE1MQ2FudmFzRWxlbWVudDo6Y29udmVy dERldmljZVRvTG9naWNhbChjb25zdCBGbG9hdFNpemUmIGRldmljZVNpemUpIGNvbnN0Cit7Cisg ICAgZmxvYXQgd2lkdGggPSBjZWlsZihkZXZpY2VTaXplLndpZHRoKCkgLyBtX2RldmljZVNjYWxl RmFjdG9yKTsKKyAgICBmbG9hdCBoZWlnaHQgPSBjZWlsZihkZXZpY2VTaXplLmhlaWdodCgpIC8g bV9kZXZpY2VTY2FsZUZhY3Rvcik7CisgICAgcmV0dXJuIEZsb2F0U2l6ZSh3aWR0aCwgaGVpZ2h0 KTsKK30KKwogU2VjdXJpdHlPcmlnaW4qIEhUTUxDYW52YXNFbGVtZW50OjpzZWN1cml0eU9yaWdp bigpIGNvbnN0CiB7CiAgICAgcmV0dXJuIGRvY3VtZW50KCktPnNlY3VyaXR5T3JpZ2luKCk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmggYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmgKaW5kZXggZWM0YzgwZS4uMWJmZTUy YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVudC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuaApAQCAtMTE1LDYgKzEx NSw4IEBAIHB1YmxpYzoKICAgICBGbG9hdFJlY3QgY29udmVydExvZ2ljYWxUb0RldmljZShjb25z dCBGbG9hdFJlY3QmKSBjb25zdDsKICAgICBGbG9hdFNpemUgY29udmVydExvZ2ljYWxUb0Rldmlj ZShjb25zdCBGbG9hdFNpemUmKSBjb25zdDsKIAorICAgIEZsb2F0U2l6ZSBjb252ZXJ0RGV2aWNl VG9Mb2dpY2FsKGNvbnN0IEZsb2F0U2l6ZSYpIGNvbnN0OworCiAgICAgU2VjdXJpdHlPcmlnaW4q IHNlY3VyaXR5T3JpZ2luKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRPcmlnaW5UYWludGVkKCkgeyBt X29yaWdpbkNsZWFuID0gZmFsc2U7IH0KICAgICBib29sIG9yaWdpbkNsZWFuKCkgY29uc3QgeyBy ZXR1cm4gbV9vcmlnaW5DbGVhbjsgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9j YW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwv Y2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKaW5kZXggOGJkMjE1YS4uOTQ4YzIx OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5n Q29udGV4dDJELmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5k ZXJpbmdDb250ZXh0MkQuY3BwCkBAIC0xMzYxLDcgKzEzNjEsMTUgQEAgdm9pZCBDYW52YXNSZW5k ZXJpbmdDb250ZXh0MkQ6OmRyYXdJbWFnZShIVE1MQ2FudmFzRWxlbWVudCogY2FudmFzLCBmbG9h dCB4LCBmbG8KICAgICAgICAgZWMgPSBUWVBFX01JU01BVENIX0VSUjsKICAgICAgICAgcmV0dXJu OwogICAgIH0KLSAgICBkcmF3SW1hZ2UoY2FudmFzLCB4LCB5LCBjYW52YXMtPndpZHRoKCksIGNh bnZhcy0+aGVpZ2h0KCksIGVjKTsKKworICAgIC8vIEluIG9yZGVyIHRvIGVtdWxhdGUgZHJhd2lu ZyB0aGUgcmVzdWx0IG9mIHRvRGF0YVVSTCgpIGludG8gdGhlIGNhbnZhcywgd2UKKyAgICAvLyBu ZWVkIHRvIGRlZmxhdGUgdGhlIHNpemUgb2YgdGhlIHNvdXJjZSByZWN0YW5nbGUgYnkgdGhlIHNv dXJjZSBjYW52YXMncworICAgIC8vIGJhY2tpbmcgc3RvcmUgc2NhbGUgZmFjdG9yLgorICAgIC8v IFNlZSBodHRwczovL3d3dy53My5vcmcvQnVncy9QdWJsaWMvc2hvd19idWcuY2dpP2lkPTE1MDQx IGZvciBtb3RpdmF0aW9uLgorCisgICAgRmxvYXRTaXplIGxvZ2ljYWxTaXplID0gY2FudmFzLT5j b252ZXJ0RGV2aWNlVG9Mb2dpY2FsKGNhbnZhcy0+c2l6ZSgpKTsKKworICAgIGRyYXdJbWFnZShj YW52YXMsIDAsIDAsIGxvZ2ljYWxTaXplLndpZHRoKCksIGxvZ2ljYWxTaXplLmhlaWdodCgpLCB4 LCB5LCBjYW52YXMtPndpZHRoKCksIGNhbnZhcy0+aGVpZ2h0KCksIGVjKTsKIH0KIAogdm9pZCBD YW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmRyYXdJbWFnZShIVE1MQ2FudmFzRWxlbWVudCogY2Fu dmFzLApAQCAtMTQzMCwxOCArMTQzOCwyMSBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQy RDo6ZHJhd0ltYWdlKEhUTUxDYW52YXNFbGVtZW50KiBzb3VyY2VDYW52YXMsIGNvbnN0CiAgICAg c291cmNlQ2FudmFzLT5tYWtlUmVuZGVyaW5nUmVzdWx0c0F2YWlsYWJsZSgpOwogI2VuZGlmCiAK KyAgICAvLyBkcmF3SW1hZ2VCdWZmZXIncyBzcmNSZWN0IGlzIGluIGJ1ZmZlciBwaXhlbHMgKGJh Y2tpbmcgc3RvcmUgcGl4ZWxzLCBpbiBvdXIgY2FzZSksIGRzdFJlY3QgaXMgaW4gY2FudmFzIHBp eGVscy4KKyAgICBGbG9hdFJlY3QgYnVmZmVyU3JjUmVjdChzb3VyY2VDYW52YXMtPmNvbnZlcnRM b2dpY2FsVG9EZXZpY2Uoc3JjUmVjdCkpOworCiAgICAgaWYgKHJlY3RDb250YWluc0NhbnZhcyhk c3RSZWN0KSkgewotICAgICAgICBjLT5kcmF3SW1hZ2VCdWZmZXIoYnVmZmVyLCBDb2xvclNwYWNl RGV2aWNlUkdCLCBkc3RSZWN0LCBzcmNSZWN0LCBzdGF0ZSgpLm1fZ2xvYmFsQ29tcG9zaXRlKTsK KyAgICAgICAgYy0+ZHJhd0ltYWdlQnVmZmVyKGJ1ZmZlciwgQ29sb3JTcGFjZURldmljZVJHQiwg ZHN0UmVjdCwgYnVmZmVyU3JjUmVjdCwgc3RhdGUoKS5tX2dsb2JhbENvbXBvc2l0ZSk7CiAgICAg ICAgIGRpZERyYXdFbnRpcmVDYW52YXMoKTsKICAgICB9IGVsc2UgaWYgKGlzRnVsbENhbnZhc0Nv bXBvc2l0ZU1vZGUoc3RhdGUoKS5tX2dsb2JhbENvbXBvc2l0ZSkpIHsKLSAgICAgICAgZnVsbENh bnZhc0NvbXBvc2l0ZWREcmF3SW1hZ2UoYnVmZmVyLCBDb2xvclNwYWNlRGV2aWNlUkdCLCBkc3RS ZWN0LCBzcmNSZWN0LCBzdGF0ZSgpLm1fZ2xvYmFsQ29tcG9zaXRlKTsKKyAgICAgICAgZnVsbENh bnZhc0NvbXBvc2l0ZWREcmF3SW1hZ2UoYnVmZmVyLCBDb2xvclNwYWNlRGV2aWNlUkdCLCBidWZm ZXJTcmNSZWN0LCBzcmNSZWN0LCBzdGF0ZSgpLm1fZ2xvYmFsQ29tcG9zaXRlKTsKICAgICAgICAg ZGlkRHJhd0VudGlyZUNhbnZhcygpOwogICAgIH0gZWxzZSBpZiAoc3RhdGUoKS5tX2dsb2JhbENv bXBvc2l0ZSA9PSBDb21wb3NpdGVDb3B5KSB7CiAgICAgICAgIGNsZWFyQ2FudmFzKCk7Ci0gICAg ICAgIGMtPmRyYXdJbWFnZUJ1ZmZlcihidWZmZXIsIENvbG9yU3BhY2VEZXZpY2VSR0IsIGRzdFJl Y3QsIHNyY1JlY3QsIHN0YXRlKCkubV9nbG9iYWxDb21wb3NpdGUpOworICAgICAgICBjLT5kcmF3 SW1hZ2VCdWZmZXIoYnVmZmVyLCBDb2xvclNwYWNlRGV2aWNlUkdCLCBkc3RSZWN0LCBidWZmZXJT cmNSZWN0LCBzdGF0ZSgpLm1fZ2xvYmFsQ29tcG9zaXRlKTsKICAgICAgICAgZGlkRHJhd0VudGly ZUNhbnZhcygpOwogICAgIH0gZWxzZSB7Ci0gICAgICAgIGMtPmRyYXdJbWFnZUJ1ZmZlcihidWZm ZXIsIENvbG9yU3BhY2VEZXZpY2VSR0IsIGRzdFJlY3QsIHNyY1JlY3QsIHN0YXRlKCkubV9nbG9i YWxDb21wb3NpdGUpOworICAgICAgICBjLT5kcmF3SW1hZ2VCdWZmZXIoYnVmZmVyLCBDb2xvclNw YWNlRGV2aWNlUkdCLCBkc3RSZWN0LCBidWZmZXJTcmNSZWN0LCBzdGF0ZSgpLm1fZ2xvYmFsQ29t cG9zaXRlKTsKICAgICAgICAgZGlkRHJhdyhkc3RSZWN0KTsKICAgICB9CiB9Cg==