74722 2011-12-16 09:08:13 -0800 [chromium] Add setOpaque to WebMediaPlayerClient interface, don't set VideoLayer's opaque when grabbing current frame. 2011-12-16 11:24:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj backer fischman fishd jamesr piman webkit.review.bot oldest_to_newest 522766 0 danakj 2011-12-16 09:08:13 -0800 [chromium] Add setOpaque to WebMediaPlayerClient interface, don't set VideoLayer's opaque when grabbing current frame. 522767 1 119616 danakj 2011-12-16 09:10:53 -0800 Created attachment 119616 Patch @fischman is changing the video compositing process so that the current frame is grabbed from the impl thread instead of the main thread. This conflicts with our setting the LC::opaque flag when retrieving a video frame. Instead, this adds a setOpaque() function to the WebMediaPlayerClient interface, that forwards the flag through to the VideoLayerChromium. The flag will be set from chromium's WebMediaPlayerImpl when it initializes its pipeline. 522770 2 webkit.review.bot 2011-12-16 09:13:09 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 522865 3 119616 webkit.review.bot 2011-12-16 11:24:43 -0800 Comment on attachment 119616 Patch Clearing flags on attachment: 119616 Committed r103086: <http://trac.webkit.org/changeset/103086> 522866 4 webkit.review.bot 2011-12-16 11:24:47 -0800 All reviewed patches have been landed. Closing bug. 119616 2011-12-16 09:10:53 -0800 2011-12-16 11:24:43 -0800 Patch bug-74722-20111216121051.patch text/plain 5412 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDhlNGEwNzA2MzE3MzM4YTc1M2VjNDZiZWUyODhhOWIwMWNlZmRjOTkuLjM0ZDAzOWE1NTdmNzBj MzQ1MzliMThhNTQ2NDhmYWM1YTBlZDBmNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTEtMTItMTYgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBBZGQgc2V0T3BhcXVlIHRvIFdlYk1lZGlhUGxh eWVyQ2xpZW50IGludGVyZmFjZSwgZG9uJ3Qgc2V0IFZpZGVvTGF5ZXIncyBvcGFxdWUgd2hlbiBn cmFiYmluZyBjdXJyZW50IGZyYW1lLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzQ3MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHB1YmxpYy9XZWJNZWRpYVBsYXllckNsaWVudC5oOgorICAgICAgICAq IHNyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJN ZWRpYVBsYXllckNsaWVudEltcGw6OnJlYWR5U3RhdGVDaGFuZ2VkKToKKyAgICAgICAgKFdlYktp dDo6V2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsOjpzZXRPcGFxdWUpOgorICAgICAgICAoV2ViS2l0 OjpXZWJNZWRpYVBsYXllckNsaWVudEltcGw6OmdldEN1cnJlbnRGcmFtZSk6CisgICAgICAgIChX ZWJLaXQ6OldlYk1lZGlhUGxheWVyQ2xpZW50SW1wbDo6V2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBs KToKKyAgICAgICAgKiBzcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJbXBsLmg6CisKIDIwMTEtMTIt MTIgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgV2ViS2l0IGNv ZGUgc2hvdWxkbid0IGJlIGNhbGxpbmcgYXBwbHlDb21tYW5kIGRpcmVjdGx5CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllckNsaWVudC5oIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJDbGllbnQuaAppbmRl eCA0OGFlM2IwM2FiMmIzOTdiODA2ZjZkOGY0NGE0MjJhZmMyY2M4ZTI5Li4xYmM5Mzc4MjQzNDI4 ZDI5MWYzMTU3Njk1YWQ5NTU2ODQ4MDRjNzE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJNZWRpYVBsYXllckNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYk1lZGlhUGxheWVyQ2xpZW50LmgKQEAgLTQ5LDYgKzQ5LDcgQEAg cHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkdXJhdGlvbkNoYW5nZWQoKSA9IDA7CiAgICAgdmly dHVhbCB2b2lkIHJhdGVDaGFuZ2VkKCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBzaXplQ2hhbmdl ZCgpID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0T3BhcXVlKGJvb2wpID0gMDsKICAgICB2aXJ0 dWFsIHZvaWQgc2F3VW5zdXBwb3J0ZWRUcmFja3MoKSA9IDA7CiAgICAgdmlydHVhbCBmbG9hdCB2 b2x1bWUoKSBjb25zdCA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHBsYXliYWNrU3RhdGVDaGFuZ2Vk KCkgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQ bGF5ZXJDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYk1lZGlh UGxheWVyQ2xpZW50SW1wbC5jcHAKaW5kZXggOTkzNjFlZDk0MWFhNDYzMDZkNTY3YmQyM2Q4ZGNk ZWFkZjY1YTk5Ni4uYmNlNWY2MjM4MzlhZjI1ZDQwMDM0NzU1YjNjZGJmOGI0ZTAyNmJjMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQbGF5ZXJDbGllbnRJ bXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNs aWVudEltcGwuY3BwCkBAIC02MiwyOSArNjIsNiBAQCBzdGF0aWMgUGFzc093blB0cjxXZWJNZWRp YVBsYXllcj4gY3JlYXRlV2ViTWVkaWFQbGF5ZXIoV2ViTWVkaWFQbGF5ZXJDbGllbnQqIGNsaQog ICAgIHJldHVybiBhZG9wdFB0cih3ZWJGcmFtZS0+Y2xpZW50KCktPmNyZWF0ZU1lZGlhUGxheWVy KHdlYkZyYW1lLCBjbGllbnQpKTsKIH0KIAotc3RhdGljIGJvb2wgaXNWaWRlb0ZyYW1lRm9ybWF0 T3BhcXVlKFdlYlZpZGVvRnJhbWU6OkZvcm1hdCBmb3JtYXQpCi17Ci0gICAgc3dpdGNoIChmb3Jt YXQpIHsKLSAgICBjYXNlIFdlYlZpZGVvRnJhbWU6OkZvcm1hdEludmFsaWQ6Ci0gICAgY2FzZSBX ZWJWaWRlb0ZyYW1lOjpGb3JtYXRFbXB0eToKLSAgICBjYXNlIFdlYlZpZGVvRnJhbWU6OkZvcm1h dFJHQkE6Ci0gICAgY2FzZSBXZWJWaWRlb0ZyYW1lOjpGb3JtYXROYXRpdmVUZXh0dXJlOgotICAg ICAgICByZXR1cm4gZmFsc2U7Ci0gICAgY2FzZSBXZWJWaWRlb0ZyYW1lOjpGb3JtYXRSR0I1NTU6 Ci0gICAgY2FzZSBXZWJWaWRlb0ZyYW1lOjpGb3JtYXRSR0I1NjU6Ci0gICAgY2FzZSBXZWJWaWRl b0ZyYW1lOjpGb3JtYXRSR0IyNDoKLSAgICBjYXNlIFdlYlZpZGVvRnJhbWU6OkZvcm1hdFJHQjMy OgotICAgIGNhc2UgV2ViVmlkZW9GcmFtZTo6Rm9ybWF0WVYxMjoKLSAgICBjYXNlIFdlYlZpZGVv RnJhbWU6OkZvcm1hdFlWMTY6Ci0gICAgY2FzZSBXZWJWaWRlb0ZyYW1lOjpGb3JtYXROVjEyOgot ICAgIGNhc2UgV2ViVmlkZW9GcmFtZTo6Rm9ybWF0QVNDSUk6Ci0gICAgY2FzZSBXZWJWaWRlb0Zy YW1lOjpGb3JtYXRJNDIwOgotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICB9Ci0gICAgQVNTRVJU X05PVF9SRUFDSEVEKCk7Ci0gICAgcmV0dXJuIGZhbHNlOwotfQotCiBib29sIFdlYk1lZGlhUGxh eWVyQ2xpZW50SW1wbDo6bV9pc0VuYWJsZWQgPSBmYWxzZTsKIAogYm9vbCBXZWJNZWRpYVBsYXll ckNsaWVudEltcGw6OmlzRW5hYmxlZCgpCkBAIC0xNDIsOCArMTE5LDEwIEBAIHZvaWQgV2ViTWVk aWFQbGF5ZXJDbGllbnRJbXBsOjpyZWFkeVN0YXRlQ2hhbmdlZCgpCiAgICAgQVNTRVJUKG1fbWVk aWFQbGF5ZXIpOwogICAgIG1fbWVkaWFQbGF5ZXItPnJlYWR5U3RhdGVDaGFuZ2VkKCk7CiAjaWYg VVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotICAgIGlmIChoYXNWaWRlbygpICYmIHN1cHBv cnRzQWNjZWxlcmF0ZWRSZW5kZXJpbmcoKSAmJiAhbV92aWRlb0xheWVyKQorICAgIGlmIChoYXNW aWRlbygpICYmIHN1cHBvcnRzQWNjZWxlcmF0ZWRSZW5kZXJpbmcoKSAmJiAhbV92aWRlb0xheWVy KSB7CiAgICAgICAgIG1fdmlkZW9MYXllciA9IFZpZGVvTGF5ZXJDaHJvbWl1bTo6Y3JlYXRlKDAs IHRoaXMpOworICAgICAgICBtX3ZpZGVvTGF5ZXItPnNldE9wYXF1ZShtX29wYXF1ZSk7CisgICAg fQogI2VuZGlmCiB9CiAKQEAgLTE5Myw2ICsxNzIsMTUgQEAgdm9pZCBXZWJNZWRpYVBsYXllckNs aWVudEltcGw6OnNpemVDaGFuZ2VkKCkKICAgICBtX21lZGlhUGxheWVyLT5zaXplQ2hhbmdlZCgp OwogfQogCit2b2lkIFdlYk1lZGlhUGxheWVyQ2xpZW50SW1wbDo6c2V0T3BhcXVlKGJvb2wgb3Bh cXVlKQoreworI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKKyAgICBtX29wYXF1ZSA9 IG9wYXF1ZTsKKyAgICBpZiAobV92aWRlb0xheWVyKQorICAgICAgICBtX3ZpZGVvTGF5ZXItPnNl dE9wYXF1ZShtX29wYXF1ZSk7CisjZW5kaWYKK30KKwogdm9pZCBXZWJNZWRpYVBsYXllckNsaWVu dEltcGw6OnNhd1Vuc3VwcG9ydGVkVHJhY2tzKCkKIHsKICAgICBBU1NFUlQobV9tZWRpYVBsYXll cik7CkBAIC02MDAsOCArNTg4LDYgQEAgVmlkZW9GcmFtZUNocm9taXVtKiBXZWJNZWRpYVBsYXll ckNsaWVudEltcGw6OmdldEN1cnJlbnRGcmFtZSgpCiAgICAgICAgIFdlYlZpZGVvRnJhbWUqIHdl YmtpdFZpZGVvRnJhbWUgPSBtX3dlYk1lZGlhUGxheWVyLT5nZXRDdXJyZW50RnJhbWUoKTsKICAg ICAgICAgaWYgKHdlYmtpdFZpZGVvRnJhbWUpCiAgICAgICAgICAgICBtX2N1cnJlbnRWaWRlb0Zy YW1lID0gYWRvcHRQdHIobmV3IFZpZGVvRnJhbWVDaHJvbWl1bUltcGwod2Via2l0VmlkZW9GcmFt ZSkpOwotICAgICAgICBpZiAobV92aWRlb0xheWVyKQotICAgICAgICAgICAgbV92aWRlb0xheWVy LT5zZXRPcGFxdWUod2Via2l0VmlkZW9GcmFtZSAmJiBpc1ZpZGVvRnJhbWVGb3JtYXRPcGFxdWUo d2Via2l0VmlkZW9GcmFtZS0+Zm9ybWF0KCkpKTsKICAgICB9CiAgICAgcmV0dXJuIG1fY3VycmVu dFZpZGVvRnJhbWUuZ2V0KCk7CiB9CkBAIC02ODAsNiArNjY2LDcgQEAgV2ViTWVkaWFQbGF5ZXJD bGllbnRJbXBsOjpXZWJNZWRpYVBsYXllckNsaWVudEltcGwoKQogI2lmIFVTRShBQ0NFTEVSQVRF RF9DT01QT1NJVElORykKICAgICAsIG1fdmlkZW9MYXllcigwKQogICAgICwgbV9zdXBwb3J0c0Fj Y2VsZXJhdGVkQ29tcG9zaXRpbmcoZmFsc2UpCisgICAgLCBtX29wYXF1ZShmYWxzZSkKICNlbmRp ZgogewogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFQ bGF5ZXJDbGllbnRJbXBsLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBs YXllckNsaWVudEltcGwuaAppbmRleCBmY2MxZGE1YzQzNzMyZjViOGQzNmQ4NTJmMzAzZjIwMTBl YjMwNGI1Li4xMDg4ODMwY2IwOTNjNTc0NDgwNDYwMjM1OGZmYjNhYjM1ZWFjZDUzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudEltcGwu aAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVBsYXllckNsaWVudElt cGwuaApAQCAtNzksNiArNzksNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGR1cmF0aW9u Q2hhbmdlZCgpOwogICAgIHZpcnR1YWwgdm9pZCByYXRlQ2hhbmdlZCgpOwogICAgIHZpcnR1YWwg dm9pZCBzaXplQ2hhbmdlZCgpOworICAgIHZpcnR1YWwgdm9pZCBzZXRPcGFxdWUoYm9vbCk7CiAg ICAgdmlydHVhbCB2b2lkIHNhd1Vuc3VwcG9ydGVkVHJhY2tzKCk7CiAgICAgdmlydHVhbCBmbG9h dCB2b2x1bWUoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgcGxheWJhY2tTdGF0ZUNoYW5nZWQo KTsKQEAgLTE2OSw2ICsxNzAsNyBAQCBwcml2YXRlOgogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01Q T1NJVElORykKICAgICBSZWZQdHI8V2ViQ29yZTo6VmlkZW9MYXllckNocm9taXVtPiBtX3ZpZGVv TGF5ZXI7CiAgICAgYm9vbCBtX3N1cHBvcnRzQWNjZWxlcmF0ZWRDb21wb3NpdGluZzsKKyAgICBi b29sIG1fb3BhcXVlOwogI2VuZGlmCiAgICAgc3RhdGljIGJvb2wgbV9pc0VuYWJsZWQ7CiAK