74714 2011-12-16 05:59:01 -0800 [chromium] MediaStream API: Fixing memory leak in WebMediaStreamSource 2011-12-19 13:02:20 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 tommyw tommyw grunell webkit.review.bot oldest_to_newest 522719 0 tommyw 2011-12-16 05:59:01 -0800 Missed that PassRefPtr does a ref if constructed with a raw pointer. 522726 1 119608 tommyw 2011-12-16 06:03:02 -0800 Created attachment 119608 Patch 524045 2 119608 eric 2011-12-19 11:16:20 -0800 Comment on attachment 119608 Patch Yes, assuming m_private is a RefPtr, the previous code was nonsense. :) I'm curious who reviewed it! :p 524132 3 119608 webkit.review.bot 2011-12-19 13:02:16 -0800 Comment on attachment 119608 Patch Clearing flags on attachment: 119608 Committed r103258: <http://trac.webkit.org/changeset/103258> 524133 4 webkit.review.bot 2011-12-19 13:02:20 -0800 All reviewed patches have been landed. Closing bug. 119608 2011-12-16 06:03:02 -0800 2011-12-19 13:02:16 -0800 Patch bug-74714-20111216150300.patch text/plain 2496 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMDQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGMxNWI3ODRiOGU0YTNkNDYwN2I0MGU0MjAwMjI1ZTc3YjkyZjIyMjYuLmUyNDM5YTZlODRkNmI5 NTY4ODJiMTJhY2MwZjQ4ZmUxY2Y5N2M4ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTEtMTItMTYgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9tbXl3QGdv b2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBNZWRpYVN0cmVhbSBBUEk6IEZpeGluZyBt ZW1vcnkgbGVhayBpbiBXZWJNZWRpYVN0cmVhbVNvdXJjZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ3MTQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNaXNzZWQgdGhhdCBQYXNzUmVmUHRyIGRvZXMgYSBy ZWYgaWYgY29uc3RydWN0ZWQgd2l0aCBhIHJhdyBwb2ludGVyLgorICAgICAgICBBbHNvIHJlbW92 ZWQgYW4gZXh0cmEgc3BhY2UgaW4gV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yLmNwcC4KKworICAg ICAgICAqIHNyYy9XZWJNZWRpYVN0cmVhbURlc2NyaXB0b3IuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJNZWRpYVN0cmVhbURlc2NyaXB0b3I6OnNvdXJjZXMpOgorICAgICAgICAqIHNyYy9XZWJN ZWRpYVN0cmVhbVNvdXJjZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYk1lZGlhU3RyZWFtU291 cmNlOjpvcGVyYXRvcj0pOgorCiAyMDExLTEyLTE1ICBZb25nanVuIFpoYW5nICA8eW9uZ2p1bl96 aGFuZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUE9ESW50ZXJ2YWxUcmVlIHRha2VzIDEuN01CIG1l bW9yeSBvbiB3d3cubnl0aW1lcy5jb20uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJNZWRpYVN0cmVhbURlc2NyaXB0b3IuY3BwIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViTWVkaWFTdHJlYW1EZXNjcmlwdG9yLmNwcAppbmRleCBmNmFjNmNkZmU1OGQ5 N2U5ZWVlMmEyMThkMTVhZjM5NTI4YWFjZTJjLi4wY2Y1M2MwZWJmYTBiYTAzMjFmY2RhNjU5NzU4 ZjNjZWVjODQ4ZWVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJN ZWRpYVN0cmVhbURlc2NyaXB0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYk1lZGlhU3RyZWFtRGVzY3JpcHRvci5jcHAKQEAgLTY1LDcgKzY1LDcgQEAgdm9pZCBXZWJN ZWRpYVN0cmVhbURlc2NyaXB0b3I6OnNvdXJjZXMoV2ViVmVjdG9yPFdlYk1lZGlhU3RyZWFtU291 cmNlPiYgd2ViU291cmMKICAgICBzaXplX3QgbnVtYmVyT2ZTb3VyY2VzID0gbV9wcml2YXRlLT5u dW1iZXJPZkNvbXBvbmVudHMoKTsKICAgICBXZWJWZWN0b3I8V2ViTWVkaWFTdHJlYW1Tb3VyY2U+ IHJlc3VsdChudW1iZXJPZlNvdXJjZXMpOwogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbnVt YmVyT2ZTb3VyY2VzOyArK2kpCi0gICAgICAgIHJlc3VsdFtpXSA9ICBtX3ByaXZhdGUtPmNvbXBv bmVudChpKS0+c291cmNlKCk7CisgICAgICAgIHJlc3VsdFtpXSA9IG1fcHJpdmF0ZS0+Y29tcG9u ZW50KGkpLT5zb3VyY2UoKTsKICAgICB3ZWJTb3VyY2VzLnN3YXAocmVzdWx0KTsKIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFTdHJlYW1Tb3VyY2Uu Y3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViTWVkaWFTdHJlYW1Tb3VyY2UuY3Bw CmluZGV4IGJlMmI1MjQ4MTkzODY0NTJlNDVlMzE2YTk5MjQxZDNhYmY2NTJmM2IuLmZlODI2ZjE4 YmUzZTQ1MWJhN2ZiOTU2YWEwMDI5ZjgyMjdjYzU5Y2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYk1lZGlhU3RyZWFtU291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJNZWRpYVN0cmVhbVNvdXJjZS5jcHAKQEAgLTQ5LDExICs0OSw3 IEBAIFdlYk1lZGlhU3RyZWFtU291cmNlOjpXZWJNZWRpYVN0cmVhbVNvdXJjZShjb25zdCBQYXNz UmVmUHRyPE1lZGlhU3RyZWFtU291cmNlPiYKIAogV2ViTWVkaWFTdHJlYW1Tb3VyY2UmIFdlYk1l ZGlhU3RyZWFtU291cmNlOjpvcGVyYXRvcj0oV2ViQ29yZTo6TWVkaWFTdHJlYW1Tb3VyY2UqIG1l ZGlhU3RyZWFtU291cmNlKQogewotICAgIG1fcHJpdmF0ZS5yZXNldCgpOwotICAgIGlmIChtZWRp YVN0cmVhbVNvdXJjZSkgewotICAgICAgICBtZWRpYVN0cmVhbVNvdXJjZS0+cmVmKCk7Ci0gICAg ICAgIG1fcHJpdmF0ZSA9IG1lZGlhU3RyZWFtU291cmNlOwotICAgIH0KKyAgICBtX3ByaXZhdGUg PSBtZWRpYVN0cmVhbVNvdXJjZTsKICAgICByZXR1cm4gKnRoaXM7CiB9CiAK