74713 2011-12-16 05:53:33 -0800 [GTK] Use bit field for bool members of WebKitWindowPropertiesPrivate 2011-12-16 06:46:40 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand webkit.review.bot oldest_to_newest 522711 0 cgarcia 2011-12-16 05:53:33 -0800 Most of the members are bools, so we can reduce the memory footprint a bit. 522715 1 119607 cgarcia 2011-12-16 05:57:15 -0800 Created attachment 119607 Patch 522725 2 webkit.review.bot 2011-12-16 06:02:53 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 522735 3 119607 gustavo 2011-12-16 06:19:20 -0800 Comment on attachment 119607 Patch It's funny that you need to do this for the boolean type, but from what I read this seems to be indeed correct, so r=me 522740 4 cgarcia 2011-12-16 06:46:40 -0800 Committed r103068: <http://trac.webkit.org/changeset/103068> 119607 2011-12-16 05:57:15 -0800 2011-12-16 06:19:20 -0800 Patch wk2-bitfield-window-properties.diff text/plain 1601 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0YTJjM2JjLi44MzllNDE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTItMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFVzZSBiaXQgZmllbGQgZm9yIGJvb2wgbWVtYmVycyBvZiBXZWJL aXRXaW5kb3dQcm9wZXJ0aWVzUHJpdmF0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzQ3MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNb3N0IG9mIHRoZSBtZW1iZXJzIGFyZSBib29scywgc28gaXQgcmVk dWNlcyB0aGUgbWVtb3J5IGZvb3RwcmludC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdFdpbmRvd1Byb3BlcnRpZXMuY3BwOgorCiAyMDExLTEyLTE2ICBNaWNoYWVsIEJydW5p bmcgIDxtaWNoYWVsLmJydW5pbmdAbm9raWEuY29tPgogCiAgICAgICAgIFtxdF1bd2syXSBWaWV3 cG9ydCBpbmZvIHBhbmVsIHNob3dzIHdyb25nIGN1cnJlbnQgc2NhbGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdpbmRvd1Byb3BlcnRpZXMuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2luZG93UHJvcGVydGll cy5jcHAKaW5kZXggMzg4MjVlNS4uYzk5ZjZkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2luZG93UHJvcGVydGllcy5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2luZG93UHJvcGVydGllcy5jcHAKQEAg LTExMiwxNCArMTEyLDE0IEBAIEdfREVGSU5FX1RZUEUoV2ViS2l0V2luZG93UHJvcGVydGllcywg d2Via2l0X3dpbmRvd19wcm9wZXJ0aWVzLCBHX1RZUEVfT0JKRUNUKQogc3RydWN0IF9XZWJLaXRX aW5kb3dQcm9wZXJ0aWVzUHJpdmF0ZSB7CiAgICAgR2RrUmVjdGFuZ2xlIGdlb21ldHJ5OwogCi0g ICAgYm9vbCB0b29sYmFyVmlzaWJsZTsKLSAgICBib29sIHN0YXR1c2JhclZpc2libGU7Ci0gICAg Ym9vbCBzY3JvbGxiYXJzVmlzaWJsZTsKLSAgICBib29sIG1lbnViYXJWaXNpYmxlOwotICAgIGJv b2wgbG9jYXRpb25iYXJWaXNpYmxlOwotCi0gICAgYm9vbCByZXNpemFibGU7Ci0gICAgYm9vbCBm dWxsc2NyZWVuOworICAgIGJvb2wgdG9vbGJhclZpc2libGUgOiAxOworICAgIGJvb2wgc3RhdHVz YmFyVmlzaWJsZSA6IDE7CisgICAgYm9vbCBzY3JvbGxiYXJzVmlzaWJsZSA6IDE7CisgICAgYm9v bCBtZW51YmFyVmlzaWJsZSA6IDE7CisgICAgYm9vbCBsb2NhdGlvbmJhclZpc2libGUgOiAxOwor CisgICAgYm9vbCByZXNpemFibGUgOiAxOworICAgIGJvb2wgZnVsbHNjcmVlbiA6IDE7CiB9Owog CiBzdGF0aWMgdm9pZCB3ZWJraXRXaW5kb3dQcm9wZXJ0aWVzRmluYWxpemUoR09iamVjdCogb2Jq ZWN0KQo=