74709 2011-12-16 05:29:29 -0800 [GTK] Window frame should be 0x0 when the toplevel window is not visible 2011-12-16 06:42:02 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 74711 1 cgarcia webkit-unassigned gustavo pnormand webkit.review.bot oldest_to_newest 522700 0 cgarcia 2011-12-16 05:29:29 -0800 When a new view is requested FrameLoader::createWindow() is called with the window features already set. Then, the window size it's adjusted for the difference between the window size and the page size. The page size is 0x0 because the new view is not yet realized, and the toplevel window containing the view is not shown yet, so the windowFrame we are reporting at this point is the default window size. So we end up adding the default window size to the size already set in the window features object. 522701 1 119604 cgarcia 2011-12-16 05:32:32 -0800 Created attachment 119604 Patch 522702 2 webkit.review.bot 2011-12-16 05:37:38 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 522713 3 119604 gustavo 2011-12-16 05:57:04 -0800 Comment on attachment 119604 Patch How does this impact the WindowProperties test, if at all? Would be good to update it. I had to disable asserting x and y because WebCore was handing us a wrong value for the y coordinate, this sounds like it could have a positive impact for that problem? =) 522721 4 cgarcia 2011-12-16 05:59:55 -0800 It doesn't affect the tests because in the tests the view is never realized beause we don't use a window, that's why I haven't noticed it until I impemented it in MiniBrowser, see bug #74711 522723 5 cgarcia 2011-12-16 06:02:14 -0800 btw, the unit test passes for me with and without the patch, so I don't know why Webcore reports a different x, y values, because coordintates are not adjusted in FrameLoader::createWindow() only the window size. 522729 6 gustavo 2011-12-16 06:09:12 -0800 (In reply to comment #5) > btw, the unit test passes for me with and without the patch, so I don't know why Webcore reports a different x, y values, because coordintates are not adjusted in FrameLoader::createWindow() only the window size. Even if you add the asserts for x, y? Yeah, I digged quite a bit to try to find where the wrong value of y was coming from, but stopped when I reached WebCore, will have to dig a bit more from there. 522731 7 119604 gustavo 2011-12-16 06:10:27 -0800 Comment on attachment 119604 Patch OK 522739 8 cgarcia 2011-12-16 06:42:02 -0800 Committed r103067: <http://trac.webkit.org/changeset/103067> 119604 2011-12-16 05:32:32 -0800 2011-12-16 06:10:27 -0800 Patch wk2-window-frame-invisible.diff text/plain 1464 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0YTJjM2JjLi40M2Q4MTBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTItMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdpbmRvdyBmcmFtZSBzaG91bGQgYmUgMHgwIHdoZW4gdGhlIHRv cGxldmVsIHdpbmRvdyBpcyBub3QgdmlzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ3MDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFVJQ2xpZW50LmNw cDoKKyAgICAgICAgKGdldFdpbmRvd0ZyYW1lKTogQ2hlY2sgYWxzbyB3aGV0aGVyIHRoZSB0b3Bs ZXZlbCBpcyB2aXNpYmxlCisgICAgICAgIGJlZm9yZSBnZXR0aW5nIGl0cyBzaXplIGFuZCBwb3Np dGlvbi4KKwogMjAxMS0xMi0xNiAgTWljaGFlbCBCcnVuaW5nICA8bWljaGFlbC5icnVuaW5nQG5v a2lhLmNvbT4KIAogICAgICAgICBbcXRdW3drMl0gVmlld3BvcnQgaW5mbyBwYW5lbCBzaG93cyB3 cm9uZyBjdXJyZW50IHNjYWxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRVSUNsaWVudC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRVSUNsaWVudC5jcHAKaW5kZXggYzFjZjkxYS4uZmNmZGRkYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0VUlDbGllbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFVJQ2xpZW50LmNwcApA QCAtMTEyLDcgKzExMiw3IEBAIHN0YXRpYyBXS1JlY3QgZ2V0V2luZG93RnJhbWUoV0tQYWdlUmVm IHBhZ2UsIGNvbnN0IHZvaWQqKQogewogICAgIEdka1JlY3RhbmdsZSBnZW9tZXRyeSA9IHsgMCwg MCwgMCwgMCB9OwogICAgIEd0a1dpZGdldCogd2luZG93ID0gZ3RrX3dpZGdldF9nZXRfdG9wbGV2 ZWwodG9JbXBsKHBhZ2UpLT52aWV3V2lkZ2V0KCkpOwotICAgIGlmIChndGtfd2lkZ2V0X2lzX3Rv cGxldmVsKHdpbmRvdykpIHsKKyAgICBpZiAoZ3RrX3dpZGdldF9pc190b3BsZXZlbCh3aW5kb3cp ICYmIGd0a193aWRnZXRfZ2V0X3Zpc2libGUod2luZG93KSkgewogICAgICAgICBndGtfd2luZG93 X2dldF9wb3NpdGlvbihHVEtfV0lORE9XKHdpbmRvdyksICZnZW9tZXRyeS54LCAmZ2VvbWV0cnku eSk7CiAgICAgICAgIGd0a193aW5kb3dfZ2V0X3NpemUoR1RLX1dJTkRPVyh3aW5kb3cpLCAmZ2Vv bWV0cnkud2lkdGgsICZnZW9tZXRyeS5oZWlnaHQpOwogICAgIH0K