74687 2011-12-15 22:47:55 -0800 [Qt] Incremental build problem revealed by r102981 2012-01-24 05:28:28 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 76528 1 ossy kadam abarth eric ossy rniwa vestbo webkit.review.bot oldest_to_newest 522552 0 ossy 2011-12-15 22:47:55 -0800 This change http://trac.webkit.org/changeset/102981/trunk/Source/WebCore/mathml/mathattrs.in caused a build fail on the Qt bot, because the necessarry generated file wasn't regenerated. It must be a bug in the Qt build system. I'll check it. Thanks for you kicked the bot with touching a file. ;) 540510 1 123550 kadam 2012-01-23 06:31:41 -0800 Created attachment 123550 proposed patch It is necessary to set mathattrs.in dependency for generating MathMLNames.cpp file. I added depend this file /Source/WebCore/DerivedSources.pri. 540520 2 123550 vestbo 2012-01-23 06:52:18 -0800 Comment on attachment 123550 proposed patch While the fix is correct it unfortunately doesn't solve the general problem, for exxample is $$PWD/mathml/mathtags.in still left out of depends. And there's a bunch of other generators that have the same problem. The better approach I think would be to add code in default_post.prf that walks every argument of commands and checks if it's a file that exists, and if so, adds it to depends. That should ideally fix it for all of these cases. Feel free to have a stab at it, or assign the bug to me and I'll have a look. Thanks! 541235 3 ossy 2012-01-24 04:05:51 -0800 (In reply to comment #2) > (From update of attachment 123550 [details]) > While the fix is correct it unfortunately doesn't solve the general problem, for exxample is $$PWD/mathml/mathtags.in still left out of depends. And there's a bunch of other generators that have the same problem. The correct is absolutely correct for this bug. And $$PWD/mathml/mathtags.in isn't missing from the dependency list, because MATHML_NAMES is $$PWD/mathml/mathtags.in which is the input of this generator. > The better approach I think would be to add code in default_post.prf that walks every argument of commands and checks if it's a file that exists, and if so, adds it to depends. That should ideally fix it for all of these cases. > Feel free to have a stab at it, or assign the bug to me and I'll have a look. Thanks! The idea is good, but I'm not sure if it works always. Let's try it. But I don't think if we shouldn't land this trivial, necssarry and correct fix because maybe we can do a general fix sometimes in the future. I filed a new bug report for this future development: https://bugs.webkit.org/show_bug.cgi?id=76902 541236 4 ossy 2012-01-24 04:07:12 -0800 (In reply to comment #3) > The correct is absolutely correct for this bug. And $$PWD/mathml/mathtags.in isn't missing from the dependency list, because MATHML_NAMES is $$PWD/mathml/mathtags.in which is the input of this generator. I should have reread my comment. :) s/The correct/The fix/g 541237 5 123550 ossy 2012-01-24 04:08:57 -0800 Comment on attachment 123550 proposed patch r=me to decrease the number of possible incremental build bugs in the future. 541265 6 123550 ossy 2012-01-24 05:28:19 -0800 Comment on attachment 123550 proposed patch Clearing flags on attachment: 123550 Committed r105731: <http://trac.webkit.org/changeset/105731> 541266 7 ossy 2012-01-24 05:28:28 -0800 All reviewed patches have been landed. Closing bug. 123550 2012-01-23 06:31:41 -0800 2012-01-24 05:28:19 -0800 proposed patch incremental.patch text/plain 1443 kadam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1M2RlMmYxLi43OTBlZGQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDEtMjMgIMOBZMOhbSBLYWxsYWkgIDxLYWxsYWkuQWRhbUBzdHVkLnUtc3plZ2Vk Lmh1PgorCisgICAgICAgIFtRdF0gSW5jcmVtZW50YWwgYnVpbGQgcHJvYmxlbS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0Njg3CisKKyAgICAgICAg SXQgaXMgbmVjZXNzYXJ5IHRvIHNldCBtYXRoYXR0cnMuaW4gZGVwZW5kZW5jeSBmb3IgZ2VuZXJh dGluZyBNYXRoTUxOYW1lcy5jcHAgZmlsZS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIERlcml2ZWRTb3VyY2VzLnByaToKKyAgICAgICAgSSBhZGRl ZCBtaXNzaW5nIGRlcGVuZC4KKwogMjAxMi0wMS0xOSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJr aXQub3JnPgogCiAgICAgICAgIGNyZWF0ZUF0dHJpYnV0ZU5TIHNob3VsZCB1bmRlcnN0YW5kIHRo YXQgInhtbG5zIiBpcyBhbGxvd2VkIGluIHRoZSBodHRwOi8vd3d3LnczLm9yZy8yMDAwL3htbG5z LwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMucHJpIGIvU291cmNl L1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMucHJpCmluZGV4IDI5N2I2YmYuLmU4ZmUzNTQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLnByaQorKysgYi9Tb3VyY2UvV2Vi Q29yZS9EZXJpdmVkU291cmNlcy5wcmkKQEAgLTYxMCw2ICs2MTAsNyBAQCBlbHNlOiB3cmFwcGVy RmFjdG9yeUFyZyA9IC0td3JhcHBlckZhY3RvcnkKIAogbWF0aG1sbmFtZXMub3V0cHV0ID0gTWF0 aE1MTmFtZXMuY3BwCiBtYXRobWxuYW1lcy5pbnB1dCA9IE1BVEhNTF9OQU1FUworbWF0aG1sbmFt ZXMuZGVwZW5kcyA9ICQkUFdEL21hdGhtbC9tYXRoYXR0cnMuaW4KIG1hdGhtbG5hbWVzLnNjcmlw dCA9ICQkUFdEL2RvbS9tYWtlX25hbWVzLnBsCiBtYXRobWxuYW1lcy5jb21tYW5kcyA9IHBlcmwg LUkkJFBXRC9iaW5kaW5ncy9zY3JpcHRzICQkbWF0aG1sbmFtZXMuc2NyaXB0IC0tdGFncyAkJFBX RC9tYXRobWwvbWF0aHRhZ3MuaW4gLS1hdHRycyAkJFBXRC9tYXRobWwvbWF0aGF0dHJzLmluIC0t ZXh0cmFEZWZpbmVzIFwiJCR7REVGSU5FU31cIiAtLXByZXByb2Nlc3NvciBcIiQke1FNQUtFX01P Q30gLUVcIiAtLWZhY3RvcnkgJCR3cmFwcGVyRmFjdG9yeUFyZyAtLW91dHB1dERpciAke1FNQUtF X0ZVTkNfRklMRV9PVVRfUEFUSH0KIG1hdGhtbG5hbWVzLmV4dHJhX3NvdXJjZXMgPSBNYXRoTUxF bGVtZW50RmFjdG9yeS5jcHAK