74680 2011-12-15 20:10:31 -0800 [Plugins GTK/QT] Signed to Unsigned Conversion Error 2022-06-22 22:23:10 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All Linux RESOLVED WONTFIX P2 Normal --- 0 justine.bang webkit-unassigned ahmad.saleem792 ap gyuyoung.kim rniwa oldest_to_newest 522470 0 119548 justine.bang 2011-12-15 20:10:31 -0800 Created attachment 119548 the patch file created by svn-create-patch If signed integer variables having negative number is allocated to unsigned short variables, unsigned short variables will have an unexpected value. So, if signed integer variable has negative number,fill unsigned short variables to zero before type casting. If not, clipRect(unsigned short) have an unexpected value cause of the first bit for negative. 522481 1 119550 justine.bang 2011-12-15 20:24:43 -0800 Created attachment 119550 recreate the patch with changelog 522858 2 119550 mrobinson 2011-12-16 11:15:08 -0800 Comment on attachment 119550 recreate the patch with changelog In what situations can these values be negative? 523684 3 justine.bang 2011-12-18 20:45:53 -0800 it can be negative by something which can move viewport like scroller. 525459 4 119550 eric 2011-12-21 12:23:55 -0800 Comment on attachment 119550 recreate the patch with changelog View in context: https://bugs.webkit.org/attachment.cgi?id=119550&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This will cause the commit-queue to fail. You shoul deithe rlist the tests affected by this change, or explain why this change is impossible/impractical to test. We have a TestPlugin in DRT which can be helpful if you need to make a test which involves NPAPI code. Otherwise most tests use javascript to poke and prod at things, or dump the painted pixels and compare them against a reference. > Source/WebCore/plugins/gtk/PluginViewGtk.cpp:527 > + // Clipping rectangle of the plug-in; the origin is the top left corner of the drawable or window. > + // Signed to Unsigned Conversion Error; if signed integer variable has negative number, > + // fill unsigned short variables to zero before type casting. > + // If not, clipRect have an unexpected value cause of the first bit for negative. > + m_npWindow.clipRect.left = max(0, m_npWindow.x + m_clipRect.x()); > + m_npWindow.clipRect.top = max(0, m_npWindow.y + m_clipRect.y()); > + m_npWindow.clipRect.right = max(0, m_npWindow.x + m_clipRect.x() + m_clipRect.width()); > + m_npWindow.clipRect.bottom = max(0, m_npWindow.y + m_clipRect.y() + m_clipRect.height()); Seems we should be sharing this code on the root PluginView implementation with a private helper method, no? 530010 5 justine.bang 2012-01-04 22:23:50 -0800 i'll upload the patch again after test. And I think this patch should be shared to gtk/mac/qt platform having setNPWindowIfNeeded(). it is not need to implement to root Plugiview because some platform does not use setNPWindowIfNeeded() including this problem. 594105 6 135250 justine.bang 2012-04-02 18:08:15 -0700 Created attachment 135250 Signed to Unsigned Conversion Error rebase the patch. When tested webkit for desktop, it's not need this patch. My testing environment is using floating viewport for mobile browser( view is bigger than device screen). For getting m_windowRect, I'm using contentsToScreen instead of contentsToWindow. so, m_windowRect.x or y can be the negative. However, I think these codes are a basic problem about conversion. ( unsigned = signed ) this patch will prevent "Signed to Unsigned Conversion Error" and remove the warning in build time. How do you think about my opinion ? 671122 7 gyuyoung.kim 2012-07-17 03:17:14 -0700 (In reply to comment #6) > Created an attachment (id=135250) [details] > Signed to Unsigned Conversion Error > > rebase the patch. > > When tested webkit for desktop, it's not need this patch. > My testing environment is using floating viewport for mobile browser( view is bigger than device screen). > For getting m_windowRect, I'm using contentsToScreen instead of contentsToWindow. > so, m_windowRect.x or y can be the negative. > > However, I think these codes are a basic problem about conversion. ( unsigned = signed ) > this patch will prevent "Signed to Unsigned Conversion Error" and remove the warning in build time. > > How do you think about my opinion ? As Eric said on comment #4, I think reviewers can accept this patch when you submit this patch with test cases. And, if you have test cases for this patch, I also think this patch can be adjusted to root file. 874891 8 135250 pnormand 2013-04-12 12:10:38 -0700 Comment on attachment 135250 Signed to Unsigned Conversion Error We need a test for this patch, please. 1877390 9 ahmad.saleem792 2022-06-22 13:16:16 -0700 NPAPI support is removed from Safari 14 onward and it is not supported in Webkit Builds like WebkitGTK as well. I think this can be marked as "RESOLVED WONTFIX". Thanks! 1877568 10 rniwa 2022-06-22 22:23:10 -0700 Yup, won't fix. 119548 2011-12-15 20:10:31 -0800 2011-12-15 20:24:43 -0800 the patch file created by svn-create-patch patch-[20111215]-[justine.bang@samsung.com]-[conversion-error].patch text/plain 3236 justine.bang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCShy ZXZpc2lvbiAxMDMwMDYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3 R3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTE3LDExICs1MTcsMTQgQEAgdm9pZCBQbHVnaW5W aWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKCkKICAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC50 b3AgPSAwOwogICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmJvdHRvbSA9IDA7CiAgICAgfSBl bHNlIHsKLSAgICAgICAgLy8gQ2xpcHBpbmcgcmVjdGFuZ2xlIG9mIHRoZSBwbHVnLWluOyB0aGUg b3JpZ2luIGlzIHRoZSB0b3AgbGVmdCBjb3JuZXIgb2YgdGhlIGRyYXdhYmxlIG9yIHdpbmRvdy4g Ci0gICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QubGVmdCA9IG1fbnBXaW5kb3cueCArIG1fY2xp cFJlY3QueCgpOwotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnRvcCA9IG1fbnBXaW5kb3cu eSArIG1fY2xpcFJlY3QueSgpOwotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnJpZ2h0ID0g bV9ucFdpbmRvdy54ICsgbV9jbGlwUmVjdC54KCkgKyBtX2NsaXBSZWN0LndpZHRoKCk7Ci0gICAg ICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QuYm90dG9tID0gbV9ucFdpbmRvdy55ICsgbV9jbGlwUmVj dC55KCkgKyBtX2NsaXBSZWN0LmhlaWdodCgpOworICAgICAgICAvLyBDbGlwcGluZyByZWN0YW5n bGUgb2YgdGhlIHBsdWctaW47IHRoZSBvcmlnaW4gaXMgdGhlIHRvcCBsZWZ0IGNvcm5lciBvZiB0 aGUgZHJhd2FibGUgb3Igd2luZG93LgorICAgICAgICAvLyBTaWduZWQgdG8gVW5zaWduZWQgQ29u dmVyc2lvbiBFcnJvcjsgaWYgc2lnbmVkIGludGVnZXIgdmFyaWFibGUgaGFzIG5lZ2F0aXZlIG51 bWJlciwKKyAgICAgICAgLy8gZmlsbCB1bnNpZ25lZCBzaG9ydCB2YXJpYWJsZXMgdG8gemVybyBi ZWZvcmUgdHlwZSBjYXN0aW5nLgorICAgICAgICAvLyBJZiBub3QsIGNsaXBSZWN0IGhhdmUgYW4g dW5leHBlY3RlZCB2YWx1ZSBjYXVzZSBvZiB0aGUgZmlyc3QgYml0IGZvciBuZWdhdGl2ZS4KKyAg ICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5sZWZ0ID0gbWF4KDAsIG1fbnBXaW5kb3cueCArIG1f Y2xpcFJlY3QueCgpKTsKKyAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC50b3AgPSBtYXgoMCwg bV9ucFdpbmRvdy55ICsgbV9jbGlwUmVjdC55KCkpOworICAgICAgICBtX25wV2luZG93LmNsaXBS ZWN0LnJpZ2h0ID0gbWF4KDAsIG1fbnBXaW5kb3cueCArIG1fY2xpcFJlY3QueCgpICsgbV9jbGlw UmVjdC53aWR0aCgpKTsKKyAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5ib3R0b20gPSBtYXgo MCwgbV9ucFdpbmRvdy55ICsgbV9jbGlwUmVjdC55KCkgKyBtX2NsaXBSZWN0LmhlaWdodCgpKTsK ICAgICB9CiAKICAgICAvLyBGTEFTSCBXT1JLQVJPVU5EOiBPbmx5IHNldCBpbml0aWFsbHkuIE11 bHRpcGxlIGNhbGxzIHRvCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZp ZXdRdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5W aWV3UXQuY3BwCShyZXZpc2lvbiAxMDMwMDYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3F0 L1BsdWdpblZpZXdRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYwMiwxMSArNjAyLDE0IEBAIHZv aWQgUGx1Z2luVmlldzo6c2V0TlBXaW5kb3dJZk5lZWRlZCgpCiAgICAgICAgIG1fbnBXaW5kb3cu Y2xpcFJlY3QudG9wID0gMDsKICAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5ib3R0b20gPSAw OwogICAgIH0gZWxzZSB7Ci0gICAgICAgIC8vIENsaXBwaW5nIHJlY3RhbmdsZSBvZiB0aGUgcGx1 Zy1pbjsgdGhlIG9yaWdpbiBpcyB0aGUgdG9wIGxlZnQgY29ybmVyIG9mIHRoZSBkcmF3YWJsZSBv ciB3aW5kb3cuIAotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmxlZnQgPSBtX25wV2luZG93 LnggKyBtX2NsaXBSZWN0LngoKTsKLSAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC50b3AgPSBt X25wV2luZG93LnkgKyBtX2NsaXBSZWN0LnkoKTsKLSAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVj dC5yaWdodCA9IG1fbnBXaW5kb3cueCArIG1fY2xpcFJlY3QueCgpICsgbV9jbGlwUmVjdC53aWR0 aCgpOwotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmJvdHRvbSA9IG1fbnBXaW5kb3cueSAr IG1fY2xpcFJlY3QueSgpICsgbV9jbGlwUmVjdC5oZWlnaHQoKTsKKyAgICAgICAgLy8gQ2xpcHBp bmcgcmVjdGFuZ2xlIG9mIHRoZSBwbHVnLWluOyB0aGUgb3JpZ2luIGlzIHRoZSB0b3AgbGVmdCBj b3JuZXIgb2YgdGhlIGRyYXdhYmxlIG9yIHdpbmRvdy4KKyAgICAgICAgLy8gU2lnbmVkIHRvIFVu c2lnbmVkIENvbnZlcnNpb24gRXJyb3I7IGlmIHNpZ25lZCBpbnRlZ2VyIHZhcmlhYmxlIGhhcyBu ZWdhdGl2ZSBudW1iZXIsCisgICAgICAgIC8vIGZpbGwgdW5zaWduZWQgc2hvcnQgdmFyaWFibGVz IHRvIHplcm8gYmVmb3JlIHR5cGUgY2FzdGluZy4KKyAgICAgICAgLy8gSWYgbm90LCBjbGlwUmVj dCBoYXZlIGFuIHVuZXhwZWN0ZWQgdmFsdWUgY2F1c2Ugb2YgdGhlIGZpcnN0IGJpdCBmb3IgbmVn YXRpdmUuCisgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QubGVmdCA9IG1heCgwLCBtX25wV2lu ZG93LnggKyBtX2NsaXBSZWN0LngoKSk7CisgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QudG9w ID0gbWF4KDAsIG1fbnBXaW5kb3cueSArIG1fY2xpcFJlY3QueSgpKTsKKyAgICAgICAgbV9ucFdp bmRvdy5jbGlwUmVjdC5yaWdodCA9IG1heCgwLCBtX25wV2luZG93LnggKyBtX2NsaXBSZWN0Lngo KSArIG1fY2xpcFJlY3Qud2lkdGgoKSk7CisgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QuYm90 dG9tID0gbWF4KDAsIG1fbnBXaW5kb3cueSArIG1fY2xpcFJlY3QueSgpICsgbV9jbGlwUmVjdC5o ZWlnaHQoKSk7CiAgICAgfQogCiAgICAgaWYgKG1fcGx1Z2luLT5xdWlya3MoKS5jb250YWlucyhQ bHVnaW5RdWlya0RvbnRDYWxsU2V0V2luZG93TW9yZVRoYW5PbmNlKSkgewo= 119550 2011-12-15 20:24:43 -0800 2012-04-02 18:08:15 -0700 recreate the patch with changelog patch-[20111215]-[justine.bang@samsung.com]-[conversion-error].patch text/plain 4404 justine.bang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEwMzAxNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDExLTEyLTE1ICBLd2FuZ21p biBCYW5nIDxqdXN0aW5lLmJhbmdAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1BsdWdpbnMgR1RL L1FUXSBTaWduZWQgdG8gVW5zaWduZWQgQ29udmVyc2lvbiBFcnJvcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ2ODAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKwor ICAgICAgICBJZiBzaWduZWQgaW50ZWdlciB2YXJpYWJsZXMgaGF2aW5nIG5lZ2F0aXZlIG51bWJl ciBpcyBhbGxvY2F0ZWQgdG8gdW5zaWduZWQgc2hvcnQgdmFyaWFibGVzLAorICAgICAgICB1bnNp Z25lZCBzaG9ydCB2YXJpYWJsZXMgd2lsbCBoYXZlIGFuIHVuZXhwZWN0ZWQgdmFsdWUuCisgICAg ICAgIFNvLCBpZiBzaWduZWQgaW50ZWdlciB2YXJpYWJsZSBoYXMgbmVnYXRpdmUgbnVtYmVyLGZp bGwgdW5zaWduZWQgc2hvcnQgdmFyaWFibGVzIHRvIHplcm8gYmVmb3JlIHR5cGUgY2FzdGluZy4K KyAgICAgICAgSWYgbm90LCBjbGlwUmVjdCh1bnNpZ25lZCBzaG9ydCkgaGF2ZSBhbiB1bmV4cGVj dGVkIHZhbHVlIGNhdXNlIG9mIHRoZSBmaXJzdCBiaXQgZm9yIG5lZ2F0aXZlLgorCisgICAgICAg ICogcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVn aW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKToKKyAgICAgICAgKiBwbHVnaW5zL3F0L1BsdWdp blZpZXdRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3OjpzZXROUFdpbmRvd0lm TmVlZGVkKToKKwogMjAxMS0xMi0xNSAgQWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29t PgogCiAgICAgICAgIFtjaHJvbWl1bV0gQ2xlYW4gdXAgdW5uZWNlc3NhcnkgbGVhZiBmdW5jdGlv bnMgaW4gR3JhcGhpY3NMYXllckNocm9taXVtCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5z L2d0ay9QbHVnaW5WaWV3R3RrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbHVn aW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcAkocmV2aXNpb24gMTAzMDA2KQorKysgU291cmNlL1dl YkNvcmUvcGx1Z2lucy9ndGsvUGx1Z2luVmlld0d0ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUx NywxMSArNTE3LDE0IEBAIHZvaWQgUGx1Z2luVmlldzo6c2V0TlBXaW5kb3dJZk5lZWRlZCgpCiAg ICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QudG9wID0gMDsKICAgICAgICAgbV9ucFdpbmRvdy5j bGlwUmVjdC5ib3R0b20gPSAwOwogICAgIH0gZWxzZSB7Ci0gICAgICAgIC8vIENsaXBwaW5nIHJl Y3RhbmdsZSBvZiB0aGUgcGx1Zy1pbjsgdGhlIG9yaWdpbiBpcyB0aGUgdG9wIGxlZnQgY29ybmVy IG9mIHRoZSBkcmF3YWJsZSBvciB3aW5kb3cuIAotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0 LmxlZnQgPSBtX25wV2luZG93LnggKyBtX2NsaXBSZWN0LngoKTsKLSAgICAgICAgbV9ucFdpbmRv dy5jbGlwUmVjdC50b3AgPSBtX25wV2luZG93LnkgKyBtX2NsaXBSZWN0LnkoKTsKLSAgICAgICAg bV9ucFdpbmRvdy5jbGlwUmVjdC5yaWdodCA9IG1fbnBXaW5kb3cueCArIG1fY2xpcFJlY3QueCgp ICsgbV9jbGlwUmVjdC53aWR0aCgpOwotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmJvdHRv bSA9IG1fbnBXaW5kb3cueSArIG1fY2xpcFJlY3QueSgpICsgbV9jbGlwUmVjdC5oZWlnaHQoKTsK KyAgICAgICAgLy8gQ2xpcHBpbmcgcmVjdGFuZ2xlIG9mIHRoZSBwbHVnLWluOyB0aGUgb3JpZ2lu IGlzIHRoZSB0b3AgbGVmdCBjb3JuZXIgb2YgdGhlIGRyYXdhYmxlIG9yIHdpbmRvdy4KKyAgICAg ICAgLy8gU2lnbmVkIHRvIFVuc2lnbmVkIENvbnZlcnNpb24gRXJyb3I7IGlmIHNpZ25lZCBpbnRl Z2VyIHZhcmlhYmxlIGhhcyBuZWdhdGl2ZSBudW1iZXIsCisgICAgICAgIC8vIGZpbGwgdW5zaWdu ZWQgc2hvcnQgdmFyaWFibGVzIHRvIHplcm8gYmVmb3JlIHR5cGUgY2FzdGluZy4KKyAgICAgICAg Ly8gSWYgbm90LCBjbGlwUmVjdCBoYXZlIGFuIHVuZXhwZWN0ZWQgdmFsdWUgY2F1c2Ugb2YgdGhl IGZpcnN0IGJpdCBmb3IgbmVnYXRpdmUuCisgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QubGVm dCA9IG1heCgwLCBtX25wV2luZG93LnggKyBtX2NsaXBSZWN0LngoKSk7CisgICAgICAgIG1fbnBX aW5kb3cuY2xpcFJlY3QudG9wID0gbWF4KDAsIG1fbnBXaW5kb3cueSArIG1fY2xpcFJlY3QueSgp KTsKKyAgICAgICAgbV9ucFdpbmRvdy5jbGlwUmVjdC5yaWdodCA9IG1heCgwLCBtX25wV2luZG93 LnggKyBtX2NsaXBSZWN0LngoKSArIG1fY2xpcFJlY3Qud2lkdGgoKSk7CisgICAgICAgIG1fbnBX aW5kb3cuY2xpcFJlY3QuYm90dG9tID0gbWF4KDAsIG1fbnBXaW5kb3cueSArIG1fY2xpcFJlY3Qu eSgpICsgbV9jbGlwUmVjdC5oZWlnaHQoKSk7CiAgICAgfQogCiAgICAgLy8gRkxBU0ggV09SS0FS T1VORDogT25seSBzZXQgaW5pdGlhbGx5LiBNdWx0aXBsZSBjYWxscyB0bwpJbmRleDogU291cmNl L1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAkocmV2aXNpb24gMTAzMDA2KQor KysgU291cmNlL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC02MDIsMTEgKzYwMiwxNCBAQCB2b2lkIFBsdWdpblZpZXc6OnNldE5QV2luZG93SWZO ZWVkZWQoKQogICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnRvcCA9IDA7CiAgICAgICAgIG1f bnBXaW5kb3cuY2xpcFJlY3QuYm90dG9tID0gMDsKICAgICB9IGVsc2UgewotICAgICAgICAvLyBD bGlwcGluZyByZWN0YW5nbGUgb2YgdGhlIHBsdWctaW47IHRoZSBvcmlnaW4gaXMgdGhlIHRvcCBs ZWZ0IGNvcm5lciBvZiB0aGUgZHJhd2FibGUgb3Igd2luZG93LiAKLSAgICAgICAgbV9ucFdpbmRv dy5jbGlwUmVjdC5sZWZ0ID0gbV9ucFdpbmRvdy54ICsgbV9jbGlwUmVjdC54KCk7Ci0gICAgICAg IG1fbnBXaW5kb3cuY2xpcFJlY3QudG9wID0gbV9ucFdpbmRvdy55ICsgbV9jbGlwUmVjdC55KCk7 Ci0gICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QucmlnaHQgPSBtX25wV2luZG93LnggKyBtX2Ns aXBSZWN0LngoKSArIG1fY2xpcFJlY3Qud2lkdGgoKTsKLSAgICAgICAgbV9ucFdpbmRvdy5jbGlw UmVjdC5ib3R0b20gPSBtX25wV2luZG93LnkgKyBtX2NsaXBSZWN0LnkoKSArIG1fY2xpcFJlY3Qu aGVpZ2h0KCk7CisgICAgICAgIC8vIENsaXBwaW5nIHJlY3RhbmdsZSBvZiB0aGUgcGx1Zy1pbjsg dGhlIG9yaWdpbiBpcyB0aGUgdG9wIGxlZnQgY29ybmVyIG9mIHRoZSBkcmF3YWJsZSBvciB3aW5k b3cuCisgICAgICAgIC8vIFNpZ25lZCB0byBVbnNpZ25lZCBDb252ZXJzaW9uIEVycm9yOyBpZiBz aWduZWQgaW50ZWdlciB2YXJpYWJsZSBoYXMgbmVnYXRpdmUgbnVtYmVyLAorICAgICAgICAvLyBm aWxsIHVuc2lnbmVkIHNob3J0IHZhcmlhYmxlcyB0byB6ZXJvIGJlZm9yZSB0eXBlIGNhc3Rpbmcu CisgICAgICAgIC8vIElmIG5vdCwgY2xpcFJlY3QgaGF2ZSBhbiB1bmV4cGVjdGVkIHZhbHVlIGNh dXNlIG9mIHRoZSBmaXJzdCBiaXQgZm9yIG5lZ2F0aXZlLgorICAgICAgICBtX25wV2luZG93LmNs aXBSZWN0LmxlZnQgPSBtYXgoMCwgbV9ucFdpbmRvdy54ICsgbV9jbGlwUmVjdC54KCkpOworICAg ICAgICBtX25wV2luZG93LmNsaXBSZWN0LnRvcCA9IG1heCgwLCBtX25wV2luZG93LnkgKyBtX2Ns aXBSZWN0LnkoKSk7CisgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QucmlnaHQgPSBtYXgoMCwg bV9ucFdpbmRvdy54ICsgbV9jbGlwUmVjdC54KCkgKyBtX2NsaXBSZWN0LndpZHRoKCkpOworICAg ICAgICBtX25wV2luZG93LmNsaXBSZWN0LmJvdHRvbSA9IG1heCgwLCBtX25wV2luZG93LnkgKyBt X2NsaXBSZWN0LnkoKSArIG1fY2xpcFJlY3QuaGVpZ2h0KCkpOwogICAgIH0KIAogICAgIGlmICht X3BsdWdpbi0+cXVpcmtzKCkuY29udGFpbnMoUGx1Z2luUXVpcmtEb250Q2FsbFNldFdpbmRvd01v cmVUaGFuT25jZSkpIHsK 135250 2012-04-02 18:08:15 -0700 2013-04-12 12:10:37 -0700 Signed to Unsigned Conversion Error patch-[20120402]-[justine.bang@samsung.com]-[conversion-error].patch text/plain 3468 justine.bang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNDVmNjQ1Li5kOTA5OWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDQtMDIgIEJhbmcgS3dhbmcgbWluICA8anVzdGluZS5iYW5nQHNhbXN1bmcuY29t PgorCisgICAgICAgIFtQbHVnaW5zIEdUSy9RVF0gU2lnbmVkIHRvIFVuc2lnbmVkIENvbnZlcnNp b24gRXJyb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc0NjgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SWYgc2lnbmVkIGludGVnZXIgdmFyaWFibGVzIGhhdmluZyBuZWdhdGl2ZSBudW1iZXIgaXMgYWxs b2NhdGVkIHRvIHVuc2lnbmVkIHNob3J0IHZhcmlhYmxlcywKKyAgICAgICAgdW5zaWduZWQgc2hv cnQgdmFyaWFibGVzIHdpbGwgaGF2ZSBhbiB1bmV4cGVjdGVkIHZhbHVlLgorICAgICAgICBTbywg aWYgc2lnbmVkIGludGVnZXIgdmFyaWFibGUgaGFzIG5lZ2F0aXZlIG51bWJlcixmaWxsIHVuc2ln bmVkIHNob3J0IHZhcmlhYmxlcyB0byB6ZXJvIGJlZm9yZSB0eXBlIGNhc3RpbmcuCisgICAgICAg IElmIG5vdCwgY2xpcFJlY3QodW5zaWduZWQgc2hvcnQpIGhhdmUgYW4gdW5leHBlY3RlZCB2YWx1 ZSBjYXVzZSBvZiB0aGUgZmlyc3QgYml0IGZvciBuZWdhdGl2ZS4KKworICAgICAgICAqIHBsdWdp bnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6 c2V0TlBXaW5kb3dJZk5lZWRlZCk6CisgICAgICAgICogcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6c2V0TlBXaW5kb3dJZk5lZWRlZCk6 CisKIDIwMTItMDQtMDIgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMTI2NTkuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL2d0ay9QbHVnaW5WaWV3R3RrLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCmluZGV4IGM1NjhhNGIuLjNmMTIw ZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMvZ3RrL1BsdWdpblZpZXdHdGsuY3BwCkBA IC01MjAsMTAgKzUyMCwxMCBAQCB2b2lkIFBsdWdpblZpZXc6OnNldE5QV2luZG93SWZOZWVkZWQo KQogICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmJvdHRvbSA9IDA7CiAgICAgfSBlbHNlIHsK ICAgICAgICAgLy8gQ2xpcHBpbmcgcmVjdGFuZ2xlIG9mIHRoZSBwbHVnLWluOyB0aGUgb3JpZ2lu IGlzIHRoZSB0b3AgbGVmdCBjb3JuZXIgb2YgdGhlIGRyYXdhYmxlIG9yIHdpbmRvdy4gCi0gICAg ICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QubGVmdCA9IG1fbnBXaW5kb3cueCArIG1fY2xpcFJlY3Qu eCgpOwotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnRvcCA9IG1fbnBXaW5kb3cueSArIG1f Y2xpcFJlY3QueSgpOwotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnJpZ2h0ID0gbV9ucFdp bmRvdy54ICsgbV9jbGlwUmVjdC54KCkgKyBtX2NsaXBSZWN0LndpZHRoKCk7Ci0gICAgICAgIG1f bnBXaW5kb3cuY2xpcFJlY3QuYm90dG9tID0gbV9ucFdpbmRvdy55ICsgbV9jbGlwUmVjdC55KCkg KyBtX2NsaXBSZWN0LmhlaWdodCgpOworICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmxlZnQg PSBtYXgoMCwgbV9ucFdpbmRvdy54ICsgbV9jbGlwUmVjdC54KCkpOworICAgICAgICBtX25wV2lu ZG93LmNsaXBSZWN0LnRvcCA9IG1heCgwLCBtX25wV2luZG93LnkgKyBtX2NsaXBSZWN0LnkoKSk7 CisgICAgICAgIG1fbnBXaW5kb3cuY2xpcFJlY3QucmlnaHQgPSBtYXgoMCwgbV9ucFdpbmRvdy54 ICsgbV9jbGlwUmVjdC54KCkgKyBtX2NsaXBSZWN0LndpZHRoKCkpOworICAgICAgICBtX25wV2lu ZG93LmNsaXBSZWN0LmJvdHRvbSA9IG1heCgwLCBtX25wV2luZG93LnkgKyBtX2NsaXBSZWN0Lnko KSArIG1fY2xpcFJlY3QuaGVpZ2h0KCkpOwogICAgIH0KIAogICAgIC8vIEZMQVNIIFdPUktBUk9V TkQ6IE9ubHkgc2V0IGluaXRpYWxseS4gTXVsdGlwbGUgY2FsbHMgdG8KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAppbmRleCBmZjkxMmRiLi5jZjAyNDFkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCkBAIC02MDQsMTAgKzYw NCwxMCBAQCB2b2lkIFBsdWdpblZpZXc6OnNldE5QV2luZG93SWZOZWVkZWQoKQogICAgICAgICBt X25wV2luZG93LmNsaXBSZWN0LmJvdHRvbSA9IDA7CiAgICAgfSBlbHNlIHsKICAgICAgICAgLy8g Q2xpcHBpbmcgcmVjdGFuZ2xlIG9mIHRoZSBwbHVnLWluOyB0aGUgb3JpZ2luIGlzIHRoZSB0b3Ag bGVmdCBjb3JuZXIgb2YgdGhlIGRyYXdhYmxlIG9yIHdpbmRvdy4gCi0gICAgICAgIG1fbnBXaW5k b3cuY2xpcFJlY3QubGVmdCA9IG1fbnBXaW5kb3cueCArIG1fY2xpcFJlY3QueCgpOwotICAgICAg ICBtX25wV2luZG93LmNsaXBSZWN0LnRvcCA9IG1fbnBXaW5kb3cueSArIG1fY2xpcFJlY3QueSgp OwotICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LnJpZ2h0ID0gbV9ucFdpbmRvdy54ICsgbV9j bGlwUmVjdC54KCkgKyBtX2NsaXBSZWN0LndpZHRoKCk7Ci0gICAgICAgIG1fbnBXaW5kb3cuY2xp cFJlY3QuYm90dG9tID0gbV9ucFdpbmRvdy55ICsgbV9jbGlwUmVjdC55KCkgKyBtX2NsaXBSZWN0 LmhlaWdodCgpOworICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0LmxlZnQgPSBtYXgoMCwgbV9u cFdpbmRvdy54ICsgbV9jbGlwUmVjdC54KCkpOworICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0 LnRvcCA9IG1heCgwLCBtX25wV2luZG93LnkgKyBtX2NsaXBSZWN0LnkoKSk7CisgICAgICAgIG1f bnBXaW5kb3cuY2xpcFJlY3QucmlnaHQgPSBtYXgoMCwgbV9ucFdpbmRvdy54ICsgbV9jbGlwUmVj dC54KCkgKyBtX2NsaXBSZWN0LndpZHRoKCkpOworICAgICAgICBtX25wV2luZG93LmNsaXBSZWN0 LmJvdHRvbSA9IG1heCgwLCBtX25wV2luZG93LnkgKyBtX2NsaXBSZWN0LnkoKSArIG1fY2xpcFJl Y3QuaGVpZ2h0KCkpOwogICAgIH0KIAogICAgIGlmIChtX3BsdWdpbi0+cXVpcmtzKCkuY29udGFp bnMoUGx1Z2luUXVpcmtEb250Q2FsbFNldFdpbmRvd01vcmVUaGFuT25jZSkpIHsK