74670 2011-12-15 17:32:06 -0800 Remove legacy node types 2016-08-04 14:18:11 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91316 1 ojan webkit-unassigned adamk annevk ap arv cdumez darin rniwa syoichi oldest_to_newest 522389 0 ojan 2011-12-15 17:32:06 -0800 http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html DOM4 removes a bunch of node types. We should remove them from webcore. const unsigned short ATTRIBUTE_NODE = 2; // historical const unsigned short CDATA_SECTION_NODE = 4; // historical const unsigned short ENTITY_REFERENCE_NODE = 5; // historical const unsigned short NOTATION_NODE = 12; // historical There's already bug 74371 for attributes. It appears that ENTITY_REFERENCE_NODE can only be created in XML documents by script calling document.createEntityReference. I think we can safely remove them. This will also have the added benefit of improving appendChild/insertBefore performance. I haven't looked into cdata_section or notation. 1217592 1 cdumez 2016-08-04 14:16:56 -0700 The following were already removed: const unsigned short ENTITY_REFERENCE_NODE = 5; // historical const unsigned short NOTATION_NODE = 12; // historical I believe Anne plans to add CDATA_SECTION_NODE / ATTRIBUTE_NODE back into the DOM specification this month because no major browser has been able to drop them. 1217595 2 cdumez 2016-08-04 14:17:52 -0700 (In reply to comment #1) > The following were already removed: > const unsigned short ENTITY_REFERENCE_NODE = 5; // historical > const unsigned short NOTATION_NODE = 12; // historical > > I believe Anne plans to add CDATA_SECTION_NODE / ATTRIBUTE_NODE back into > the DOM specification this month because no major browser has been able to > drop them. Referring to Anne's recent comment on https://github.com/whatwg/dom/issues/102#issuecomment-236141842