74655 2011-12-15 15:36:55 -0800 Regression (r102866): Navigating away from or closing a page with a plugin crashes 2011-12-16 15:35:08 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson andersca andersca c.petersen87 webkit.review.bot oldest_to_newest 522267 0 beidson 2011-12-15 15:36:55 -0800 Regression (r102866): Navigating away from a cachable page with a plugin crashes Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit2 0x000000010f7d694f CoreIPC::Connection::dispatchConnectionDidClose() + 63 (Connection.cpp:606) 1 com.apple.WebKit2 0x000000010f7ddc10 WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator()(CoreIPC::Connection*) + 112 (Functional.h:135) 2 com.apple.WebKit2 0x000000010f7ddb95 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void ()(CoreIPC::Connection*)>::operator()() + 37 (Functional.h:221) 3 com.apple.WebKit2 0x000000010f83e978 WTF::Function<void ()()>::operator()() + 136 (Functional.h:299) 4 com.apple.WebKit2 0x000000010f83e8dc FunctionWorkItem::execute() + 28 (WorkItem.h:230) 5 com.apple.WebKit2 0x000000010f83d82f RunLoop::performWork() + 207 (RunLoop.cpp:64) 6 com.apple.WebKit2 0x000000010f83ebb0 RunLoop::performWork(void*) + 96 (RunLoopMac.mm:38) The crashing line is: client->didClose(this); 522271 1 beidson 2011-12-15 15:38:54 -0800 <rdar://problem/10590024> 522344 2 beidson 2011-12-15 16:56:40 -0800 You can actually trigger this just by closing a tab with a page with a plug-in - I noticed closing a tab with Yelp. 522400 3 119530 andersca 2011-12-15 17:55:11 -0800 Created attachment 119530 Patch 522402 4 webkit.review.bot 2011-12-15 17:58:20 -0800 Attachment 119530 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:156: Code inside a namespace should not be indented. [whitespace/indent] [4] Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:166: More than one command on the same line [whitespace/newline] [4] Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:169: More than one command on the same line [whitespace/newline] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 522405 5 andersca 2011-12-15 18:00:53 -0800 Committed r103008: <http://trac.webkit.org/changeset/103008> 523116 6 ap 2011-12-16 15:35:08 -0800 *** Bug 74684 has been marked as a duplicate of this bug. *** 119530 2011-12-15 17:55:11 -0800 2011-12-15 17:59:42 -0800 Patch bug-74655-20111215175509.patch text/plain 4086 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi ODgzZGI3YWFkNThjZjY4YzFiMDAxZjcyMmEyZTNlOTU0ZDBhN2U3Li40YTZiZTY0NWNlNzZhNTIz YjZlNjY3YjIxZjdkYWJmNDQyZjczMTk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMS0xMi0xNSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgorCisgICAgICAgIFJlZ3Jlc3Npb24gKHIxMDI4NjYpOiBOYXZpZ2F0aW5nIGF3YXkgZnJv bSBvciBjbG9zaW5nIGEgcGFnZSB3aXRoIGEgcGx1Z2luIGNyYXNoZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0NjU1CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8xMDU5MDAyND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZXdyaXRlIEhhc1JlZkFuZERlcmVmIHRvIHdvcmsgaWYgcmVmIGFuZCBkZXJl ZiBhcmUgaW1wbGVtZW50ZWQgaW4gYmFzZSBjbGFzc2VzLAorICAgICAgICB1c2luZyBhIG1vZGlm aWVkIHZlcnNpb24gb2YgdGhlIHRlY2huaXF1ZSBkZXNjcmliZWQgaGVyZToKKyAgICAgICAgaHR0 cDovL2dyb3Vwcy5nb29nbGUuY29tL2dyb3VwL2NvbXAubGFuZy5jKysubW9kZXJhdGVkL21zZy9l NWZiYzkzMDU1MzlmNjk5CisgICAgICAgIAorICAgICAgICAqIHd0Zi9GdW5jdGlvbmFsLmg6CisK IDIwMTEtMTItMTUgIEFuZHkgV2luZ28gIDx3aW5nb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFdh cm5pbmdzIGZpeGVzIGluIEludGVycHJldGVyLmNwcCBhbmQgUHJpdmF0ZUV4ZWN1dGUuY3BwCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Z1bmN0aW9uYWwuaCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS93dGYvRnVuY3Rpb25hbC5oCmluZGV4IGQ4ZjY5OTNlMjEyMzJmOGYw NTY2NzJiNDMxZTI1OTZmODk4MTA4MDUuLmEzODMxNmQ4NTRlZjAwNTYzNGYyZDZiNDE2YjU1YmUw Yjk3YWEzNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRnVuY3Rpb25h bC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRnVuY3Rpb25hbC5oCkBAIC00Niwx NiArNDYsMjYgQEAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gY2xhc3MgSGFzUmVmQW5kRGVyZWYgewog ICAgICAgICBjaGFyIHBhZGRpbmdbOF07CiAgICAgfTsKIAotICAgIHRlbXBsYXRlPHR5cGVuYW1l IFUsIFUsIFU+IHN0cnVjdCBUeXBlQ2hlY2tlciB7IH07CisgICAgc3RydWN0IEJhc2VNaXhpbiB7 CisgICAgICAgIHZvaWQgZGVyZWYoKTsKKyAgICAgICAgdm9pZCByZWYoKTsKKyAgICB9OworCisg ICAgc3RydWN0IEJhc2UgOiBwdWJsaWMgVCwgcHVibGljIEJhc2VNaXhpbiB7IH07CisKKyAgICB0 ZW1wbGF0ZTx0eXBlbmFtZSBVLCBVPiBzdHJ1Y3QKKyAgICBUeXBlQ2hlY2tlciB7IH07CiAKICAg ICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPgotICAgIHN0YXRpYyBZZXNUeXBlIHJlZkFuZERlcmVmQ2hl Y2soVHlwZUNoZWNrZXI8dm9pZCAoVTo6KikoKSwgJlU6OnJlZiwgJlU6OmRlcmVmPiopOworICAg IHN0YXRpYyBOb1R5cGUgcmVmQ2hlY2soVSosIFR5cGVDaGVja2VyPHZvaWQgKEJhc2VNaXhpbjo6 KikoKSwgJlU6OnJlZj4qID0gMCk7CisgICAgc3RhdGljIFllc1R5cGUgcmVmQ2hlY2soLi4uKTsK IAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+Ci0gICAgc3RhdGljIE5vVHlwZSByZWZBbmREZXJl ZkNoZWNrKC4uLik7CisgICAgc3RhdGljIE5vVHlwZSBkZXJlZkNoZWNrKFUqLCBUeXBlQ2hlY2tl cjx2b2lkIChCYXNlTWl4aW46OiopKCksICZVOjpkZXJlZj4qID0gMCk7CisgICAgc3RhdGljIFll c1R5cGUgZGVyZWZDaGVjayguLi4pOwogCiBwdWJsaWM6Ci0gICAgc3RhdGljIGNvbnN0IGJvb2wg dmFsdWUgPSBzaXplb2YocmVmQW5kRGVyZWZDaGVjazxUPigwKSkgPT0gc2l6ZW9mKFllc1R5cGUp OworICAgIHN0YXRpYyBjb25zdCBib29sIHZhbHVlID0gc2l6ZW9mKHJlZkNoZWNrKHN0YXRpY19j YXN0PEJhc2UqPigwKSkpID09IHNpemVvZihZZXNUeXBlKSAmJiBzaXplb2YoZGVyZWZDaGVjayhz dGF0aWNfY2FzdDxCYXNlKj4oMCkpKSA9PSBzaXplb2YoWWVzVHlwZSk7CiB9OwogCiAvLyBBIEZ1 bmN0aW9uV3JhcHBlciBpcyBhIGNsYXNzIHRlbXBsYXRlIHRoYXQgY2FuIHdyYXAgYSBmdW5jdGlv biBwb2ludGVyIG9yIGEgbWVtYmVyIGZ1bmN0aW9uIHBvaW50ZXIgYW5kCmRpZmYgLS1naXQgYS9U b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTJlZTMyMTg0NjViOGZhM2Rl MTM4NTkzNTRmMjYyMzcwNzcxOGVlZS4uYTI2NDJkZmJkNTgzNDVlMjUzM2Q4N2UwODA4NjJhOGJl OTNmNDY3MCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE0IEBACisyMDExLTEyLTE1ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbiAocjEwMjg2Nik6IE5hdmlnYXRpbmcg YXdheSBmcm9tIG9yIGNsb3NpbmcgYSBwYWdlIHdpdGggYSBwbHVnaW4gY3Jhc2hlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ2NTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBidW5jaCBvZiB0 ZXN0cy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0Z1bmN0aW9uYWwuY3Bw OgorCiAyMDExLTEyLTE1ICBTdGVwaGFuaWUgTGV3aXMgIDxzbGV3aXNAYXBwbGUuY29tPgogCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDQ2OQpkaWZm IC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRnVuY3Rpb25hbC5jcHAgYi9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9GdW5jdGlvbmFsLmNwcAppbmRleCBhYjc0MmU0 YjAxMzhhNzgzZWNhMDI5ZWY3OGY1ZTdhOTBmYWIyZDY0Li5jNWZmZjA2YzZjNzZhY2U3N2I0N2Vk NzkxYjhhMzM2MjlmZGU1NTBkIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dURi9GdW5jdGlvbmFsLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9G dW5jdGlvbmFsLmNwcApAQCAtMTUxLDQgKzE1MSwyNCBAQCBURVNUKEZ1bmN0aW9uYWxUZXN0LCBN ZW1iZXJGdW5jdGlvbkJpbmRSZWZEZXJlZikKIAogfQogCituYW1lc3BhY2UgUmVmQW5kRGVyZWZU ZXN0cyB7CisgICAgCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gc3RydWN0IFJlZkNvdW50ZWQg eworICAgICAgICB2b2lkIHJlZigpOworICAgICAgICB2b2lkIGRlcmVmKCk7CisgICAgfTsKKyAg ICBzdHJ1Y3QgQ29ubmVjdGlvbiA6IFJlZkNvdW50ZWQ8Q29ubmVjdGlvbj4geyB9OworICAgIENP TVBJTEVfQVNTRVJUKFdURjo6SGFzUmVmQW5kRGVyZWY8Q29ubmVjdGlvbj46OnZhbHVlLCBjbGFz c19oYXNfcmVmX2FuZF9kZXJlZik7CisgICAgCisgICAgc3RydWN0IE5vUmVmT3JEZXJlZiB7IH07 CisgICAgQ09NUElMRV9BU1NFUlQoIVdURjo6SGFzUmVmQW5kRGVyZWY8Tm9SZWZPckRlcmVmPjo6 dmFsdWUsIGNsYXNzX2hhc19ub19yZWZfb3JfZGVyZWYpOworICAgIAorICAgIHN0cnVjdCBSZWZP bmx5IHsgdm9pZCByZWYoKTsgfTsKKyAgICBDT01QSUxFX0FTU0VSVCghV1RGOjpIYXNSZWZBbmRE ZXJlZjxSZWZPbmx5Pjo6dmFsdWUsIGNsYXNzX2hhc19yZWZfb25seSk7CisgICAgCisgICAgc3Ry dWN0IERlcmVmT25seSB7IHZvaWQgZGVyZWYoKTsgfTsKKyAgICBDT01QSUxFX0FTU0VSVCghV1RG OjpIYXNSZWZBbmREZXJlZjxEZXJlZk9ubHk+Ojp2YWx1ZSwgY2xhc3NfaGFzX2RlcmVmX29ubHkp OworCit9CisKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkK