74650 2011-12-15 14:56:59 -0800 NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process) 2012-01-31 03:32:38 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified OS X 10.7 RESOLVED FIXED P2 Normal --- 77419 1 ap eric abarth aroben dpranke eric ojan rniwa webkit.review.bot oldest_to_newest 522247 0 ap 2011-12-15 14:56:59 -0800 run-webkit-tests doesn't start on my machine. This appears the be because the script checks for free memory. An OS X system is expected to have as close to 0 free memory as possible, because there is no reason to evict stuff from caches before someone asks for memory. Can a better heuristic be found, perhaps based on inactive memory? Can at least one process be always started? PhysMem: 1146M wired, 3105M active, 3867M inactive, 8119M used, 61M free. VM: 253G vsize, 1122M framework vsize, 81575868(0) pageins, 929707(0) pageouts. 522251 1 eric 2011-12-15 15:02:55 -0800 Yeah, I'm not a huge fan of this check. I'm happy to change it (or assist you in changing it) to use a different heuristic. See bug 74021 and bug 73847. 522256 2 eric 2011-12-15 15:11:21 -0800 does "pages inactive" in vm_stat include free pages? Or are you asking for this heuristic to add both? 522262 3 119506 eric 2011-12-15 15:22:37 -0800 Created attachment 119506 Patch 522532 4 119506 webkit.review.bot 2011-12-15 22:03:12 -0800 Comment on attachment 119506 Patch Clearing flags on attachment: 119506 Committed r103026: <http://trac.webkit.org/changeset/103026> 522533 5 webkit.review.bot 2011-12-15 22:03:17 -0800 All reviewed patches have been landed. Closing bug. 119506 2011-12-15 15:22:37 -0800 2011-12-15 22:03:12 -0800 Patch bug-74650-20111215152236.patch text/plain 5039 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyOTc1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTE5M2Q0MWY1NjlmODc4MTE5OTRlNjgzNzYxZGEyNjlm OWE1OGNhMC4uMzE2YTE0OTIxYTBmNTM5Zjk5YWM2ZThmZjM2ZGJkMDI4OTRmN2Q0OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDExLTEyLTE1ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBOUldUIHNob3VsZCB1c2UgZnJlZSArIGluYWN0aXZlIG1lbW9yeSBmb3IgZGVmYXVsdF9jaGls ZF9wcm9jZXNzZXMgb24gT1MgWCAoYW5kIG5ldmVyIHJldHVybiA8IDEgcHJvY2VzcykKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0NjUwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5OgorICAgICAgICAoUGxhdGZvcm1JbmZv Ll9jb21wdXRlX2J5dGVzX2Zyb21fdm1fc3RhdF9vdXRwdXQpOgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weToKKyAgICAgICAgKFBvcnQuZGVmYXVs dF9jaGlsZF9wcm9jZXNzZXMpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3BvcnQvYmFzZV91bml0dGVzdC5weToKKyAgICAgICAgKFBvcnRUZXN0LnRlc3RfZGVmYXVs dF9jaGlsZF9wcm9jZXNzZXMpOgorCiAyMDExLTEyLTE1ICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEg IDxrdWJvQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFtFRkxdIEFkZCBhIGZldyBtb3JlIHdl YiBkYXRhYmFzZSBmdW5jdGlvbnMgdG8gZXdrX3NldHRpbmdzLgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9wbGF0Zm9ybWluZm8ucHkKaW5kZXggMGU0NDA3 ZTJiOWFhOWEwMjEwZGVhMzViZmRmZjE0OTQ2ZmZkNGNlZi4uNjRlODA1ZGYyNTk0ODM2OGU1ZTFm YTg4ZDY0NzE0MDhhNmRmZGNlMCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vc3lzdGVtL3BsYXRmb3JtaW5mby5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1vbi9zeXN0ZW0vcGxhdGZvcm1pbmZvLnB5CkBAIC01MSw5ICs1MSw5IEBAIGNsYXNzIFBs YXRmb3JtSW5mbyhvYmplY3QpOgogICAgICAgICAgICAgcmV0dXJuIGludChzZWxmLl9leGVjdXRp dmUucnVuX2NvbW1hbmQoWyJzeXNjdGwiLCAiLW4iLCAiaHcubWVtc2l6ZSJdKSkKICAgICAgICAg cmV0dXJuIE5vbmUKIAotICAgIGRlZiBfY29tcHV0ZV9mcmVlX2J5dGVzX2Zyb21fdm1fc3RhdF9v dXRwdXQoc2VsZiwgdm1fc3RhdF9vdXRwdXQpOgorICAgIGRlZiBfY29tcHV0ZV9ieXRlc19mcm9t X3ZtX3N0YXRfb3V0cHV0KHNlbGYsIGxhYmVsX3RleHQsIHZtX3N0YXRfb3V0cHV0KToKICAgICAg ICAgcGFnZV9zaXplX21hdGNoID0gcmUuc2VhcmNoKHIicGFnZSBzaXplIG9mIChcZCspIGJ5dGVz Iiwgdm1fc3RhdF9vdXRwdXQpCi0gICAgICAgIGZyZWVfcGFnZXNfbWF0Y2ggPSByZS5zZWFyY2go ciJQYWdlcyBmcmVlOlxzKyhcZCspLiIsIHZtX3N0YXRfb3V0cHV0KQorICAgICAgICBmcmVlX3Bh Z2VzX21hdGNoID0gcmUuc2VhcmNoKHIiJXM6XHMrKFxkKykuIiAlIGxhYmVsX3RleHQsIHZtX3N0 YXRfb3V0cHV0KQogICAgICAgICBpZiBub3QgcGFnZV9zaXplX21hdGNoIG9yIG5vdCBmcmVlX3Bh Z2VzX21hdGNoOgogICAgICAgICAgICAgcmV0dXJuIE5vbmUKICAgICAgICAgZnJlZV9wYWdlX2Nv dW50ID0gaW50KGZyZWVfcGFnZXNfbWF0Y2guZ3JvdXAoMSkpCkBAIC02NCw1ICs2NCw4IEBAIGNs YXNzIFBsYXRmb3JtSW5mbyhvYmplY3QpOgogICAgICAgICBzeXN0ZW1fbmFtZSA9IHBsYXRmb3Jt LnN5c3RlbSgpCiAgICAgICAgIGlmIHN5c3RlbV9uYW1lID09ICJEYXJ3aW4iOgogICAgICAgICAg ICAgdm1fc3RhdF9vdXRwdXQgPSBzZWxmLl9leGVjdXRpdmUucnVuX2NvbW1hbmQoWyJ2bV9zdGF0 Il0pCi0gICAgICAgICAgICByZXR1cm4gc2VsZi5fY29tcHV0ZV9mcmVlX2J5dGVzX2Zyb21fdm1f c3RhdF9vdXRwdXQodm1fc3RhdF9vdXRwdXQpCisgICAgICAgICAgICBmcmVlX2J5dGVzID0gc2Vs Zi5fY29tcHV0ZV9ieXRlc19mcm9tX3ZtX3N0YXRfb3V0cHV0KCJQYWdlcyBmcmVlIiwgdm1fc3Rh dF9vdXRwdXQpCisgICAgICAgICAgICAjIFBlciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NzQ2NTAgaW5jbHVkZSBpbmFjdGl2ZSBtZW1vcnkgc2luY2UgdGhlIE9TIGlz IGxhenkgYWJvdXQgZnJlZWluZyBtZW1vcnkuCisgICAgICAgICAgICBmcmVlX2J5dGVzICs9IHNl bGYuX2NvbXB1dGVfYnl0ZXNfZnJvbV92bV9zdGF0X291dHB1dCgiUGFnZXMgaW5hY3RpdmUiLCB2 bV9zdGF0X291dHB1dCkKKyAgICAgICAgICAgIHJldHVybiBmcmVlX2J5dGVzCiAgICAgICAgIHJl dHVybiBOb25lCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Jhc2UucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Jhc2UucHkKaW5kZXggODUxMTQ0MDAyNTE5MDYyODRiZDEwYTNmNDljNzVjZjA5NWRiNzk2ZS4u M2QxN2I5NDQwNTE5YmFkMGZmN2U5ZDEzMTc2NDNlMTUxYmFhMTQwNCAxMDA3NTUKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weQpAQCAtMTY5LDcgKzE2 OSw3IEBAIGNsYXNzIFBvcnQob2JqZWN0KToKICAgICAgICAgZnJlZV9tZW1vcnkgPSBzZWxmLmhv c3QucGxhdGZvcm0uZnJlZV9ieXRlc19tZW1vcnkoKQogICAgICAgICBpZiBmcmVlX21lbW9yeToK ICAgICAgICAgICAgIGJ5dGVzX3Blcl9kcnQgPSAyMDAgKiAxMDI0ICogMTAyNCAgIyBBc3N1bWUg ZWFjaCBEUlQgbmVlZHMgMjAwTUIgdG8gcnVuLgotICAgICAgICAgICAgc3VwcG9ydGFibGVfaW5z dGFuY2VzID0gZnJlZV9tZW1vcnkgLyBieXRlc19wZXJfZHJ0CisgICAgICAgICAgICBzdXBwb3J0 YWJsZV9pbnN0YW5jZXMgPSBtYXgoZnJlZV9tZW1vcnkgLyBieXRlc19wZXJfZHJ0LCAxKSAgIyBB bHdheXMgdXNlIG9uZSBwcm9jZXNzLCBldmVuIGlmIHdlIGRvbid0IGhhdmUgc3BhY2UgZm9yIGl0 LgogICAgICAgICAgICAgaWYgc3VwcG9ydGFibGVfaW5zdGFuY2VzIDwgY3B1X2NvdW50OgogICAg ICAgICAgICAgICAgICMgRklYTUU6IFRoZSBQcmludGVyIGlzbid0IGluaXRpYWxpemVkIHdoZW4g dGhpcyBpcyBjYWxsZWQsIHNvIHVzaW5nIF9sb2cgd291bGQganVzdCBzaG93IGFuIHVuaXRpYWxp emVkIGxvZ2dlciBlcnJvci4KICAgICAgICAgICAgICAgICBwcmludCAiVGhpcyBtYWNoaW5lIGNv dWxkIHN1cHBvcnQgJXMgY2hpbGQgcHJvY2Vzc2VzLCBidXQgb25seSBoYXMgZW5vdWdoIG1lbW9y eSBmb3IgJXMuIiAlIChjcHVfY291bnQsIHN1cHBvcnRhYmxlX2luc3RhbmNlcykKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZV91bml0dGVz dC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZV91bml0 dGVzdC5weQppbmRleCAyNGM2ZmM5OGNkMWU5YmIyMmQwNGE3NGYyYWUzYmI2ZjZjZjg4OWE1Li4y ZmRjZDgwYzIyNTBjOTYzOGQyMWEyNTE1YTljODllN2U3ODdmZmE5IDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2VfdW5pdHRlc3QucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlX3VuaXR0ZXN0 LnB5CkBAIC02NSwxMCArNjUsMTEgQEAgY2xhc3MgUG9ydFRlc3QodW5pdHRlc3QuVGVzdENhc2Up OgogICAgICAgICBjaGlsZF9wcm9jZXNzZXMgPSBPdXRwdXRDYXB0dXJlKCkuYXNzZXJ0X291dHB1 dHMoc2VsZiwgcG9ydC5kZWZhdWx0X2NoaWxkX3Byb2Nlc3NlcywgKCksIGV4cGVjdGVkX3N0ZG91 dD1leHBlY3RlZF9zdGRvdXQpCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoY2hpbGRfcHJvY2Vz c2VzLCAxKQogCisgICAgICAgICMgTWFrZSBzdXJlIHRoYXQgd2UgYWx3YXlzIHVzZSBvbmUgcHJv Y2VzcywgZXZlbiBpZiB3ZSBkb24ndCBoYXZlIHRoZSBtZW1vcnkgZm9yIGl0LgogICAgICAgICBw b3J0Lmhvc3QucGxhdGZvcm0uZnJlZV9ieXRlc19tZW1vcnkgPSBsYW1iZGE6IGJ5dGVzX2Zvcl9k cnQgLSAxCi0gICAgICAgIGV4cGVjdGVkX3N0ZG91dCA9ICJUaGlzIG1hY2hpbmUgY291bGQgc3Vw cG9ydCAyIGNoaWxkIHByb2Nlc3NlcywgYnV0IG9ubHkgaGFzIGVub3VnaCBtZW1vcnkgZm9yIDAu XG4iCisgICAgICAgIGV4cGVjdGVkX3N0ZG91dCA9ICJUaGlzIG1hY2hpbmUgY291bGQgc3VwcG9y dCAyIGNoaWxkIHByb2Nlc3NlcywgYnV0IG9ubHkgaGFzIGVub3VnaCBtZW1vcnkgZm9yIDEuXG4i CiAgICAgICAgIGNoaWxkX3Byb2Nlc3NlcyA9IE91dHB1dENhcHR1cmUoKS5hc3NlcnRfb3V0cHV0 cyhzZWxmLCBwb3J0LmRlZmF1bHRfY2hpbGRfcHJvY2Vzc2VzLCAoKSwgZXhwZWN0ZWRfc3Rkb3V0 PWV4cGVjdGVkX3N0ZG91dCkKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChjaGlsZF9wcm9jZXNz ZXMsIDApCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwoY2hpbGRfcHJvY2Vzc2VzLCAxKQogCiAg ICAgZGVmIHRlc3RfZm9ybWF0X3dkaWZmX291dHB1dF9hc19odG1sKHNlbGYpOgogICAgICAgICBv dXRwdXQgPSAiT1VUUFVUICVzICVzICVzIiAlIChQb3J0Ll9XRElGRl9ERUwsIFBvcnQuX1dESUZG X0FERCwgUG9ydC5fV0RJRkZfRU5EKQo=