74638 2011-12-15 12:07:22 -0800 Make Element::setAttributeInternal inline in an attempt to avoid function call overhead 2011-12-15 20:19:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adamk adamk rniwa webkit.review.bot oldest_to_newest 522125 0 adamk 2011-12-15 12:07:22 -0800 Make Element::setAttributeInternal inline in an attempt to avoid function call overhead 522129 1 119479 adamk 2011-12-15 12:11:33 -0800 Created attachment 119479 Patch 522131 2 adamk 2011-12-15 12:13:38 -0800 See also the Chromium perf bots: http://build.chromium.org/f/chromium/perf/linux-release-webkit-latest/dromaeo_domcore/report.html?history=500&rev=-1&graph=dom_attr_element_property___value Looking at the right half, the big drop was flipping ENABLE(MUTATION_OBSERVERS) to true. The uplift was Rafael's http://trac.webkit.org/changeset/102721. But in the meantime, I'd submitted http://trac.webkit.org/changeset/102695, which I suspect further regressed performance of the set-attribute-through-property case. 522474 3 119479 webkit.review.bot 2011-12-15 20:19:50 -0800 Comment on attachment 119479 Patch Clearing flags on attachment: 119479 Committed r103017: <http://trac.webkit.org/changeset/103017> 522475 4 webkit.review.bot 2011-12-15 20:19:54 -0800 All reviewed patches have been landed. Closing bug. 119479 2011-12-15 12:11:33 -0800 2011-12-15 20:19:50 -0800 Patch bug-74638-20111215121132.patch text/plain 1796 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyOTcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzE1N2FjZjI0YTk0NDhl ZjYwNTNmODkyNzBjMDBkZmUwYzc5Y2I4Yy4uNDJjN2U4NzJjMmNlM2Y4YjkxZTYyYzgyOWM5ZTY3 NTIwNTc4MGJjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDExLTEyLTE1ICBBZGFt IEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE1ha2UgRWxlbWVudDo6c2V0 QXR0cmlidXRlSW50ZXJuYWwgaW5saW5lIGluIGFuIGF0dGVtcHQgdG8gYXZvaWQgZnVuY3Rpb24g Y2FsbCBvdmVyaGVhZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NzQ2MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbiByMTAyNjk1LCBJIGZhY3RvcmVkIGNvbW1vbiBjb2RlIGluIHNldEF0dHJpYnV0ZSBp bnRvCisgICAgICAgIEVsZW1lbnQ6OnNldEF0dHJpYnV0ZUludGVybmFsLiBUaGlzIG1heSBoYXZl IGNhdXNlZCBhIHBlcmYgcmVncmVzc2lvbgorICAgICAgICBkdWUgdG8gdGhlIGV4dHJhIGZ1bmN0 aW9uIGNhbGwsIHdoaWNoIGlubGluaW5nIHNob3VsZCBlbGltaW5hdGUuCisKKyAgICAgICAgUnVu bmluZyBEcm9tYWVvIGxvY2FsbHkgc3VnZ2VzdHMgdGhhdCB0aGlzIHdpbGwgaW1wcm92ZSBwZXJm b3JtYW5jZQorICAgICAgICBieSB+OSUgb24gdGhlICJkb20tYXR0ciBlbGVtZW50LnByb3BlcnR5 ID0gdmFsdWUiIHRlc3QgKHdoaWNoIGFzc2lnbnMKKyAgICAgICAgYSB2YWx1ZSB0byBhbiBlbGVt ZW50J3MgaWQpLgorCisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RWxlbWVudDo6c2V0QXR0cmlidXRlSW50ZXJuYWwpOgorCiAyMDExLTEyLTE1ICBCcmFkeSBF aWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ2MzEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCAzZGY3 ZDMzNmNjMmIxNWVjYmJhMmYxODk2Y2E5NDhiOGFkZWY2Y2NlLi4xYjJiYjkwMTQyM2QwY2NhMjAz MDMzMjFmYTExMmY5MDk5ZGUwMWRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC02NDcsNyAr NjQ3LDcgQEAgdm9pZCBFbGVtZW50OjpzZXRBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYg bmFtZSwgY29uc3QgQXRvbWljU3RyaW5nJiB2YWx1ZSwKICAgICBzZXRBdHRyaWJ1dGVJbnRlcm5h bChvbGQsIG5hbWUsIHZhbHVlKTsKIH0KIAotdm9pZCBFbGVtZW50OjpzZXRBdHRyaWJ1dGVJbnRl cm5hbChBdHRyaWJ1dGUqIG9sZCwgY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29uc3QgQXRv bWljU3RyaW5nJiB2YWx1ZSkKK2lubGluZSB2b2lkIEVsZW1lbnQ6OnNldEF0dHJpYnV0ZUludGVy bmFsKEF0dHJpYnV0ZSogb2xkLCBjb25zdCBRdWFsaWZpZWROYW1lJiBuYW1lLCBjb25zdCBBdG9t aWNTdHJpbmcmIHZhbHVlKQogewogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgaWYgKCFpc1N5 bmNocm9uaXppbmdTdHlsZUF0dHJpYnV0ZSgpKQo=