74624 2011-12-15 10:44:52 -0800 Warnings fixes in Interpreter.cpp and PrivateExecute.cpp 2011-12-15 17:13:05 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 wingo webkit-unassigned barraclough ggaren webkit.review.bot oldest_to_newest 522040 0 wingo 2011-12-15 10:44:52 -0800 The patch to be attached fixes a couple of warnings in the debug-mode interpreter, and in wtf/PrivateExecute.cpp. 522044 1 119459 wingo 2011-12-15 10:46:46 -0800 Created attachment 119459 Patch 522305 2 119459 darin 2011-12-15 16:11:06 -0800 Comment on attachment 119459 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119459&action=review Looks fine. > Source/JavaScriptCore/wtf/ParallelJobsGeneric.cpp:69 > + if (s_threadPool->size() < static_cast<unsigned>(i) + 1U) I would have changed the loop variable to be unsigned instead of putting this cast here. 522365 3 119459 webkit.review.bot 2011-12-15 17:13:01 -0800 Comment on attachment 119459 Patch Clearing flags on attachment: 119459 Committed r103003: <http://trac.webkit.org/changeset/103003> 522366 4 webkit.review.bot 2011-12-15 17:13:05 -0800 All reviewed patches have been landed. Closing bug. 119459 2011-12-15 10:46:46 -0800 2011-12-15 17:13:01 -0800 Patch bug-74624-20111215194644.patch text/plain 3900 wingo U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyOTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm YTg0MTIyNmM3MjFjNzEyMzQ4NDg5MGMxNjhkMDc5YjU3MzY4YmE4Li44MTNlYjI3ZWZiNTkyNzUy MTViYzRkMDFkMjg5MzY2MTQyMjNhMTFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxMS0xMi0xNSAgQW5keSBXaW5nbyAgPHdpbmdvQGlnYWxpYS5jb20+CisK KyAgICAgICAgV2FybmluZ3MgZml4ZXMgaW4gSW50ZXJwcmV0ZXIuY3BwIGFuZCBQcml2YXRlRXhl Y3V0ZS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc0NjI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OkludGVycHJldGVy Ojpwcml2YXRlRXhlY3V0ZSk6IEZpeCB2YXJpYWJsZXMgdW51c2VkIGluCisgICAgICAgIHJlbGVh c2UgbW9kZS4KKyAgICAgICAgKiB3dGYvUGFyYWxsZWxKb2JzR2VuZXJpYy5jcHA6CisgICAgICAg IChXVEY6OlBhcmFsbGVsRW52aXJvbm1lbnQ6OlBhcmFsbGVsRW52aXJvbm1lbnQpOiBGaXgKKyAg ICAgICAgc2lnbmVkL3Vuc2lnbmVkIGNvbXBhcmlzb24gd2FybmluZywgd2l0aCBhIGNhc3QuCisK IDIwMTEtMTItMTQgIEFuZHkgV2luZ28gIDx3aW5nb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEFk ZCBFTkFCTEUoSEFSTU9OWSkgYW5kIC0taGFybW9ueQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKaW5kZXggNDliZmRkMDRmMzBjMjBjNTdi M2M1NzJhMzUwYmI5MzRmOGY4NDNkMi4uNzBhNDQzMmVhODhjOTczNjcwYTkzN2IxZDAxZGQxNDZk MzdjOGFlNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0lu dGVycHJldGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50 ZXJwcmV0ZXIuY3BwCkBAIC0yNjU1LDE3ICsyNjU1LDE3IEBAIEpTVmFsdWUgSW50ZXJwcmV0ZXI6 OnByaXZhdGVFeGVjdXRlKEV4ZWN1dGlvbkZsYWcgZmxhZywgUmVnaXN0ZXJGaWxlKiByZWdpc3Rl ckZpCiAgICAgICAgIFNjb3BlQ2hhaW5Ob2RlKiBzY29wZUNoYWluID0gY2FsbEZyYW1lLT5zY29w ZUNoYWluKCk7CiAgICAgICAgIFNjb3BlQ2hhaW5JdGVyYXRvciBpdGVyID0gc2NvcGVDaGFpbi0+ YmVnaW4oKTsKICAgICAgICAgU2NvcGVDaGFpbkl0ZXJhdG9yIGVuZCA9IHNjb3BlQ2hhaW4tPmVu ZCgpOwotICAgICAgICBBU1NFUlQoaXRlciAhPSBlbmQpOworICAgICAgICBBU1NFUlRfVU5VU0VE KGVuZCwgaXRlciAhPSBlbmQpOwogICAgICAgICBBU1NFUlQoY29kZUJsb2NrID09IGNhbGxGcmFt ZS0+Y29kZUJsb2NrKCkpOwogICAgICAgICBib29sIGNoZWNrVG9wTGV2ZWwgPSBjb2RlQmxvY2st PmNvZGVUeXBlKCkgPT0gRnVuY3Rpb25Db2RlICYmIGNvZGVCbG9jay0+bmVlZHNGdWxsU2NvcGVD aGFpbigpOwogICAgICAgICBBU1NFUlQoc2tpcCB8fCAhY2hlY2tUb3BMZXZlbCk7Ci0gICAgaWYg KGNoZWNrVG9wTGV2ZWwgJiYgc2tpcC0tKSB7CisgICAgICAgIGlmIChjaGVja1RvcExldmVsICYm IHNraXAtLSkgewogICAgICAgICAgICAgaWYgKGNhbGxGcmFtZS0+cihjb2RlQmxvY2stPmFjdGl2 YXRpb25SZWdpc3RlcigpKS5qc1ZhbHVlKCkpCiAgICAgICAgICAgICAgICAgKytpdGVyOwogICAg ICAgICB9CiAgICAgICAgIHdoaWxlIChza2lwLS0pIHsKICAgICAgICAgICAgICsraXRlcjsKLSAg ICAgICAgICAgIEFTU0VSVChpdGVyICE9IGVuZCk7CisgICAgICAgICAgICBBU1NFUlRfVU5VU0VE KGVuZCwgaXRlciAhPSBlbmQpOwogICAgICAgICB9CiAgICAgICAgIEFTU0VSVCgoKml0ZXIpLT5p c1ZhcmlhYmxlT2JqZWN0KCkpOwogICAgICAgICBKU1ZhcmlhYmxlT2JqZWN0KiBzY29wZSA9IHN0 YXRpY19jYXN0PEpTVmFyaWFibGVPYmplY3QqPihpdGVyLT5nZXQoKSk7CkBAIC0yNjg2LDE2ICsy Njg2LDE2IEBAIEpTVmFsdWUgSW50ZXJwcmV0ZXI6OnByaXZhdGVFeGVjdXRlKEV4ZWN1dGlvbkZs YWcgZmxhZywgUmVnaXN0ZXJGaWxlKiByZWdpc3RlckZpCiAgICAgICAgIFNjb3BlQ2hhaW5JdGVy YXRvciBpdGVyID0gc2NvcGVDaGFpbi0+YmVnaW4oKTsKICAgICAgICAgU2NvcGVDaGFpbkl0ZXJh dG9yIGVuZCA9IHNjb3BlQ2hhaW4tPmVuZCgpOwogICAgICAgICBBU1NFUlQoY29kZUJsb2NrID09 IGNhbGxGcmFtZS0+Y29kZUJsb2NrKCkpOwotICAgICAgICBBU1NFUlQoaXRlciAhPSBlbmQpOwor ICAgICAgICBBU1NFUlRfVU5VU0VEKGVuZCwgaXRlciAhPSBlbmQpOwogICAgICAgICBib29sIGNo ZWNrVG9wTGV2ZWwgPSBjb2RlQmxvY2stPmNvZGVUeXBlKCkgPT0gRnVuY3Rpb25Db2RlICYmIGNv ZGVCbG9jay0+bmVlZHNGdWxsU2NvcGVDaGFpbigpOwogICAgICAgICBBU1NFUlQoc2tpcCB8fCAh Y2hlY2tUb3BMZXZlbCk7Ci0gICAgaWYgKGNoZWNrVG9wTGV2ZWwgJiYgc2tpcC0tKSB7CisgICAg ICAgIGlmIChjaGVja1RvcExldmVsICYmIHNraXAtLSkgewogICAgICAgICAgICAgaWYgKGNhbGxG cmFtZS0+cihjb2RlQmxvY2stPmFjdGl2YXRpb25SZWdpc3RlcigpKS5qc1ZhbHVlKCkpCiAgICAg ICAgICAgICAgICAgKytpdGVyOwogICAgICAgICB9CiAgICAgICAgIHdoaWxlIChza2lwLS0pIHsK ICAgICAgICAgICAgICsraXRlcjsKLSAgICAgICAgICAgIEFTU0VSVChpdGVyICE9IGVuZCk7Cisg ICAgICAgICAgICBBU1NFUlRfVU5VU0VEKGVuZCwgaXRlciAhPSBlbmQpOwogICAgICAgICB9CiAK ICAgICAgICAgQVNTRVJUKCgqaXRlciktPmlzVmFyaWFibGVPYmplY3QoKSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BhcmFsbGVsSm9ic0dlbmVyaWMuY3BwIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QYXJhbGxlbEpvYnNHZW5lcmljLmNwcAppbmRleCAxMmVh ZjRlNjA0ZTljZmRhNTQwZTg3ZWExMTIyNTZmYzZhM2YyNjRhLi5iNjIwN2RjODhhMThkNTI2OTcz OTgzMDkxMzdmMzIzOGI0OTE0ZTk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d3RmL1BhcmFsbGVsSm9ic0dlbmVyaWMuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvUGFyYWxsZWxKb2JzR2VuZXJpYy5jcHAKQEAgLTY2LDcgKzY2LDcgQEAgUGFyYWxsZWxFbnZp cm9ubWVudDo6UGFyYWxsZWxFbnZpcm9ubWVudChUaHJlYWRGdW5jdGlvbiB0aHJlYWRGdW5jdGlv biwgc2l6ZV90IHMKICAgICBpbnQgbWF4TnVtYmVyT2ZOZXdUaHJlYWRzID0gcmVxdWVzdGVkSm9i TnVtYmVyIC0gMTsKIAogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgc19tYXhOdW1iZXJPZlBhcmFs bGVsVGhyZWFkcyAmJiBtX3RocmVhZHMuc2l6ZSgpIDwgc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KG1h eE51bWJlck9mTmV3VGhyZWFkcyk7ICsraSkgewotICAgICAgICBpZiAoc190aHJlYWRQb29sLT5z aXplKCkgPCBpICsgMSkKKyAgICAgICAgaWYgKHNfdGhyZWFkUG9vbC0+c2l6ZSgpIDwgc3RhdGlj X2Nhc3Q8dW5zaWduZWQ+KGkpICsgMVUpCiAgICAgICAgICAgICBzX3RocmVhZFBvb2wtPmFwcGVu ZChUaHJlYWRQcml2YXRlOjpjcmVhdGUoKSk7CiAKICAgICAgICAgaWYgKCgqc190aHJlYWRQb29s KVtpXS0+dHJ5TG9ja0Zvcih0aGlzKSkK