<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>74617</bug_id>
          
          <creation_ts>2011-12-15 09:56:18 -0800</creation_ts>
          <short_desc>[qt][wk2] MiniBrowser: Add pressed state for viewport info button</short_desc>
          <delta_ts>2011-12-15 16:32:48 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Brüning">michael.bruning</reporter>
          <assigned_to name="Michael Brüning">michael.bruning</assigned_to>
          <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>521988</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Brüning">michael.bruning</who>
    <bug_when>2011-12-15 09:56:18 -0800</bug_when>
    <thetext>The viewport info button should have the same color as the other buttons in MiniBrowser when the viewport panel is up.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>521993</commentid>
    <comment_count>1</comment_count>
      <attachid>119447</attachid>
    <who name="Michael Brüning">michael.bruning</who>
    <bug_when>2011-12-15 10:01:12 -0800</bug_when>
    <thetext>Created attachment 119447
Patch.

Added pressed state + rounded rect for viewport info button.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>522190</commentid>
    <comment_count>2</comment_count>
      <attachid>119447</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2011-12-15 13:21:16 -0800</bug_when>
    <thetext>Comment on attachment 119447
Patch.

I suppose this looks exactly like for the other buttons :-)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>522317</commentid>
    <comment_count>3</comment_count>
      <attachid>119447</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-12-15 16:32:44 -0800</bug_when>
    <thetext>Comment on attachment 119447
Patch.

Clearing flags on attachment: 119447

Committed r102996: &lt;http://trac.webkit.org/changeset/102996&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>522318</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-12-15 16:32:48 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>119447</attachid>
            <date>2011-12-15 10:01:12 -0800</date>
            <delta_ts>2011-12-15 16:32:44 -0800</delta_ts>
            <desc>Patch.</desc>
            <filename>0001-qt-wk2-MiniBrowser-Add-pressed-state-for-viewport-in.patch</filename>
            <type>text/plain</type>
            <size>1971</size>
            <attacher name="Michael Brüning">michael.bruning</attacher>
            
              <data encoding="base64">RnJvbSBkOTZiMGEwYmNlNDRjYzFiNTRkZTYxZmMyMzVmMTgxOTVjMmQ2ZDY0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWNoYWVsIEJydW5pbmcgPG1pY2hhZWwuYnJ1bmluZ0Bub2tp
YS5jb20+CkRhdGU6IFRodSwgMTUgRGVjIDIwMTEgMTg6NTk6MTcgKzAxMDAKU3ViamVjdDogW1BB
VENIXSBbcXRdW3drMl0gTWluaUJyb3dzZXI6IEFkZCBwcmVzc2VkIHN0YXRlIGZvciB2aWV3cG9y
dCBpbmZvIGJ1dHRvbi4KCmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03
NDYxNwoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgoqIE1pbmlCcm93c2VyL3F0L3FtbC9C
cm93c2VyV2luZG93LnFtbDogQWRkZWQgc3RhdGUgZGVwZW5kZW50IGNvbG9yaW5nCmZvciB2aWV3
cG9ydCBpbmZvIGJ1dHRvbiwgYWRqdXN0ZWQgaGVpZ2h0IGFuZCBhZGRlZCByb3VuZGVkIGNvcm5l
cnMuCi0tLQogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAx
MCArKysrKysrKysrCiBUb29scy9NaW5pQnJvd3Nlci9xdC9xbWwvQnJvd3NlcldpbmRvdy5xbWwg
fCAgICA1ICsrKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDIgZGVsZXRp
b25zKC0pCgpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmlu
ZGV4IDY1NGI4NzIuLmI4ZmY1ODQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U
b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0xMi0xNSAgTWljaGFlbCBCcnVu
aW5nICA8bWljaGFlbC5icnVuaW5nQG5va2lhLmNvbT4KKworICAgICAgICBbcXRdW3drMl0gTWlu
aUJyb3dzZXI6IEFkZCBwcmVzc2VkIHN0YXRlIGZvciB2aWV3cG9ydCBpbmZvIGJ1dHRvbi4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0NjE3CisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nl
ci9xdC9xbWwvQnJvd3NlcldpbmRvdy5xbWw6IEFkZGVkIHN0YXRlIGRlcGVuZGVudCBjb2xvcmlu
ZworICAgICAgICBmb3Igdmlld3BvcnQgaW5mbyBidXR0b24sIGFkanVzdGVkIGhlaWdodCBhbmQg
YWRkZWQgcm91bmRlZCBjb3JuZXJzLgorCiAyMDExLTEyLTE1ICBLZW5uZXRoIFJ1c3NlbGwgIDxr
YnJAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCBEUlQgc3VwcG9ydCBmb3Ig
V2ViS2l0UGFnZUNhY2hlU3VwcG9ydHNQbHVnaW5zUHJlZmVyZW5jZUtleQpkaWZmIC0tZ2l0IGEv
VG9vbHMvTWluaUJyb3dzZXIvcXQvcW1sL0Jyb3dzZXJXaW5kb3cucW1sIGIvVG9vbHMvTWluaUJy
b3dzZXIvcXQvcW1sL0Jyb3dzZXJXaW5kb3cucW1sCmluZGV4IDJkNmU2MjkuLjgyZDEwYjIgMTAw
NjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L3FtbC9Ccm93c2VyV2luZG93LnFtbAorKysg
Yi9Ub29scy9NaW5pQnJvd3Nlci9xdC9xbWwvQnJvd3NlcldpbmRvdy5xbWwKQEAgLTE2Myw5ICsx
NjMsMTAgQEAgUmVjdGFuZ2xlIHsKIAogICAgICAgICAgICAgUmVjdGFuZ2xlIHsKICAgICAgICAg
ICAgICAgICBpZDogdmlld3BvcnRJbmZvQnV0dG9uCi0gICAgICAgICAgICAgICAgaGVpZ2h0OiBu
YXZpZ2F0aW9uQmFyLmhlaWdodCAtIDIKKyAgICAgICAgICAgICAgICBoZWlnaHQ6IHBhcmVudC5o
ZWlnaHQKICAgICAgICAgICAgICAgICB3aWR0aDogaGVpZ2h0Ci0gICAgICAgICAgICAgICAgY29s
b3I6ICIjZWZlZmVmIgorICAgICAgICAgICAgICAgIGNvbG9yOiB7IHZpZXdwb3J0SW5mb0l0ZW0u
dmlzaWJsZSA/ICIjY2ZjZmNmIiA6ICIjZWZlZmVmIiB9CisgICAgICAgICAgICAgICAgcmFkaXVz
OiA2CiAKICAgICAgICAgICAgICAgICBJbWFnZSB7CiAgICAgICAgICAgICAgICAgICAgIGFuY2hv
cnMuY2VudGVySW46IHBhcmVudAotLSAKMS43LjQuMQoK
</data>

          </attachment>
      

    </bug>

</bugzilla>