74612 2011-12-15 09:01:23 -0800 Each worker separately logs its complaint about the directory I am in 2012-06-19 21:10:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED NRWT P2 Normal --- 1 darin webkit-unassigned dpranke eric oldest_to_newest 521941 0 darin 2011-12-15 09:01:23 -0800 When I run tests, I get this: The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource Starting 8 workers ...The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource The current directory (/Users/darin/Safari) is not a WebKit checkout, using /Users/darin/Safari/OpenSource I don’t need to see that log message 9 times. In fact, I’d prefer not to see it even once. 521996 1 eric 2011-12-15 10:06:52 -0800 Sure thing. Easy to fix. Just an unintented consequence of re-using single-process code in our new multi-process architecture. :) 522013 2 eric 2011-12-15 10:15:51 -0800 You'll likely want this when running webkit-patch apply-from-bug outside of a webkit directory, but not when running new-run-webkit-tests. Or at least not 7 times. :) Then again, it's possible it's not even useful when running webkit-patch from outside of a webkit directory. 522145 3 dpranke 2011-12-15 12:38:18 -0800 I agree w/ Darin; new-run-webkit-tests shouldn't be complaining about this at all by default, and it should definitely only be complaining once. Can we change scm/detection.py to provide a am_inside_the_checkout() function so that webkit-patch can call this separately and log the warning? 522152 4 eric 2011-12-15 12:43:19 -0800 (In reply to comment #3) > I agree w/ Darin; new-run-webkit-tests shouldn't be complaining about this at all by default, and it should definitely only be complaining once. Can we change scm/detection.py to provide a am_inside_the_checkout() function so that webkit-patch can call this separately and log the warning? Sounds like a good approach. I agree. webkit-patch should be specifically opting into this warning, instead of all SCM clients causing it. 653163 5 dpranke 2012-06-19 21:10:01 -0700 I think this was fixed in r120646. Please let me know if you're still seeing an issue.