74597 2011-12-15 02:49:37 -0800 [Chromium] Enable TestNetscapePlugIn to link for Android 2011-12-15 04:35:47 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66689 1 peter peter abarth jrg tonyg webkit.review.bot oldest_to_newest 521775 0 peter 2011-12-15 02:49:37 -0800 [Chromium] Enable TestNetscapePlugIn to link 521777 1 119404 peter 2011-12-15 02:52:43 -0800 Created attachment 119404 Patch 521778 2 peter 2011-12-15 02:56:08 -0800 After this change, TestNetscapePlugIn.so will be able to link, bringing us up to 2 out of 5 targets. The flag is being set for all targets by this line in common.gypi, this is intentional: http://codesearch.google.com/#OAMlx_jo-ck/src/build/common.gypi&exact_package=chromium&q=common.gypi&type=cs&l=2090 Build errors related to this target (unable to locate crtbegin_so.o) were fixed upstream in the following commit, which has landed in WebKit via the roll yesterday. http://src.chromium.org/viewvc/chrome?view=rev&revision=114216 521781 3 119404 peter 2011-12-15 03:02:46 -0800 Comment on attachment 119404 Patch Thank you! 521828 4 119404 webkit.review.bot 2011-12-15 04:35:43 -0800 Comment on attachment 119404 Patch Clearing flags on attachment: 119404 Committed r102921: <http://trac.webkit.org/changeset/102921> 521829 5 webkit.review.bot 2011-12-15 04:35:47 -0800 All reviewed patches have been landed. Closing bug. 119404 2011-12-15 02:52:43 -0800 2011-12-15 04:35:43 -0800 Patch bug-74597-20111215105241.patch text/plain 1658 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyOTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDI5OTBkYzdkMmExNzQ1MjZmY2Q5OTExMDlmMzYyM2RmZGM4ZDc3YzcuLmE4N2ViODZkNDVlOGI5 NjM1YTM1ZGNkMTVhNGVmMWFhZTE5Y2Y1N2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMTItMTUgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRW5hYmxlIFRlc3ROZXRzY2FwZVBsdWdJbiB0 byBsaW5rIGZvciBBbmRyb2lkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NDU5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSAtbm9zdGRsaWIgbGlua2VyIGZsYWcgaXMgYmVpbmcgcGFzc2VkIHRvIGFs bCB0YXJnZXRzIGJlaW5nIGJ1aWxkCisgICAgICAgIGZvciBBbmRyb2lkLCB3aGljaCBjb25mbGlj dHMgd2l0aCB0aGUgc2hhcmVkIGxpYnJhcnkgdGhlCisgICAgICAgIFRlc3ROZXRzY2FwZVBsdWdJ biB0YXJnZXQgY3JlYXRlZC4gRXhwbGljaXRseSBleGNsdWRlIHRoZSBmbGFnLgorCisgICAgICAg ICogV2ViS2l0Lmd5cDoKKwogMjAxMS0xMi0xNCAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBEYXRhYmFzZU9ic2VydmVyIG5lZWRzIHRocmVh ZHNhZmUgZml4ZXMgYW5kIG90aGVyIGNsZWFuLXVwLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9XZWJLaXQuZ3lwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lw CmluZGV4IDlhODNmYmZlNTAxMzIwZTFjOGQ4MzYxMTVlYTBhNjMzZTIzMDhkYzkuLjZjZjI5ODBk YzQ3NTFkYTdlOTNiMzRkNDU5M2RiYjc5YzNiNTRjMjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vV2ViS2l0Lmd5cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktp dC5neXAKQEAgLTE0NTIsNiArMTQ1MiwxMSBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAnLWZ2aXNpYmlsaXR5PWRlZmF1bHQnLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg IF0sCiAgICAgICAgICAgICAgICAgICAgICAgICB9XSwKKyAgICAgICAgICAgICAgICAgICAgICAg IFsnT1M9PSJhbmRyb2lkIicsIHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAnbGRmbGFn cyEnOiBbCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICctbm9zdGRsaWInLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgIF0sCisgICAgICAgICAgICAgICAgICAgICAgICB9XSwK ICAgICAgICAgICAgICAgICAgICAgICAgIFsnT1M9PSJ3aW4iJywgewogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICdkZWZpbmVzJzogWwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAjIFRoaXMgc2VlbXMgbGlrZSBhIGhhY2ssIGJ1dCB0aGlzIGlzIHdoYXQgU2FmYXJpIFdpbiBk b2VzLgo=