74588 2011-12-14 22:52:31 -0800 [Qt] Remove unnecessary methods and members from DeviceOrientationClientQt 2011-12-15 02:58:36 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ahf ahf kenneth webkit.review.bot oldest_to_newest 521684 0 ahf 2011-12-14 22:52:31 -0800 Currently we save a pointer to the DeviceOrientationController and we have an unused method: changeDeviceOrientation(). 521693 1 119383 ahf 2011-12-14 23:01:57 -0800 Created attachment 119383 Patch 521694 2 ahf 2011-12-14 23:02:48 -0800 Adding Kenneth. 521779 3 119383 webkit.review.bot 2011-12-15 02:58:31 -0800 Comment on attachment 119383 Patch Clearing flags on attachment: 119383 Committed r102912: <http://trac.webkit.org/changeset/102912> 521780 4 webkit.review.bot 2011-12-15 02:58:36 -0800 All reviewed patches have been landed. Closing bug. 119383 2011-12-14 23:01:57 -0800 2011-12-15 02:58:31 -0800 Patch bug-74588-20111215080154.patch text/plain 3207 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDU2NWRkOTNjYTRl NDI3MmQ5ZWVjNDRmNTJhMjhmOTViZThkOTVlMjYuLmQ4YTI0MTBkMGM4YWNmNzI0ODJiOTVmZTVj ZjIyMTVmNTk5YWE0MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMTIt MTQgIEFsZXhhbmRlciBGw6Zyw7h5ICA8YWhmQDB4OTAuZGs+CisKKyAgICAgICAgW1F0XSBSZW1v dmUgdW5uZWNlc3NhcnkgbWV0aG9kcyBhbmQgbWVtYmVycyBmcm9tIERldmljZU9yaWVudGF0aW9u Q2xpZW50UXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTc0NTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVtb3ZlIHRoZSB1bnVzZWQgbWV0aG9kIGNoYW5nZURldmljZU9yaWVudGF0aW9uKCkgZnJvbQor ICAgICAgICBEZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0IGFuZCByZW1vdmUgdGhlIERldmljZU9y aWVudGF0aW9uQ29udHJvbGxlcgorICAgICAgICBtZW1iZXIgc2luY2UgaXQgaXMgdW51c2VkLgor CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRGV2aWNlT3JpZW50YXRpb25DbGllbnRRdC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0OjpEZXZpY2VPcmll bnRhdGlvbkNsaWVudFF0KToKKyAgICAgICAgKFdlYkNvcmU6OkRldmljZU9yaWVudGF0aW9uQ2xp ZW50UXQ6OnNldENvbnRyb2xsZXIpOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0RldmljZU9y aWVudGF0aW9uQ2xpZW50UXQuaDoKKwogMjAxMS0xMi0xNCAgQWxleGFuZGVyIEbDpnLDuHkgIDxh bGV4YW5kZXIuZmFlcm95QG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZpeCBjb21waWxhdGlv biBvZiBRdFdlYktpdCB3aXRoIC0tb3JpZW50YXRpb24tZXZlbnRzIHdpdGhvdXQgRU5BQkxFX0RF VklDRV9PUklFTlRBVElPTgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3Vw cG9ydC9EZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvRGV2aWNlT3JpZW50YXRpb25DbGllbnRRdC5jcHAKaW5kZXggODJmOWI3Zjlh NjM4NWU0ZGE5YTQ2NDQ4OGEyOWVhYmE1OTliOTVlNi4uZWU3OTQyMjEwYTMyZWJlODU5MmE5ZGQ3 YTdlYjcwZmFmOTUyYzcxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3Vw cG9ydC9EZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L0RldmljZU9yaWVudGF0aW9uQ2xpZW50UXQuY3BwCkBAIC0xOSwxNSAr MTksMTIgQEAKICAqLwogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkRldmljZU9yaWVu dGF0aW9uQ2xpZW50UXQuaCIKLQotI2luY2x1ZGUgIkRldmljZU9yaWVudGF0aW9uQ29udHJvbGxl ci5oIgogI2luY2x1ZGUgIkRldmljZU9yaWVudGF0aW9uUHJvdmlkZXJRdC5oIgogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIERldmljZU9yaWVudGF0aW9uQ2xpZW50UXQ6OkRldmljZU9yaWVudGF0 aW9uQ2xpZW50UXQoKQotICAgIDogbV9jb250cm9sbGVyKDApCi0gICAgLCBtX3Byb3ZpZGVyKG5l dyBEZXZpY2VPcmllbnRhdGlvblByb3ZpZGVyUXQoKSkKKyAgICA6IG1fcHJvdmlkZXIobmV3IERl dmljZU9yaWVudGF0aW9uUHJvdmlkZXJRdCkKIHsKIH0KIApAQCAtMzgsNyArMzUsNyBAQCBEZXZp Y2VPcmllbnRhdGlvbkNsaWVudFF0Ojp+RGV2aWNlT3JpZW50YXRpb25DbGllbnRRdCgpCiAKIHZv aWQgRGV2aWNlT3JpZW50YXRpb25DbGllbnRRdDo6c2V0Q29udHJvbGxlcihEZXZpY2VPcmllbnRh dGlvbkNvbnRyb2xsZXIqIGNvbnRyb2xsZXIpCiB7Ci0gICAgbV9jb250cm9sbGVyID0gY29udHJv bGxlcjsKKyAgICBtX3Byb3ZpZGVyLT5zZXRDb250cm9sbGVyKGNvbnRyb2xsZXIpOwogfQogCiB2 b2lkIERldmljZU9yaWVudGF0aW9uQ2xpZW50UXQ6OnN0YXJ0VXBkYXRpbmcoKQpAQCAtNjEsMTIg KzU4LDQgQEAgdm9pZCBEZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0OjpkZXZpY2VPcmllbnRhdGlv bkNvbnRyb2xsZXJEZXN0cm95ZWQoKQogICAgIGRlbGV0ZSB0aGlzOwogfQogCi12b2lkIERldmlj ZU9yaWVudGF0aW9uQ2xpZW50UXQ6OmNoYW5nZURldmljZU9yaWVudGF0aW9uKERldmljZU9yaWVu dGF0aW9uKiBvcmllbnRhdGlvbikKLXsKLSAgICBpZiAoIW1fY29udHJvbGxlcikKLSAgICAgICAg cmV0dXJuOwotCi0gICAgbV9jb250cm9sbGVyLT5kaWRDaGFuZ2VEZXZpY2VPcmllbnRhdGlvbihv cmllbnRhdGlvbik7Ci19Ci0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRGV2aWNlT3JpZW50YXRpb25DbGllbnRRdC5o IGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EZXZpY2VPcmllbnRhdGlvbkNsaWVu dFF0LmgKaW5kZXggNDE3NDIwZTI1YzU2ZmNiODBmOWMyOThjMGU2NGEwMTZjNGZlNmJiNi4uOGI4 NDQxZTBmYjlkMzJhMWU4MmRiMDM3M2Q4NzE0ODAxYmQ4MWI2NCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0LmgKKysr IGIvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EZXZpY2VPcmllbnRhdGlvbkNsaWVu dFF0LmgKQEAgLTM3LDEwICszNyw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc3RvcFVw ZGF0aW5nKCk7CiAgICAgdmlydHVhbCBEZXZpY2VPcmllbnRhdGlvbiogbGFzdE9yaWVudGF0aW9u KCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIGRldmljZU9yaWVudGF0aW9uQ29udHJvbGxlckRl c3Ryb3llZCgpOwotICAgIHZpcnR1YWwgdm9pZCBjaGFuZ2VEZXZpY2VPcmllbnRhdGlvbihEZXZp Y2VPcmllbnRhdGlvbiopOwogCiBwcml2YXRlOgotICAgIERldmljZU9yaWVudGF0aW9uQ29udHJv bGxlciogbV9jb250cm9sbGVyOwogICAgIERldmljZU9yaWVudGF0aW9uUHJvdmlkZXJRdCogbV9w cm92aWRlcjsKIH07CiAK