74581 2011-12-14 19:49:09 -0800 [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey 2011-12-15 09:52:11 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 13634 1 kbr kbr beidson fishd morrita tkent tony webkit.review.bot oldest_to_newest 521591 0 kbr 2011-12-14 19:49:09 -0800 Bug 13634 added a new key that can be overridden by the LayoutTestController. The Chromium port needs support in order to pass new tests that are added. 521597 1 119365 kbr 2011-12-14 20:01:54 -0800 Created attachment 119365 Patch 521599 2 kbr 2011-12-14 20:02:53 -0800 Not sure who's worked on DRT plugin support. 521601 3 webkit.review.bot 2011-12-14 20:07:47 -0800 Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API. 521612 4 119365 tkent 2011-12-14 20:31:29 -0800 Comment on attachment 119365 Patch The DRT change looks ok. 521650 5 tkent 2011-12-14 21:58:56 -0800 *** Bug 74584 has been marked as a duplicate of this bug. *** 521979 6 kbr 2011-12-15 09:52:11 -0800 Committed r102950: <http://trac.webkit.org/changeset/102950> 119365 2011-12-14 20:01:54 -0800 2011-12-14 21:16:51 -0800 Patch bug-74581-20111214200153.patch text/plain 7342 kbr SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMDI4NzMpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1 IEBACisyMDExLTEyLTE0ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KKworICAg ICAgICBbY2hyb21pdW1dIEFkZCBEUlQgc3VwcG9ydCBmb3IgV2ViS2l0UGFnZUNhY2hlU3VwcG9y dHNQbHVnaW5zUHJlZmVyZW5jZUtleQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NzQ1ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIHB1YmxpYy9XZWJTZXR0aW5ncy5oOgorICAgICAgICAqIHNyYy9XZWJT ZXR0aW5nc0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTZXR0aW5nc0ltcGw6OnNldFBh Z2VDYWNoZVN1cHBvcnRzUGx1Z2lucyk6CisgICAgICAgICogc3JjL1dlYlNldHRpbmdzSW1wbC5o OgorCiAyMDExLTEyLTE0ICBLZW5pY2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbQ2hyb21pdW1dIEltcGxlbWVudCBQbHVnaW5WaWV3QmFzZTo6Z2V0Rm9ybVZh bHVlCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZXR0aW5ncy5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNldHRpbmdzLmgJ KHJldmlzaW9uIDEwMjg3MCkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNl dHRpbmdzLmgJKHdvcmtpbmcgY29weSkKQEAgLTgwLDYgKzgwLDcgQEAgcHVibGljOgogICAgIHZp cnR1YWwgdm9pZCBzZXRVc2VyU3R5bGVTaGVldExvY2F0aW9uKGNvbnN0IFdlYlVSTCYpID0gMDsK ICAgICB2aXJ0dWFsIHZvaWQgc2V0QXV0aG9yQW5kVXNlclN0eWxlc0VuYWJsZWQoYm9vbCkgPSAw OwogICAgIHZpcnR1YWwgdm9pZCBzZXRVc2VzUGFnZUNhY2hlKGJvb2wpID0gMDsKKyAgICB2aXJ0 dWFsIHZvaWQgc2V0UGFnZUNhY2hlU3VwcG9ydHNQbHVnaW5zKGJvb2wpID0gMDsKICAgICB2aXJ0 dWFsIHZvaWQgc2V0RG93bmxvYWRhYmxlQmluYXJ5Rm9udHNFbmFibGVkKGJvb2wpID0gMDsKICAg ICB2aXJ0dWFsIHZvaWQgc2V0SmF2YVNjcmlwdENhbkFjY2Vzc0NsaXBib2FyZChib29sKSA9IDA7 CiAgICAgdmlydHVhbCB2b2lkIHNldFhTU0F1ZGl0b3JFbmFibGVkKGJvb2wpID0gMDsKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmNwcAkocmV2 aXNpb24gMTAyODcwKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJ bXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTk5LDYgKzE5OSwxMSBAQCB2b2lkIFdlYlNldHRp bmdzSW1wbDo6c2V0VXNlc1BhZ2VDYWNoZShiCiAgICAgbV9zZXR0aW5ncy0+c2V0VXNlc1BhZ2VD YWNoZSh1c2VzUGFnZUNhY2hlKTsKIH0KIAordm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldFBhZ2VD YWNoZVN1cHBvcnRzUGx1Z2lucyhib29sIHBhZ2VDYWNoZVN1cHBvcnRzUGx1Z2lucykKK3sKKyAg ICBtX3NldHRpbmdzLT5zZXRQYWdlQ2FjaGVTdXBwb3J0c1BsdWdpbnMocGFnZUNhY2hlU3VwcG9y dHNQbHVnaW5zKTsKK30KKwogdm9pZCBXZWJTZXR0aW5nc0ltcGw6OnNldERvd25sb2FkYWJsZUJp bmFyeUZvbnRzRW5hYmxlZChib29sIGVuYWJsZWQpCiB7CiAgICAgbV9zZXR0aW5ncy0+c2V0RG93 bmxvYWRhYmxlQmluYXJ5Rm9udHNFbmFibGVkKGVuYWJsZWQpOwpJbmRleDogU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViU2V0dGluZ3NJbXBsLmgJKHJldmlzaW9uIDEwMjg3MCkKKysr IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNldHRpbmdzSW1wbC5oCSh3b3JraW5nIGNv cHkpCkBAIC03Miw2ICs3Miw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgc2V0VXNlclN0 eWxlU2hlZXRMb2NhdGlvbihjb25zdCBXZWJVUkwmKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0QXV0 aG9yQW5kVXNlclN0eWxlc0VuYWJsZWQoYm9vbCk7CiAgICAgdmlydHVhbCB2b2lkIHNldFVzZXNQ YWdlQ2FjaGUoYm9vbCk7CisgICAgdmlydHVhbCB2b2lkIHNldFBhZ2VDYWNoZVN1cHBvcnRzUGx1 Z2lucyhib29sKTsKICAgICB2aXJ0dWFsIHZvaWQgc2V0RG93bmxvYWRhYmxlQmluYXJ5Rm9udHNF bmFibGVkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRKYXZhU2NyaXB0Q2FuQWNjZXNzQ2xp cGJvYXJkKGJvb2wpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRYU1NBdWRpdG9yRW5hYmxlZChib29s KTsKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDEwMjg3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE3IEBACisyMDExLTEyLTE0ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNv bT4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBEUlQgc3VwcG9ydCBmb3IgV2ViS2l0UGFnZUNh Y2hlU3VwcG9ydHNQbHVnaW5zUHJlZmVyZW5jZUtleQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ1ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRl c3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpvdmVycmlk ZVByZWZlcmVuY2UpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlByZWZl cmVuY2VzLmNwcDoKKyAgICAgICAgKFdlYlByZWZlcmVuY2VzOjpyZXNldCk6CisgICAgICAgIChX ZWJQcmVmZXJlbmNlczo6YXBwbHlUbyk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21p dW0vV2ViUHJlZmVyZW5jZXMuaDoKKwogMjAxMS0xMi0xNCAgU2FtIFdlaW5pZyAgPHdlaW5pZ0Bh cHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHdoaXRlc3BhY2UgZnJvbSBJbmhlcml0ZWRQcm9w ZXJ0eVNoZWV0cyBhdHRyaWJ1dGVzIGluCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJv bWl1bS9MYXlvdXRUZXN0Q29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiAxMDI4 NzApCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxl ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0ODYsNiArMTQ4Niw4IEBAIHZvaWQgTGF5b3V0VGVz dENvbnRyb2xsZXI6Om92ZXJyaWRlUHJlZmUKICAgICAgICAgcHJlZnMtPmphdmFFbmFibGVkID0g Y3BwVmFyaWFudFRvQm9vbCh2YWx1ZSk7CiAgICAgZWxzZSBpZiAoa2V5ID09ICJXZWJLaXRVc2Vz UGFnZUNhY2hlUHJlZmVyZW5jZUtleSIpCiAgICAgICAgIHByZWZzLT51c2VzUGFnZUNhY2hlID0g Y3BwVmFyaWFudFRvQm9vbCh2YWx1ZSk7CisgICAgZWxzZSBpZiAoa2V5ID09ICJXZWJLaXRQYWdl Q2FjaGVTdXBwb3J0c1BsdWdpbnNQcmVmZXJlbmNlS2V5IikKKyAgICAgICAgcHJlZnMtPnBhZ2VD YWNoZVN1cHBvcnRzUGx1Z2lucyA9IGNwcFZhcmlhbnRUb0Jvb2wodmFsdWUpOwogICAgIGVsc2Ug aWYgKGtleSA9PSAiV2ViS2l0SmF2YVNjcmlwdENhbkFjY2Vzc0NsaXBib2FyZCIpCiAgICAgICAg IHByZWZzLT5qYXZhU2NyaXB0Q2FuQWNjZXNzQ2xpcGJvYXJkID0gY3BwVmFyaWFudFRvQm9vbCh2 YWx1ZSk7CiAgICAgZWxzZSBpZiAoa2V5ID09ICJXZWJLaXRYU1NBdWRpdG9yRW5hYmxlZCIpCklu ZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJQcmVmZXJlbmNlcy5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViUHJlZmVyZW5jZXMu Y3BwCShyZXZpc2lvbiAxMDI4NzApCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9X ZWJQcmVmZXJlbmNlcy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTkyLDYgKzkyLDcgQEAgdm9pZCBX ZWJQcmVmZXJlbmNlczo6cmVzZXQoKQogICAgIHRleHRBcmVhc0FyZVJlc2l6YWJsZSA9IGZhbHNl OwogICAgIHVzZXJTdHlsZVNoZWV0TG9jYXRpb24gPSBXZWJVUkwoKTsKICAgICB1c2VzUGFnZUNh Y2hlID0gZmFsc2U7CisgICAgcGFnZUNhY2hlU3VwcG9ydHNQbHVnaW5zID0gZmFsc2U7CiAgICAg d2ViU2VjdXJpdHlFbmFibGVkID0gdHJ1ZTsKICAgICBjYXJldEJyb3dzaW5nRW5hYmxlZCA9IGZh bHNlOwogCkBAIC0yMDMsNiArMjA0LDcgQEAgdm9pZCBXZWJQcmVmZXJlbmNlczo6YXBwbHlUbyhX ZWJWaWV3KiB3ZQogICAgIHNldHRpbmdzLT5zZXRUZXh0QXJlYXNBcmVSZXNpemFibGUodGV4dEFy ZWFzQXJlUmVzaXphYmxlKTsKICAgICBzZXR0aW5ncy0+c2V0VXNlclN0eWxlU2hlZXRMb2NhdGlv bih1c2VyU3R5bGVTaGVldExvY2F0aW9uKTsKICAgICBzZXR0aW5ncy0+c2V0VXNlc1BhZ2VDYWNo ZSh1c2VzUGFnZUNhY2hlKTsKKyAgICBzZXR0aW5ncy0+c2V0UGFnZUNhY2hlU3VwcG9ydHNQbHVn aW5zKHBhZ2VDYWNoZVN1cHBvcnRzUGx1Z2lucyk7CiAgICAgc2V0dGluZ3MtPnNldFdlYlNlY3Vy aXR5RW5hYmxlZCh3ZWJTZWN1cml0eUVuYWJsZWQpOwogICAgIHNldHRpbmdzLT5zZXRBbGxvd1Vu aXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJMcyhhbGxvd1VuaXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJM cyk7CiAgICAgc2V0dGluZ3MtPnNldEVkaXRpbmdCZWhhdmlvcihlZGl0aW5nQmVoYXZpb3IpOwpJ bmRleDogVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViUHJlZmVyZW5jZXMuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJQcmVmZXJlbmNlcy5o CShyZXZpc2lvbiAxMDI4NzApCisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJQ cmVmZXJlbmNlcy5oCSh3b3JraW5nIGNvcHkpCkBAIC05NCw2ICs5NCw3IEBAIHN0cnVjdCBXZWJQ cmVmZXJlbmNlcyB7CiAgICAgYm9vbCB0ZXh0QXJlYXNBcmVSZXNpemFibGU7CiAgICAgV2ViS2l0 OjpXZWJVUkwgdXNlclN0eWxlU2hlZXRMb2NhdGlvbjsKICAgICBib29sIHVzZXNQYWdlQ2FjaGU7 CisgICAgYm9vbCBwYWdlQ2FjaGVTdXBwb3J0c1BsdWdpbnM7CiAgICAgYm9vbCB3ZWJTZWN1cml0 eUVuYWJsZWQ7CiAgICAgYm9vbCBhbGxvd1VuaXZlcnNhbEFjY2Vzc0Zyb21GaWxlVVJMczsKICAg ICBXZWJLaXQ6OldlYlNldHRpbmdzOjpFZGl0aW5nQmVoYXZpb3IgZWRpdGluZ0JlaGF2aW9yOwpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gMTAyODczKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTItMTQgIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIERSVCBzdXBwb3J0IGZv ciBXZWJLaXRQYWdlQ2FjaGVTdXBwb3J0c1BsdWdpbnNQcmVmZXJlbmNlS2V5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDU4MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcCBvbmUgdGVzdCB3aGlj aCBub3cgcGFzc2VzLiBUaGUgb3RoZXIgb25lIHdpbGwgY29udGludWUgdG8KKyAgICAgICAgYmUg Y292ZXJlZCB1bmRlciB0aGUgb3RoZXIgYnVnLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21p dW0vdGVzdF9leHBlY3RhdGlvbnMudHh0OgorCiAyMDExLTEyLTE0ICBIYWppbWUgTW9ycml0YSAg PG1vcnJpdGFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZXhwZWN0YXRpb24g dXBkYXRlLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3Rh dGlvbnMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rl c3RfZXhwZWN0YXRpb25zLnR4dAkocmV2aXNpb24gMTAyODcwKQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC00 MDAwLDcgKzQwMDAsNiBAQCBCVUdXSzc0MTY3IFdJTiBMSU5VWCA6IGZhc3QvcmVwbGFjZWQvd2lk CiBCVUdXSzc0MzE3IExJTlVYIDogdHJhbnNpdGlvbnMvY3Jvc3MtZmFkZS1ib3JkZXItaW1hZ2Uu aHRtbCA9IFBBU1MgQ1JBU0gKIAogQlVHV0s3NDM1NyBTS0lQIDogcGx1Z2lucy9uZXRzY2FwZS1w bHVnaW4tcGFnZS1jYWNoZS13b3Jrcy5odG1sID0gVEVYVCBUSU1FT1VUCi1CVUdXSzc0MzU3IFNL SVAgOiBtZWRpYS9jcmFzaC1jbG9zaW5nLXBhZ2Utd2l0aC1tZWRpYS1hcy1wbHVnaW4tZmFsbGJh Y2suaHRtbCA9IFRFWFQKIAogQlVHV0s3NDM3NCBXSU4gOiBmYXN0L2Zvcm1zL3NlbGVjdC1saXN0 Ym94LW11bHRpcGxlLW5vLWZvY3VzcmluZy5odG1sID0gUEFTUyBJTUFHRQogCg==