74556 2011-12-14 16:29:24 -0800 webkitpy: clean up TestPort to (mostly) not create a new filesystem 2011-12-15 19:41:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74551 74138 74562 74566 1 dpranke dpranke abarth eric ojan tony oldest_to_newest 521441 0 dpranke 2011-12-14 16:29:24 -0800 webkitpy: clean up TestPort to (mostly) not create a new filesystem 521460 1 119330 dpranke 2011-12-14 16:43:01 -0800 Created attachment 119330 Patch 521463 2 dpranke 2011-12-14 16:44:18 -0800 This is part of the Host/SystemHost/Port refactoring cleanup ... 521556 3 119330 eric 2011-12-14 18:18:57 -0800 Comment on attachment 119330 Patch OK. 522455 4 dpranke 2011-12-15 19:41:28 -0800 Committed r103014: <http://trac.webkit.org/changeset/103014> 119330 2011-12-14 16:43:01 -0800 2011-12-14 18:24:53 -0800 Patch bug-74556-20111214164300.patch text/plain 7394 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNzI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTNhNWY5NWIyMTJmNjcxOTRhMmM5N2VjZWM0ODBlMDA1 ZmM3YTNlYy4uMDMxYmRjNTU0ZDEyNzRhNmZjMGNmYjkyMWYzYzZiNDgzODhiOTE1MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2 IEBACiAyMDExLTEyLTE0ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHdlYmtpdHB5OiBjbGVhbiB1cCBUZXN0UG9ydCB0byAobW9zdGx5KSBub3QgY3JlYXRl IGEgbmV3IGZpbGVzeXN0ZW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTc0NTU2CisKKyAgICAgICAgVGhpcyBjaGFuZ2UgbW9kaWZpZXMgdGhlIFRlc3RQ b3J0IHRvIGJlIHJlYWR5IHRvIGFkZCB0ZXN0cyB0byBhbgorICAgICAgICBleGlzdGluZyBmaWxl c3lzdGVtIGluc3RlYWQgb2YgY3JlYXRpbmcgYSBuZXcgZmlsZXN5c3RlbTsgd2UKKyAgICAgICAg bGVhdmUgdW5pdF90ZXN0X2ZpbGVzeXN0ZW0oKSBpbiBmb3Igbm93IGZvciBjb21wYXRpYmlsaXR5 LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdF9tb2NrLnB5OgorICAg ICAgICAoTW9ja0hvc3QuX19pbml0X18pOgorICAgICAgICAgIC0gY2FsbCBhZGRfdW5pdF90ZXN0 c190b19tb2NrX2ZpbGVzeXN0ZW0gYnkgZGVmYXVsdCB0byBtYWtlCisgICAgICAgICAgICB0aGUg TW9ja0hvc3QgbW9yZSBnZW5lcmFsbHkgdXNlZnVsIGZvciBsYXlvdXRfdGVzdCB1bml0IHRlc3Rz LgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvdGVzdC5weToK KyAgICAgICAgKFRlc3RJbnN0YW5jZS5fX2luaXRfXyk6CisgICAgICAgIChhZGRfdW5pdF90ZXN0 c190b19tb2NrX2ZpbGVzeXN0ZW0pOgorICAgICAgICAoYWRkX2ZpbGUpOgorICAgICAgICAodW5p dF90ZXN0X2ZpbGVzeXN0ZW0pOgorICAgICAgICAoVGVzdFBvcnQuX19pbml0X18pOgorICAgICAg ICAoVGVzdFBvcnQuX3NldF9kZWZhdWx0X292ZXJyaWRpbmdfbm9uZSk6CisKKzIwMTEtMTItMTQg IERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgd2Via2l0cHk6 IGNsZWFudXAgcHJpb3IgdG8gc3lzdGVtaG9zdGlmeWluZyB0aGUgbGF5b3V0X3Rlc3QvcG9ydCog Y2xhc3NlcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NzQ1NTEKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdF9t b2NrLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vaG9zdF9tb2NrLnB5CmluZGV4 IGQ3ZDMzNjRjM2Y2ZmJkZTIwZjJkY2ZmNGIwMmE4YTNmMjgxNTVmM2EuLjU1ZGYzZTlhMjRhMGY0 ZmVlMWY2MDc4OTdlZTEzYzJlZjIyMTc5ZjkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2hvc3RfbW9jay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9ob3N0X21vY2sucHkKQEAgLTM2LDExICszNiwxMyBAQCBmcm9tIHdlYmtpdHB5LmNvbW1v bi53YXRjaGxpc3Qud2F0Y2hsaXN0X21vY2sgaW1wb3J0IE1vY2tXYXRjaExpc3QKIAogIyBOZXct c3R5bGUgcG9ydHMgbmVlZCB0byBtb3ZlIGRvd24gaW50byB3ZWJraXRweS5jb21tb24uCiBmcm9t IHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0LmZhY3RvcnkgaW1wb3J0IFBvcnRGYWN0b3J5Citm cm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0LnRlc3QgaW1wb3J0IGFkZF91bml0X3Rlc3Rz X3RvX21vY2tfZmlsZXN5c3RlbQogCiAKIGNsYXNzIE1vY2tIb3N0KE1vY2tTeXN0ZW1Ib3N0KToK ICAgICBkZWYgX19pbml0X18oc2VsZiwgbG9nX2V4ZWN1dGl2ZT1GYWxzZSwgZXhlY3V0aXZlX3Ro cm93c193aGVuX3J1bj1Ob25lKToKICAgICAgICAgTW9ja1N5c3RlbUhvc3QuX19pbml0X18oc2Vs ZiwgbG9nX2V4ZWN1dGl2ZSwgZXhlY3V0aXZlX3Rocm93c193aGVuX3J1bikKKyAgICAgICAgYWRk X3VuaXRfdGVzdHNfdG9fbW9ja19maWxlc3lzdGVtKHNlbGYuZmlsZXN5c3RlbSkKICAgICAgICAg c2VsZi53ZWIgPSBNb2NrV2ViKCkKIAogICAgICAgICBzZWxmLl9jaGVja291dCA9IE1vY2tDaGVj a291dCgpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L3Rlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3Rl c3QucHkKaW5kZXggM2ZkMTI2Mzk5ZTNkZjdhMTkwOGI3NWE4YTYyNDQ5NTI1MDJiZjQ0MS4uOGU0 NzI4ZDE2ZTYxN2ZhNGY4YjcyMTUyNTVlNTg3MTViMWU3ZTExMSAxMDA2NDQKLS0tIGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC90ZXN0LnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvdGVzdC5weQpAQCAtMzUsNyArMzUsNiBA QCBpbXBvcnQgdGltZQogCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0IGltcG9ydCBQ b3J0LCBEcml2ZXIsIERyaXZlck91dHB1dAogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubW9k ZWxzLnRlc3RfY29uZmlndXJhdGlvbiBpbXBvcnQgVGVzdENvbmZpZ3VyYXRpb24KLWZyb20gd2Vi a2l0cHkuY29tbW9uLmhvc3RfbW9jayBpbXBvcnQgTW9ja0hvc3QKIGZyb20gd2Via2l0cHkuY29t bW9uLnN5c3RlbS5maWxlc3lzdGVtX21vY2sgaW1wb3J0IE1vY2tGaWxlU3lzdGVtCiAKIApAQCAt MjI3LDM1ICsyMjYsMTEgQEAgTEFZT1VUX1RFU1RfRElSID0gJy90ZXN0LmNoZWNrb3V0L0xheW91 dFRlc3RzJwogIyBIZXJlIHdlIHN5bnRoZXNpemUgYW4gaW4tbWVtb3J5IGZpbGVzeXN0ZW0gZnJv bSB0aGUgdGVzdCBsaXN0CiAjIGluIG9yZGVyIHRvIGZ1bGx5IGNvbnRyb2wgdGhlIHRlc3Qgb3V0 cHV0IGFuZCB0byBkZW1vbnN0cmF0ZSB0aGF0CiAjIHdlIGRvbid0IG5lZWQgYSByZWFsIGZpbGVz eXN0ZW0gdG8gcnVuIHRoZSB0ZXN0cy4KLQotZGVmIHVuaXRfdGVzdF9maWxlc3lzdGVtKGZpbGVz PU5vbmUpOgotICAgICIiIlJldHVybiB0aGUgRmlsZVN5c3RlbSBvYmplY3QgdXNlZCBieSB0aGUg dW5pdCB0ZXN0cy4iIiIKLSAgICB0ZXN0X2xpc3QgPSB1bml0X3Rlc3RfbGlzdCgpCi0gICAgZmls ZXMgPSBmaWxlcyBvciB7fQotCi0gICAgZGVmIGFkZF90ZXN0X2ZpbGUoZmlsZXMsIHRlc3QsIHN1 ZmZpeCwgY29udGVudHMpOgotICAgICAgICBkaXJuYW1lID0gdGVzdC5uYW1lWzA6dGVzdC5uYW1l LnJmaW5kKCcvJyldCi0gICAgICAgIGJhc2UgPSB0ZXN0LmJhc2UKLSAgICAgICAgYWRkX2ZpbGUo ZmlsZXMsIGRpcm5hbWUgKyAnLycgKyBiYXNlICsgc3VmZml4LCBjb250ZW50cykKLQotICAgIGRl ZiBhZGRfZmlsZShmaWxlcywgZmlsZV9uYW1lLCBjb250ZW50cyk6Ci0gICAgICAgIGZpbGVzW0xB WU9VVF9URVNUX0RJUiArICcvJyArIGZpbGVfbmFtZV0gPSBjb250ZW50cwotCi0gICAgIyBBZGQg ZWFjaCB0ZXN0IGFuZCB0aGUgZXhwZWN0ZWQgb3V0cHV0LCBpZiBhbnkuCi0gICAgZm9yIHRlc3Qg aW4gdGVzdF9saXN0LnRlc3RzLnZhbHVlcygpOgotICAgICAgICBhZGRfdGVzdF9maWxlKGZpbGVz LCB0ZXN0LCAnLmh0bWwnLCAnJykKLSAgICAgICAgaWYgdGVzdC5pc19yZWZ0ZXN0OgotICAgICAg ICAgICAgY29udGludWUKLSAgICAgICAgaWYgdGVzdC5hY3R1YWxfYXVkaW86Ci0gICAgICAgICAg ICBhZGRfdGVzdF9maWxlKGZpbGVzLCB0ZXN0LCAnLWV4cGVjdGVkLndhdicsIHRlc3QuZXhwZWN0 ZWRfYXVkaW8pCi0gICAgICAgICAgICBjb250aW51ZQotCi0gICAgICAgIGFkZF90ZXN0X2ZpbGUo ZmlsZXMsIHRlc3QsICctZXhwZWN0ZWQudHh0JywgdGVzdC5leHBlY3RlZF90ZXh0KQotICAgICAg ICBhZGRfdGVzdF9maWxlKGZpbGVzLCB0ZXN0LCAnLWV4cGVjdGVkLnBuZycsIHRlc3QuZXhwZWN0 ZWRfaW1hZ2UpCi0KLQorZGVmIGFkZF91bml0X3Rlc3RzX3RvX21vY2tfZmlsZXN5c3RlbShmaWxl c3lzdGVtKToKICAgICAjIEFkZCB0aGUgdGVzdF9leHBlY3RhdGlvbnMgZmlsZS4KLSAgICBmaWxl c1tMQVlPVVRfVEVTVF9ESVIgKyAnL3BsYXRmb3JtL3Rlc3QvdGVzdF9leHBlY3RhdGlvbnMudHh0 J10gPSAiIiIKKyAgICBmaWxlc3lzdGVtLm1heWJlX21ha2VfZGlyZWN0b3J5KExBWU9VVF9URVNU X0RJUiArICcvcGxhdGZvcm0vdGVzdCcpCisgICAgaWYgbm90IGZpbGVzeXN0ZW0uZXhpc3RzKExB WU9VVF9URVNUX0RJUiArICcvcGxhdGZvcm0vdGVzdC90ZXN0X2V4cGVjdGF0aW9ucy50eHQnKToK KyAgICAgICAgZmlsZXN5c3RlbS53cml0ZV90ZXh0X2ZpbGUoTEFZT1VUX1RFU1RfRElSICsgJy9w bGF0Zm9ybS90ZXN0L3Rlc3RfZXhwZWN0YXRpb25zLnR4dCcsICIiIgogV09OVEZJWCA6IGZhaWx1 cmVzL2V4cGVjdGVkL2NoZWNrc3VtLmh0bWwgPSBJTUFHRQogV09OVEZJWCA6IGZhaWx1cmVzL2V4 cGVjdGVkL2NyYXNoLmh0bWwgPSBDUkFTSAogV09OVEZJWCA6IGZhaWx1cmVzL2V4cGVjdGVkL2lt YWdlLmh0bWwgPSBJTUFHRQpAQCAtMjc1LDkgKzI1MCwxMCBAQCBXT05URklYIDogZmFpbHVyZXMv ZXhwZWN0ZWQvdGltZW91dC5odG1sID0gVElNRU9VVAogV09OVEZJWCBTS0lQIDogZmFpbHVyZXMv ZXhwZWN0ZWQvaGFuZy5odG1sID0gVElNRU9VVAogV09OVEZJWCBTS0lQIDogZmFpbHVyZXMvZXhw ZWN0ZWQva2V5Ym9hcmQuaHRtbCA9IENSQVNICiBXT05URklYIFNLSVAgOiBmYWlsdXJlcy9leHBl Y3RlZC9leGNlcHRpb24uaHRtbCA9IENSQVNICi0iIiIKKyIiIikKIAotICAgIGFkZF9maWxlKGZp bGVzLCAncmVmdGVzdHMvZm9vL3JlZnRlc3QubGlzdCcsICIiIgorICAgIGZpbGVzeXN0ZW0ubWF5 YmVfbWFrZV9kaXJlY3RvcnkoTEFZT1VUX1RFU1RfRElSICsgJy9yZWZ0ZXN0cy9mb28nKQorICAg IGZpbGVzeXN0ZW0ud3JpdGVfdGV4dF9maWxlKExBWU9VVF9URVNUX0RJUiArICcvcmVmdGVzdHMv Zm9vL3JlZnRlc3QubGlzdCcsICIiIgogPT0gdGVzdC5odG1sIHRlc3QtcmVmLmh0bWwKIAogPT0g bXVsdGlwbGUtbWF0Y2gtc3VjY2Vzcy5odG1sIG1pc21hdGNoaW5nLXJlZi5odG1sCkBAIC0zMDEs OCArMjc3LDMyIEBAIFdPTlRGSVggU0tJUCA6IGZhaWx1cmVzL2V4cGVjdGVkL2V4Y2VwdGlvbi5o dG1sID0gQ1JBU0gKICAgICAjIEFkZCBpbiBhIGZpbGUgc2hvdWxkIGJlIGlnbm9yZWQgYnkgcG9y dC5maW5kX3Rlc3RfZmlsZXMoKS4KICAgICAjZmlsZXNbTEFZT1VUX1RFU1RfRElSICsgJy91c2Vy c2NyaXB0cy9yZXNvdXJjZXMvaWZyYW1lLmh0bWwnXSA9ICdpZnJhbWUnCiAKKyAgICBkZWYgYWRk X2ZpbGUodGVzdCwgc3VmZml4LCBjb250ZW50cyk6CisgICAgICAgIGRpcm5hbWUgPSBmaWxlc3lz dGVtLmpvaW4oTEFZT1VUX1RFU1RfRElSLCB0ZXN0Lm5hbWVbMDp0ZXN0Lm5hbWUucmZpbmQoJy8n KV0pCisgICAgICAgIGJhc2UgPSB0ZXN0LmJhc2UKKyAgICAgICAgZmlsZXN5c3RlbS5tYXliZV9t YWtlX2RpcmVjdG9yeShkaXJuYW1lKQorICAgICAgICBmaWxlc3lzdGVtLndyaXRlX2JpbmFyeV9m aWxlKGZpbGVzeXN0ZW0uam9pbihkaXJuYW1lLCBiYXNlICsgc3VmZml4KSwgY29udGVudHMpCisK KyAgICAjIEFkZCBlYWNoIHRlc3QgYW5kIHRoZSBleHBlY3RlZCBvdXRwdXQsIGlmIGFueS4KKyAg ICB0ZXN0X2xpc3QgPSB1bml0X3Rlc3RfbGlzdCgpCisgICAgZm9yIHRlc3QgaW4gdGVzdF9saXN0 LnRlc3RzLnZhbHVlcygpOgorICAgICAgICBhZGRfZmlsZSh0ZXN0LCAnLmh0bWwnLCAnJykKKyAg ICAgICAgaWYgdGVzdC5pc19yZWZ0ZXN0OgorICAgICAgICAgICAgY29udGludWUKKyAgICAgICAg aWYgdGVzdC5hY3R1YWxfYXVkaW86CisgICAgICAgICAgICBhZGRfZmlsZSh0ZXN0LCAnLWV4cGVj dGVkLndhdicsIHRlc3QuZXhwZWN0ZWRfYXVkaW8pCisgICAgICAgICAgICBjb250aW51ZQorICAg ICAgICBhZGRfZmlsZSh0ZXN0LCAnLWV4cGVjdGVkLnR4dCcsIHRlc3QuZXhwZWN0ZWRfdGV4dCkK KyAgICAgICAgYWRkX2ZpbGUodGVzdCwgJy1leHBlY3RlZC5wbmcnLCB0ZXN0LmV4cGVjdGVkX2lt YWdlKQorCisgICAgIyBDbGVhciB0aGUgbGlzdCBvZiB3cml0dGVuIGZpbGVzIHNvIHRoYXQgd2Ug Y2FuIHdhdGNoIHdoYXQgaGFwcGVucyBkdXJpbmcgdGVzdGluZy4KKyAgICBmaWxlc3lzdGVtLmNs ZWFyX3dyaXR0ZW5fZmlsZXMoKQorCisKK2RlZiB1bml0X3Rlc3RfZmlsZXN5c3RlbShmaWxlcz1O b25lKToKKyAgICBmaWxlcyA9IGZpbGVzIG9yIHt9CiAgICAgZnMgPSBNb2NrRmlsZVN5c3RlbShm aWxlcywgZGlycz1zZXQoWycvbW9jay1jaGVja291dCddKSkgICMgTWFrZSBzdXJlIGF0IGxlYXN0 IHRoZSBjaGVja291dF9yb290IGV4aXN0cyBhcyBhIGRpcmVjdG9yeS4KLSAgICBmcy5fdGVzdHMg PSB0ZXN0X2xpc3QKKyAgICBhZGRfdW5pdF90ZXN0c190b19tb2NrX2ZpbGVzeXN0ZW0oZnMpCiAg ICAgcmV0dXJuIGZzCiAKIApAQCAtMzI0LDE0ICszMjQsMTYgQEAgY2xhc3MgVGVzdFBvcnQoUG9y dCk6CiAgICAgICAgIGlmIG5vdCBwb3J0X25hbWUgb3IgcG9ydF9uYW1lID09ICd0ZXN0JzoKICAg ICAgICAgICAgIHBvcnRfbmFtZSA9ICd0ZXN0LW1hYy1sZW9wYXJkJwogCisgICAgICAgICMgRklY TUU6IHdlIGltcG9ydCB0aGlzIGhlcmUgaW5zdGVhZCBvZiBhdCB0aGUgdG9wLWxldmVsIGluIG9y ZGVyIHRvIGF2b2lkCisgICAgICAgICMgYSBjaXJjdWxhciBpbXBvcnQuIFRoaXMgc2hvdWxkIGJl IHJlbW92ZWQgd2hlbiBob3N0IGJlY29tZSBhIHJlcXVpcmVkIHBhcmFtZXRlci4KKyAgICAgICAg ZnJvbSB3ZWJraXRweS5jb21tb24uaG9zdF9tb2NrIGltcG9ydCBNb2NrSG9zdAogICAgICAgICBo b3N0ID0gaG9zdCBvciBNb2NrSG9zdCgpCiAgICAgICAgIGZpbGVzeXN0ZW0gPSBzZWxmLl9zZXRf ZGVmYXVsdF9vdmVycmlkaW5nX25vbmUoa3dhcmdzLCAnZmlsZXN5c3RlbScsIHVuaXRfdGVzdF9m aWxlc3lzdGVtKCkpCiAKICAgICAgICAgUG9ydC5fX2luaXRfXyhzZWxmLCBob3N0LCBwb3J0X25h bWU9cG9ydF9uYW1lLCAqKmt3YXJncykKICAgICAgICAgc2VsZi5fcmVzdWx0c19kaXJlY3Rvcnkg PSBOb25lCiAKLSAgICAgICAgYXNzZXJ0IGZpbGVzeXN0ZW0uX3Rlc3RzCi0gICAgICAgIHNlbGYu X3Rlc3RzID0gZmlsZXN5c3RlbS5fdGVzdHMKKyAgICAgICAgc2VsZi5fdGVzdHMgPSB1bml0X3Rl c3RfbGlzdCgpCiAKICAgICAgICAgc2VsZi5fb3BlcmF0aW5nX3N5c3RlbSA9ICdtYWMnCiAgICAg ICAgIGlmIHBvcnRfbmFtZS5zdGFydHN3aXRoKCd0ZXN0LXdpbicpOgo=