74552 2011-12-14 16:02:22 -0800 binding a member function should ref/deref the object pointer if needed 2011-12-14 17:37:58 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca dglazkov webkit.review.bot oldest_to_newest 521402 0 andersca 2011-12-14 16:02:22 -0800 binding a member function should ref/deref the object pointer if needed 521409 1 119314 andersca 2011-12-14 16:07:39 -0800 Created attachment 119314 Patch 521412 2 webkit.review.bot 2011-12-14 16:09:24 -0800 Attachment 119314 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:144: Extra space before ( in function call [whitespace/parens] [4] Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:147: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 521452 3 119314 webkit.review.bot 2011-12-14 16:38:48 -0800 Comment on attachment 119314 Patch Attachment 119314 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10900013 521511 4 119314 sam 2011-12-14 17:28:22 -0800 Comment on attachment 119314 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119314&action=review > Source/JavaScriptCore/wtf/Functional.h:160 > +template<typename T, bool> struct RefAndDeref { You should note what the bool means here. 521525 5 andersca 2011-12-14 17:37:58 -0800 Committed r102857: <http://trac.webkit.org/changeset/102857> 119314 2011-12-14 16:07:39 -0800 2011-12-14 17:28:22 -0800 Patch bug-74552-20111214160739.patch text/plain 7009 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyODM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm NzJiOTE2NzFiNThmZThiN2I4ZGZhMzdiNGUwMDdhMWM3NzkyYzAxLi5iOTQ3ZTI2ZjJlZGU1ODk5 ODcwMGIxY2M5NzJhZWIxYTY5MDIyYzQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMSBAQAogMjAxMS0xMi0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgogCisgICAgICAgIGJpbmRpbmcgYSBtZW1iZXIgZnVuY3Rpb24gc2hvdWxkIHJlZi9kZXJl ZiB0aGUgb2JqZWN0IHBvaW50ZXIgaWYgbmVlZGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDU1MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIEhhc1JlZkFuZERlcmVmIGhlbHBlciBjbGFzcyB0 ZW1wbGF0ZSB3aGljaCBjaGVja3MgaWYgYSBnaXZlbiBjbGFzcyB0eXBlIGhhcyByZWYgYW5kIGRl cmVmCisgICAgICAgIG1lbWJlciBmdW5jdGlvbnMgd2hpY2ggdGhlIHJpZ2h0IHR5cGUuIFVzZSB0 aGlzIHRvIGRldGVybWluZSBpZiB3ZSBzaG91bGQgcmVmL2RlcmVmIHRoZSBmaXJzdCBwYXJhbWV0 ZXIuCisKKyAgICAgICAgKiB3dGYvRnVuY3Rpb25hbC5oOgorICAgICAgICAoV1RGOjpSKToKKyAg ICAgICAgKFdURjo6Qzo6KToKKyAgICAgICAgKFdURjo6UmVmQW5kRGVyZWY6OnJlZik6CisgICAg ICAgIChXVEY6OlJlZkFuZERlcmVmOjpkZXJlZik6CisKKzIwMTEtMTItMTQgIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBXb3JrIGFyb3VuZCBhIGJ1ZyBp biB0aGUgTVNWQzIwMDUgY29tcGlsZXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTc0NTUwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS93dGYvRnVuY3Rpb25hbC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9GdW5jdGlvbmFs LmgKaW5kZXggM2U0MTgxYzRjNDUxMjNkYmQxN2FhYjMwNTM1M2Y2NzdjZDZkYjEwNy4uYzAwNmYx ZjhhYWFlMzNiZTVlMDM5MDhhYTcxNWQ3ZjVlMWZkMGZmNSAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9GdW5jdGlvbmFsLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3d0Zi9GdW5jdGlvbmFsLmgKQEAgLTM4LDYgKzM4LDI2IEBAIG5hbWVzcGFjZSBXVEYgewogLy8g VGhlIGltcGxlbWVudGF0aW9uIGlzIGN1cnJlbnRseSB2ZXJ5IHNpbXBsZSwgYnV0IHRoZSBnb2Fs IGlzIHRvIHJlcGxhY2UgV29ya0l0ZW0gaW4gV2ViS2l0MiBhbmQgbWFrZSBpdCBlYXNpZXIgdG8K IC8vIHBhY2thZ2UgdXAgYW5kIGludm9rZSBmdW5jdGlvbiBjYWxscyBpbnNpZGUgV2ViQ29yZS4K IAorLy8gSGVscGVyIGNsYXNzIHRlbXBsYXRlIHRvIGRldGVybWluZSB3aGV0aGVyIGEgZ2l2ZW4g dHlwZSBoYXMgcmVmIGFuZCBkZXJlZiBtZW1iZXIgZnVuY3Rpb25zCisvLyB3aXRoIHRoZSByaWdo dCB0eXBlIHNpZ25hdHVyZS4KK3RlbXBsYXRlPHR5cGVuYW1lIFQ+IGNsYXNzIEhhc1JlZkFuZERl cmVmIHsKKyAgICB0eXBlZGVmIGNoYXIgWWVzVHlwZTsKKyAgICBzdHJ1Y3QgTm9UeXBlIHsKKyAg ICAgICAgY2hhciBwYWRkaW5nWzhdOworICAgIH07CisKKyAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBV LCBVLCBVPiBzdHJ1Y3QgVHlwZUNoZWNrZXIgeyB9OworCisgICAgdGVtcGxhdGU8dHlwZW5hbWUg VT4KKyAgICBzdGF0aWMgWWVzVHlwZSByZWZBbmREZXJlZkNoZWNrKFR5cGVDaGVja2VyPHZvaWQg KFU6OiopKCksICZVOjpyZWYsICZVOjpkZXJlZj4qKTsKKworICAgIHRlbXBsYXRlPHR5cGVuYW1l IFU+CisgICAgc3RhdGljIE5vVHlwZSByZWZBbmREZXJlZkNoZWNrKC4uLik7CisKK3B1YmxpYzoK KyAgICBzdGF0aWMgY29uc3QgYm9vbCB2YWx1ZSA9IHNpemVvZihyZWZBbmREZXJlZkNoZWNrPFQ+ KDApKSA9PSBzaXplb2YoWWVzVHlwZSk7Cit9OworCiAvLyBBIEZ1bmN0aW9uV3JhcHBlciBpcyBh IGNsYXNzIHRlbXBsYXRlIHRoYXQgY2FuIHdyYXAgYSBmdW5jdGlvbiBwb2ludGVyIG9yIGEgbWVt YmVyIGZ1bmN0aW9uIHBvaW50ZXIgYW5kCiAvLyBwcm92aWRlIGEgdW5pZmllZCBpbnRlcmZhY2Ug Zm9yIGNhbGxpbmcgdGhhdCBmdW5jdGlvbi4KIHRlbXBsYXRlPHR5cGVuYW1lPiBjbGFzcyBGdW5j dGlvbldyYXBwZXI7CkBAIC00NSw2ICs2NSw3IEBAIHRlbXBsYXRlPHR5cGVuYW1lPiBjbGFzcyBG dW5jdGlvbldyYXBwZXI7CiB0ZW1wbGF0ZTx0eXBlbmFtZSBSPiBjbGFzcyBGdW5jdGlvbldyYXBw ZXI8UiAoKikoKT4gewogcHVibGljOgogICAgIHR5cGVkZWYgUiBSZXN1bHRUeXBlOworICAgIHN0 YXRpYyBjb25zdCBib29sIHNob3VsZFJlZkZpcnN0UGFyYW1ldGVyID0gZmFsc2U7CiAKICAgICBl eHBsaWNpdCBGdW5jdGlvbldyYXBwZXIoUiAoKmZ1bmN0aW9uKSgpKQogICAgICAgICA6IG1fZnVu Y3Rpb24oZnVuY3Rpb24pCkBAIC02Myw2ICs4NCw3IEBAIHByaXZhdGU6CiB0ZW1wbGF0ZTx0eXBl bmFtZSBSLCB0eXBlbmFtZSBQMD4gY2xhc3MgRnVuY3Rpb25XcmFwcGVyPFIgKCopKFAwKT4gewog cHVibGljOgogICAgIHR5cGVkZWYgUiBSZXN1bHRUeXBlOworICAgIHN0YXRpYyBjb25zdCBib29s IHNob3VsZFJlZkZpcnN0UGFyYW1ldGVyID0gZmFsc2U7CiAKICAgICBleHBsaWNpdCBGdW5jdGlv bldyYXBwZXIoUiAoKmZ1bmN0aW9uKShQMCkpCiAgICAgICAgIDogbV9mdW5jdGlvbihmdW5jdGlv bikKQEAgLTgxLDYgKzEwMyw3IEBAIHByaXZhdGU6CiB0ZW1wbGF0ZTx0eXBlbmFtZSBSLCB0eXBl bmFtZSBQMCwgdHlwZW5hbWUgUDE+IGNsYXNzIEZ1bmN0aW9uV3JhcHBlcjxSICgqKShQMCwgUDEp PiB7CiBwdWJsaWM6CiAgICAgdHlwZWRlZiBSIFJlc3VsdFR5cGU7CisgICAgc3RhdGljIGNvbnN0 IGJvb2wgc2hvdWxkUmVmRmlyc3RQYXJhbWV0ZXIgPSBmYWxzZTsKIAogICAgIGV4cGxpY2l0IEZ1 bmN0aW9uV3JhcHBlcihSICgqZnVuY3Rpb24pKFAwLCBQMSkpCiAgICAgICAgIDogbV9mdW5jdGlv bihmdW5jdGlvbikKQEAgLTk5LDYgKzEyMiw3IEBAIHByaXZhdGU6CiB0ZW1wbGF0ZTx0eXBlbmFt ZSBSLCB0eXBlbmFtZSBDPiBjbGFzcyBGdW5jdGlvbldyYXBwZXI8UiAoQzo6KikoKT4gewogcHVi bGljOgogICAgIHR5cGVkZWYgUiBSZXN1bHRUeXBlOworICAgIHN0YXRpYyBjb25zdCBib29sIHNo b3VsZFJlZkZpcnN0UGFyYW1ldGVyID0gSGFzUmVmQW5kRGVyZWY8Qz46OnZhbHVlOwogCiAgICAg ZXhwbGljaXQgRnVuY3Rpb25XcmFwcGVyKFIgKEM6OipmdW5jdGlvbikoKSkKICAgICAgICAgOiBt X2Z1bmN0aW9uKGZ1bmN0aW9uKQpAQCAtMTE3LDYgKzE0MSw3IEBAIHByaXZhdGU6CiB0ZW1wbGF0 ZTx0eXBlbmFtZSBSLCB0eXBlbmFtZSBDLCB0eXBlbmFtZSBQMD4gY2xhc3MgRnVuY3Rpb25XcmFw cGVyPFIgKEM6OiopKFAwKT4gewogcHVibGljOgogICAgIHR5cGVkZWYgUiBSZXN1bHRUeXBlOwor ICAgIHN0YXRpYyBjb25zdCBib29sIHNob3VsZFJlZkZpcnN0UGFyYW1ldGVyID0gSGFzUmVmQW5k RGVyZWY8Qz46OnZhbHVlOwogCiAgICAgZXhwbGljaXQgRnVuY3Rpb25XcmFwcGVyKFIgKEM6Oipm dW5jdGlvbikoUDApKQogICAgICAgICA6IG1fZnVuY3Rpb24oZnVuY3Rpb24pCkBAIC0xMzIsNiAr MTU3LDE2IEBAIHByaXZhdGU6CiAgICAgUiAoQzo6Km1fZnVuY3Rpb24pKFAwKTsKIH07CiAKK3Rl bXBsYXRlPHR5cGVuYW1lIFQsIGJvb2w+IHN0cnVjdCBSZWZBbmREZXJlZiB7CisgICAgc3RhdGlj IHZvaWQgcmVmKFQpIHsgfQorICAgIHN0YXRpYyB2b2lkIGRlcmVmKFQpIHsgfQorfTsKKwordGVt cGxhdGU8dHlwZW5hbWUgVD4gc3RydWN0IFJlZkFuZERlcmVmPFQqLCB0cnVlPiB7CisgICAgc3Rh dGljIHZvaWQgcmVmKFQqIHQpIHsgdC0+cmVmKCk7IH0KKyAgICBzdGF0aWMgdm9pZCBkZXJlZihU KiB0KSB7IHQtPmRlcmVmKCk7IH0KK307CisKIGNsYXNzIEZ1bmN0aW9uSW1wbEJhc2UgOiBwdWJs aWMgVGhyZWFkU2FmZVJlZkNvdW50ZWQ8RnVuY3Rpb25JbXBsQmFzZT4gewogcHVibGljOgogICAg IHZpcnR1YWwgfkZ1bmN0aW9uSW1wbEJhc2UoKSB7IH0KQEAgLTE3Miw2ICsyMDcsMTIgQEAgcHVi bGljOgogICAgICAgICA6IG1fZnVuY3Rpb25XcmFwcGVyKGZ1bmN0aW9uV3JhcHBlcikKICAgICAg ICAgLCBtX3AwKHAwKQogICAgIHsKKyAgICAgICAgUmVmQW5kRGVyZWY8UDAsIEZ1bmN0aW9uV3Jh cHBlcjo6c2hvdWxkUmVmRmlyc3RQYXJhbWV0ZXI+OjpyZWYobV9wMCk7CisgICAgfQorCisgICAg fkJvdW5kRnVuY3Rpb25JbXBsKCkKKyAgICB7CisgICAgICAgIFJlZkFuZERlcmVmPFAwLCBGdW5j dGlvbldyYXBwZXI6OnNob3VsZFJlZkZpcnN0UGFyYW1ldGVyPjo6ZGVyZWYobV9wMCk7CiAgICAg fQogCiAgICAgdmlydHVhbCBSIG9wZXJhdG9yKCkoKQpAQCAtMTkxLDYgKzIzMiwxMiBAQCBwdWJs aWM6CiAgICAgICAgICwgbV9wMChwMCkKICAgICAgICAgLCBtX3AxKHAxKQogICAgIHsKKyAgICAg ICAgUmVmQW5kRGVyZWY8UDAsIEZ1bmN0aW9uV3JhcHBlcjo6c2hvdWxkUmVmRmlyc3RQYXJhbWV0 ZXI+OjpyZWYobV9wMCk7CisgICAgfQorICAgIAorICAgIH5Cb3VuZEZ1bmN0aW9uSW1wbCgpCisg ICAgeworICAgICAgICBSZWZBbmREZXJlZjxQMCwgRnVuY3Rpb25XcmFwcGVyOjpzaG91bGRSZWZG aXJzdFBhcmFtZXRlcj46OmRlcmVmKG1fcDApOwogICAgIH0KIAogICAgIHZpcnR1YWwgdHlwZW5h bWUgRnVuY3Rpb25XcmFwcGVyOjpSZXN1bHRUeXBlIG9wZXJhdG9yKCkoKQpkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGM2ZmJhZDc5MmYwY2YzNTI3 NTZlNmVlZTA1MDIyYTU2NGVjMzUyMTEuLmQ0Yjc1YjJjZTVlNDdjMGQzYWFjNDVmYzE1NzczZjI0 NTYxOGU5MWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VM b2cKQEAgLTEsNSArMSwyMyBAQAogMjAxMS0xMi0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgogCisgICAgICAgIGJpbmRpbmcgYSBtZW1iZXIgZnVuY3Rpb24gc2hvdWxk IHJlZi9kZXJlZiB0aGUgb2JqZWN0IHBvaW50ZXIgaWYgbmVlZGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDU1MgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBuZXcgdGVzdHMuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9GdW5jdGlvbmFsLmNwcDoKKyAgICAgICAgKFRlc3RX ZWJLaXRBUEk6OkI6OkIpOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6Qjo6fkIpOgorICAgICAg ICAoVGVzdFdlYktpdEFQSTo6Qjo6cmVmKToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OkI6OmRl cmVmKToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OkI6OmYpOgorICAgICAgICAoVGVzdFdlYktp dEFQSTo6Qjo6Zyk6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKworMjAxMS0xMi0x NCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIFdvcmsg YXJvdW5kIGEgYnVnIGluIHRoZSBNU1ZDMjAwNSBjb21waWxlcgogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ1NTAKIApkaWZmIC0tZ2l0IGEvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRnVuY3Rpb25hbC5jcHAgYi9Ub29scy9UZXN0V2ViS2l0 QVBJL1Rlc3RzL1dURi9GdW5jdGlvbmFsLmNwcAppbmRleCBmOWM4NTE5NjU0Yzk1NzE0YTYwOTQ1 YzQxYWVkNDYzZDlmYzdhNjY5Li5jOWU4NDg1Yzg2OGZmYWMyN2U2YWJjZDk2OTk2NmMyODBlOTQ5 NmE1IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9GdW5jdGlvbmFs LmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9GdW5jdGlvbmFsLmNwcApA QCAtMTA1LDQgKzEwNSw0NyBAQCBURVNUKEZ1bmN0aW9uYWxUZXN0LCBNZW1iZXJGdW5jdGlvbkJp bmQpCiAgICAgQVNTRVJUX0VRKDI1LCBmdW5jdGlvbjIoKSk7CiB9CiAKK2NsYXNzIEIgeworcHVi bGljOgorICAgIEIoKQorICAgICAgICA6IG1fbnVtUmVmQ2FsbHMoMCkKKyAgICAgICAgLCBtX251 bURlcmVmQ2FsbHMoMCkKKyAgICB7CisgICAgfQorCisgICAgfkIoKQorICAgIHsKKyAgICAgICAg QVNTRVJUX1RSVUUobV9udW1SZWZDYWxscyA9PSBtX251bURlcmVmQ2FsbHMpOworICAgICAgICBB U1NFUlRfR1QobV9udW1SZWZDYWxscywgMCk7CisgICAgfQorCisgICAgdm9pZCByZWYoKQorICAg IHsKKyAgICAgICAgbV9udW1SZWZDYWxscysrOworICAgIH0KKworICAgIHZvaWQgZGVyZWYoKQor ICAgIHsKKyAgICAgICAgbV9udW1EZXJlZkNhbGxzKys7CisgICAgfQorCisgICAgdm9pZCBmKCkg eyBBU1NFUlRfR1QobV9udW1SZWZDYWxscywgMCk7IH0KKyAgICB2b2lkIGcoaW50KSB7IEFTU0VS VF9HVChtX251bVJlZkNhbGxzLCAwKTsgfQorCitwcml2YXRlOgorICAgIGludCBtX251bVJlZkNh bGxzOworICAgIGludCBtX251bURlcmVmQ2FsbHM7Cit9OworCitURVNUKEZ1bmN0aW9uYWxUZXN0 LCBNZW1iZXJGdW5jdGlvbkJpbmRSZWZEZXJlZikKK3sKKyAgICBCIGI7CisKKyAgICBGdW5jdGlv bjx2b2lkICgpPiBmdW5jdGlvbjEgPSBiaW5kKCZCOjpmLCAmYik7CisgICAgZnVuY3Rpb24xKCk7 CisKKyAgICBGdW5jdGlvbjx2b2lkICgpPiBmdW5jdGlvbjIgPSBiaW5kKCZCOjpnLCAmYiwgMTAp OworICAgIGZ1bmN0aW9uMigpOworfQorCiB9IC8vIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJCg==