74530 2011-12-14 12:37:11 -0800 [chromium] Compositor needs to set texture filtering on canvas layers 2011-12-14 14:38:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne cc-bugs enne jamesr senorblanco webkit.review.bot oldest_to_newest 521189 0 enne 2011-12-14 12:37:11 -0800 [chromium] Compositor needs to set texture filtering on canvas layers 521191 1 119276 enne 2011-12-14 12:38:17 -0800 Created attachment 119276 Patch 521194 2 enne 2011-12-14 12:39:53 -0800 Other layers (WebGL, plugin) set texture filtering to linear. The canvas layer just takes whatever's on the texture it's been given, which happens to be linear. Set it explicitly instead. See: http://code.google.com/p/chromium/issues/detail?id=101928 521201 3 119276 jamesr 2011-12-14 12:47:46 -0800 Comment on attachment 119276 Patch R=me, but it seems a bit silly to do it here. tex parameters are associated with the texture, not a particular binding, so we should only do this once when we create the texture. 521204 4 enne 2011-12-14 12:50:41 -0800 (In reply to comment #3) > (From update of attachment 119276 [details]) > R=me, but it seems a bit silly to do it here. tex parameters are associated with the texture, not a particular binding, so we should only do this once when we create the texture. I'm not totally convinced of that. When canvas switches to using a ManagedTexture, it's possible that its texture could be recycled from some texture that has different settings. 521209 5 jamesr 2011-12-14 12:52:57 -0800 In that case the recycling should preserve any texParameters. I agree that it probably doesn't today (grumble about crappy recycling code). 521301 6 119276 webkit.review.bot 2011-12-14 14:38:24 -0800 Comment on attachment 119276 Patch Clearing flags on attachment: 119276 Committed r102828: <http://trac.webkit.org/changeset/102828> 521302 7 webkit.review.bot 2011-12-14 14:38:28 -0800 All reviewed patches have been landed. Closing bug. 119276 2011-12-14 12:38:17 -0800 2011-12-14 14:38:24 -0800 Patch bug-74530-20111214123816.patch text/plain 1859 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTFiODU5MGU2MDQ0NGZi NzNjNGFkZDFjNjFkZmUzNWU3ZjBkNTkyYS4uODg1MWYwODAzYzIwYjQwMGJiYTI2OTNjOGQ2NjEw ZWRkZGVjYWQwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTEyLTE0ICBBZHJp ZW5uZSBXYWxrZXIgIDxlbm5lQGdvb2dsZS5jb20+CisKKyAgICAgICAgW2Nocm9taXVtXSBDb21w b3NpdG9yIG5lZWRzIHRvIHNldCB0ZXh0dXJlIGZpbHRlcmluZyBvbiBjYW52YXMgbGF5ZXJzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDUzMAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NDYW52YXNMYXllckltcGwuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6Q0NDYW52YXNMYXllckltcGw6OmRyYXcpOgorCiAyMDExLTEyLTEzICBSb2JpbiBEdW5u ICA8cm9iaW5AYWxsZHVubi5jb20+CiAKICAgICAgICAgRG9uJ3QgbWFrZSB0aGUgYml0bWFwIHRy YW5zcGFyZW50IHdoZW4gdXNpbmcgdGhlbWUgZHJhd2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NDYW52YXNMYXllckltcGwuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NDYW52YXNM YXllckltcGwuY3BwCmluZGV4IDIyNDM2MDdhMzEzMDM4MzI4NWY3MDM2ZDA0NWJlYzY5ZTg0ZjYy YjQuLjZlY2RkOTBmMjZhNzQxNzBiNTgxNmE4NzE2ZTgzODM2Mjk5ZGRjZDggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDQ2FudmFzTGF5 ZXJJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9jYy9DQ0NhbnZhc0xheWVySW1wbC5jcHAKQEAgLTU2LDYgKzU2LDkgQEAgdm9pZCBDQ0NhbnZh c0xheWVySW1wbDo6ZHJhdyhMYXllclJlbmRlcmVyQ2hyb21pdW0qIGxheWVyUmVuZGVyZXIpCiAg ICAgR3JhcGhpY3NDb250ZXh0M0QqIGNvbnRleHQgPSBsYXllclJlbmRlcmVyLT5jb250ZXh0KCk7 CiAgICAgR0xDKGNvbnRleHQsIGNvbnRleHQtPmFjdGl2ZVRleHR1cmUoR3JhcGhpY3NDb250ZXh0 M0Q6OlRFWFRVUkUwKSk7CiAgICAgR0xDKGNvbnRleHQsIGNvbnRleHQtPmJpbmRUZXh0dXJlKEdy YXBoaWNzQ29udGV4dDNEOjpURVhUVVJFXzJELCBtX3RleHR1cmVJZCkpOworICAgIEdMQyhjb250 ZXh0LCBjb250ZXh0LT50ZXhQYXJhbWV0ZXJpKEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFXzJE LCBHcmFwaGljc0NvbnRleHQzRDo6VEVYVFVSRV9NSU5fRklMVEVSLCBHcmFwaGljc0NvbnRleHQz RDo6TElORUFSKSk7CisgICAgR0xDKGNvbnRleHQsIGNvbnRleHQtPnRleFBhcmFtZXRlcmkoR3Jh cGhpY3NDb250ZXh0M0Q6OlRFWFRVUkVfMkQsIEdyYXBoaWNzQ29udGV4dDNEOjpURVhUVVJFX01B R19GSUxURVIsIEdyYXBoaWNzQ29udGV4dDNEOjpMSU5FQVIpKTsKKwogICAgIGlmICghbV9oYXNB bHBoYSkgewogICAgICAgICAvLyBFdmVuIHRob3VnaCB0aGUgV2ViR0wgbGF5ZXIncyB0ZXh0dXJl IHdhcyBsaWtlbHkgYWxsb2NhdGVkCiAgICAgICAgIC8vIGFzIEdMX1JHQiwgZGlzYWJsZSBibGVu ZGluZyBhbnl3YXkgZm9yIGJldHRlciByb2J1c3RuZXNzLgo=