74527 2011-12-14 11:29:51 -0800 DFG relies on returning a struct in registers 2011-12-14 12:51:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 barraclough barraclough oldest_to_newest 521128 0 barraclough 2011-12-14 11:29:51 -0800 This will not work on all platforms. Returning a uint64_t will more reliably achieve what we want, on 32-bit platforms (on 64-bit, stick with the struct return). 521131 1 119264 barraclough 2011-12-14 11:31:38 -0800 Created attachment 119264 fix 521138 2 119264 ggaren 2011-12-14 11:38:10 -0800 Comment on attachment 119264 fix r=me 521207 3 barraclough 2011-12-14 12:51:36 -0800 Fixed in r102811 119264 2011-12-14 11:31:38 -0800 2011-12-14 11:38:10 -0800 fix 74527.patch text/plain 3713 barraclough SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTAyODAyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDExLTEyLTE0ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4K KworICAgICAgICBERkcgcmVsaWVzIG9uIHJldHVybmluZyBhIHN0cnVjdCBpbiByZWdpc3RlcnMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0NTI3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB3aWxs IG5vdCB3b3JrIG9uIGFsbCBwbGF0Zm9ybXMuIFJldHVybmluZyBhIHVpbnQ2NF90IHdpbGwgbW9y ZSByZWxpYWJseSBhY2hpZXZlCisgICAgICAgIHdoYXQgd2Ugd2FudCwgb24gMzItYml0IHBsYXRm b3JtcyAob24gNjQtYml0LCBzdGljayB3aXRoIHRoZSBzdHJ1Y3QgcmV0dXJuKS4KKworICAgICAg ICAqIGRmZy9ERkdPcGVyYXRpb25zLmNwcDoKKyAgICAgICAgKiBkZmcvREZHT3BlcmF0aW9ucy5o OgorICAgICAgICAoSlNDOjpERkc6OkRGR0hhbmRsZXI6OmRmZ0hhbmRsZXJFbmNvZGVkKToKKwog MjAxMS0xMi0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAg ICAgIEFkZCBiYWNrIHRoZSBjYWxsT25NYWluVGhyZWFkIG92ZXJsb2FkIHRoYXQgdGFrZXMgYSBX VEY6OkZ1bmN0aW9uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlv bnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT3BlcmF0 aW9ucy5jcHAJKHJldmlzaW9uIDEwMjcwOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHT3BlcmF0aW9ucy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc5NSw3ICs3OTUsNyBAQCBFbmNv ZGVkSlNWYWx1ZSBERkdfT1BFUkFUSU9OIG9wZXJhdGlvbk5lCiAgICAgcmV0dXJuIEpTVmFsdWU6 OmVuY29kZShSZWdFeHBPYmplY3Q6OmNyZWF0ZShleGVjLT5nbG9iYWxEYXRhKCksIGV4ZWMtPmxl eGljYWxHbG9iYWxPYmplY3QoKSwgZXhlYy0+bGV4aWNhbEdsb2JhbE9iamVjdCgpLT5yZWdFeHBT dHJ1Y3R1cmUoKSwgcmVnZXhwKSk7CiB9CiAKLURGR0hhbmRsZXIgREZHX09QRVJBVElPTiBsb29r dXBFeGNlcHRpb25IYW5kbGVyKEV4ZWNTdGF0ZSogZXhlYywgUmV0dXJuQWRkcmVzc1B0ciBmYXVs dExvY2F0aW9uKQorREZHSGFuZGxlckVuY29kZWQgREZHX09QRVJBVElPTiBsb29rdXBFeGNlcHRp b25IYW5kbGVyKEV4ZWNTdGF0ZSogZXhlYywgUmV0dXJuQWRkcmVzc1B0ciBmYXVsdExvY2F0aW9u KQogewogICAgIEpTVmFsdWUgZXhjZXB0aW9uVmFsdWUgPSBleGVjLT5leGNlcHRpb24oKTsKICAg ICBBU1NFUlQoZXhjZXB0aW9uVmFsdWUpOwpAQCAtODA1LDcgKzgwNSw3IEBAIERGR0hhbmRsZXIg REZHX09QRVJBVElPTiBsb29rdXBFeGNlcHRpb24KIAogICAgIHZvaWQqIGNhdGNoUm91dGluZSA9 IGhhbmRsZXIgPyBoYW5kbGVyLT5uYXRpdmVDb2RlLmV4ZWN1dGFibGVBZGRyZXNzKCkgOiAodm9p ZCopY3RpT3BUaHJvd05vdENhdWdodDsKICAgICBBU1NFUlQoY2F0Y2hSb3V0aW5lKTsKLSAgICBy ZXR1cm4gREZHSGFuZGxlcihleGVjLCBjYXRjaFJvdXRpbmUpOworICAgIHJldHVybiBkZmdIYW5k bGVyRW5jb2RlZChleGVjLCBjYXRjaFJvdXRpbmUpOwogfQogCiBkb3VibGUgREZHX09QRVJBVElP TiBkZmdDb252ZXJ0SlNWYWx1ZVRvTnVtYmVyKEV4ZWNTdGF0ZSogZXhlYywgRW5jb2RlZEpTVmFs dWUgdmFsdWUpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09wZXJhdGlvbnMu aAkocmV2aXNpb24gMTAyNzA4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPcGVy YXRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0NiwxNSArMTQ2LDQxIEBAIHZvaWQqIERGR19P UEVSQVRJT04gb3BlcmF0aW9uTGlua0NvbnN0cnUKIC8vIHRoZSByZXR1cm4gbG9jYXRpb24gZnJv bSBvbmUgb2YgdGhlIGNhbGxzIG91dCB0byBvbmUgb2YgdGhlIGhlbHBlciBvcGVyYXRpb25zIGFi b3ZlLgogc3RydWN0IERGR0hhbmRsZXIgewogICAgIERGR0hhbmRsZXIoRXhlY1N0YXRlKiBleGVj LCB2b2lkKiBoYW5kbGVyKQotICAgICAgICA6IGV4ZWMoZXhlYykKLSAgICAgICAgLCBoYW5kbGVy KGhhbmRsZXIpCiAgICAgeworICAgICAgICB1LnMuZXhlYyA9IGV4ZWM7CisgICAgICAgIHUucy5o YW5kbGVyID0gaGFuZGxlcjsKICAgICB9CiAKLSAgICBFeGVjU3RhdGUqIGV4ZWM7Ci0gICAgdm9p ZCogaGFuZGxlcjsKKyNpZiAhQ1BVKFg4Nl82NCkKKyAgICB1aW50NjRfdCBlbmNvZGVkKCkKKyAg ICB7CisgICAgICAgIENPTVBJTEVfQVNTRVJUKHNpemVvZihVbmlvbikgPT0gc2l6ZW9mKHVpbnQ2 NF90KSwgREZHSGFuZGxlcl9Vbmlvbl9pc182NGJpdCk7CisgICAgICAgIHJldHVybiB1LmVuY29k ZWQ7CisgICAgfQorI2VuZGlmCisKKyAgICB1bmlvbiBVbmlvbiB7CisgICAgICAgIHN0cnVjdCBT dHJ1Y3QgeworICAgICAgICAgICAgRXhlY1N0YXRlKiBleGVjOworICAgICAgICAgICAgdm9pZCog aGFuZGxlcjsKKyAgICAgICAgfSBzOworICAgICAgICB1aW50NjRfdCBlbmNvZGVkOworICAgIH0g dTsKIH07Ci1ERkdIYW5kbGVyIERGR19PUEVSQVRJT04gbG9va3VwRXhjZXB0aW9uSGFuZGxlcihF eGVjU3RhdGUqLCBSZXR1cm5BZGRyZXNzUHRyIGZhdWx0TG9jYXRpb24pOworI2lmIENQVShYODZf NjQpCit0eXBlZGVmIERGR0hhbmRsZXIgREZHSGFuZGxlckVuY29kZWQ7CitpbmxpbmUgREZHSGFu ZGxlckVuY29kZWQgZGZnSGFuZGxlckVuY29kZWQoRXhlY1N0YXRlKiBleGVjLCB2b2lkKiBoYW5k bGVyKQoreworICAgIHJldHVybiBERkdIYW5kbGVyKGV4ZWMsIGhhbmRsZXIpOworfQorI2Vsc2UK K3R5cGVkZWYgdWludDY0X3QgREZHSGFuZGxlckVuY29kZWQ7CitpbmxpbmUgREZHSGFuZGxlckVu Y29kZWQgZGZnSGFuZGxlckVuY29kZWQoRXhlY1N0YXRlKiBleGVjLCB2b2lkKiBoYW5kbGVyKQor eworICAgIHJldHVybiBERkdIYW5kbGVyKGV4ZWMsIGhhbmRsZXIpLmVuY29kZWQoKTsKK30KKyNl bmRpZgorREZHSGFuZGxlckVuY29kZWQgREZHX09QRVJBVElPTiBsb29rdXBFeGNlcHRpb25IYW5k bGVyKEV4ZWNTdGF0ZSosIFJldHVybkFkZHJlc3NQdHIgZmF1bHRMb2NhdGlvbik7CiAKIC8vIFRo ZXNlIG9wZXJhdGlvbnMgaW1wbGVtZW50IHRoZSBpbXBsaWNpdGx5IGNhbGxlZCBUb0ludDMyLCBU b051bWJlciwgYW5kIFRvQm9vbGVhbiBjb252ZXJzaW9ucyBmcm9tIEVTNS4KIGRvdWJsZSBERkdf T1BFUkFUSU9OIGRmZ0NvbnZlcnRKU1ZhbHVlVG9OdW1iZXIoRXhlY1N0YXRlKiwgRW5jb2RlZEpT VmFsdWUpOwo=