74524 2011-12-14 11:14:36 -0800 Add unary and binary bind overloads 2011-12-14 11:56:08 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca webkit.review.bot oldest_to_newest 521109 0 andersca 2011-12-14 11:14:36 -0800 Add unary and binary bind overloads 521110 1 119258 andersca 2011-12-14 11:15:47 -0800 Created attachment 119258 Patch 521113 2 webkit.review.bot 2011-12-14 11:17:54 -0800 Attachment 119258 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:38: Extra space before ( in function call [whitespace/parens] [4] Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:41: Extra space before ( in function call [whitespace/parens] [4] Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:58: Extra space before ( in function call [whitespace/parens] [4] Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:61: Extra space before ( in function call [whitespace/parens] [4] Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:77: Extra space before ( in function call [whitespace/parens] [4] Tools/TestWebKitAPI/Tests/WTF/Functional.cpp:80: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/wtf/Functional.h:132: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/wtf/Functional.h:151: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/wtf/Functional.h:226: Extra space before ( in function call [whitespace/parens] [4] Source/JavaScriptCore/wtf/Functional.h:232: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 10 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 521156 3 andersca 2011-12-14 11:56:08 -0800 Committed r102808: <http://trac.webkit.org/changeset/102808> 119258 2011-12-14 11:15:47 -0800 2011-12-14 11:45:02 -0800 Patch bug-74524-20111214111547.patch text/plain 6863 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 ZWU2MjYxZWYzMDBiYjc0MDRjZjI0ZWQzNTI4Y2UwZTExZjY5MGE3Li41OTBjYzgwZDA1ODJjMTIw NDU5MWExZjhhNTFjZDBkM2ZkMTVkYzU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxMS0xMi0xNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUu Y29tPgogCisgICAgICAgIEFkZCB1bmFyeSBhbmQgYmluYXJ5IGJpbmQgb3ZlcmxvYWRzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDUyNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0Z1bmN0aW9u YWwuaDoKKyAgICAgICAgKFdURjo6Uik6CisgICAgICAgIChXVEY6OkZ1bmN0aW9uV3JhcHBlcjo6 UmVzdWx0VHlwZSk6CisgICAgICAgIChXVEY6OmJpbmQpOgorCisyMDExLTEyLTE0ICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgQWRkIGJhY2sgdGhlIGNh bGxPbk1haW5UaHJlYWQgb3ZlcmxvYWQgdGhhdCB0YWtlcyBhIFdURjo6RnVuY3Rpb24KICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0NTEyCiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvRnVuY3Rpb25hbC5oIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3d0Zi9GdW5jdGlvbmFsLmgKaW5kZXggYzI2ODhjZmVhMDlkYjg2ZGZlMzA5 NzBiZGY0Zjg2ZjBjOTBkNjY2MC4uNmUwZGRjZmUyNTg5MWEyZmRjOTYwZDYxOTMxOWZkMWM5ODFi ZmQ5NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9GdW5jdGlvbmFsLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9GdW5jdGlvbmFsLmgKQEAgLTYwLDYgKzYw LDQyIEBAIHByaXZhdGU6CiAgICAgUiAoKm1fZnVuY3Rpb24pKCk7CiB9OwogCit0ZW1wbGF0ZTx0 eXBlbmFtZSBSLCB0eXBlbmFtZSBQMD4gY2xhc3MgRnVuY3Rpb25XcmFwcGVyPFIgKCopKFAwKT4g eworcHVibGljOgorICAgIHR5cGVkZWYgUiBSZXN1bHRUeXBlOworCisgICAgZXhwbGljaXQgRnVu Y3Rpb25XcmFwcGVyKFIgKCpmdW5jdGlvbikoUDApKQorICAgICAgICA6IG1fZnVuY3Rpb24oZnVu Y3Rpb24pCisgICAgeworICAgIH0KKworICAgIFIgb3BlcmF0b3IoKShQMCBwMCkKKyAgICB7Cisg ICAgICAgIHJldHVybiBtX2Z1bmN0aW9uKHAwKTsKKyAgICB9CisKK3ByaXZhdGU6CisgICAgUiAo Km1fZnVuY3Rpb24pKFAwKTsKK307CisKK3RlbXBsYXRlPHR5cGVuYW1lIFIsIHR5cGVuYW1lIFAw LCB0eXBlbmFtZSBQMT4gY2xhc3MgRnVuY3Rpb25XcmFwcGVyPFIgKCopKFAwLCBQMSk+IHsKK3B1 YmxpYzoKKyAgICB0eXBlZGVmIFIgUmVzdWx0VHlwZTsKKworICAgIGV4cGxpY2l0IEZ1bmN0aW9u V3JhcHBlcihSICgqZnVuY3Rpb24pKFAwLCBQMSkpCisgICAgICAgIDogbV9mdW5jdGlvbihmdW5j dGlvbikKKyAgICB7CisgICAgfQorCisgICAgUiBvcGVyYXRvcigpKFAwIHAwLCBQMSBwMSkKKyAg ICB7CisgICAgICAgIHJldHVybiBtX2Z1bmN0aW9uKHAwLCBwMSk7CisgICAgfQorCitwcml2YXRl OgorICAgIFIgKCptX2Z1bmN0aW9uKShQMCwgUDEpOworfTsKKwogY2xhc3MgRnVuY3Rpb25JbXBs QmFzZSA6IHB1YmxpYyBUaHJlYWRTYWZlUmVmQ291bnRlZDxGdW5jdGlvbkltcGxCYXNlPiB7CiBw dWJsaWM6CiAgICAgdmlydHVhbCB+RnVuY3Rpb25JbXBsQmFzZSgpIHsgfQpAQCAtOTMsNiArMTI5 LDQ1IEBAIHByaXZhdGU6CiAgICAgRnVuY3Rpb25XcmFwcGVyIG1fZnVuY3Rpb25XcmFwcGVyOwog fTsKIAordGVtcGxhdGU8dHlwZW5hbWUgRnVuY3Rpb25XcmFwcGVyLCB0eXBlbmFtZSBQMD4gY2xh c3MgQm91bmRGdW5jdGlvbkltcGw8RnVuY3Rpb25XcmFwcGVyLCB0eXBlbmFtZSBGdW5jdGlvbldy YXBwZXI6OlJlc3VsdFR5cGUgKFAwKT4gOiBwdWJsaWMgRnVuY3Rpb25JbXBsPHR5cGVuYW1lIEZ1 bmN0aW9uV3JhcHBlcjo6UmVzdWx0VHlwZSAoKT4geworCitwdWJsaWM6CisgICAgQm91bmRGdW5j dGlvbkltcGwoRnVuY3Rpb25XcmFwcGVyIGZ1bmN0aW9uV3JhcHBlciwgY29uc3QgUDAmIHAwKQor ICAgICAgICA6IG1fZnVuY3Rpb25XcmFwcGVyKGZ1bmN0aW9uV3JhcHBlcikKKyAgICAgICAgLCBt X3AwKHAwKQorICAgIHsKKyAgICB9CisKKyAgICB2aXJ0dWFsIHR5cGVuYW1lIEZ1bmN0aW9uV3Jh cHBlcjo6UmVzdWx0VHlwZSBvcGVyYXRvcigpKCkKKyAgICB7CisgICAgICAgIHJldHVybiBtX2Z1 bmN0aW9uV3JhcHBlcihtX3AwKTsKKyAgICB9CisKK3ByaXZhdGU6CisgICAgRnVuY3Rpb25XcmFw cGVyIG1fZnVuY3Rpb25XcmFwcGVyOworICAgIFAwIG1fcDA7Cit9OworCit0ZW1wbGF0ZTx0eXBl bmFtZSBGdW5jdGlvbldyYXBwZXIsIHR5cGVuYW1lIFAwLCB0eXBlbmFtZSBQMT4gY2xhc3MgQm91 bmRGdW5jdGlvbkltcGw8RnVuY3Rpb25XcmFwcGVyLCB0eXBlbmFtZSBGdW5jdGlvbldyYXBwZXI6 OlJlc3VsdFR5cGUgKFAwLCBQMSk+IDogcHVibGljIEZ1bmN0aW9uSW1wbDx0eXBlbmFtZSBGdW5j dGlvbldyYXBwZXI6OlJlc3VsdFR5cGUgKCk+IHsKK3B1YmxpYzoKKyAgICBCb3VuZEZ1bmN0aW9u SW1wbChGdW5jdGlvbldyYXBwZXIgZnVuY3Rpb25XcmFwcGVyLCBjb25zdCBQMCYgcDAsIGNvbnN0 IFAxJiBwMSkKKyAgICAgICAgOiBtX2Z1bmN0aW9uV3JhcHBlcihmdW5jdGlvbldyYXBwZXIpCisg ICAgICAgICwgbV9wMChwMCkKKyAgICAgICAgLCBtX3AxKHAxKQorICAgIHsKKyAgICB9CisKKyAg ICB2aXJ0dWFsIHR5cGVuYW1lIEZ1bmN0aW9uV3JhcHBlcjo6UmVzdWx0VHlwZSBvcGVyYXRvcigp KCkKKyAgICB7CisgICAgICAgIHJldHVybiBtX2Z1bmN0aW9uV3JhcHBlcihtX3AwLCBtX3AxKTsK KyAgICB9CisKK3ByaXZhdGU6CisgICAgRnVuY3Rpb25XcmFwcGVyIG1fZnVuY3Rpb25XcmFwcGVy OworICAgIFAwIG1fcDA7CisgICAgUDEgbV9wMTsKK307CisKIGNsYXNzIEZ1bmN0aW9uQmFzZSB7 CiBwdWJsaWM6CiAgICAgYm9vbCBpc051bGwoKSBjb25zdApAQCAtMTQ3LDYgKzIyMiwxOCBAQCBG dW5jdGlvbjx0eXBlbmFtZSBGdW5jdGlvbldyYXBwZXI8RnVuY3Rpb25UeXBlPjo6UmVzdWx0VHlw ZSAoKT4gYmluZChGdW5jdGlvblR5cAogICAgIHJldHVybiBGdW5jdGlvbjx0eXBlbmFtZSBGdW5j dGlvbldyYXBwZXI8RnVuY3Rpb25UeXBlPjo6UmVzdWx0VHlwZSAoKT4oYWRvcHRSZWYobmV3IEJv dW5kRnVuY3Rpb25JbXBsPEZ1bmN0aW9uV3JhcHBlcjxGdW5jdGlvblR5cGU+LCB0eXBlbmFtZSBG dW5jdGlvbldyYXBwZXI8RnVuY3Rpb25UeXBlPjo6UmVzdWx0VHlwZSAoKT4oRnVuY3Rpb25XcmFw cGVyPEZ1bmN0aW9uVHlwZT4oZnVuY3Rpb24pKSkpOwogfQogCit0ZW1wbGF0ZTx0eXBlbmFtZSBG dW5jdGlvblR5cGUsIHR5cGVuYW1lIEExPgorRnVuY3Rpb248dHlwZW5hbWUgRnVuY3Rpb25XcmFw cGVyPEZ1bmN0aW9uVHlwZT46OlJlc3VsdFR5cGUgKCk+IGJpbmQoRnVuY3Rpb25UeXBlIGZ1bmN0 aW9uLCBjb25zdCBBMSYgYTEpCit7CisgICAgcmV0dXJuIEZ1bmN0aW9uPHR5cGVuYW1lIEZ1bmN0 aW9uV3JhcHBlcjxGdW5jdGlvblR5cGU+OjpSZXN1bHRUeXBlICgpPihhZG9wdFJlZihuZXcgQm91 bmRGdW5jdGlvbkltcGw8RnVuY3Rpb25XcmFwcGVyPEZ1bmN0aW9uVHlwZT4sIHR5cGVuYW1lIEZ1 bmN0aW9uV3JhcHBlcjxGdW5jdGlvblR5cGU+OjpSZXN1bHRUeXBlIChBMSk+KEZ1bmN0aW9uV3Jh cHBlcjxGdW5jdGlvblR5cGU+KGZ1bmN0aW9uKSwgYTEpKSk7Cit9CisKK3RlbXBsYXRlPHR5cGVu YW1lIEZ1bmN0aW9uVHlwZSwgdHlwZW5hbWUgQTEsIHR5cGVuYW1lIEEyPgorRnVuY3Rpb248dHlw ZW5hbWUgRnVuY3Rpb25XcmFwcGVyPEZ1bmN0aW9uVHlwZT46OlJlc3VsdFR5cGUgKCk+IGJpbmQo RnVuY3Rpb25UeXBlIGZ1bmN0aW9uLCBjb25zdCBBMSYgYTEsIGNvbnN0IEEyJiBhMikKK3sKKyAg ICByZXR1cm4gRnVuY3Rpb248dHlwZW5hbWUgRnVuY3Rpb25XcmFwcGVyPEZ1bmN0aW9uVHlwZT46 OlJlc3VsdFR5cGUgKCk+KGFkb3B0UmVmKG5ldyBCb3VuZEZ1bmN0aW9uSW1wbDxGdW5jdGlvbldy YXBwZXI8RnVuY3Rpb25UeXBlPiwgdHlwZW5hbWUgRnVuY3Rpb25XcmFwcGVyPEZ1bmN0aW9uVHlw ZT46OlJlc3VsdFR5cGUgKEExLCBBMik+KEZ1bmN0aW9uV3JhcHBlcjxGdW5jdGlvblR5cGU+KGZ1 bmN0aW9uKSwgYTEsIGEyKSkpOworfQorCiB9CiAKIHVzaW5nIFdURjo6RnVuY3Rpb247CmRpZmYg LS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjI0N2IyMDQ3 MDE2NzhjZDY1ZDRhZjFlYmUzM2ExNzE4ZmQxYTk3Yi4uYTY3Y2Q1OWI5OTk1YzNkZmJlMTQ4Yjhk NWEyZjZjZTM4NTZlYjMxOSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDExLTEyLTE0ICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHVuYXJ5IGFuZCBiaW5hcnkgYmlu ZCBvdmVybG9hZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTc0NTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQWRkIHRlc3RzLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRnVuY3Rp b25hbC5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKyAgICAgICAgKFRlc3RX ZWJLaXRBUEk6Om11bHRpcGx5QnlUd28pOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6bXVsdGlw bHlCeU9uZUFuZEFIYWxmKToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6Om11bHRpcGx5KToKKyAg ICAgICAgKFRlc3RXZWJLaXRBUEk6OnN1YnRyYWN0KToKKwogMjAxMS0xMi0xNCAgQ3NhYmEgT3N6 dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0gVW5yZXZpZXdlZCBz cGVjdWxhdGl2ZSBNSVBTIGFuZCBTSDQgYnVpbGRmaXggYWZ0ZXIgcjEwMjc3Ni4KZGlmZiAtLWdp dCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL0Z1bmN0aW9uYWwuY3BwIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRnVuY3Rpb25hbC5jcHAKaW5kZXggMWQ0NGMwYTVmZmVh Y2RhM2YyOGJjMzg4MDhjZTFhYjAzNjZlMTNjNy4uZjZhODFmMTczNGQ3MDA0YjM3MTU1OTM0MWIx MTQ4MWIzNGI1NmYyYSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYv RnVuY3Rpb25hbC5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvRnVuY3Rp b25hbC5jcHAKQEAgLTM1LDEyICszNSw1MCBAQCBzdGF0aWMgaW50IHJldHVybkZvcnR5VHdvKCkK IAogVEVTVChGdW5jdGlvbmFsVGVzdCwgQmFzaWMpCiB7Ci0gICAgRnVuY3Rpb248aW50KCk+IGVt cHR5RnVuY3Rpb247CisgICAgRnVuY3Rpb248aW50ICgpPiBlbXB0eUZ1bmN0aW9uOwogICAgIEFT U0VSVF9UUlVFKGVtcHR5RnVuY3Rpb24uaXNOdWxsKCkpOwogCi0gICAgRnVuY3Rpb248aW50KCk+ IHJldHVybkZvcnR5VHdvRnVuY3Rpb24gPSBiaW5kKHJldHVybkZvcnR5VHdvKTsKKyAgICBGdW5j dGlvbjxpbnQgKCk+IHJldHVybkZvcnR5VHdvRnVuY3Rpb24gPSBiaW5kKHJldHVybkZvcnR5VHdv KTsKICAgICBBU1NFUlRfRkFMU0UocmV0dXJuRm9ydHlUd29GdW5jdGlvbi5pc051bGwoKSk7CiAg ICAgQVNTRVJUX0VRKDQyLCByZXR1cm5Gb3J0eVR3b0Z1bmN0aW9uKCkpOwogfQogCitzdGF0aWMg aW50IG11bHRpcGx5QnlUd28oaW50IG4pCit7CisgICAgcmV0dXJuIG4gKiAyOworfQorCitzdGF0 aWMgZG91YmxlIG11bHRpcGx5QnlPbmVBbmRBSGFsZihkb3VibGUgZCkKK3sKKyAgICByZXR1cm4g ZCAqIDEuNTsKK30KKworVEVTVChGdW5jdGlvbmFsVGVzdCwgVW5hcnlCaW5kKQoreworICAgIEZ1 bmN0aW9uPGludCAoKT4gbXVsdGlwbHlGb3VyQnlUd29GdW5jdGlvbiA9IGJpbmQobXVsdGlwbHlC eVR3bywgNCk7CisgICAgQVNTRVJUX0VRKDgsIG11bHRpcGx5Rm91ckJ5VHdvRnVuY3Rpb24oKSk7 CisKKyAgICBGdW5jdGlvbjxkb3VibGUgKCk+IG11bHRpcGx5QnlPbmVBbmRBSGFsZkZ1bmN0aW9u ID0gYmluZChtdWx0aXBseUJ5T25lQW5kQUhhbGYsIDMpOworICAgIEFTU0VSVF9FUSg0LjUsIG11 bHRpcGx5QnlPbmVBbmRBSGFsZkZ1bmN0aW9uKCkpOworfQorCitzdGF0aWMgaW50IG11bHRpcGx5 KGludCB4LCBpbnQgeSkKK3sKKyAgICByZXR1cm4geCAqIHk7Cit9CisKK3N0YXRpYyBpbnQgc3Vi dHJhY3QoaW50IHgsIGludCB5KQoreworICAgIHJldHVybiB4IC0geTsKK30KKworVEVTVChGdW5j dGlvbmFsVGVzdCwgQmluYXJ5QmluZCkKK3sKKyAgICBGdW5jdGlvbjxpbnQgKCk+IG11bHRpcGx5 Rm91ckJ5VHdvRnVuY3Rpb24gPSBiaW5kKG11bHRpcGx5LCA0LCAyKTsKKyAgICBBU1NFUlRfRVEo OCwgbXVsdGlwbHlGb3VyQnlUd29GdW5jdGlvbigpKTsKKworICAgIEZ1bmN0aW9uPGludCAoKT4g c3VidHJhY3RUd29Gcm9tRm91ckZ1bmN0aW9uID0gYmluZChzdWJ0cmFjdCwgNCwgMik7CisgICAg QVNTRVJUX0VRKDIsIHN1YnRyYWN0VHdvRnJvbUZvdXJGdW5jdGlvbigpKTsKK30KKwogfSAvLyBu YW1lc3BhY2UgVGVzdFdlYktpdEFQSQo=