74523 2011-12-14 11:01:39 -0800 [GTK] Page size should be 0,0 when view widget is not realized 2011-12-14 11:38:30 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo pnormand webkit.review.bot oldest_to_newest 521086 0 cgarcia 2011-12-14 11:01:39 -0800 For consistency with WebCore that uses 0,0 as empty size. GTK+ initializes the widget allocation as -1, -1, 1, 1. 521092 1 119254 cgarcia 2011-12-14 11:04:37 -0800 Created attachment 119254 Patch 521098 2 119254 mrobinson 2011-12-14 11:08:17 -0800 Comment on attachment 119254 Patch How did you notice this? Did it cause a bug somewhere? 521106 3 webkit.review.bot 2011-12-14 11:12:42 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 521121 4 cgarcia 2011-12-14 11:24:22 -0800 (In reply to comment #2) > (From update of attachment 119254 [details]) > How did you notice this? Did it cause a bug somewhere? Writing the unit test for the window properties patch. I do someting like window.open('', '', 'left=10,top=20,width=800,height=600'); and I get 10, 20, 799, 599 from WindowFeatures, because in FrameLoader::createWindow() the window size is adjusted for the difference between the window size and the page size: if (features.widthSet) windowRect.setWidth(features.width + (windowRect.width() - pageSize.width())); if (features.heightSet) windowRect.setHeight(features.height + (windowRect.height() - pageSize.height())); initially the window rect is 0, 0 and page size is 1, 1 521139 5 cgarcia 2011-12-14 11:38:30 -0800 Committed r102804: <http://trac.webkit.org/changeset/102804> 119254 2011-12-14 11:04:37 -0800 2011-12-14 11:30:00 -0800 Patch wk2-page-size.diff text/plain 1440 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmZWE2ZTkzLi4wNjliMzU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMTItMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFBhZ2Ugc2l6ZSBzaG91bGQgYmUgMCwwIHdoZW4gdmlldyB3aWRn ZXQgaXMgbm90IHJlYWxpemVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD03NDUyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlIGN1cnJlbnRseSByZXR1cm4gMSwxIGJlY2F1c2UgR1RLKyBpbml0aWFsaXpl cyB3aWRnZXQgYWxsb2NhdGlvbgorICAgICAgICBhcyAtMSwtMSwxLDEuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBh Z2VDbGllbnRJbXBsOjp2aWV3U2l6ZSk6IENoZWNrIHdoZXRoZXIgd2lkZ2V0IGlzCisgICAgICAg IHJlYWxpemVkIGFuZCByZXR1cm4gSW50U2l6ZSgpIGluIHRoYXQgY2FzZS4KKwogMjAxMS0xMi0x MyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAg W0dUS10gQWRkIHN1cHBvcnQgZm9yIGphdmFzY3JpcHQgZGlhbG9ncyBpbiBXZWJLaXQyIEdUSysg QVBJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xp ZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50 SW1wbC5jcHAKaW5kZXggMGU0MzI1OS4uYzNhZDNmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcApAQCAtODcsNiArODcsOCBA QCB2b2lkIFBhZ2VDbGllbnRJbXBsOjpzY3JvbGxWaWV3KGNvbnN0IFdlYkNvcmU6OkludFJlY3Qm IHNjcm9sbFJlY3QsIGNvbnN0IFdlYkNvcgogCiBXZWJDb3JlOjpJbnRTaXplIFBhZ2VDbGllbnRJ bXBsOjp2aWV3U2l6ZSgpCiB7CisgICAgaWYgKCFndGtfd2lkZ2V0X2dldF9yZWFsaXplZChtX3Zp ZXdXaWRnZXQpKQorICAgICAgICByZXR1cm4gSW50U2l6ZSgpOwogICAgIEd0a0FsbG9jYXRpb24g YWxsb2NhdGlvbjsKICAgICBndGtfd2lkZ2V0X2dldF9hbGxvY2F0aW9uKG1fdmlld1dpZGdldCwg JmFsbG9jYXRpb24pOwogICAgIHJldHVybiBJbnRTaXplKGFsbG9jYXRpb24ud2lkdGgsIGFsbG9j YXRpb24uaGVpZ2h0KTsK