74522 2011-12-14 11:00:52 -0800 [Qt] DeviceOrientationClientQt should initialize m_controller to zero. 2011-12-14 14:10:08 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ahf ahf kenneth tonikitoo vestbo webkit.review.bot oldest_to_newest 521084 0 ahf 2011-12-14 11:00:52 -0800 We currently forget to set m_controller to zero upon construction. We should also forward any calls to setController() to our provider. Patch coming. 521090 1 119253 ahf 2011-12-14 11:03:27 -0800 Created attachment 119253 Patch 521094 2 119253 vestbo 2011-12-14 11:06:26 -0800 Comment on attachment 119253 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119253&action=review > Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.cpp:33 > + m_controller = 0; initializer 521105 3 119257 ahf 2011-12-14 11:12:30 -0800 Created attachment 119257 Patch 521107 4 ahf 2011-12-14 11:13:44 -0800 Adding Tor Arne. 521169 5 119257 tonikitoo 2011-12-14 12:14:41 -0800 Comment on attachment 119257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119257&action=review > Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp:43 > + ASSERT(controller); > m_controller = controller; > + m_provider->setController(controller); you seem to be doing more than what to changelog'ed. > Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.cpp:32 > + : m_lastOrientation(DeviceOrientation::create()) > + , m_controller(0) > + , m_sensor() ditto 521170 6 tonikitoo 2011-12-14 12:15:49 -0800 (In reply to comment #5) > (From update of attachment 119257 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119257&action=review > > > Source/WebKit/qt/WebCoreSupport/DeviceOrientationClientQt.cpp:43 > > + ASSERT(controller); > > m_controller = controller; > > + m_provider->setController(controller); > > you seem to be doing more than what to changelog'ed. s/what to/what you/g 521192 7 119257 kenneth 2011-12-14 12:39:08 -0800 Comment on attachment 119257 Patch Write proper changelogs Alex! :-) 521198 8 ahf 2011-12-14 12:46:14 -0800 (In reply to comment #7) > (From update of attachment 119257 [details]) > Write proper changelogs Alex! :-) It is because you are not around to pet me! Jokes aside, new patch coming up in one moment. It is being split up such that the setController() changes are being moved to a separate patch. 521206 9 119257 kenneth 2011-12-14 12:51:18 -0800 Comment on attachment 119257 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119257&action=review > Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.cpp:31 > + , m_controller(0) why isn't it a smart controller? you seem to use it by two here in this patch? should it be reffed? 521208 10 kenneth 2011-12-14 12:52:33 -0800 (In reply to comment #9) > (From update of attachment 119257 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119257&action=review > > > Source/WebKit/qt/WebCoreSupport/DeviceOrientationProviderQt.cpp:31 > > + , m_controller(0) > > why isn't it a smart controller? you seem to use it by two here in this patch? should it be reffed? smart pointer :-) 521214 11 119278 ahf 2011-12-14 12:55:34 -0800 Created attachment 119278 Patch 521277 12 119278 webkit.review.bot 2011-12-14 14:10:04 -0800 Comment on attachment 119278 Patch Clearing flags on attachment: 119278 Committed r102822: <http://trac.webkit.org/changeset/102822> 521278 13 webkit.review.bot 2011-12-14 14:10:08 -0800 All reviewed patches have been landed. Closing bug. 119253 2011-12-14 11:03:27 -0800 2011-12-14 11:12:21 -0800 Patch bug-74522-20111214200323.patch text/plain 2278 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDU2NWRkOTNjYTRl NDI3MmQ5ZWVjNDRmNTJhMjhmOTViZThkOTVlMjYuLmYyNDkwNDQ2MThhN2Q1ODFiNmM5YWVmNWQ3 ODIwMTUxYjBjMmEwOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTIt MTQgIEFsZXhhbmRlciBGw6Zyw7h5ICA8YWhmQDB4OTAuZGs+CisKKyAgICAgICAgW1F0XSBEZXZp Y2VPcmllbnRhdGlvbkNsaWVudFF0IHNob3VsZCBpbml0aWFsaXplIG1fY29udHJvbGxlciB0byB6 ZXJvLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ1 MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdl YkNvcmVTdXBwb3J0L0RldmljZU9yaWVudGF0aW9uQ2xpZW50UXQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RGV2aWNlT3JpZW50YXRpb25DbGllbnRRdDo6c2V0Q29udHJvbGxlcik6CisgICAgICAg ICogV2ViQ29yZVN1cHBvcnQvRGV2aWNlT3JpZW50YXRpb25Qcm92aWRlclF0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkRldmljZU9yaWVudGF0aW9uUHJvdmlkZXJRdDo6RGV2aWNlT3JpZW50YXRp b25Qcm92aWRlclF0KToKKwogMjAxMS0xMi0xNCAgQWxleGFuZGVyIEbDpnLDuHkgIDxhbGV4YW5k ZXIuZmFlcm95QG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZpeCBjb21waWxhdGlvbiBvZiBR dFdlYktpdCB3aXRoIC0tb3JpZW50YXRpb24tZXZlbnRzIHdpdGhvdXQgRU5BQkxFX0RFVklDRV9P UklFTlRBVElPTgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9E ZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1 cHBvcnQvRGV2aWNlT3JpZW50YXRpb25DbGllbnRRdC5jcHAKaW5kZXggODJmOWI3ZjlhNjM4NWU0 ZGE5YTQ2NDQ4OGEyOWVhYmE1OTliOTVlNi4uZmUwOWZmODUwZTdhNmEyY2EwOTZkOTI4Y2E3MWJh ZDFiNmFmMzkzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9E ZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNv cmVTdXBwb3J0L0RldmljZU9yaWVudGF0aW9uQ2xpZW50UXQuY3BwCkBAIC0zOCw3ICszOCw5IEBA IERldmljZU9yaWVudGF0aW9uQ2xpZW50UXQ6On5EZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0KCkK IAogdm9pZCBEZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0OjpzZXRDb250cm9sbGVyKERldmljZU9y aWVudGF0aW9uQ29udHJvbGxlciogY29udHJvbGxlcikKIHsKKyAgICBBU1NFUlQoY29udHJvbGxl cik7CiAgICAgbV9jb250cm9sbGVyID0gY29udHJvbGxlcjsKKyAgICBtX3Byb3ZpZGVyLT5zZXRD b250cm9sbGVyKGNvbnRyb2xsZXIpOwogfQogCiB2b2lkIERldmljZU9yaWVudGF0aW9uQ2xpZW50 UXQ6OnN0YXJ0VXBkYXRpbmcoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3Jl U3VwcG9ydC9EZXZpY2VPcmllbnRhdGlvblByb3ZpZGVyUXQuY3BwIGIvU291cmNlL1dlYktpdC9x dC9XZWJDb3JlU3VwcG9ydC9EZXZpY2VPcmllbnRhdGlvblByb3ZpZGVyUXQuY3BwCmluZGV4IDIx N2JmNTUxMTEzODg0MjhiMWY3OTQ1MTI5MmFkZDdhODFhM2U4NWMuLmJiZTYwOGQzYmQzZmEyMGFm ZmJhY2Q0NTAwN2JjODU0ODE3NTlmN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvRGV2aWNlT3JpZW50YXRpb25Qcm92aWRlclF0LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0RldmljZU9yaWVudGF0aW9uUHJvdmlkZXJRdC5jcHAK QEAgLTMwLDYgKzMwLDcgQEAgRGV2aWNlT3JpZW50YXRpb25Qcm92aWRlclF0OjpEZXZpY2VPcmll bnRhdGlvblByb3ZpZGVyUXQoKQogewogICAgIG1fc2Vuc29yLmFkZEZpbHRlcih0aGlzKTsKICAg ICBtX2xhc3RPcmllbnRhdGlvbiA9IERldmljZU9yaWVudGF0aW9uOjpjcmVhdGUoKTsKKyAgICBt X2NvbnRyb2xsZXIgPSAwOwogfQogCiB2b2lkIERldmljZU9yaWVudGF0aW9uUHJvdmlkZXJRdDo6 c2V0Q29udHJvbGxlcihEZXZpY2VPcmllbnRhdGlvbkNvbnRyb2xsZXIqIGNvbnRyb2xsZXIpCg== 119257 2011-12-14 11:12:30 -0800 2011-12-14 12:55:19 -0800 Patch bug-74522-20111214201227.patch text/plain 2393 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNzkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDU2NWRkOTNjYTRl NDI3MmQ5ZWVjNDRmNTJhMjhmOTViZThkOTVlMjYuLmYyNDkwNDQ2MThhN2Q1ODFiNmM5YWVmNWQ3 ODIwMTUxYjBjMmEwOTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTIt MTQgIEFsZXhhbmRlciBGw6Zyw7h5ICA8YWhmQDB4OTAuZGs+CisKKyAgICAgICAgW1F0XSBEZXZp Y2VPcmllbnRhdGlvbkNsaWVudFF0IHNob3VsZCBpbml0aWFsaXplIG1fY29udHJvbGxlciB0byB6 ZXJvLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ1 MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdl YkNvcmVTdXBwb3J0L0RldmljZU9yaWVudGF0aW9uQ2xpZW50UXQuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RGV2aWNlT3JpZW50YXRpb25DbGllbnRRdDo6c2V0Q29udHJvbGxlcik6CisgICAgICAg ICogV2ViQ29yZVN1cHBvcnQvRGV2aWNlT3JpZW50YXRpb25Qcm92aWRlclF0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkRldmljZU9yaWVudGF0aW9uUHJvdmlkZXJRdDo6RGV2aWNlT3JpZW50YXRp b25Qcm92aWRlclF0KToKKwogMjAxMS0xMi0xNCAgQWxleGFuZGVyIEbDpnLDuHkgIDxhbGV4YW5k ZXIuZmFlcm95QG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZpeCBjb21waWxhdGlvbiBvZiBR dFdlYktpdCB3aXRoIC0tb3JpZW50YXRpb24tZXZlbnRzIHdpdGhvdXQgRU5BQkxFX0RFVklDRV9P UklFTlRBVElPTgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9E ZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1 cHBvcnQvRGV2aWNlT3JpZW50YXRpb25DbGllbnRRdC5jcHAKaW5kZXggODJmOWI3ZjlhNjM4NWU0 ZGE5YTQ2NDQ4OGEyOWVhYmE1OTliOTVlNi4uZmUwOWZmODUwZTdhNmEyY2EwOTZkOTI4Y2E3MWJh ZDFiNmFmMzkzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9E ZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNv cmVTdXBwb3J0L0RldmljZU9yaWVudGF0aW9uQ2xpZW50UXQuY3BwCkBAIC0zOCw3ICszOCw5IEBA IERldmljZU9yaWVudGF0aW9uQ2xpZW50UXQ6On5EZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0KCkK IAogdm9pZCBEZXZpY2VPcmllbnRhdGlvbkNsaWVudFF0OjpzZXRDb250cm9sbGVyKERldmljZU9y aWVudGF0aW9uQ29udHJvbGxlciogY29udHJvbGxlcikKIHsKKyAgICBBU1NFUlQoY29udHJvbGxl cik7CiAgICAgbV9jb250cm9sbGVyID0gY29udHJvbGxlcjsKKyAgICBtX3Byb3ZpZGVyLT5zZXRD b250cm9sbGVyKGNvbnRyb2xsZXIpOwogfQogCiB2b2lkIERldmljZU9yaWVudGF0aW9uQ2xpZW50 UXQ6OnN0YXJ0VXBkYXRpbmcoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC9XZWJDb3Jl U3VwcG9ydC9EZXZpY2VPcmllbnRhdGlvblByb3ZpZGVyUXQuY3BwIGIvU291cmNlL1dlYktpdC9x dC9XZWJDb3JlU3VwcG9ydC9EZXZpY2VPcmllbnRhdGlvblByb3ZpZGVyUXQuY3BwCmluZGV4IDIx N2JmNTUxMTEzODg0MjhiMWY3OTQ1MTI5MmFkZDdhODFhM2U4NWMuLjExNTY1MWMwNjAwMzI4ODRi ZGE3ZGU2NzZmOGM1Mjg1OTE4ZWVhYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvV2Vi Q29yZVN1cHBvcnQvRGV2aWNlT3JpZW50YXRpb25Qcm92aWRlclF0LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0RldmljZU9yaWVudGF0aW9uUHJvdmlkZXJRdC5jcHAK QEAgLTI3LDkgKzI3LDExIEBAIFFUTV9VU0VfTkFNRVNQQUNFCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIERldmljZU9yaWVudGF0aW9uUHJvdmlkZXJRdDo6RGV2aWNlT3JpZW50YXRpb25Qcm92aWRl clF0KCkKKyAgICA6IG1fbGFzdE9yaWVudGF0aW9uKERldmljZU9yaWVudGF0aW9uOjpjcmVhdGUo KSkKKyAgICAsIG1fY29udHJvbGxlcigwKQorICAgICwgbV9zZW5zb3IoKQogewogICAgIG1fc2Vu c29yLmFkZEZpbHRlcih0aGlzKTsKLSAgICBtX2xhc3RPcmllbnRhdGlvbiA9IERldmljZU9yaWVu dGF0aW9uOjpjcmVhdGUoKTsKIH0KIAogdm9pZCBEZXZpY2VPcmllbnRhdGlvblByb3ZpZGVyUXQ6 OnNldENvbnRyb2xsZXIoRGV2aWNlT3JpZW50YXRpb25Db250cm9sbGVyKiBjb250cm9sbGVyKQo= 119278 2011-12-14 12:55:34 -0800 2011-12-14 14:10:03 -0800 Patch bug-74522-20111214215530.patch text/plain 1413 ahf U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyODA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDU2NWRkOTNjYTRl NDI3MmQ5ZWVjNDRmNTJhMjhmOTViZThkOTVlMjYuLjg2OGUwY2ZkNzYxYzNiZWZjMjJjZWMyNjE4 NmU1ODQ1MzVkYmExZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTIt MTQgIEFsZXhhbmRlciBGw6Zyw7h5ICA8YWhmQDB4OTAuZGs+CisKKyAgICAgICAgW1F0XSBEZXZp Y2VPcmllbnRhdGlvbkNsaWVudFF0IHNob3VsZCBpbml0aWFsaXplIG1fY29udHJvbGxlciB0byB6 ZXJvLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ1 MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdl YkNvcmVTdXBwb3J0L0RldmljZU9yaWVudGF0aW9uUHJvdmlkZXJRdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpEZXZpY2VPcmllbnRhdGlvblByb3ZpZGVyUXQ6OkRldmljZU9yaWVudGF0aW9uUHJv dmlkZXJRdCk6CisKIDIwMTEtMTItMTQgIEFsZXhhbmRlciBGw6Zyw7h5ICA8YWxleGFuZGVyLmZh ZXJveUBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBGaXggY29tcGlsYXRpb24gb2YgUXRXZWJL aXQgd2l0aCAtLW9yaWVudGF0aW9uLWV2ZW50cyB3aXRob3V0IEVOQUJMRV9ERVZJQ0VfT1JJRU5U QVRJT04KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRGV2aWNl T3JpZW50YXRpb25Qcm92aWRlclF0LmNwcCBiL1NvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBv cnQvRGV2aWNlT3JpZW50YXRpb25Qcm92aWRlclF0LmNwcAppbmRleCAyMTdiZjU1MTExMzg4NDI4 YjFmNzk0NTEyOTJhZGQ3YTgxYTNlODVjLi43YmNkYTEyMDkwMmExNmMxNGVkOTI2Yzc5ZDFiZWNl Mzg1MzlmM2QyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Rl dmljZU9yaWVudGF0aW9uUHJvdmlkZXJRdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9EZXZpY2VPcmllbnRhdGlvblByb3ZpZGVyUXQuY3BwCkBAIC0yNyw2ICsyNyw3 IEBAIFFUTV9VU0VfTkFNRVNQQUNFCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIERldmljZU9yaWVu dGF0aW9uUHJvdmlkZXJRdDo6RGV2aWNlT3JpZW50YXRpb25Qcm92aWRlclF0KCkKKyAgICA6IG1f Y29udHJvbGxlcigwKQogewogICAgIG1fc2Vuc29yLmFkZEZpbHRlcih0aGlzKTsKICAgICBtX2xh c3RPcmllbnRhdGlvbiA9IERldmljZU9yaWVudGF0aW9uOjpjcmVhdGUoKTsK