74444 2011-12-13 13:32:21 -0800 [Blackberry] Fix a leak in BackingStore class 2011-12-13 15:40:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 arvid2.nilsson arvid2.nilsson jkjiang tonikitoo webkit.review.bot oldest_to_newest 520339 0 arvid2.nilsson 2011-12-13 13:32:21 -0800 Don't leak the blit generation mutex+cond var 520344 1 119078 arvid2.nilsson 2011-12-13 13:42:49 -0800 Created attachment 119078 Patch 520365 2 119078 arvid2.nilsson 2011-12-13 14:15:58 -0800 Comment on attachment 119078 Patch There's no ChangeLog entry 520366 3 119082 arvid2.nilsson 2011-12-13 14:17:32 -0800 Created attachment 119082 Patch 520369 4 119082 tonikitoo 2011-12-13 14:19:15 -0800 Comment on attachment 119082 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119082&action=review > Source/WebKit/ChangeLog:7 > +2011-12-13 Arvid Nilsson <anilsson@rim.com> > + > + [Blackberry] Fix a leak in BackingStore class > + https://bugs.webkit.org/show_bug.cgi?id=74444 > + > + Reviewed by NOBODY (OOPS!). > + Arvid, could you add to the changelog what was leaking? 520370 5 119083 arvid2.nilsson 2011-12-13 14:22:46 -0800 Created attachment 119083 Patch 520373 6 119083 tonikitoo 2011-12-13 14:25:29 -0800 Comment on attachment 119083 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119083&action=review > Source/WebKit/ChangeLog:9 > + Don't leak the blit generation condvar and mutex. > + > + https://bugs.webkit.org/show_bug.cgi?id=74444 > + > + Reviewed by NOBODY (OOPS!). The order is bug title, bug url, reviewed by, fix explanation :) ok for now though. 520425 7 119083 webkit.review.bot 2011-12-13 15:40:02 -0800 Comment on attachment 119083 Patch Clearing flags on attachment: 119083 Committed r102713: <http://trac.webkit.org/changeset/102713> 520427 8 webkit.review.bot 2011-12-13 15:40:07 -0800 All reviewed patches have been landed. Closing bug. 119078 2011-12-13 13:42:49 -0800 2011-12-13 14:17:26 -0800 Patch bug-74444-20111213164247.patch text/plain 585 arvid2.nilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL0JhY2tpbmdTdG9yZS5jcHAKaW5kZXggNWZhYTYwZTQ5MTZhYWMzZWFhYTZmZDA5MGEwMzdh ZjQ0ZWE2ZjJkNi4uZjA4MjY0Njg4N2NiMzkwZjAyNWQxMmNkYjA3OWQyYmQwNjMwMTYyOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcApAQCAtMjE5 LDYgKzIxOSw4IEBAIEJhY2tpbmdTdG9yZVByaXZhdGU6On5CYWNraW5nU3RvcmVQcml2YXRlKCkK ICAgICBkZWxldGUgYmFjazsKICAgICBtX2JhY2tTdGF0ZSA9IDA7CiAKKyAgICBwdGhyZWFkX2Nv bmRfZGVzdHJveSgmbV9ibGl0R2VuZXJhdGlvbkNvbmQpOworICAgIHB0aHJlYWRfbXV0ZXhfZGVz dHJveSgmbV9ibGl0R2VuZXJhdGlvbkxvY2spOwogICAgIHB0aHJlYWRfbXV0ZXhfZGVzdHJveSgm bV9tdXRleCk7CiB9CiAK 119082 2011-12-13 14:17:32 -0800 2011-12-13 14:22:36 -0800 Patch bug-74444-20111213171730.patch text/plain 1235 arvid2.nilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU4M2QzYjUxNDdjYWE5OWVk YTE0YWYwYzYwODI1MTNkNGJlZTAyNDIuLjI3MWE2YTc0OWFmN2ZhZWRjZjEyNmJmYzlmMGFkNDAx M2JkMDU4NGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMTItMTMgIEFydmlkIE5p bHNzb24gIDxhbmlsc3NvbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja2JlcnJ5XSBGaXggYSBs ZWFrIGluIEJhY2tpbmdTdG9yZSBjbGFzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NzQ0NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIGJsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHA6CisgICAg ICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6On5CYWNraW5nU3Rv cmVQcml2YXRlKToKKwogMjAxMS0wNy0yOCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEFkZCBzcWwgdG8gc3ZuOmlnbm9yZSBhbmQgcmVtb3ZlIGFwcC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcCBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAppbmRleCA1ZmFhNjBl NDkxNmFhYzNlYWFhNmZkMDkwYTAzN2FmNDRlYTZmMmQ2Li5mMDgyNjQ2ODg3Y2IzOTBmMDI1ZDEy Y2RiMDc5ZDJiZDA2MzAxNjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL0JhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9C YWNraW5nU3RvcmUuY3BwCkBAIC0yMTksNiArMjE5LDggQEAgQmFja2luZ1N0b3JlUHJpdmF0ZTo6 fkJhY2tpbmdTdG9yZVByaXZhdGUoKQogICAgIGRlbGV0ZSBiYWNrOwogICAgIG1fYmFja1N0YXRl ID0gMDsKIAorICAgIHB0aHJlYWRfY29uZF9kZXN0cm95KCZtX2JsaXRHZW5lcmF0aW9uQ29uZCk7 CisgICAgcHRocmVhZF9tdXRleF9kZXN0cm95KCZtX2JsaXRHZW5lcmF0aW9uTG9jayk7CiAgICAg cHRocmVhZF9tdXRleF9kZXN0cm95KCZtX211dGV4KTsKIH0KIAo= 119083 2011-12-13 14:22:46 -0800 2011-12-13 15:40:02 -0800 Patch bug-74444-20111213172243.patch text/plain 1298 arvid2.nilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU4M2QzYjUxNDdjYWE5OWVk YTE0YWYwYzYwODI1MTNkNGJlZTAyNDIuLmZmZjQ1MWY3NmNjNDJjYmQ5OTQ4MzY0NjkzZTdjMTAz MWZjYzlmNjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTItMTMgIEFydmlkIE5p bHNzb24gIDxhbmlsc3NvbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja2JlcnJ5XSBGaXggYSBs ZWFrIGluIEJhY2tpbmdTdG9yZSBjbGFzcworCisgICAgICAgIERvbid0IGxlYWsgdGhlIGJsaXQg Z2VuZXJhdGlvbiBjb25kdmFyIGFuZCBtdXRleC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ0NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGJsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHA6 CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6On5CYWNr aW5nU3RvcmVQcml2YXRlKToKKwogMjAxMS0wNy0yOCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIEFkZCBzcWwgdG8gc3ZuOmlnbm9yZSBhbmQgcmVtb3ZlIGFwcC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNw cCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAppbmRleCA1 ZmFhNjBlNDkxNmFhYzNlYWFhNmZkMDkwYTAzN2FmNDRlYTZmMmQ2Li5mMDgyNjQ2ODg3Y2IzOTBm MDI1ZDEyY2RiMDc5ZDJiZDA2MzAxNjI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0FwaS9CYWNraW5nU3RvcmUuY3BwCkBAIC0yMTksNiArMjE5LDggQEAgQmFja2luZ1N0b3JlUHJp dmF0ZTo6fkJhY2tpbmdTdG9yZVByaXZhdGUoKQogICAgIGRlbGV0ZSBiYWNrOwogICAgIG1fYmFj a1N0YXRlID0gMDsKIAorICAgIHB0aHJlYWRfY29uZF9kZXN0cm95KCZtX2JsaXRHZW5lcmF0aW9u Q29uZCk7CisgICAgcHRocmVhZF9tdXRleF9kZXN0cm95KCZtX2JsaXRHZW5lcmF0aW9uTG9jayk7 CiAgICAgcHRocmVhZF9tdXRleF9kZXN0cm95KCZtX211dGV4KTsKIH0KIAo=