74437 2011-12-13 12:10:57 -0800 Update variable names in NamedNodeMap methods to match WebKit style 2011-12-13 14:32:25 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adamk adamk dglazkov ojan rniwa webkit.review.bot oldest_to_newest 520270 0 adamk 2011-12-13 12:10:57 -0800 Update variable names in NamedNodeMap methods to match WebKit style 520271 1 119060 adamk 2011-12-13 12:12:17 -0800 Created attachment 119060 Patch 520331 2 119060 webkit.review.bot 2011-12-13 13:22:30 -0800 Comment on attachment 119060 Patch Attachment 119060 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10848496 520359 3 adamk 2011-12-13 14:05:08 -0800 Committed r102705: <http://trac.webkit.org/changeset/102705> 119060 2011-12-13 12:12:17 -0800 2011-12-13 14:32:25 -0800 Patch bug-74437-20111213121216.patch text/plain 4471 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNjgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWQ0M2MyMWZjM2UyMjRk NTg5ZjdiYjRkYWIzNjJmYTNmYzc1ZWJhNS4uN2QwYmJjZDNkNDM5ODI1ZDcwM2IyZWI4NjQwODAx MTVlZjVmMDZlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDExLTEyLTEzICBBZGFt IEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFVwZGF0ZSB2YXJpYWJsZSBu YW1lcyBpbiBOYW1lZE5vZGVNYXAgbWV0aG9kcyB0byBtYXRjaCBXZWJLaXQgc3R5bGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0NDM3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hpbGUgcmVhZGluZyB0 aGVzZSBtZXRob2RzIGluIHByZXBhcmF0aW9uIGZvciBhIHJlZmFjdG9yLCBJIGZvdW5kCisgICAg ICAgIHRoZW0gaGFyZCB0byB1bmRlcnN0YW5kIGR1ZSB0byBzaG9ydCBvciBjb25mdXNpbmcgdmFy aWFibGUgbmFtZXMuCisgICAgICAgIEkgdGhpbmsgdGhlIG5ldyBuYW1lcyBhcmUgbXVjaCBjbGVh cmVyLCBhbmQgbWF0Y2ggV2ViS2l0IHN0eWxlLgorCisgICAgICAgICogZG9tL05hbWVkTm9kZU1h cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpOYW1lZE5vZGVNYXA6OnNldE5hbWVkSXRlbSk6Cisg ICAgICAgIChXZWJDb3JlOjpOYW1lZE5vZGVNYXA6OnJlbW92ZU5hbWVkSXRlbSk6CisKIDIwMTEt MTItMTMgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAg ICAgICAgIFtRdF0gR2V0IHJpZCBvZiBsYXllcmluZyB2aW9sYXRpb25zIGluIGluY2x1ZGVzCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vTmFtZWROb2RlTWFwLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9OYW1lZE5vZGVNYXAuY3BwCmluZGV4IDg1ODFhNjE3YTI2YTAwMjk0NzIzYzli NTA4MDAxNDgxMmRmNmMxMWIuLmRjNTM1MDE0Y2ZjMTE3ZTk2NmI2MTdhNmFkYTA5Njc3MTQ1YTYx NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1lZE5vZGVNYXAuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9OYW1lZE5vZGVNYXAuY3BwCkBAIC05MywyNiArOTMsMjYgQEAg UGFzc1JlZlB0cjxOb2RlPiBOYW1lZE5vZGVNYXA6OmdldE5hbWVkSXRlbShjb25zdCBRdWFsaWZp ZWROYW1lJiBuYW1lKSBjb25zdAogICAgIHJldHVybiBhLT5jcmVhdGVBdHRySWZOZWVkZWQobV9l bGVtZW50KTsKIH0KIAotUGFzc1JlZlB0cjxOb2RlPiBOYW1lZE5vZGVNYXA6OnNldE5hbWVkSXRl bShOb2RlKiBhcmcsIEV4Y2VwdGlvbkNvZGUmIGVjKQorUGFzc1JlZlB0cjxOb2RlPiBOYW1lZE5v ZGVNYXA6OnNldE5hbWVkSXRlbShOb2RlKiBub2RlLCBFeGNlcHRpb25Db2RlJiBlYykKIHsKLSAg ICBpZiAoIW1fZWxlbWVudCB8fCAhYXJnKSB7CisgICAgaWYgKCFtX2VsZW1lbnQgfHwgIW5vZGUp IHsKICAgICAgICAgZWMgPSBOT1RfRk9VTkRfRVJSOwogICAgICAgICByZXR1cm4gMDsKICAgICB9 CiAKICAgICAvLyBOb3QgbWVudGlvbmVkIGluIHNwZWM6IHRocm93IGEgSElFUkFSQ0hZX1JFUVVF U1RfRVJST1IgaWYgdGhlIHVzZXIgcGFzc2VzIGluIGEgbm9uLWF0dHJpYnV0ZSBub2RlCi0gICAg aWYgKCFhcmctPmlzQXR0cmlidXRlTm9kZSgpKSB7CisgICAgaWYgKCFub2RlLT5pc0F0dHJpYnV0 ZU5vZGUoKSkgewogICAgICAgICBlYyA9IEhJRVJBUkNIWV9SRVFVRVNUX0VSUjsKICAgICAgICAg cmV0dXJuIDA7CiAgICAgfQotICAgIEF0dHIgKmF0dHIgPSBzdGF0aWNfY2FzdDxBdHRyKj4oYXJn KTsKKyAgICBBdHRyKiBhdHRyID0gc3RhdGljX2Nhc3Q8QXR0cio+KG5vZGUpOwogCi0gICAgQXR0 cmlidXRlKiBhID0gYXR0ci0+YXR0cigpOwotICAgIEF0dHJpYnV0ZSogb2xkID0gZ2V0QXR0cmli dXRlSXRlbShhLT5uYW1lKCkpOwotICAgIGlmIChvbGQgPT0gYSkKLSAgICAgICAgcmV0dXJuIFJl ZlB0cjxOb2RlPihhcmcpOyAvLyB3ZSBrbm93IGFib3V0IGl0IGFscmVhZHkKKyAgICBBdHRyaWJ1 dGUqIGF0dHJpYnV0ZSA9IGF0dHItPmF0dHIoKTsKKyAgICBBdHRyaWJ1dGUqIG9sZEF0dHJpYnV0 ZSA9IGdldEF0dHJpYnV0ZUl0ZW0oYXR0cmlidXRlLT5uYW1lKCkpOworICAgIGlmIChvbGRBdHRy aWJ1dGUgPT0gYXR0cmlidXRlKQorICAgICAgICByZXR1cm4gbm9kZTsgLy8gd2Uga25vdyBhYm91 dCBpdCBhbHJlYWR5CiAKLSAgICAvLyBJTlVTRV9BVFRSSUJVVEVfRVJSOiBSYWlzZWQgaWYgYXJn IGlzIGFuIEF0dHIgdGhhdCBpcyBhbHJlYWR5IGFuIGF0dHJpYnV0ZSBvZiBhbm90aGVyIEVsZW1l bnQgb2JqZWN0LgorICAgIC8vIElOVVNFX0FUVFJJQlVURV9FUlI6IFJhaXNlZCBpZiBub2RlIGlz IGFuIEF0dHIgdGhhdCBpcyBhbHJlYWR5IGFuIGF0dHJpYnV0ZSBvZiBhbm90aGVyIEVsZW1lbnQg b2JqZWN0LgogICAgIC8vIFRoZSBET00gdXNlciBtdXN0IGV4cGxpY2l0bHkgY2xvbmUgQXR0ciBu b2RlcyB0byByZS11c2UgdGhlbSBpbiBvdGhlciBlbGVtZW50cy4KICAgICBpZiAoYXR0ci0+b3du ZXJFbGVtZW50KCkpIHsKICAgICAgICAgZWMgPSBJTlVTRV9BVFRSSUJVVEVfRVJSOwpAQCAtMTIw LDE3ICsxMjAsMTcgQEAgUGFzc1JlZlB0cjxOb2RlPiBOYW1lZE5vZGVNYXA6OnNldE5hbWVkSXRl bShOb2RlKiBhcmcsIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgIH0KIAogICAgIGlmIChhdHRyLT5p c0lkKCkpCi0gICAgICAgIG1fZWxlbWVudC0+dXBkYXRlSWQob2xkID8gb2xkLT52YWx1ZSgpIDog bnVsbEF0b20sIGEtPnZhbHVlKCkpOworICAgICAgICBtX2VsZW1lbnQtPnVwZGF0ZUlkKG9sZEF0 dHJpYnV0ZSA/IG9sZEF0dHJpYnV0ZS0+dmFsdWUoKSA6IG51bGxBdG9tLCBhdHRyaWJ1dGUtPnZh bHVlKCkpOwogCiAgICAgLy8gIyMjIHNsaWdodGx5IGluZWZmaWNpZW50IC0gcmVzaXplcyBhdHRy aWJ1dGUgYXJyYXkgdHdpY2UuCi0gICAgUmVmUHRyPE5vZGU+IHI7Ci0gICAgaWYgKG9sZCkgewot ICAgICAgICByID0gb2xkLT5jcmVhdGVBdHRySWZOZWVkZWQobV9lbGVtZW50KTsKLSAgICAgICAg cmVtb3ZlQXR0cmlidXRlKGEtPm5hbWUoKSk7CisgICAgUmVmUHRyPEF0dHI+IG9sZEF0dHI7Cisg ICAgaWYgKG9sZEF0dHJpYnV0ZSkgeworICAgICAgICBvbGRBdHRyID0gb2xkQXR0cmlidXRlLT5j cmVhdGVBdHRySWZOZWVkZWQobV9lbGVtZW50KTsKKyAgICAgICAgcmVtb3ZlQXR0cmlidXRlKGF0 dHJpYnV0ZS0+bmFtZSgpKTsKICAgICB9CiAKLSAgICBhZGRBdHRyaWJ1dGUoYSk7Ci0gICAgcmV0 dXJuIHIucmVsZWFzZSgpOworICAgIGFkZEF0dHJpYnV0ZShhdHRyaWJ1dGUpOworICAgIHJldHVy biBvbGRBdHRyLnJlbGVhc2UoKTsKIH0KIAogUGFzc1JlZlB0cjxOb2RlPiBOYW1lZE5vZGVNYXA6 OnNldE5hbWVkSXRlbU5TKE5vZGUqIG5vZGUsIEV4Y2VwdGlvbkNvZGUmIGVjKQpAQCAtMTQzLDE5 ICsxNDMsMTkgQEAgUGFzc1JlZlB0cjxOb2RlPiBOYW1lZE5vZGVNYXA6OnNldE5hbWVkSXRlbU5T KE5vZGUqIG5vZGUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogLy8gYmVjYXVzZSBvZiByZW1vdmVOYW1l ZEl0ZW0sIHJlbW92ZU5hbWVkSXRlbU5TLCBhbmQgcmVtb3ZlQXR0cmlidXRlTm9kZS4KIFBhc3NS ZWZQdHI8Tm9kZT4gTmFtZWROb2RlTWFwOjpyZW1vdmVOYW1lZEl0ZW0oY29uc3QgUXVhbGlmaWVk TmFtZSYgbmFtZSwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7Ci0gICAgQXR0cmlidXRlKiBhID0gZ2V0 QXR0cmlidXRlSXRlbShuYW1lKTsKLSAgICBpZiAoIWEpIHsKKyAgICBBdHRyaWJ1dGUqIGF0dHJp YnV0ZSA9IGdldEF0dHJpYnV0ZUl0ZW0obmFtZSk7CisgICAgaWYgKCFhdHRyaWJ1dGUpIHsKICAg ICAgICAgZWMgPSBOT1RfRk9VTkRfRVJSOwogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKLSAg ICBSZWZQdHI8QXR0cj4gciA9IGEtPmNyZWF0ZUF0dHJJZk5lZWRlZChtX2VsZW1lbnQpOworICAg IFJlZlB0cjxBdHRyPiBhdHRyID0gYXR0cmlidXRlLT5jcmVhdGVBdHRySWZOZWVkZWQobV9lbGVt ZW50KTsKIAotICAgIGlmIChyLT5pc0lkKCkpCi0gICAgICAgIG1fZWxlbWVudC0+dXBkYXRlSWQo YS0+dmFsdWUoKSwgbnVsbEF0b20pOworICAgIGlmIChhdHRyLT5pc0lkKCkpCisgICAgICAgIG1f ZWxlbWVudC0+dXBkYXRlSWQoYXR0cmlidXRlLT52YWx1ZSgpLCBudWxsQXRvbSk7CiAKICAgICBy ZW1vdmVBdHRyaWJ1dGUobmFtZSk7Ci0gICAgcmV0dXJuIHIucmVsZWFzZSgpOworICAgIHJldHVy biBhdHRyLnJlbGVhc2UoKTsKIH0KIAogUGFzc1JlZlB0cjxOb2RlPiBOYW1lZE5vZGVNYXA6Oml0 ZW0odW5zaWduZWQgaW5kZXgpIGNvbnN0Cg==