74430 2011-12-13 11:42:28 -0800 watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it. 2011-12-13 13:51:24 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rakuco rakuco abarth gustavo jamesr levin ojan webkit.review.bot oldest_to_newest 520239 0 rakuco 2011-12-13 11:42:28 -0800 watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it. 520248 1 119055 rakuco 2011-12-13 11:45:00 -0800 Created attachment 119055 Patch 520258 2 119055 levin 2011-12-13 11:51:56 -0800 Comment on attachment 119055 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119055&action=review > Tools/Scripts/webkitpy/common/config/watchlist:123 > + "more": r"CMakeLists.*\.txt" Did you mean more here? That would mean that a file contains more references to this regex than it did before. > Tools/Scripts/webkitpy/common/config/watchlist:154 > + "EFLWebKitPublicAPI": [ "kubo@profusion.mobi" ], I would add a comma after your email in each of these. (It isn't required but it makes it less error prone when someone adds the next entry so they don't accidentally merge together.) You could also do "EFLWebKitPublicAPI|EFLWebCore|EFLTools|CMake|SoupNetwork": [ "kubo@profusion.mobi", ], if you wished. In some ways it depends on if you think others will add themselves to some of these sections. 520296 3 rakuco 2011-12-13 12:49:14 -0800 (In reply to comment #2) > (From update of attachment 119055 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119055&action=review > > > Tools/Scripts/webkitpy/common/config/watchlist:123 > > + "more": r"CMakeLists.*\.txt" > > Did you mean more here? That would mean that a file contains more references to this regex than it did before. Not really; the wiki page is a bit unclear about this. I had tried filename before, but my regex was probably wrong. > > Tools/Scripts/webkitpy/common/config/watchlist:154 > > + "EFLWebKitPublicAPI": [ "kubo@profusion.mobi" ], > > I would add a comma after your email in each of these. (It isn't required but it makes it less error prone when someone adds the next entry so they don't accidentally merge together.) Oops, I overlooked that. > You could also do "EFLWebKitPublicAPI|EFLWebCore|EFLTools|CMake|SoupNetwork": [ "kubo@profusion.mobi", ], if you wished. In some ways it depends on if you think others will add themselves to some of these sections. Well, I'm thinking of joining all the EFL rules into a single one. 520300 4 119055 levin 2011-12-13 12:53:06 -0800 Comment on attachment 119055 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119055&action=review >>> Tools/Scripts/webkitpy/common/config/watchlist:123 >>> + "more": r"CMakeLists.*\.txt" >> >> Did you mean more here? That would mean that a file contains more references to this regex than it did before. > > Not really; the wiki page is a bit unclear about this. I had tried filename before, but my regex was probably wrong. Sorry. I welcome any hints about clarifications or if you could explain what you thought it said, I can try to reword it. The more/less support is for matching within files. (For example, I use it to alert me about new uses of threading structures.) 520307 5 119071 rakuco 2011-12-13 12:58:56 -0800 Created attachment 119071 Patch 520309 6 levin 2011-12-13 13:01:04 -0800 PS It is good to wait for the stylebot to finish its run on these patches to watchlist because it will catch any really bad mistakes. 520314 7 rakuco 2011-12-13 13:03:45 -0800 (In reply to comment #4) > (From update of attachment 119055 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=119055&action=review > > >>> Tools/Scripts/webkitpy/common/config/watchlist:123 > >>> + "more": r"CMakeLists.*\.txt" > >> > >> Did you mean more here? That would mean that a file contains more references to this regex than it did before. > > > > Not really; the wiki page is a bit unclear about this. I had tried filename before, but my regex was probably wrong. > > Sorry. I welcome any hints about clarifications or if you could explain what you thought it said, I can try to reword it. The specific paragraphs which got me confused are these: > If is a code pattern use “more” or “less”, if you want to know if more or less of instances in that pattern occur. (more use the regex to find a match modified lines in a patch. Then it searches the to see if more instances of that exact text occur on a per file basis.) It looks like there are words missing after the first "If" and after "Then it searches the to see". > A definition is said to match if all of its clauses are true for any file in a patch. If you could look for more instances of a pattern occurring only within a group of a files by using both “filename” and “more” together. If you could look == you could look? 520354 8 rakuco 2011-12-13 13:51:24 -0800 Committed r102704: <http://trac.webkit.org/changeset/102704> 119055 2011-12-13 11:45:00 -0800 2011-12-13 12:58:49 -0800 Patch bug-74430-20111213174548.patch text/plain 2342 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNjAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjMwNWZiMmYyZTJlMDc2MjdhOTFlYWVhYTQwYTZjMWMy MjhkYjBjMS4uNTdlMTVmMjE2OWZiNmU1ZjdlMWQ2MjNmNDQ5MTZlNGNlNTcwNjEzMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDExLTEyLTEzICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5t b2JpPgorCisgICAgICAgIHdhdGNobGlzdDogQWRkIHdhdGNobGlzdCBmb3IgRUZMLCBDTWFrZSBh bmQgbGlic291cCBjb2RlIGFuZCBwdXQgbXlzZWxmIG9uIGl0LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ0MzAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2Nv bmZpZy93YXRjaGxpc3Q6CisKIDIwMTEtMTItMTIgIMOBZMOhbSBLYWxsYWkgIDxLYWxsYWkuQWRh bUBzdHVkLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF0gRml4IHNraXAgbGlzdCBzZWFyY2gg cGF0aCBhbmQgZXhwZWN0ZWQgZmlsZSBzZWFyY2ggcGF0aCBpbiBPUldUCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dhdGNobGlzdAppbmRleCBiMjZkZjdmN2MyNjM3 MmVhNjUyM2RhYTE4OTgyYmMyNjVmYTNiNmVlLi4zMDU2ZWQxNzE5MzczZDBjNGRmZWY1ZGM0NDhi NGMyZWU1MGFhMmFkIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j b25maWcvd2F0Y2hsaXN0CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZp Zy93YXRjaGxpc3QKQEAgLTEwOSw2ICsxMDksMjQgQEAKICAgICAgICAgIkNTUyI6IHsKICAgICAg ICAgICAgICJmaWxlbmFtZSI6IHIiU291cmNlL1dlYkNvcmUvY3NzLyIsCiAgICAgICAgIH0sCisg ICAgICAgICJFRkxXZWJLaXRQdWJsaWNBUEkiOiB7CisgICAgICAgICAgICAiZmlsZW5hbWUiOiBy IlNvdXJjZS9XZWJLaXQvZWZsLyIsCisgICAgICAgIH0sCisgICAgICAgICJFRkxXZWJDb3JlIjog eworICAgICAgICAgICAgImZpbGVuYW1lIjogciJTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv IiwKKyAgICAgICAgfSwKKyAgICAgICAgIkVGTFRvb2xzIjogeworICAgICAgICAgICAgImZpbGVu YW1lIjogciJUb29scy9EdW1wUmVuZGVyVHJlZS9lZmwiCisgICAgICAgICAgICAgICAgICAgICAg ICByInxUb29scy9FV2ViTGF1bmNoZXIiLAorICAgICAgICB9LAorICAgICAgICAiQ01ha2UiOiB7 CisgICAgICAgICAgICAibW9yZSI6IHIiQ01ha2VMaXN0cy4qXC50eHQiCisgICAgICAgICAgICAg ICAgICAgIHIifC4rXC5jbWFrZSIKKyAgICAgICAgICAgICAgICAgICAgciJ8U291cmNlL2NtYWtl LyIsCisgICAgICAgIH0sCisgICAgICAgICJTb3VwTmV0d29yayI6IHsKKyAgICAgICAgICAgICJm aWxlbmFtZSI6IHIiU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwLyIsCisgICAg ICAgIH0sCiAgICAgfSwKICAgICAiQ0NfUlVMRVMiOiB7CiAgICAgICAgICMgTm90ZTogQWxsIGVt YWlsIGFkZHJlc3NlcyBsaXN0ZWQgbXVzdCBiZSByZWdpc3RlcmVkIHdpdGggYnVnemlsbGEuCkBA IC0xMzMsNiArMTUxLDExIEBACiAgICAgICAgICJRdFdlYktpdDJQdWJsaWNBUEkiOiBbICJ6b2x0 YW5Ad2Via2l0Lm9yZyIsIF0sCiAgICAgICAgICJRdFdlYktpdDJQbGF0Zm9ybVNwZWNpZmljIjog WyAiem9sdGFuQHdlYmtpdC5vcmciLCBdLAogICAgICAgICAiQ1NTIjogWyAibWFjcGhlcnNvbkBj aHJvbWl1bS5vcmciLCBdLAorICAgICAgICAiRUZMV2ViS2l0UHVibGljQVBJIjogWyAia3Vib0Bw cm9mdXNpb24ubW9iaSIgXSwKKyAgICAgICAgIkVGTFdlYkNvcmUiOiBbICJrdWJvQHByb2Z1c2lv bi5tb2JpIiBdLAorICAgICAgICAiRUZMVG9vbHMiOiBbICJrdWJvQHByb2Z1c2lvbi5tb2JpIiBd LAorICAgICAgICAiQ01ha2UiOiBbICJrdWJvQHByb2Z1c2lvbi5tb2JpIiwgXSwKKyAgICAgICAg IlNvdXBOZXR3b3JrIjogWyAia3Vib0Bwcm9mdXNpb24ubW9iaSIgXSwKICAgICB9LAogICAgICJN RVNTQUdFX1JVTEVTIjogewogICAgICAgICAiQ2hyb21pdW1QdWJsaWNBcGkiOiBbICJQbGVhc2Ug d2FpdCBmb3IgYXBwcm92YWwgZnJvbSBmaXNoZEBjaHJvbWl1bS5vcmcgYmVmb3JlIHN1Ym1pdHRp bmcgIgo= 119071 2011-12-13 12:58:56 -0800 2011-12-13 13:00:18 -0800 Patch bug-74430-20111213185944.patch text/plain 2162 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNjAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMjMwNWZiMmYyZTJlMDc2MjdhOTFlYWVhYTQwYTZjMWMy MjhkYjBjMS4uNTdlMTVmMjE2OWZiNmU1ZjdlMWQ2MjNmNDQ5MTZlNGNlNTcwNjEzMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDExLTEyLTEzICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5t b2JpPgorCisgICAgICAgIHdhdGNobGlzdDogQWRkIHdhdGNobGlzdCBmb3IgRUZMLCBDTWFrZSBh bmQgbGlic291cCBjb2RlIGFuZCBwdXQgbXlzZWxmIG9uIGl0LgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ0MzAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2Nv bmZpZy93YXRjaGxpc3Q6CisKIDIwMTEtMTItMTIgIMOBZMOhbSBLYWxsYWkgIDxLYWxsYWkuQWRh bUBzdHVkLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF0gRml4IHNraXAgbGlzdCBzZWFyY2gg cGF0aCBhbmQgZXhwZWN0ZWQgZmlsZSBzZWFyY2ggcGF0aCBpbiBPUldUCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvd2F0Y2hsaXN0IGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dhdGNobGlzdAppbmRleCBiMjZkZjdmN2MyNjM3 MmVhNjUyM2RhYTE4OTgyYmMyNjVmYTNiNmVlLi4wMzU0ZmRhMDExY2FiYzc5ODg2MmVkNTYxNDMy YjI0OTM4MjMwMmIzIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9j b25maWcvd2F0Y2hsaXN0CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZp Zy93YXRjaGxpc3QKQEAgLTEwOSw2ICsxMDksMjAgQEAKICAgICAgICAgIkNTUyI6IHsKICAgICAg ICAgICAgICJmaWxlbmFtZSI6IHIiU291cmNlL1dlYkNvcmUvY3NzLyIsCiAgICAgICAgIH0sCisg ICAgICAgICJFRkwiOiB7CisgICAgICAgICAgICAiZmlsZW5hbWUiOiByIlNvdXJjZS9XZWJLaXQv ZWZsLyIKKyAgICAgICAgICAgICAgICAgICAgICAgIHIifFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2VmbC8iCisgICAgICAgICAgICAgICAgICAgICAgICByInxUb29scy9FV2ViTGF1bmNoZXIiCisg ICAgICAgICAgICAgICAgICAgICAgICByInxUb29scy9EdW1wUmVuZGVyVHJlZS9lZmwvIiwKKyAg ICAgICAgfSwKKyAgICAgICAgIkNNYWtlIjogeworICAgICAgICAgICAgImZpbGVuYW1lIjogciIu KkNNYWtlTGlzdHNcdypcLnR4dCIKKyAgICAgICAgICAgICAgICAgICAgICAgIHIifC4qXHcrXC5j bWFrZSIKKyAgICAgICAgICAgICAgICAgICAgICAgIHIifFNvdXJjZS9jbWFrZS8iLAorICAgICAg ICB9LAorICAgICAgICAiU291cE5ldHdvcmsiOiB7CisgICAgICAgICAgICAiZmlsZW5hbWUiOiBy IlNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC8iLAorICAgICAgICB9LAogICAg IH0sCiAgICAgIkNDX1JVTEVTIjogewogICAgICAgICAjIE5vdGU6IEFsbCBlbWFpbCBhZGRyZXNz ZXMgbGlzdGVkIG11c3QgYmUgcmVnaXN0ZXJlZCB3aXRoIGJ1Z3ppbGxhLgpAQCAtMTMzLDYgKzE0 Nyw5IEBACiAgICAgICAgICJRdFdlYktpdDJQdWJsaWNBUEkiOiBbICJ6b2x0YW5Ad2Via2l0Lm9y ZyIsIF0sCiAgICAgICAgICJRdFdlYktpdDJQbGF0Zm9ybVNwZWNpZmljIjogWyAiem9sdGFuQHdl YmtpdC5vcmciLCBdLAogICAgICAgICAiQ1NTIjogWyAibWFjcGhlcnNvbkBjaHJvbWl1bS5vcmci LCBdLAorICAgICAgICAiRUZMIjogWyAia3Vib0Bwcm9mdXNpb24ubW9iaSIsIF0sCisgICAgICAg ICJDTWFrZSI6IFsgImt1Ym9AcHJvZnVzaW9uLm1vYmkiLCBdLAorICAgICAgICAiU291cE5ldHdv cmsiOiBbICJrdWJvQHByb2Z1c2lvbi5tb2JpIiwgXSwKICAgICB9LAogICAgICJNRVNTQUdFX1JV TEVTIjogewogICAgICAgICAiQ2hyb21pdW1QdWJsaWNBcGkiOiBbICJQbGVhc2Ugd2FpdCBmb3Ig YXBwcm92YWwgZnJvbSBmaXNoZEBjaHJvbWl1bS5vcmcgYmVmb3JlIHN1Ym1pdHRpbmcgIgo=