74405 2011-12-13 06:12:08 -0800 [Qt][WK2] Remove statusBarMessageChanged 2011-12-20 13:41:02 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 74403 1 jesus rafael.lobo cmarcelo hausmann webkit.review.bot zoltan oldest_to_newest 520054 0 jesus 2011-12-13 06:12:08 -0800 It's common sense that we should rename this API (to statusMessageChanged?!). Maybe there should also be a statusMessage property, but this needs to be discussed. 520384 1 119086 rafael.lobo 2011-12-13 14:41:16 -0800 Created attachment 119086 Patch 521870 2 cmarcelo 2011-12-15 06:46:23 -0800 LGTM. 522928 3 hausmann 2011-12-16 12:29:21 -0800 I'm not too fond of having the property there without any proof that this would actually be useful. We're not even using it ourselves in the mini browser, so how can we be sure it's useful? Even with the signal I have to wonder: Do other browsers actually use this right now? (It's not used for link hovering) (I know it's in the WK2 C API, but does anyone know of an example web app/site that uses window.status that works?) 522949 4 cmarcelo 2011-12-16 12:44:34 -0800 (In reply to comment #3) > I'm not too fond of having the property there without any proof that this would actually be useful. We're not even using it ourselves in the mini browser, so how can we be sure it's useful? > > Even with the signal I have to wonder: Do other browsers actually use this right now? (It's not used for link hovering) > > (I know it's in the WK2 C API, but does anyone know of an example web app/site that uses window.status that works?) Interesting point. It seems that "window.status" itself is not expected to work in HTML5 (even though WebKit supports it). http://dev.w3.org/html5/spec/Overview.html#dom-window-status 523155 5 rafael.lobo 2011-12-16 16:34:34 -0800 (In reply to comment #4) > (In reply to comment #3) > > I'm not too fond of having the property there without any proof that this would actually be useful. We're not even using it ourselves in the mini browser, so how can we be sure it's useful? > > > > Even with the signal I have to wonder: Do other browsers actually use this right now? (It's not used for link hovering) > > > > (I know it's in the WK2 C API, but does anyone know of an example web app/site that uses window.status that works?) > > Interesting point. It seems that "window.status" itself is not expected to work in HTML5 (even though WebKit supports it). > > http://dev.w3.org/html5/spec/Overview.html#dom-window-status To be honest, I discovered this feature when I've worked on this bug. Never heard about it before and I'm afraid this can't be very useful as well. If we want to at least support this feature, then maybe we should just have the signal as we had before? The test case could be modified a bit. 523873 6 hausmann 2011-12-19 06:05:28 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > I'm not too fond of having the property there without any proof that this would actually be useful. We're not even using it ourselves in the mini browser, so how can we be sure it's useful? > > > > > > Even with the signal I have to wonder: Do other browsers actually use this right now? (It's not used for link hovering) > > > > > > (I know it's in the WK2 C API, but does anyone know of an example web app/site that uses window.status that works?) > > > > Interesting point. It seems that "window.status" itself is not expected to work in HTML5 (even though WebKit supports it). > > > > http://dev.w3.org/html5/spec/Overview.html#dom-window-status > > To be honest, I discovered this feature when I've worked on this bug. Never heard about it before and I'm afraid this can't be very useful as well. If we want to at least support this feature, then maybe we should just have the signal as we had before? The test case could be modified a bit. This is a great reason for removing the API altogether. 523874 7 119086 hausmann 2011-12-19 06:05:47 -0800 Comment on attachment 119086 Patch r- as it turns out that we should rather remove the status message API altogether. 524578 8 hausmann 2011-12-20 06:20:15 -0800 Adjusting title to latest conclusions ;-) 524581 9 120020 hausmann 2011-12-20 06:24:00 -0800 Created attachment 120020 Patch 524794 10 120020 webkit.review.bot 2011-12-20 13:40:57 -0800 Comment on attachment 120020 Patch Clearing flags on attachment: 120020 Committed r103347: <http://trac.webkit.org/changeset/103347> 524795 11 webkit.review.bot 2011-12-20 13:41:02 -0800 All reviewed patches have been landed. Closing bug. 119086 2011-12-13 14:41:16 -0800 2011-12-20 06:23:48 -0800 Patch bug-74405-20111213194113.patch text/plain 7589 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTAyNjg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmZiMDM2MGM4NjNjMGQz YTkyNzVhZGViZDE2MzU2YmVlOTY1Y2RkOS4uMjY3NzgyMjNjMzNhMzk3NTZkYWJmNmRmYTgyYjc0 NDgwNWU4OGE0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDExLTEyLTEzICBSYWZh ZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XVtX SzJdIFJlbmFtZSBzdGF0dXNCYXJNZXNzYWdlQ2hhbmdlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzQ0MDUKKworICAgICAgICBBbHNvIGFkZGVkIGEg cHJvcGVydHkgdG8gV2ViVmlldyBjYWxsZWQgc3RhdHVzTWVzc2FnZSB0aGF0IHdpbGwga2VlcAor ICAgICAgICB0aGUgbGFzdCBtZXNzYWdlIG1vZGlmaWVkIHRocm91Z2ggY2hhbmdlcyBvbiAnd2lu ZG93LnN0YXR1cycgb24gSlMuCisgICAgICAgIEEgdmVyeSBzaW1wbGUgdGVzdCB3YXMgYWRkZWQg dG8gY292ZXIgaXRzIHNpbXBsZSB1c2FnZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQv cXF1aWNrd2Vidmlldy5jcHA6CisgICAgICAgIChRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6c2V0U3Rh dHVzTWVzc2FnZSk6CisgICAgICAgIChRUXVpY2tXZWJWaWV3OjpzdGF0dXNNZXNzYWdlKToKKyAg ICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcC5oOgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wX3AuaDoKKyAgICAgICAgKiBVSVByb2Nlc3Mv QVBJL3F0L3Rlc3RzL2h0bWwvc3RhdHVzLXRlc3QuaHRtbDogQWRkZWQuCisgICAgICAgICogVUlQ cm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9zdGF0dXNNZXNzYWdlQ2hh bmdlZC5xbWw6IEFkZGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVz dHMvcW1sdGVzdHMucHJvOgorICAgICAgICAqIFVJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VVSUNsaWVu dC5jcHA6CisgICAgICAgIChRdFdlYlBhZ2VVSUNsaWVudDo6c2V0U3RhdHVzVGV4dCk6CisKIDIw MTEtMTItMTMgIENhaW8gTWFyY2VsbyBkZSBPbGl2ZWlyYSBGaWxobyAgPGNhaW8ub2xpdmVpcmFA b3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBbUXRdW1dLMl0gTWFrZSBRdFBhZ2VDbGllbnQgZGlz cGF0Y2ggZGlyZWN0bHkgdG8gV2ViVmlldyB3aGVuIHBvc3NpYmxlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcAppbmRleCBiYmMxODgzNjU1 OTUzNjdlNDY4ODQ4OGZjMjQ4NjRiOWQ3OGFiMjM5Li5jY2M5NGM4MjMxOTg0NTU1OTgzOGQ3MmJk ZjliMWU1MTNhNGQzYzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2Vidmlldy5jcHAKQEAgLTM5OCw2ICszOTgsMTYgQEAgdm9pZCBRUXVpY2tXZWJW aWV3UHJpdmF0ZTo6X3Ffb25PcGVuUGFuZWxGaW5pc2hlZChpbnQgcmVzdWx0KQogICAgIGZpbGVE aWFsb2cgPSAwOwogfQogCit2b2lkIFFRdWlja1dlYlZpZXdQcml2YXRlOjpzZXRTdGF0dXNNZXNz YWdlKGNvbnN0IFFTdHJpbmcmIG1lc3NhZ2UpCit7CisgICAgaWYgKHN0YXR1c01lc3NhZ2UgPT0g bWVzc2FnZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgUV9RKFFRdWlja1dlYlZpZXcpOworICAg IHN0YXR1c01lc3NhZ2UgPSBtZXNzYWdlOworICAgIGVtaXQgcS0+c3RhdHVzTWVzc2FnZUNoYW5n ZWQobWVzc2FnZSk7Cit9CisKIHZvaWQgUVF1aWNrV2ViVmlld1ByaXZhdGU6OnNldFVzZVRyYWRp dGlvbmFsRGVza3RvcEJlaGF2aW91cihib29sIGVuYWJsZSkKIHsKICAgICBRX1EoUVF1aWNrV2Vi Vmlldyk7CkBAIC02NTQsNiArNjY0LDEyIEBAIGludCBRUXVpY2tXZWJWaWV3Ojpsb2FkUHJvZ3Jl c3MoKSBjb25zdAogICAgIHJldHVybiBkLT5wYWdlTG9hZENsaWVudC0+bG9hZFByb2dyZXNzKCk7 CiB9CiAKK1FTdHJpbmcgUVF1aWNrV2ViVmlldzo6c3RhdHVzTWVzc2FnZSgpIGNvbnN0Cit7Cisg ICAgUV9EKGNvbnN0IFFRdWlja1dlYlZpZXcpOworICAgIHJldHVybiBkLT5zdGF0dXNNZXNzYWdl OworfQorCiBib29sIFFRdWlja1dlYlZpZXc6OmNhbkdvQmFjaygpIGNvbnN0CiB7CiAgICAgUV9E KGNvbnN0IFFRdWlja1dlYlZpZXcpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvcXF1aWNrd2Vidmlld19wLmgKaW5kZXggNTM5NWU2ZGJhOWU1YmVjMjJmYzM1NjVjN2M0 NTdmZTYwY2MyNTE2NC4uNWJmNmRjMzAwNjQ3ZDBkZTMzYjg4OGE5M2ZjMmYzN2EwZjBmNjhkOCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3 X3AuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdf cC5oCkBAIC01Nyw2ICs1Nyw3IEBAIGNsYXNzIFFXRUJLSVRfRVhQT1JUIFFRdWlja1dlYlZpZXcg OiBwdWJsaWMgUVF1aWNrSXRlbSB7CiAgICAgUV9QUk9QRVJUWShib29sIGNhbkdvRm9yd2FyZCBS RUFEIGNhbkdvRm9yd2FyZCBOT1RJRlkgbmF2aWdhdGlvblN0YXRlQ2hhbmdlZCBGSU5BTCkKICAg ICBRX1BST1BFUlRZKGJvb2wgbG9hZGluZyBSRUFEIGxvYWRpbmcgTk9USUZZIG5hdmlnYXRpb25T dGF0ZUNoYW5nZWQgRklOQUwpCiAgICAgUV9QUk9QRVJUWShib29sIGNhblJlbG9hZCBSRUFEIGNh blJlbG9hZCBOT1RJRlkgbmF2aWdhdGlvblN0YXRlQ2hhbmdlZCBGSU5BTCkKKyAgICBRX1BST1BF UlRZKFFTdHJpbmcgc3RhdHVzTWVzc2FnZSBSRUFEIHN0YXR1c01lc3NhZ2UgTk9USUZZIHN0YXR1 c01lc3NhZ2VDaGFuZ2VkIEZJTkFMKQogICAgIFFfUFJPUEVSVFkoUVdlYlByZWZlcmVuY2VzKiBw cmVmZXJlbmNlcyBSRUFEIHByZWZlcmVuY2VzIENPTlNUQU5UIEZJTkFMKQogICAgIFFfUFJPUEVS VFkoUVF1aWNrV2ViUGFnZSogcGFnZSBSRUFEIHBhZ2UgQ09OU1RBTlQgRklOQUwpCiAgICAgUV9F TlVNUyhOYXZpZ2F0aW9uUmVxdWVzdEFjdGlvbikKQEAgLTgxLDYgKzgyLDcgQEAgcHVibGljOgog ICAgIFFVcmwgdXJsKCkgY29uc3Q7CiAgICAgUVN0cmluZyB0aXRsZSgpIGNvbnN0OwogICAgIGlu dCBsb2FkUHJvZ3Jlc3MoKSBjb25zdDsKKyAgICBRU3RyaW5nIHN0YXR1c01lc3NhZ2UoKSBjb25z dDsKIAogICAgIGJvb2wgY2FuR29CYWNrKCkgY29uc3Q7CiAgICAgYm9vbCBjYW5Hb0ZvcndhcmQo KSBjb25zdDsKQEAgLTEwNiw3ICsxMDgsNyBAQCBwdWJsaWMgUV9TTE9UUzoKIAogUV9TSUdOQUxT OgogICAgIHZvaWQgdGl0bGVDaGFuZ2VkKGNvbnN0IFFTdHJpbmcmIHRpdGxlKTsKLSAgICB2b2lk IHN0YXR1c0Jhck1lc3NhZ2VDaGFuZ2VkKGNvbnN0IFFTdHJpbmcmIG1lc3NhZ2UpOworICAgIHZv aWQgc3RhdHVzTWVzc2FnZUNoYW5nZWQoY29uc3QgUVN0cmluZyYgc3RhdHVzTWVzc2FnZSk7CiAg ICAgdm9pZCBsb2FkU3RhcnRlZCgpOwogICAgIHZvaWQgbG9hZFN1Y2NlZWRlZCgpOwogICAgIHZv aWQgbG9hZEZhaWxlZChRUXVpY2tXZWJWaWV3OjpFcnJvclR5cGUgZXJyb3JUeXBlLCBpbnQgZXJy b3JDb2RlLCBjb25zdCBRVXJsJiB1cmwpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oCmluZGV4IGExOTc4NWQ4ODZjZTlhZDY4MDAw ODVlODc0OTM4OWIzOTVjYTBjY2EuLjU5OThmYWE1NGVmMjZkMGUxYmFjNDViMDdmNDQ2ZTg5YjRm ODk0NmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNr d2Vidmlld19wX3AuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlj a3dlYnZpZXdfcF9wLmgKQEAgLTkwLDYgKzkwLDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBzZXRV c2VUcmFkaXRpb25hbERlc2t0b3BCZWhhdmlvdXIoYm9vbCBlbmFibGUpOwogICAgIHZvaWQgc2V0 Vmlld0luQXR0YWNoZWRQcm9wZXJ0aWVzKFFPYmplY3QqKTsKKyAgICB2b2lkIHNldFN0YXR1c01l c3NhZ2UoY29uc3QgUVN0cmluZyYpOwogCiAgICAgV2ViS2l0OjpXZWJQYWdlUHJveHkqIHdlYlBh Z2VQcm94eSgpIGNvbnN0OwogCkBAIC0xNjAsNiArMTYxLDcgQEAgcHJpdmF0ZToKICAgICBib29s IHVzZVRyYWRpdGlvbmFsRGVza3RvcEJlaGF2aW91cjsKICAgICBRRmlsZURpYWxvZyogZmlsZURp YWxvZzsKICAgICBXS09wZW5QYW5lbFJlc3VsdExpc3RlbmVyUmVmIG9wZW5QYW5lbFJlc3VsdExp c3RlbmVyOworICAgIFFTdHJpbmcgc3RhdHVzTWVzc2FnZTsKIH07CiAKICNlbmRpZiAvLyBxcXVp Y2t3ZWJ2aWV3X3BfcF9oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3Rlc3RzL2h0bWwvc3RhdHVzLXRlc3QuaHRtbCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvcXQvdGVzdHMvaHRtbC9zdGF0dXMtdGVzdC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjY3Yjc3Zjgy NjYzYjJlYjZmY2U5ZDRkMTI5ZGQ5YmIzNWU0ODMzYzIKLS0tIC9kZXYvbnVsbAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL2h0bWwvc3RhdHVzLXRlc3QuaHRtbApA QCAtMCwwICsxLDEyIEBACis8aHRtbD4KKzxoZWFkPgorPHRpdGxlPlN0YXR1c1RleHQgdGVzdC48 L3RpdGxlPgorPC9oZWFkPgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgord2luZG93 Lm9ubG9hZCA9IGZ1bmN0aW9uICgpIHsKKyAgICB3aW5kb3cuc3RhdHVzID0gIlNVQ0NFU1MiOwor fTsKKzwvc2NyaXB0PgorPGJvZHk+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X3N0 YXR1c01lc3NhZ2VDaGFuZ2VkLnFtbCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv dGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3Rfc3RhdHVzTWVzc2FnZUNoYW5nZWQucW1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjkwYzk4YmJkNmExYTJiNzMyZjhkNTQwMGYzMWQ2NjBlNmUyYjQwMmMKLS0tIC9kZXYv bnVsbAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3Rz L1dlYlZpZXcvdHN0X3N0YXR1c01lc3NhZ2VDaGFuZ2VkLnFtbApAQCAtMCwwICsxLDI4IEBACitp bXBvcnQgUXRRdWljayAyLjAKK2ltcG9ydCBRdFRlc3QgMS4wCitpbXBvcnQgUXRXZWJLaXQgMy4w CisKK1dlYlZpZXcgeworICAgIGlkOiB3ZWJWaWV3CisgICAgd2lkdGg6IDIwMAorICAgIGhlaWdo dDogNDAwCisKKyAgICBTaWduYWxTcHkgeworICAgICAgICBpZDogc3RhdHVzU3B5CisgICAgICAg IHRhcmdldDogd2ViVmlldworICAgICAgICBzaWduYWxOYW1lOiAic3RhdHVzTWVzc2FnZUNoYW5n ZWQiCisgICAgfQorCisgICAgVGVzdENhc2UgeworICAgICAgICBuYW1lOiAiV2ViVmlld0NoYW5n ZXNTdGF0dXNNZXNzYWdlIgorCisgICAgICAgIGZ1bmN0aW9uIHRlc3Rfc3RhdHVzTWVzc2FnZUNo YW5nZWQoKSB7CisgICAgICAgICAgICBzdGF0dXNTcHkuY2xlYXIoKQorICAgICAgICAgICAgY29t cGFyZShzdGF0dXNTcHkuY291bnQsIDApCisgICAgICAgICAgICBjb21wYXJlKHdlYlZpZXcuc3Rh dHVzTWVzc2FnZSwgIiIpCisgICAgICAgICAgICB3ZWJWaWV3LmxvYWQoUXQucmVzb2x2ZWRVcmwo Ii4uLy4uL2h0bWwvc3RhdHVzLXRlc3QuaHRtbCIpKQorICAgICAgICAgICAgc3RhdHVzU3B5Lndh aXQoKQorICAgICAgICAgICAgY29tcGFyZSh3ZWJWaWV3LnN0YXR1c01lc3NhZ2UsICJTVUNDRVNT IikKKyAgICAgICAgfQorICAgIH0KK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvcXQvdGVzdHMvcW1sdGVzdHMvcW1sdGVzdHMucHJvIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8KaW5kZXggNWM2MWRm MjJmYjRlYjZhYWEzZGM2ODZiNmM1Y2VjYjg5MWU5Mjc0ZS4uMmRlOTIyNGI3NzQwMGU1NWZmMWQx ODY3YjU2ZDc4YTQwMDcyNmRiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8KKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9xbWx0ZXN0cy5wcm8KQEAgLTMxLDQgKzMx LDUgQEAgT1RIRVJfRklMRVMgKz0gXAogICAgIFdlYlZpZXcvdHN0X2xvYWRQcm9ncmVzc1NpZ25h bC5xbWwgXAogICAgIFdlYlZpZXcvdHN0X3ByZWZlcmVuY2VzLnFtbCBcCiAgICAgV2ViVmlldy90 c3RfcHJvcGVydGllcy5xbWwgXAorICAgIFdlYlZpZXcvdHN0X3N0YXR1c01lc3NhZ2VDaGFuZ2Vk LnFtbCBcCiAgICAgV2ViVmlldy90c3RfdGl0bGVDaGFuZ2VkLnFtbApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVVJQ2xpZW50LmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VVSUNsaWVudC5jcHAKaW5kZXggMWE2ZjA3OTQ0 ZGRkNDExMWMzNTViODJkODg4NDdiYWM4OTViYjMwMy4uYjIyNWNlZjQ1MGVkZmEyOWMyZjQ5Nzg0 ZTk1MGIzNmUyOTJiZDc5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0 L1F0V2ViUGFnZVVJQ2xpZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQv UXRXZWJQYWdlVUlDbGllbnQuY3BwCkBAIC03MCw3ICs3MCw3IEBAIHZvaWQgUXRXZWJQYWdlVUlD bGllbnQ6OnJ1bk9wZW5QYW5lbChXS09wZW5QYW5lbFJlc3VsdExpc3RlbmVyUmVmIGxpc3RlbmVy UmVmLCBjCiAKIHZvaWQgUXRXZWJQYWdlVUlDbGllbnQ6OnNldFN0YXR1c1RleHQoY29uc3QgUVN0 cmluZyYgbmV3TWVzc2FnZSkKIHsKLSAgICBlbWl0IG1fd2ViVmlldy0+c3RhdHVzQmFyTWVzc2Fn ZUNoYW5nZWQobmV3TWVzc2FnZSk7CisgICAgbV93ZWJWaWV3LT5kX2Z1bmMoKS0+c2V0U3RhdHVz TWVzc2FnZShuZXdNZXNzYWdlKTsKIH0KIAogdm9pZCBRdFdlYlBhZ2VVSUNsaWVudDo6bW91c2VE aWRNb3ZlT3ZlckVsZW1lbnQoY29uc3QgUVVybCYgbGlua1VSTCwgY29uc3QgUVN0cmluZyYgbGlu a1RpdGxlKQo= 120020 2011-12-20 06:24:00 -0800 2011-12-20 13:40:57 -0800 Patch bug-74405-20111220152358.patch text/plain 5257 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTAzMzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzlmNGRiOWNkNDU1MWY4 N2YyYzY3Y2IxNDJlYjY1N2MwMTQ4ZTM1Ni4uNTIxZjlmNmNjODEwYzZlZjY4NmM0OTEzNTczNDhi YjNhNzk2MjQ1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDExLTEyLTIwICBTaW1v biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAorICAgICAgICBbUXRdW1dL Ml0gUmVtb3ZlIHN0YXR1c0Jhck1lc3NhZ2VDaGFuZ2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDQwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92aW5nIHN1cHBvcnQgZm9yIHdpbmRvdy5zdGF0 dXMgdXBkYXRlcyBmcm9tIHRoZSBwdWJsaWMKKyAgICAgICAgUU1MIEFQSS4gU2VlIGJ1ZyBmb3Ig ZGV0YWlscy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlld19wLmg6 CisgICAgICAgICogVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVVJQ2xpZW50LmNwcDoKKyAgICAgICAg KFF0V2ViUGFnZVVJQ2xpZW50OjpRdFdlYlBhZ2VVSUNsaWVudCk6CisgICAgICAgICogVUlQcm9j ZXNzL3F0L1F0V2ViUGFnZVVJQ2xpZW50Lmg6CisKKzIwMTEtMTItMjAgIFNpbW9uIEhhdXNtYW5u ICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgorCiAgICAgICAgIFtRdF0gRmF2aWNvbiBzdXBw b3J0IHNob3VsZCB3b3JrIHdpdGggbXVsdGlwbGUgd2ViIGNvbnRleHRzCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD03NDkyMgogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXdfcC5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3AuaAppbmRleCAzOGYyM2Jj ZmI0N2ExMmM5ZTc3ZmM5MWFkNzAzYmI4YTExYmZkM2ZiLi4xZGY1Y2JlYzllZWYyYThlMzU0N2E0 ZjUxYmYwNmI4ZmJhMDNiNmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3FxdWlja3dlYnZpZXdfcC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvcXF1aWNrd2Vidmlld19wLmgKQEAgLTEwNiw3ICsxMDYsNiBAQCBwdWJsaWMgUV9TTE9U UzoKIAogUV9TSUdOQUxTOgogICAgIHZvaWQgdGl0bGVDaGFuZ2VkKGNvbnN0IFFTdHJpbmcmIHRp dGxlKTsKLSAgICB2b2lkIHN0YXR1c0Jhck1lc3NhZ2VDaGFuZ2VkKGNvbnN0IFFTdHJpbmcmIG1l c3NhZ2UpOwogICAgIHZvaWQgbG9hZFN0YXJ0ZWQoKTsKICAgICB2b2lkIGxvYWRTdWNjZWVkZWQo KTsKICAgICB2b2lkIGxvYWRGYWlsZWQoUVF1aWNrV2ViVmlldzo6RXJyb3JEb21haW4gZXJyb3JE b21haW4sIGludCBlcnJvckNvZGUsIGNvbnN0IFFVcmwmIHVybCwgY29uc3QgUVN0cmluZyYgZGVz Y3JpcHRpb24pOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2Vi UGFnZVVJQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdlYlBhZ2VV SUNsaWVudC5jcHAKaW5kZXggMWE2ZjA3OTQ0ZGRkNDExMWMzNTViODJkODg4NDdiYWM4OTViYjMw My4uZWY3NjRjNWM5ZmIwYmE5N2VhY2ZlZjJhYzVkZGI5YjBjNGUyNmE3MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVVJQ2xpZW50LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUXRXZWJQYWdlVUlDbGllbnQuY3BwCkBAIC00MSw3 ICs0MSw2IEBAIFF0V2ViUGFnZVVJQ2xpZW50OjpRdFdlYlBhZ2VVSUNsaWVudChXS1BhZ2VSZWYg cGFnZVJlZiwgUVF1aWNrV2ViVmlldyogd2ViVmlldykKICAgICB1aUNsaWVudC5ydW5KYXZhU2Ny aXB0QWxlcnQgPSBydW5KYXZhU2NyaXB0QWxlcnQ7CiAgICAgdWlDbGllbnQucnVuSmF2YVNjcmlw dENvbmZpcm0gPSBydW5KYXZhU2NyaXB0Q29uZmlybTsKICAgICB1aUNsaWVudC5ydW5KYXZhU2Ny aXB0UHJvbXB0ID0gcnVuSmF2YVNjcmlwdFByb21wdDsKLSAgICB1aUNsaWVudC5zZXRTdGF0dXNU ZXh0ID0gc2V0U3RhdHVzVGV4dDsKICAgICB1aUNsaWVudC5ydW5PcGVuUGFuZWwgPSBydW5PcGVu UGFuZWw7CiAgICAgdWlDbGllbnQubW91c2VEaWRNb3ZlT3ZlckVsZW1lbnQgPSBtb3VzZURpZE1v dmVPdmVyRWxlbWVudDsKICAgICB1aUNsaWVudC5kZWNpZGVQb2xpY3lGb3JHZW9sb2NhdGlvblBl cm1pc3Npb25SZXF1ZXN0ID0gcG9saWN5Rm9yR2VvbG9jYXRpb25QZXJtaXNzaW9uUmVxdWVzdDsK QEAgLTY4LDExICs2Nyw2IEBAIHZvaWQgUXRXZWJQYWdlVUlDbGllbnQ6OnJ1bk9wZW5QYW5lbChX S09wZW5QYW5lbFJlc3VsdExpc3RlbmVyUmVmIGxpc3RlbmVyUmVmLCBjCiAgICAgbV93ZWJWaWV3 LT5kX2Z1bmMoKS0+Y2hvb3NlRmlsZXMobGlzdGVuZXJSZWYsIHNlbGVjdGVkRmlsZU5hbWVzLCB0 eXBlKTsKIH0KIAotdm9pZCBRdFdlYlBhZ2VVSUNsaWVudDo6c2V0U3RhdHVzVGV4dChjb25zdCBR U3RyaW5nJiBuZXdNZXNzYWdlKQotewotICAgIGVtaXQgbV93ZWJWaWV3LT5zdGF0dXNCYXJNZXNz YWdlQ2hhbmdlZChuZXdNZXNzYWdlKTsKLX0KLQogdm9pZCBRdFdlYlBhZ2VVSUNsaWVudDo6bW91 c2VEaWRNb3ZlT3ZlckVsZW1lbnQoY29uc3QgUVVybCYgbGlua1VSTCwgY29uc3QgUVN0cmluZyYg bGlua1RpdGxlKQogewogICAgIGlmIChsaW5rVVJMID09IG1fbGFzdEhvdmVyZWRVUkwgJiYgbGlu a1RpdGxlID09IG1fbGFzdEhvdmVyZWRUaXRsZSkKQEAgLTEyMywxMiArMTE3LDYgQEAgV0tTdHJp bmdSZWYgUXRXZWJQYWdlVUlDbGllbnQ6OnJ1bkphdmFTY3JpcHRQcm9tcHQoV0tQYWdlUmVmLCBX S1N0cmluZ1JlZiBtZXNzYWcKICAgICByZXR1cm4gV0tTdHJpbmdDcmVhdGVXaXRoUVN0cmluZyhy ZXN1bHQpOwogfQogCi12b2lkIFF0V2ViUGFnZVVJQ2xpZW50OjpzZXRTdGF0dXNUZXh0KFdLUGFn ZVJlZiwgV0tTdHJpbmdSZWYgdGV4dCwgY29uc3Qgdm9pZCAqY2xpZW50SW5mbykKLXsKLSAgICBR U3RyaW5nIHFUZXh0ID0gV0tTdHJpbmdDb3B5UVN0cmluZyh0ZXh0KTsKLSAgICB0b1F0V2ViUGFn ZVVJQ2xpZW50KGNsaWVudEluZm8pLT5zZXRTdGF0dXNUZXh0KHFUZXh0KTsKLX0KLQogdm9pZCBR dFdlYlBhZ2VVSUNsaWVudDo6cnVuT3BlblBhbmVsKFdLUGFnZVJlZiwgV0tGcmFtZVJlZiwgV0tP cGVuUGFuZWxQYXJhbWV0ZXJzUmVmIHBhcmFtZXRlcnMsIFdLT3BlblBhbmVsUmVzdWx0TGlzdGVu ZXJSZWYgbGlzdGVuZXIsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pCiB7CiAgICAgVmVjdG9yPFN0 cmluZz4gd2tTZWxlY3RlZEZpbGVOYW1lcyA9IHRvSW1wbChwYXJhbWV0ZXJzKS0+c2VsZWN0ZWRG aWxlTmFtZXMoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9RdFdl YlBhZ2VVSUNsaWVudC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVVJ Q2xpZW50LmgKaW5kZXggMjFkMWE0ODlhMmFjMjJmMDlhYjhhZTMwYWYwMTgwYjM3OTJmMjc0Ni4u OGNmZTEzYzIxM2YxMTEwOGE1M2I3Y2NhMGNjMGUxZGYyOWZmZTM3YSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVVJQ2xpZW50LmgKKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL3F0L1F0V2ViUGFnZVVJQ2xpZW50LmgKQEAgLTQ0LDcgKzQ0LDYg QEAgcHJpdmF0ZToKICAgICB2b2lkIHJ1bkphdmFTY3JpcHRBbGVydChjb25zdCBRU3RyaW5nJiBt ZXNzYWdlKTsKICAgICBib29sIHJ1bkphdmFTY3JpcHRDb25maXJtKGNvbnN0IFFTdHJpbmcmIG1l c3NhZ2UpOwogICAgIFFTdHJpbmcgcnVuSmF2YVNjcmlwdFByb21wdChjb25zdCBRU3RyaW5nJiBt ZXNzYWdlLCBjb25zdCBRU3RyaW5nJiBkZWZhdWx0VmFsdWUsIGJvb2wmIG9rKTsKLSAgICB2b2lk IHNldFN0YXR1c1RleHQoY29uc3QgUVN0cmluZyYpOwogICAgIHZvaWQgcnVuT3BlblBhbmVsKFdL T3BlblBhbmVsUmVzdWx0TGlzdGVuZXJSZWYsIGNvbnN0IFFTdHJpbmdMaXN0JiBzZWxlY3RlZEZp bGVOYW1lcywgRmlsZUNob29zZXJUeXBlKTsKICAgICB2b2lkIG1vdXNlRGlkTW92ZU92ZXJFbGVt ZW50KGNvbnN0IFFVcmwmIGxpbmtVUkwsIGNvbnN0IFFTdHJpbmcmIGxpbmtUaXRsZSk7CiAgICAg dm9pZCBwZXJtaXNzaW9uUmVxdWVzdChRV2ViUGVybWlzc2lvblJlcXVlc3QqKTsKQEAgLTUzLDcg KzUyLDYgQEAgcHJpdmF0ZToKICAgICBzdGF0aWMgdm9pZCBydW5KYXZhU2NyaXB0QWxlcnQoV0tQ YWdlUmVmLCBXS1N0cmluZ1JlZiBhbGVydFRleHQsIFdLRnJhbWVSZWYsIGNvbnN0IHZvaWQqIGNs aWVudEluZm8pOwogICAgIHN0YXRpYyBib29sIHJ1bkphdmFTY3JpcHRDb25maXJtKFdLUGFnZVJl ZiwgV0tTdHJpbmdSZWYgbWVzc2FnZSwgV0tGcmFtZVJlZiwgY29uc3Qgdm9pZCogY2xpZW50SW5m byk7CiAgICAgc3RhdGljIFdLU3RyaW5nUmVmIHJ1bkphdmFTY3JpcHRQcm9tcHQoV0tQYWdlUmVm LCBXS1N0cmluZ1JlZiBtZXNzYWdlLCBXS1N0cmluZ1JlZiBkZWZhdWx0VmFsdWUsIFdLRnJhbWVS ZWYsIGNvbnN0IHZvaWQqIGNsaWVudEluZm8pOwotICAgIHN0YXRpYyB2b2lkIHNldFN0YXR1c1Rl eHQoV0tQYWdlUmVmLCBXS1N0cmluZ1JlZiwgY29uc3Qgdm9pZCAqY2xpZW50SW5mbyk7CiAgICAg c3RhdGljIHZvaWQgcnVuT3BlblBhbmVsKFdLUGFnZVJlZiwgV0tGcmFtZVJlZiwgV0tPcGVuUGFu ZWxQYXJhbWV0ZXJzUmVmLCBXS09wZW5QYW5lbFJlc3VsdExpc3RlbmVyUmVmLCBjb25zdCB2b2lk KiBjbGllbnRJbmZvKTsKICAgICBzdGF0aWMgdm9pZCBtb3VzZURpZE1vdmVPdmVyRWxlbWVudChX S1BhZ2VSZWYsIFdLSGl0VGVzdFJlc3VsdFJlZiwgV0tFdmVudE1vZGlmaWVycywgV0tUeXBlUmVm IHVzZXJEYXRhLCBjb25zdCB2b2lkKiBjbGllbnRJbmZvKTsKICAgICBzdGF0aWMgdm9pZCBwb2xp Y3lGb3JHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0KFdLUGFnZVJlZiwgV0tGcmFtZVJlZiwg V0tTZWN1cml0eU9yaWdpblJlZiwgV0tHZW9sb2NhdGlvblBlcm1pc3Npb25SZXF1ZXN0UmVmLCBj b25zdCB2b2lkKik7Cg==