7440 2006-02-23 21:25:15 -0800 Floats not positioned correctly 2006-02-24 20:26:47 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED http://etuovi.com P2 Normal --- 1 koivisto webkit-unassigned oldest_to_newest 33842 0 koivisto 2006-02-23 21:25:15 -0800 In etuovi.com the password entry field is not visible and there is overlapping text under "Oma etuovi" headline. The problem is with float positioning. 33843 1 6693 koivisto 2006-02-23 21:28:14 -0800 Created attachment 6693 testcase 33848 2 6696 koivisto 2006-02-23 22:33:06 -0800 Created attachment 6696 patch Correct the use of QPtrList in RenderBlock::positionNewFloats(). In case all list entries needed positioning, the list current() pointer would get cleared and only the first entry would actually be positioned. 33857 3 6696 hyatt 2006-02-24 00:13:15 -0800 Comment on attachment 6696 patch r=me 33869 4 darin 2006-02-24 08:23:30 -0800 To land, we need to turn the test case into a layout test and write ChangeLog. 33870 5 koivisto 2006-02-24 09:48:12 -0800 (In reply to comment #4) > To land, we need to turn the test case into a layout test and write ChangeLog. > I can do that to test my new commit powers. Anything I need to know about the process? 6693 2006-02-23 21:28:14 -0800 2006-02-23 21:28:14 -0800 testcase float-positioning.html text/html 388 koivisto PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiIHhtbDpsYW5nPSJmaSIg bGFuZz0iZmkiPgo8aGVhZD4KPHRpdGxlPkV0dW92aS5jb208L3RpdGxlPgo8c3R5bGU+CmRpdiB7 IGJvcmRlcjogM3B4IHNvbGlkIHJlZCB9CmRpdi5ldHVzaXZ1VGV4dCB7IHdpZHRoOiAxNDBweDsg ICBib3JkZXI6IDNweCBzb2xpZCBncmVlbiB9CmRpdiBkaXYgeyBmbG9hdDogbGVmdDsgd2lkdGg6 IDYwcHg7ICB9Cjwvc3R5bGU+Cgo8L2hlYWQ+Cjxib2R5Pgo8ZGl2IGNsYXNzPSJldHVzaXZ1VGV4 dCI+YWFhc3NkZGRzIGRzc2QgZHNhc2Rkc2Fkc2RzIGRzYSBkZHNzZGRzc2RhIHNkZGFzYWRzZGEK PGRpdj4xPC9kaXY+CjxkaXY+MjwvZGl2Pgo8ZGl2PjM8L2Rpdj4KPC9kaXY+Cg== 6696 2006-02-23 22:33:06 -0800 2006-02-24 00:13:15 -0800 patch float-positioning.patch text/plain 938 koivisto SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9uIDEyOTUyKQorKysgV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODE0LDE3 ICsxODE0LDE1IEBAIHZvaWQgUmVuZGVyQmxvY2s6OnJlbW92ZUZsb2F0aW5nT2JqZWN0KFIKIHZv aWQgUmVuZGVyQmxvY2s6OnBvc2l0aW9uTmV3RmxvYXRzKCkKIHsKICAgICBpZighbV9mbG9hdGlu Z09iamVjdHMpIHJldHVybjsKLSAgICBGbG9hdGluZ09iamVjdCAqZiA9IG1fZmxvYXRpbmdPYmpl Y3RzLT5nZXRMYXN0KCk7CisgICAgRmxvYXRpbmdPYmplY3QgKmYgPSBtX2Zsb2F0aW5nT2JqZWN0 cy0+bGFzdCgpOwogICAgIGlmKCFmIHx8IGYtPnN0YXJ0WSAhPSAtMSkgcmV0dXJuOwogICAgIEZs b2F0aW5nT2JqZWN0ICpsYXN0RmxvYXQ7CiAgICAgd2hpbGUoMSkKICAgICB7Ci0gICAgICAgIGxh c3RGbG9hdCA9IG1fZmxvYXRpbmdPYmplY3RzLT5wcmV2KCk7Ci0gICAgICAgIGlmICghbGFzdEZs b2F0IHx8IGxhc3RGbG9hdC0+c3RhcnRZICE9IC0xKSB7Ci0gICAgICAgICAgICBtX2Zsb2F0aW5n T2JqZWN0cy0+bmV4dCgpOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0KLSAgICAgICAg ZiA9IGxhc3RGbG9hdDsKKyAgICAgICAgbGFzdEZsb2F0ID0gbV9mbG9hdGluZ09iamVjdHMtPmdl dFByZXYoKTsKKyAgICAgICAgaWYgKCFsYXN0RmxvYXQgfHwgbGFzdEZsb2F0LT5zdGFydFkgIT0g LTEpCisgICAgICAgICAgICBicmVhazsgICAgICAgIAorICAgICAgICBmID0gbV9mbG9hdGluZ09i amVjdHMtPnByZXYoKTsKICAgICB9CiAKIAo=