74373 2011-12-12 17:18:53 -0800 Don't create empty file if gperf fails 2012-04-16 10:43:57 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rafael.espindola webkit-unassigned litherum macpherson webkit.review.bot oldest_to_newest 519720 0 rafael.espindola 2011-12-12 17:18:53 -0800 Currently makeprop.pl, makevalues.pl and make-hash-tools.pl run gperf with: system("gperf .... > $file") == || die ... This creates an empty $file if gperf fails, which doesn't play very well with most build systems. This patch changes them to use system("gperf .... --output-file=$file") 519723 1 118919 rafael.espindola 2011-12-12 17:21:15 -0800 Created attachment 118919 fix the gperf invocation 519729 2 webkit.review.bot 2011-12-12 17:26:12 -0800 Attachment 118919 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 519746 3 118927 rafael.espindola 2011-12-12 18:01:44 -0800 Created attachment 118927 fix the gperf invocation 522567 4 118927 webkit.review.bot 2011-12-15 23:18:20 -0800 Comment on attachment 118927 fix the gperf invocation Clearing flags on attachment: 118927 Committed r103031: <http://trac.webkit.org/changeset/103031> 522568 5 webkit.review.bot 2011-12-15 23:18:24 -0800 All reviewed patches have been landed. Closing bug. 602690 6 litherum 2012-04-14 12:28:40 -0700 Some systems' version of gperf doesn't have the --output-file flag. Is it possible to detect if the file is empty and delete it instead? 602754 7 rafael.espindola 2012-04-15 05:07:48 -0700 (In reply to comment #6) > Some systems' version of gperf doesn't have the --output-file flag. Is it possible to detect if the file is empty and delete it instead? That would create a race condition, no? What I think can be done is gperf > foo.tmp && mv foo.tmp foo 603276 8 litherum 2012-04-16 10:43:57 -0700 I'm not sure it matters that much. It's probably reasonable to just say that building WebKit depends on gperf version >= 3.x (instead of 2.7.x, which doesn't have this flag). Because gperf 3.0.1 was released 6 years ago, I think it's reasonable to require people to have the newer version. To solve this problem, I just upgraded gperf on the machine I was building on. 118919 2011-12-12 17:21:15 -0800 2011-12-12 18:01:44 -0800 fix the gperf invocation WebKit.patch text/plain 2218 rafael.espindola ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkNmJhODBmLi5kNjQyOGFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMTItMTIgIFJhZmFlbCDDgXZpbGEgZGUgRXNww61uZG9sYSAgPHJhZmFlbC5lc3Bp bmRvbGFAZ21haWwuY29tPgorCisgICAgICAgIERvbid0IGNyZWF0ZSBlbXB0eSBmaWxlcyBvbiBl cnJvci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGNzcy9tYWtlcHJvcC5wbDoKKyAgICAgICAgKiBjc3MvbWFrZXZhbHVlcy5wbDoKKyAgICAgICAg KiBtYWtlLWhhc2gtdG9vbHMucGw6CisKIDIwMTEtMTItMTEgIEFuZHJlYXMgS2xpbmcgIDxrbGlu Z0B3ZWJraXQub3JnPgogCiAgICAgICAgIE1vdmUgQ1NTRWxlbWVudFN0eWxlRGVjbGFyYXRpb24g dG8gaXRzIG93biBjcHAvaCBmaWxlcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9t YWtlcHJvcC5wbCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbAppbmRleCA0NWFmNzEz Li5mN2FkNzkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwKKysr IGIvU291cmNlL1dlYkNvcmUvY3NzL21ha2Vwcm9wLnBsCkBAIC0xNjksNCArMTY5LDQgQEAgRU9G CiAKIGNsb3NlIEhFQURFUjsKIAotc3lzdGVtKCJncGVyZiAtLWtleS1wb3NpdGlvbnM9XCIqXCIg LUQgLW4gLXMgMiBDU1NQcm9wZXJ0eU5hbWVzLmdwZXJmID4gQ1NTUHJvcGVydHlOYW1lcy5jcHAi KSA9PSAwIHx8IGRpZSAiY2FsbGluZyBncGVyZiBmYWlsZWQ6ICQ/IjsKK3N5c3RlbSgiZ3BlcmYg LS1rZXktcG9zaXRpb25zPVwiKlwiIC1EIC1uIC1zIDIgQ1NTUHJvcGVydHlOYW1lcy5ncGVyZiAt LW91dHB1dC1maWxlPUNTU1Byb3BlcnR5TmFtZXMuY3BwIikgPT0gMCB8fCBkaWUgImNhbGxpbmcg Z3BlcmYgZmFpbGVkOiAkPyI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXZh bHVlcy5wbCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtldmFsdWVzLnBsCmluZGV4IDFlYWI5YmIu LmNlZDI0MTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtldmFsdWVzLnBsCisr KyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtldmFsdWVzLnBsCkBAIC0xNTUsNCArMTU1LDQgQEAg Y29uc3QgY2hhciogZ2V0VmFsdWVOYW1lKHVuc2lnbmVkIHNob3J0IGlkKTsKIEVPRgogY2xvc2Ug SEVBREVSOwogCi1zeXN0ZW0oImdwZXJmIC0ta2V5LXBvc2l0aW9ucz1cIipcIiAtRCAtbiAtcyAy IENTU1ZhbHVlS2V5d29yZHMuZ3BlcmYgPiBDU1NWYWx1ZUtleXdvcmRzLmNwcCIpID09IDAgfHwg ZGllICJjYWxsaW5nIGdwZXJmIGZhaWxlZDogJD8iOworc3lzdGVtKCJncGVyZiAtLWtleS1wb3Np dGlvbnM9XCIqXCIgLUQgLW4gLXMgMiBDU1NWYWx1ZUtleXdvcmRzLmdwZXJmIC0tb3V0cHV0LWZp bGU9Q1NTVmFsdWVLZXl3b3Jkcy5jcHAiKSA9PSAwIHx8IGRpZSAiY2FsbGluZyBncGVyZiBmYWls ZWQ6ICQ/IjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21ha2UtaGFzaC10b29scy5wbCBi L1NvdXJjZS9XZWJDb3JlL21ha2UtaGFzaC10b29scy5wbAppbmRleCBiZGQ3NDcxLi42ODlhZjBk IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9tYWtlLWhhc2gtdG9vbHMucGwKKysrIGIvU291 cmNlL1dlYkNvcmUvbWFrZS1oYXNoLXRvb2xzLnBsCkBAIC0zMyw3ICszMyw3IEBAIGlmICgkb3B0 aW9uIGVxICJDb2xvckRhdGEiKSB7CiAgICAgbXkgJGNvbG9yRGF0YUdwZXJmICAgICAgICAgICAg ID0gJEFSR1ZbMF07CiAgICAgc2hpZnQ7CiAKLSAgICBzeXN0ZW0oImdwZXJmIC0ta2V5LXBvc2l0 aW9ucz1cIipcIiAtRCAtcyAyICRjb2xvckRhdGFHcGVyZiA+ICRjb2xvckRhdGFHZW5lcmF0ZWQi KSA9PSAwIHx8IGRpZSAiY2FsbGluZyBncGVyZiBmYWlsZWQ6ICQ/IjsKKyAgICBzeXN0ZW0oImdw ZXJmIC0ta2V5LXBvc2l0aW9ucz1cIipcIiAtRCAtcyAyICRjb2xvckRhdGFHcGVyZiAtLW91dHB1 dC1maWxlPSRjb2xvckRhdGFHZW5lcmF0ZWQiKSA9PSAwIHx8IGRpZSAiY2FsbGluZyBncGVyZiBm YWlsZWQ6ICQ/IjsKIAogfSBlbHNlIHsKICAgICBkaWUgIlVua25vd24gb3B0aW9uLiI7Cg== 118927 2011-12-12 18:01:44 -0800 2011-12-15 23:18:20 -0800 fix the gperf invocation WebKit.patch text/plain 2273 rafael.espindola ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkNmJhODBmLi5jYTE4ODhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMTItMTIgIFJhZmFlbCDDgXZpbGEgZGUgRXNww61uZG9sYSAgPHJhZmFlbC5lc3Bp bmRvbGFAZ21haWwuY29tPgorCisgICAgICAgIERvbid0IGNyZWF0ZSBlbXB0eSBmaWxlcyBvbiBl cnJvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTc0 MzczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBj c3MvbWFrZXByb3AucGw6CisgICAgICAgICogY3NzL21ha2V2YWx1ZXMucGw6CisgICAgICAgICog bWFrZS1oYXNoLXRvb2xzLnBsOgorCiAyMDExLTEyLTExICBBbmRyZWFzIEtsaW5nICA8a2xpbmdA d2Via2l0Lm9yZz4KIAogICAgICAgICBNb3ZlIENTU0VsZW1lbnRTdHlsZURlY2xhcmF0aW9uIHRv IGl0cyBvd24gY3BwL2ggZmlsZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFr ZXByb3AucGwgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXByb3AucGwKaW5kZXggNDVhZjcxMy4u ZjdhZDc5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL21ha2Vwcm9wLnBsCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbApAQCAtMTY5LDQgKzE2OSw0IEBAIEVPRgog CiBjbG9zZSBIRUFERVI7CiAKLXN5c3RlbSgiZ3BlcmYgLS1rZXktcG9zaXRpb25zPVwiKlwiIC1E IC1uIC1zIDIgQ1NTUHJvcGVydHlOYW1lcy5ncGVyZiA+IENTU1Byb3BlcnR5TmFtZXMuY3BwIikg PT0gMCB8fCBkaWUgImNhbGxpbmcgZ3BlcmYgZmFpbGVkOiAkPyI7CitzeXN0ZW0oImdwZXJmIC0t a2V5LXBvc2l0aW9ucz1cIipcIiAtRCAtbiAtcyAyIENTU1Byb3BlcnR5TmFtZXMuZ3BlcmYgLS1v dXRwdXQtZmlsZT1DU1NQcm9wZXJ0eU5hbWVzLmNwcCIpID09IDAgfHwgZGllICJjYWxsaW5nIGdw ZXJmIGZhaWxlZDogJD8iOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL21ha2V2YWx1 ZXMucGwgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXZhbHVlcy5wbAppbmRleCAxZWFiOWJiLi5j ZWQyNDE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXZhbHVlcy5wbAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvbWFrZXZhbHVlcy5wbApAQCAtMTU1LDQgKzE1NSw0IEBAIGNv bnN0IGNoYXIqIGdldFZhbHVlTmFtZSh1bnNpZ25lZCBzaG9ydCBpZCk7CiBFT0YKIGNsb3NlIEhF QURFUjsKIAotc3lzdGVtKCJncGVyZiAtLWtleS1wb3NpdGlvbnM9XCIqXCIgLUQgLW4gLXMgMiBD U1NWYWx1ZUtleXdvcmRzLmdwZXJmID4gQ1NTVmFsdWVLZXl3b3Jkcy5jcHAiKSA9PSAwIHx8IGRp ZSAiY2FsbGluZyBncGVyZiBmYWlsZWQ6ICQ/IjsKK3N5c3RlbSgiZ3BlcmYgLS1rZXktcG9zaXRp b25zPVwiKlwiIC1EIC1uIC1zIDIgQ1NTVmFsdWVLZXl3b3Jkcy5ncGVyZiAtLW91dHB1dC1maWxl PUNTU1ZhbHVlS2V5d29yZHMuY3BwIikgPT0gMCB8fCBkaWUgImNhbGxpbmcgZ3BlcmYgZmFpbGVk OiAkPyI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9tYWtlLWhhc2gtdG9vbHMucGwgYi9T b3VyY2UvV2ViQ29yZS9tYWtlLWhhc2gtdG9vbHMucGwKaW5kZXggYmRkNzQ3MS4uNjg5YWYwZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbWFrZS1oYXNoLXRvb2xzLnBsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL21ha2UtaGFzaC10b29scy5wbApAQCAtMzMsNyArMzMsNyBAQCBpZiAoJG9wdGlv biBlcSAiQ29sb3JEYXRhIikgewogICAgIG15ICRjb2xvckRhdGFHcGVyZiAgICAgICAgICAgICA9 ICRBUkdWWzBdOwogICAgIHNoaWZ0OwogCi0gICAgc3lzdGVtKCJncGVyZiAtLWtleS1wb3NpdGlv bnM9XCIqXCIgLUQgLXMgMiAkY29sb3JEYXRhR3BlcmYgPiAkY29sb3JEYXRhR2VuZXJhdGVkIikg PT0gMCB8fCBkaWUgImNhbGxpbmcgZ3BlcmYgZmFpbGVkOiAkPyI7CisgICAgc3lzdGVtKCJncGVy ZiAtLWtleS1wb3NpdGlvbnM9XCIqXCIgLUQgLXMgMiAkY29sb3JEYXRhR3BlcmYgLS1vdXRwdXQt ZmlsZT0kY29sb3JEYXRhR2VuZXJhdGVkIikgPT0gMCB8fCBkaWUgImNhbGxpbmcgZ3BlcmYgZmFp bGVkOiAkPyI7CiAKIH0gZWxzZSB7CiAgICAgZGllICJVbmtub3duIG9wdGlvbi4iOwo=