74342 2011-12-12 14:44:10 -0800 De-virtualize destructors part 2 2011-12-18 12:23:43 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 74341 74331 74347 1 mhahnenberg mhahnenberg oldest_to_newest 519494 0 mhahnenberg 2011-12-12 14:44:10 -0800 Same as bug 74341, just moving the static destroy functions down another level in the hierarchy and leaving behind any necessary destroy functions. 519518 1 118865 mhahnenberg 2011-12-12 14:53:39 -0800 Created attachment 118865 De-virtualizing destructors part 2 No changelog (see bug 74331). 519582 2 118865 ggaren 2011-12-12 15:28:38 -0800 Comment on attachment 118865 De-virtualizing destructors part 2 View in context: https://bugs.webkit.org/attachment.cgi?id=118865&action=review r=me > Source/JavaScriptCore/runtime/Executable.cpp:108 > + jsCast<ScriptExecutable*>(cell)->~ScriptExecutable(); ScriptExecutable::~ScriptExecutable(). 118865 2011-12-12 14:53:39 -0800 2011-12-12 15:28:38 -0800 De-virtualizing destructors part 2 0008-Completed-level-2.patch text/plain 6805 mhahnenberg RnJvbSAwN2RmM2QwNDZjNTgzYzA5MTNmZjQxNmI0OTA5ZDYzYzA0ZGRjZDhhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJrIEhhaG5lbmJlcmcgPG1oYWhuZW5iZXJnQGFwcGxlLmNv bT4KRGF0ZTogVHVlLCA2IERlYyAyMDExIDE3OjExOjA0IC0wODAwClN1YmplY3Q6IFtQQVRDSCAw OC8xOF0gQ29tcGxldGVkIGxldmVsIDIKCi0tLQogU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFT Y3JpcHRDb3JlLmV4cCAgICAgfCAgICAzICsrKwogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvRXhlY3V0YWJsZS5jcHAgfCAgIDE4ICsrKysrKysrKysrKy0tLS0tLQogU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvRXhlY3V0YWJsZS5oICAgfCAgIDExICsrKysrKysrKy0tCiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAgICB8ICAgMTMgKysrKysrKysr KystLQogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuaCAgICAgfCAgICA1 ICsrKysrCiA1IGZpbGVzIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5leHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZXhwCmluZGV4IDYzZDAyMjgu LjM0NTk4YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29y ZS5leHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmV4cApAQCAt MTk3LDYgKzE5Nyw4IEBAIF9fWk4zSlNDMTZJbnRlcm5hbEZ1bmN0aW9uMTRmaW5pc2hDcmVhdGlv bkVSTlNfMTJKU0dsb2JhbERhdGFFUktOU18xMElkZW50aWZpZXJFCiBfX1pOM0pTQzE2SW50ZXJu YWxGdW5jdGlvbjRuYW1lRVBOU185RXhlY1N0YXRlRQogX19aTjNKU0MxNkludGVybmFsRnVuY3Rp b242c19pbmZvRQogX19aTjNKU0MxNkludGVybmFsRnVuY3Rpb25DMkVQTlNfMTRKU0dsb2JhbE9i amVjdEVQTlNfOVN0cnVjdHVyZUUKK19fWk4zSlNDMTZKU05vbkZpbmFsT2JqZWN0N2Rlc3Ryb3lF UE5TXzZKU0NlbGxFCitfX1pOM0pTQzE2SlNOb25GaW5hbE9iamVjdEQyRXYKIF9fWk4zSlNDMTZK U1ZhcmlhYmxlT2JqZWN0MTRkZWxldGVQcm9wZXJ0eUVQTlNfNkpTQ2VsbEVQTlNfOUV4ZWNTdGF0 ZUVSS05TXzEwSWRlbnRpZmllckUKIF9fWk4zSlNDMTZKU1ZhcmlhYmxlT2JqZWN0MTRzeW1ib2xU YWJsZUdldEVSS05TXzEwSWRlbnRpZmllckVSTlNfMThQcm9wZXJ0eURlc2NyaXB0b3JFCiBfX1pO M0pTQzE2SlNWYXJpYWJsZU9iamVjdDE5Z2V0T3duUHJvcGVydHlOYW1lc0VQTlNfOEpTT2JqZWN0 RVBOU185RXhlY1N0YXRlRVJOU18xN1Byb3BlcnR5TmFtZUFycmF5RU5TXzE1RW51bWVyYXRpb25N b2RlRQpAQCAtNjI3LDYgKzYyOSw3IEBAIF9fWlRWTjNKU0MxNFNjb3BlQ2hhaW5Ob2RlRQogX19a VFZOM0pTQzE1SlNXcmFwcGVyT2JqZWN0RQogX19aVFZOM0pTQzE1V2Vha0hhbmRsZU93bmVyRQog X19aVFZOM0pTQzE2SW50ZXJuYWxGdW5jdGlvbkUKK19fWlRWTjNKU0MxNkpTTm9uRmluYWxPYmpl Y3RFCiBfX1pUVk4zSlNDMTZKU1ZhcmlhYmxlT2JqZWN0RQogX19aVFZOM0pTQzZKU0NlbGxFCiBf X1pUVk4zSlNDOERlYnVnZ2VyRQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvRXhlY3V0YWJsZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGVj dXRhYmxlLmNwcAppbmRleCBhYTQ3MDFiLi4zMDVlYWU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9FeGVjdXRhYmxlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9FeGVjdXRhYmxlLmNwcApAQCAtMzgsMTMgKzM4LDkgQEAgbmFtZXNwYWNl IEpTQyB7CiAKIGNvbnN0IENsYXNzSW5mbyBFeGVjdXRhYmxlQmFzZTo6c19pbmZvID0geyAiRXhl Y3V0YWJsZSIsIDAsIDAsIDAsIENSRUFURV9NRVRIT0RfVEFCTEUoRXhlY3V0YWJsZUJhc2UpIH07 CiAKLUV4ZWN1dGFibGVCYXNlOjp+RXhlY3V0YWJsZUJhc2UoKQotewotfQotCiB2b2lkIEV4ZWN1 dGFibGVCYXNlOjpkZXN0cm95KEpTQ2VsbCogY2VsbCkKIHsKLSAgICBqc0Nhc3Q8RXhlY3V0YWJs ZUJhc2UqPihjZWxsKS0+fkV4ZWN1dGFibGVCYXNlKCk7CisgICAganNDYXN0PEV4ZWN1dGFibGVC YXNlKj4oY2VsbCktPkV4ZWN1dGFibGVCYXNlOjp+RXhlY3V0YWJsZUJhc2UoKTsKIH0KIAogaW5s aW5lIHZvaWQgRXhlY3V0YWJsZUJhc2U6OmNsZWFyQ29kZSgpCkBAIC03MCw4ICs2Niw5IEBAIElu dHJpbnNpYyBFeGVjdXRhYmxlQmFzZTo6aW50cmluc2ljKCkgY29uc3QKIAogY29uc3QgQ2xhc3NJ bmZvIE5hdGl2ZUV4ZWN1dGFibGU6OnNfaW5mbyA9IHsgIk5hdGl2ZUV4ZWN1dGFibGUiLCAmRXhl Y3V0YWJsZUJhc2U6OnNfaW5mbywgMCwgMCwgQ1JFQVRFX01FVEhPRF9UQUJMRShOYXRpdmVFeGVj dXRhYmxlKSB9OwogCi1OYXRpdmVFeGVjdXRhYmxlOjp+TmF0aXZlRXhlY3V0YWJsZSgpCit2b2lk IE5hdGl2ZUV4ZWN1dGFibGU6OmRlc3Ryb3koSlNDZWxsKiBjZWxsKQogeworICAgIGpzQ2FzdDxO YXRpdmVFeGVjdXRhYmxlKj4oY2VsbCktPk5hdGl2ZUV4ZWN1dGFibGU6On5OYXRpdmVFeGVjdXRh YmxlKCk7CiB9CiAKICNpZiBFTkFCTEUoREZHX0pJVCkKQEAgLTEwMiw2ICs5OSwxNSBAQCB2b2lk IE5hdGl2ZUV4ZWN1dGFibGU6OmZpbmFsaXplKEpTQ2VsbCogY2VsbCkKIAogY29uc3QgQ2xhc3NJ bmZvIFNjcmlwdEV4ZWN1dGFibGU6OnNfaW5mbyA9IHsgIlNjcmlwdEV4ZWN1dGFibGUiLCAmRXhl Y3V0YWJsZUJhc2U6OnNfaW5mbywgMCwgMCwgQ1JFQVRFX01FVEhPRF9UQUJMRShTY3JpcHRFeGVj dXRhYmxlKSB9OwogCitTY3JpcHRFeGVjdXRhYmxlOjp+U2NyaXB0RXhlY3V0YWJsZSgpCit7Cit9 CisKK3ZvaWQgU2NyaXB0RXhlY3V0YWJsZTo6ZGVzdHJveShKU0NlbGwqIGNlbGwpCit7CisgICAg anNDYXN0PFNjcmlwdEV4ZWN1dGFibGUqPihjZWxsKS0+flNjcmlwdEV4ZWN1dGFibGUoKTsKK30K KwogY29uc3QgQ2xhc3NJbmZvIEV2YWxFeGVjdXRhYmxlOjpzX2luZm8gPSB7ICJFdmFsRXhlY3V0 YWJsZSIsICZTY3JpcHRFeGVjdXRhYmxlOjpzX2luZm8sIDAsIDAsIENSRUFURV9NRVRIT0RfVEFC TEUoRXZhbEV4ZWN1dGFibGUpIH07CiAKIEV2YWxFeGVjdXRhYmxlOjpFdmFsRXhlY3V0YWJsZShF eGVjU3RhdGUqIGV4ZWMsIGNvbnN0IFNvdXJjZUNvZGUmIHNvdXJjZSwgYm9vbCBpblN0cmljdENv bnRleHQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGVjdXRh YmxlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9FeGVjdXRhYmxlLmgKaW5kZXgg YTFkZmNlMy4uYjU1MzYyMyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvRXhlY3V0YWJsZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0V4ZWN1 dGFibGUuaApAQCAtNTUsNiArNTUsOSBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIH0KIAorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHB1c2gKKyNwcmFnbWEg Y2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVkICItV25vbi12aXJ0dWFsLWR0b3IiCisKICAgICBjbGFz cyBFeGVjdXRhYmxlQmFzZSA6IHB1YmxpYyBKU0NlbGwgewogICAgICAgICBmcmllbmQgY2xhc3Mg SklUOwogCkBAIC03Nyw3ICs4MCw2IEBAIG5hbWVzcGFjZSBKU0MgewogICAgIHB1YmxpYzoKICAg ICAgICAgdHlwZWRlZiBKU0NlbGwgQmFzZTsKIAotICAgICAgICB2aXJ0dWFsIH5FeGVjdXRhYmxl QmFzZSgpOwogICAgICAgICBzdGF0aWMgdm9pZCBkZXN0cm95KEpTQ2VsbCopOwogCiAgICAgICAg IGJvb2wgaXNIb3N0RnVuY3Rpb24oKSBjb25zdApAQCAtMjA5LDcgKzIxMSw3IEBAIG5hbWVzcGFj ZSBKU0MgewogICAgICAgICB9CiAjZW5kaWYKIAotICAgICAgICB2aXJ0dWFsIH5OYXRpdmVFeGVj dXRhYmxlKCk7CisgICAgICAgIHN0YXRpYyB2b2lkIGRlc3Ryb3koSlNDZWxsKik7CiAKICAgICAg ICAgTmF0aXZlRnVuY3Rpb24gZnVuY3Rpb24oKSB7IHJldHVybiBtX2Z1bmN0aW9uOyB9CiAgICAg ICAgIE5hdGl2ZUZ1bmN0aW9uIGNvbnN0cnVjdG9yKCkgeyByZXR1cm4gbV9jb25zdHJ1Y3Rvcjsg fQpAQCAtMjc3LDYgKzI3OSw5IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICB7CiAgICAgICAg IH0KIAorICAgICAgICB2aXJ0dWFsIH5TY3JpcHRFeGVjdXRhYmxlKCk7CisgICAgICAgIHN0YXRp YyB2b2lkIGRlc3Ryb3koSlNDZWxsKik7CisKICAgICAgICAgY29uc3QgU291cmNlQ29kZSYgc291 cmNlKCkgeyByZXR1cm4gbV9zb3VyY2U7IH0KICAgICAgICAgaW50cHRyX3Qgc291cmNlSUQoKSBj b25zdCB7IHJldHVybiBtX3NvdXJjZS5wcm92aWRlcigpLT5hc0lEKCk7IH0KICAgICAgICAgY29u c3QgVVN0cmluZyYgc291cmNlVVJMKCkgY29uc3QgeyByZXR1cm4gbV9zb3VyY2UucHJvdmlkZXIo KS0+dXJsKCk7IH0KQEAgLTY2NCw2ICs2NjksOCBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAg U2hhcmVkU3ltYm9sVGFibGUqIG1fc3ltYm9sVGFibGU7CiAgICAgfTsKIAorI3ByYWdtYSBjbGFu ZyBkaWFnbm9zdGljIHBvcAorCiAgICAgaW5saW5lIEZ1bmN0aW9uRXhlY3V0YWJsZSogSlNGdW5j dGlvbjo6anNFeGVjdXRhYmxlKCkgY29uc3QKICAgICB7CiAgICAgICAgIEFTU0VSVCghaXNIb3N0 RnVuY3Rpb25Ob25JbmxpbmUoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU09iamVjdC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09i amVjdC5jcHAKaW5kZXggNDc1MGRlYi4uOTRlMWNmYiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0pTT2JqZWN0LmNwcApAQCAtNTIsOSArNTIsMTggQEAgY29uc3QgQ2xhc3NJbmZv IEpTT2JqZWN0OjpzX2luZm8gPSB7ICJPYmplY3QiLCAwLCAwLCAwLCBDUkVBVEVfTUVUSE9EX1RB QkxFKEpTT2IKIAogY29uc3QgQ2xhc3NJbmZvIEpTRmluYWxPYmplY3Q6OnNfaW5mbyA9IHsgIk9i amVjdCIsICZCYXNlOjpzX2luZm8sIDAsIDAsIENSRUFURV9NRVRIT0RfVEFCTEUoSlNGaW5hbE9i amVjdCkgfTsKIAotdm9pZCBKU0ZpbmFsT2JqZWN0Ojp2dGFibGVBbmNob3IoKQordm9pZCBKU0Zp bmFsT2JqZWN0OjpkZXN0cm95KEpTQ2VsbCogY2VsbCkKIHsKLSAgICBwcmludGYoIlNvbWV0aGlu ZyBWaXN1YWwgU3R1ZGlvIGNhbid0IG9wdGltaXplIGF3YXkuXG4iKTsKKyAgICBqc0Nhc3Q8SlNG aW5hbE9iamVjdCo+KGNlbGwpLT5KU0ZpbmFsT2JqZWN0Ojp+SlNGaW5hbE9iamVjdCgpOworfQor CitKU05vbkZpbmFsT2JqZWN0Ojp+SlNOb25GaW5hbE9iamVjdCgpCit7Cit9CisKK3ZvaWQgSlNO b25GaW5hbE9iamVjdDo6ZGVzdHJveShKU0NlbGwqIGNlbGwpCit7CisgICAganNDYXN0PEpTTm9u RmluYWxPYmplY3QqPihjZWxsKS0+fkpTTm9uRmluYWxPYmplY3QoKTsKIH0KIAogc3RhdGljIGlu bGluZSB2b2lkIGdldENsYXNzUHJvcGVydHlOYW1lcyhFeGVjU3RhdGUqIGV4ZWMsIGNvbnN0IENs YXNzSW5mbyogY2xhc3NJbmZvLCBQcm9wZXJ0eU5hbWVBcnJheSYgcHJvcGVydHlOYW1lcywgRW51 bWVyYXRpb25Nb2RlIG1vZGUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9KU09iamVjdC5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3Qu aAppbmRleCBhMTc3MDEyLi44MDBmYThkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU09iamVjdC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTT2JqZWN0LmgKQEAgLTMyMiw2ICszMjIsOSBAQCBDT01QSUxFX0FTU0VSVCgoSlNGaW5hbE9i amVjdF9pbmxpbmVTdG9yYWdlQ2FwYWNpdHkgPj0gSlNOb25GaW5hbE9iamVjdF9pbmxpbmVTdAog ICAgICAgICAgICAgcmV0dXJuIFN0cnVjdHVyZTo6Y3JlYXRlKGdsb2JhbERhdGEsIGdsb2JhbE9i amVjdCwgcHJvdG90eXBlLCBUeXBlSW5mbyhPYmplY3RUeXBlLCBTdHJ1Y3R1cmVGbGFncyksICZz X2luZm8pOwogICAgICAgICB9CiAKKyAgICAgICAgdmlydHVhbCB+SlNOb25GaW5hbE9iamVjdCgp OworICAgICAgICBzdGF0aWMgdm9pZCBkZXN0cm95KEpTQ2VsbCopOworCiAgICAgcHJvdGVjdGVk OgogICAgICAgICBleHBsaWNpdCBKU05vbkZpbmFsT2JqZWN0KFZQdHJTdGVhbGluZ0hhY2tUeXBl KQogICAgICAgICAgICAgOiBKU09iamVjdChWUHRyU3RlYWxpbmdIYWNrLCBtX2lubGluZVN0b3Jh Z2UpCkBAIC0zODEsNiArMzg0LDggQEAgQ09NUElMRV9BU1NFUlQoKEpTRmluYWxPYmplY3RfaW5s aW5lU3RvcmFnZUNhcGFjaXR5ID49IEpTTm9uRmluYWxPYmplY3RfaW5saW5lU3QKICAgICAgICAg ICAgIEFTU0VSVChjbGFzc0luZm8oKSk7CiAgICAgICAgIH0KIAorICAgICAgICBzdGF0aWMgdm9p ZCBkZXN0cm95KEpTQ2VsbCopOworCiAgICAgcHJpdmF0ZToKICAgICAgICAgZXhwbGljaXQgSlNG aW5hbE9iamVjdChKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEsIFN0cnVjdHVyZSogc3RydWN0dXJl KQogICAgICAgICAgICAgOiBKU09iamVjdChnbG9iYWxEYXRhLCBzdHJ1Y3R1cmUsIG1faW5saW5l U3RvcmFnZSkKLS0gCjEuNy40LjQKCg==